| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2019-05-31 | |||
| 12:34:26 | aspiers | mdbooth: He's a slippery one, that kashyap ;-) | |
| 12:34:32 | mdbooth | aspiers: I know! | |
| 12:34:41 | mdbooth | kashyap: You've rephrased your comment! | |
| 12:34:43 | mdbooth | -1 | |
| 12:34:59 | kashyap | mdbooth: Hehe, that was after an elaborate discussion with aspiers | |
| 12:35:00 | aspiers | I mean, he once tried to slip some Perl 4 into nova | |
| 12:35:03 | kashyap | For better clarity :-) | |
| 12:35:21 | mdbooth | kashyap: Yeah, that reads a bit better. | |
| 12:35:42 | kashyap | mdbooth: Thanks. *Clear* phrasing is bloody hard work, it never ceases to amaze me. | |
| 12:36:10 | kashyap | aspiers: Hah, now, tell the truth | |
| 12:36:29 | aspiers | OK OK, it's was COBOL | |
| 12:36:35 | aspiers | it, even | |
| 12:37:04 | kashyap | aspiers: "It's COBOL all the way down"! | |
| 12:37:10 | aspiers | :) | |
| 12:37:31 | aspiers | the parent company I just left (Micro Focus) actually is *the* COBOL company these days | |
| 12:37:34 | kashyap | aspiers: https://increment.com/programming-languages/cobol-all-the-way-down/ | |
| 12:38:09 | kashyap | aspiers: I see, didn't know. | |
| 12:38:18 | aspiers | oh yeah, MF mentioned in that article | |
| 12:38:37 | kashyap | aspiers: I'll address Eric's nits (which you agreed with) in a couple of hours. Finishing up something else that is racing against time. | |
| 12:39:19 | aspiers | sure | |
| 12:40:10 | kashyap | aspiers: Unrelated: What terminal font do you use? I'm really enjoying "Liberation Mono Regular" | |
| 12:40:14 | aspiers | http://www.csis.ul.ie/cobol/exercises/Exm-BestSellersRpt/BestSellers.cbl | |
| 12:40:19 | aspiers | OK, now I need to wash my eyes out | |
| 12:41:33 | kashyap | Hehe | |
| 12:41:54 | aspiers | kashyap: https://github.com/aspiers/desktop-config/blob/master/.Xresources.d/terms.rdb#L237 | |
| 12:42:38 | kashyap | So whatever is the default | |
| 12:54:39 | stephenfin | kashyap: Done | |
| 12:55:29 | kashyap | stephenfin: Vielen Dank | |
| 13:06:46 | mriedem | stephenfin: can you confirm on the todo here to drop the cell_name column https://review.opendev.org/#/c/651309/9/nova/db/sqlalchemy/models.py@343 that you're just talking about from the model and not an actual alter table drop column schema change? | |
| 13:31:04 | openstackgerrit | Merged openstack/nova master: Stop handling 'InstanceUnknownCell' exception https://review.opendev.org/651307 | |
| 13:31:15 | mriedem | sean-k-mooney: you might want to check my comments in here https://review.opendev.org/#/c/661237/3 | |
| 13:34:33 | mriedem | i thought we agreed in the ML to validate the requested node using placement rather than iterating the cells, but maybe that wasn't clear | |
| 13:40:44 | stephenfin | mriedem: I just wanted to indicate that the column was unused and _something_ should be done about it. If that's just a case of removing the model and keeping the actual column, I'm a-ok with it | |
| 13:40:58 | stephenfin | Heck, the thing could stay there forever for all I care. It's just cleanup :) | |
| 13:41:28 | stephenfin | mriedem: Do you want a follow-up to clarify the comment? If so, what would you propose it says? | |
| 13:43:24 | mriedem | per those 2 other changes i linked for internal_id and scheduled_at, it looks like a follow up could just be to comment on the column with a comment saying it's still in the db schema but not used in code so it's removed from the model | |
| 13:44:23 | mriedem | it looks like we actually did a drop column on scheduled_at but never did for internal_id | |
| 13:44:53 | openstackgerrit | Merged openstack/nova master: Remove unnecessary wrapper https://review.opendev.org/651308 | |
| 13:46:14 | mriedem | stephenfin: +W | |
| 13:46:22 | stephenfin | ta | |
| 13:47:14 | mriedem | someone want to get in this very old test patch for dan? https://review.opendev.org/#/c/452006/ | |
| 13:48:54 | openstackgerrit | Merged openstack/nova stable/stein: Block swap volume on volumes with >1 rw attachment https://review.opendev.org/662331 | |
| 13:55:17 | openstackgerrit | Lee Yarwood proposed openstack/nova stable/queens: Restore connection_info after live migration rollback https://review.opendev.org/662471 | |
| 13:55:17 | openstackgerrit | Lee Yarwood proposed openstack/nova stable/queens: DRY up test_rollback_live_migration_set_migration_status https://review.opendev.org/662470 | |
| 13:56:30 | stephenfin | gibi: Replied to https://review.opendev.org/#/c/660774/3 | |
| 13:59:44 | mriedem | lyarwood: i kicked out the stein release https://review.opendev.org/#/c/656304/ from the gate so we can get https://review.opendev.org/#/c/656304/ into it | |
| 14:02:05 | lyarwood | mriedem: ack thanks | |
| 14:26:27 | openstackgerrit | Julia Kreger proposed openstack/nova stable/stein: [ironic] Don't remove instance info twice in destroy https://review.opendev.org/662479 | |
| 14:35:11 | mriedem | gibi: thanks for wading into the cross-cell resize series | |
| 14:35:15 | mriedem | you're brave | |
| 14:35:20 | mriedem | i shall call you beowulf | |
| 14:52:55 | kashyap | aspiers: Hey, FWIW, Erik Skultety from libvirt upstream was just inquiring about SEV work. I pointed to the in-progress patch series, and what's remaining. And says: "hopefully I'll find some time to go through the patches thoroughly" | |
| 14:53:16 | aspiers | kashyap: thanks, the more reviews the better! | |
| 14:53:31 | aspiers | kashyap: is he on IRC? | |
| 14:53:54 | kashyap | aspiers: On OFTC (#virt): eskultet | |
| 14:54:25 | efried | aspiers, kashyap: I'm off doing something else but it occurs to me my time right now would be well spent reviewing the os-traits and SEV stuff while y'all are around. | |
| 14:54:31 | efried | is there an update since yesterday? | |
| 14:54:38 | efried | esp on the os-traits side? | |
| 14:54:47 | efried | cause the can't-build-shit thing is getting annoying. | |
| 14:55:01 | kashyap | efried: Hiya, _just_ about to push one | |
| 14:55:10 | efried | ack, please ping when done, thx | |
| 14:55:20 | kashyap | efried: I'm done addressing your remarks. Feel free to nit-pick away | |
| 14:55:35 | efried | feel like we were on the downward slope | |
| 14:56:04 | kashyap | Heh, no. I appreciate the "soft -1" | |
| 14:58:32 | openstackgerrit | Kashyap Chamarthy proposed openstack/os-traits master: hw: cpu: Rework the directory layout; add missing traits https://review.opendev.org/655193 | |
| 14:58:39 | kashyap | efried: aspiers --^ Did I get it right? | |
| 14:59:53 | kashyap | [I'm here for an hour more, then I need to bike to get some groceries] | |
| 15:01:11 | openstackgerrit | melanie witt proposed openstack/nova master: Use instance mappings to count server group members https://review.opendev.org/638324 | |
| 15:01:12 | openstackgerrit | melanie witt proposed openstack/nova master: Follow up for counting quota usage from placement https://review.opendev.org/662056 | |
| 15:01:12 | openstackgerrit | melanie witt proposed openstack/nova master: Add documentation for counting quota usage from placement https://review.opendev.org/653845 | |
| 15:31:44 | openstack | Launchpad bug 1829479 in OpenStack Compute (nova) "The allocation table has residual records when instance is evacuated and the source physical node is removed" [Undecided,New] | |
| 15:31:44 | mriedem | gibi: i suspect this bug https://bugs.launchpad.net/nova/+bug/1829479 is a duplicate of the orphaned allocations from wiped evacuated node you worked on, but i'm having a hard time parsing it from the reporter | |
| 15:41:28 | openstackgerrit | Merged openstack/nova master: libvirt: Rework 'EBUSY' (SIGKILL) error handling code path https://review.opendev.org/639091 | |
| 15:54:55 | mriedem | oof the ironic hashring stuff in nova is not documented at all | |
| 15:56:54 | mriedem | re https://bugs.launchpad.net/nova/+bug/1831195 | |
| 15:56:55 | openstack | Launchpad bug 1831195 in OpenStack Compute (nova) "disable one compute service will prevent scheduler to choose the hypervisor the compute service manange" [Undecided,Invalid] | |
| 15:57:18 | mriedem | "i've disabled my nova-compute service managing ironic nodes but still want to schedule stuff there, what gives?!" | |
| 15:58:43 | mriedem | i'm assuming they just aren't aware of the hashring | |
| 16:00:41 | aspiers | kashyap: think you missed the s/e\.g\./i.e./ | |
| 16:00:58 | kashyap | aspiers: ****; let me do it. I _knew_ I'd miss something | |
| 16:01:03 | aspiers | :) | |
| 16:01:23 | kashyap | It's not even a nit-pick, it's a logical mistake, so I _want_ to correct it :-) | |
| 16:01:51 | kashyap | Anything else? | |
| 16:01:53 | aspiers | nope | |
| 16:01:56 | aspiers | Not that I can see | |
| 16:02:37 | openstackgerrit | Kashyap Chamarthy proposed openstack/os-traits master: hw: cpu: Rework the directory layout; add missing traits https://review.opendev.org/655193 | |
| 16:02:42 | kashyap | aspiers: Hehe, done. | |
| 16:03:07 | aspiers | Hrm | |
| 16:03:10 | aspiers | not sure I see a difference | |
| 16:03:30 | openstackgerrit | Stephen Finucane proposed openstack/nova master: ec2: Remove unused functions from 'ec2utils' https://review.opendev.org/662501 | |
| 16:03:31 | openstackgerrit | Stephen Finucane proposed openstack/nova master: ec2: Remove ec2.CloudController https://review.opendev.org/662503 | |
| 16:03:31 | openstackgerrit | Stephen Finucane proposed openstack/nova master: objects: Remove unused ec2 objects https://review.opendev.org/662502 | |
| 16:03:32 | openstackgerrit | Stephen Finucane proposed openstack/nova master: ec2: Move ec2utils functions to their callers https://review.opendev.org/662505 | |
| 16:03:32 | openstackgerrit | Stephen Finucane proposed openstack/nova master: ec2: Pre-move cleanup of utils https://review.opendev.org/662504 | |
| 16:03:33 | openstackgerrit | Stephen Finucane proposed openstack/nova master: api: Remove 'Debug' middleware https://review.opendev.org/662506 | |
| 16:03:36 | aspiers | kashyap: "Uploaded patch set 8: Commit message was updated." | |
| 16:04:01 | aspiers | stephenfin: No technical debt to see here, move along now! | |
| 16:04:20 | kashyap | aspiers: That's it, no? | |
| 16:04:35 | aspiers | Doh | |
| 16:04:37 | aspiers | Yes it is | |