Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2019-05-28
22:45:43 openstackgerrit Adam Spiers proposed openstack/nova master: extract baselineCPU API call from _get_cpu_traits() https://review.opendev.org/661782
22:45:57 eandersson We found that with a high number of computes, the whole heal instance info cache got a little too chatty on the default setting.
22:46:32 aspiers efried: at risk of highlighting my own incompetence, this is the kind of change where normally I'd be inclined to avoid a rebase of everything sitting on top: https://review.opendev.org/#/c/661782/3..4/nova/virt/libvirt/driver.py
22:47:00 aspiers efried: that said, I'm totally fine with rebasing if you'd prefer that
22:47:56 aspiers ah actually, since splitting out some other patches, there's only one patch sitting on top
22:48:02 aspiers so maybe I will anyway
22:49:37 aspiers hah, especially considering zuul absolutely hates that change sitting on top
22:49:49 efried aspiers: I respect your green-ness. And maybe you'll start a sea change in nova. All I'm saying is that all the series contributions I've seen in my (albeit limited) time here have been managed in a series-as-a-whole fashion.
22:50:39 aspiers efried: fine by me :) I maintain the belief that Gerrit should visualise the dependency tree in a way which would make this kind of stuff a no-brainer
22:50:57 aspiers but until it gets smarter, I'm happy to do whatever to make reviews easier
22:51:59 efried aspiers: I use the tree-shaped version of git log locally, do you?
22:52:14 efried To me, that sounds more or less like the visualization you're talking about...
22:52:17 aspiers I use gitk, but that shows the history, not the real dependency tree
22:52:26 efried ...and in that visualization, the way it's expressed is bang on.
22:52:54 efried i.e. you can't say that PS4 of X is based on PS2 of Y when it's in fact based on PS1 of Y.
22:53:05 aspiers I'm talking about semantic dependencies https://aspiers.github.io/nashville-git-automagic-april-2019/#/git-deps-concept
22:53:07 efried Because PS1 and PS2 of Y could be *wildly* bifferent.
22:53:11 efried or even different.
22:53:25 aspiers I like bifferent, it should be a word
22:53:47 efried Back to the Future referential, somehow.
22:53:54 aspiers :)
22:54:13 efried like how a guy can be a jerk until you go back in time and kick his ass, then when you come back to the present, he's bifferent.
22:54:32 aspiers exactly :)
22:55:06 aspiers actually that was misleading - git-deps deals in textual dependencies, but here I mean semantic ones
23:09:18 openstackgerrit Matt Riedemann proposed openstack/nova master: Update usage in RT.drop_move_claim during confirm resize https://review.opendev.org/641806
23:09:18 openstackgerrit Matt Riedemann proposed openstack/nova master: Fix hard-delete of instance with soft-deleted referential constraints https://review.opendev.org/661398
23:09:19 openstackgerrit Matt Riedemann proposed openstack/nova master: Add Migration.cross_cell_move and get_by_uuid https://review.opendev.org/614012
23:09:19 openstackgerrit Matt Riedemann proposed openstack/nova master: Robustify attachment tracking in CinderFixtureNewAttachFlow https://review.opendev.org/658904
23:09:20 openstackgerrit Matt Riedemann proposed openstack/nova master: Add Instance.hidden field https://review.opendev.org/631123
23:09:20 openstackgerrit Matt Riedemann proposed openstack/nova master: Add InstanceAction/Event create() method https://review.opendev.org/614036
23:09:21 openstackgerrit Matt Riedemann proposed openstack/nova master: Add CrossCellMigrationTask https://review.opendev.org/631581
23:09:21 openstackgerrit Matt Riedemann proposed openstack/nova master: Add TargetDBSetupTask https://review.opendev.org/627892
23:09:22 openstackgerrit Matt Riedemann proposed openstack/nova master: Add prep_snapshot_based_resize_at_dest compute method https://review.opendev.org/633293
23:09:22 openstackgerrit Matt Riedemann proposed openstack/nova master: Execute TargetDBSetupTask https://review.opendev.org/633853
23:09:23 openstackgerrit Matt Riedemann proposed openstack/nova master: Add prep_snapshot_based_resize_at_source compute method https://review.opendev.org/634832
23:09:23 openstackgerrit Matt Riedemann proposed openstack/nova master: Add PrepResizeAtDestTask https://review.opendev.org/627890
23:09:24 openstackgerrit Matt Riedemann proposed openstack/nova master: Add PrepResizeAtSourceTask https://review.opendev.org/627891
23:09:24 openstackgerrit Matt Riedemann proposed openstack/nova master: Add nova.compute.utils.delete_image https://review.opendev.org/637605
23:09:25 openstackgerrit Matt Riedemann proposed openstack/nova master: Add power_on kwarg to ComputeDriver.spawn() method https://review.opendev.org/642590
23:09:25 openstackgerrit Matt Riedemann proposed openstack/nova master: Refactor ComputeManager.remove_volume_connection https://review.opendev.org/642183
23:09:26 openstackgerrit Matt Riedemann proposed openstack/nova master: Add FinishResizeAtDestTask https://review.opendev.org/635646
23:09:26 openstackgerrit Matt Riedemann proposed openstack/nova master: Add finish_snapshot_based_resize_at_dest compute method https://review.opendev.org/635080
23:09:38 openstackgerrit Matt Riedemann proposed openstack/nova master: Support cross-cell moves in external_instance_event https://review.opendev.org/658478
23:09:38 openstackgerrit Matt Riedemann proposed openstack/nova master: Add CrossCellWeigher https://review.opendev.org/614353
23:09:39 openstackgerrit Matt Riedemann proposed openstack/nova master: WIP: Enable cross-cell resize in the nova-multi-cell job https://review.opendev.org/656656
23:09:39 openstackgerrit Matt Riedemann proposed openstack/nova master: Add cross-cell resize policy rule and enable in API https://review.opendev.org/638269
23:09:40 openstackgerrit Matt Riedemann proposed openstack/nova master: Add functional test for anti-affinity cross-cell migration https://review.opendev.org/661859
23:10:38 mriedem melwitt: you might be interested in https://review.opendev.org/#/c/661859/ since it's related to the setup_instance_group group.hosts lazy-load / cell context stuff you worked on before
23:11:30 mriedem turns out the move operation assumptions in there don't work for cross-cell migration with an anti-affinity group but the anti-affinity server group filter doesn't look at request_spec.instance_group.hosts since rocky anyway
23:11:37 mriedem so it magically just sort of works
#openstack-nova - 2019-05-29
00:50:57 openstackgerrit Tony Breeds proposed openstack/nova stable/queens: Delete allocations even if _confirm_resize raises https://review.opendev.org/652153
00:52:50 openstackgerrit Tony Breeds proposed openstack/nova stable/queens: [stable-only] Delete allocations even if _confirm_resize raises (part 2) https://review.opendev.org/661349
00:54:40 openstackgerrit Tony Breeds proposed openstack/nova stable/queens: Add functional confirm_migration_error test https://review.opendev.org/658136
01:19:54 openstackgerrit Yikun Jiang proposed openstack/nova master: Fix the server group "policy" field type in api-ref https://review.opendev.org/661869
01:20:49 yikun [1] https://review.opendev.org/#/c/567534/31..32/doc/api_samples/os-server-groups/v2.64/server-groups-post-req.json
01:20:49 yikun ^ mriedem, Yes, I think it's a api-ref bug. And I also saw why it happened: it came from original patch PS31~32 [1], the policy code had been change from "object" to "string", but I forgot to change the api-ref together.
02:57:25 openstackgerrit Guo Jingyu proposed openstack/nova master: Define and catch QemuGuestAgentNotRunning for set-password failure https://review.opendev.org/661466
03:25:32 openstackgerrit guangchao.pan proposed openstack/nova master: Add a name for the automatically created volume https://review.opendev.org/660096
03:56:06 openstackgerrit Merged openstack/nova master: Use run_immediately=True for _cleanup_running_deleted_instances https://review.opendev.org/657132
03:56:13 openstackgerrit Merged openstack/nova master: Remove 'instance_update_from_api' https://review.opendev.org/651302
03:56:23 openstackgerrit Merged openstack/nova master: Stop handling 'update_cells' on 'BandwidthUsage.create' https://review.opendev.org/651303
03:56:31 openstackgerrit Merged openstack/nova master: Stop handling cells v1 for instance naming https://review.opendev.org/651304
03:56:41 openstackgerrit Merged openstack/nova master: Remove cells code https://review.opendev.org/651306
03:56:50 openstackgerrit Merged openstack/nova master: Remove conductor_api and _last_host_check from manager.py https://review.opendev.org/651059
03:57:55 openstackgerrit Merged openstack/nova master: Remove 'etc/nova/cells.json' https://review.opendev.org/660146
04:00:20 openstackgerrit Merged openstack/nova master: Reduce logging of host hypervisor capabilities to DEBUG level https://review.opendev.org/661379
04:09:18 openstackgerrit Merged openstack/nova master: Fix live-migration when glance image deleted https://review.opendev.org/659054
07:06:50 openstackgerrit Yongli He proposed openstack/nova-specs master: add spec "show-server-numa-topology" https://review.opendev.org/658716
08:00:21 kashyap efried: aspiers: Thanks for the review on that os-traits patch. Will address it soon.
08:15:06 openstackgerrit guangchao.pan proposed openstack/nova master: Add a name for the automatically created volume https://review.opendev.org/660096
09:12:32 aspiers kashyap: cool
09:48:12 kashyap aspiers: Still about?
09:48:19 aspiers yep
09:48:56 kashyap aspiers: When you get a moment, I'm stuck in "unit test rut", wonder if you can have a gander at this WIP (line 102): http://paste.openstack.org/show/752226/
09:49:29 kashyap aspiers: The code it is testing is also pasted in the pastebin, for convenience. (It is in relation to this patch you reviewed in the past: https://review.opendev.org/#/c/639091/)
09:49:59 kashyap Maybe I should just post the WIP, broken unit test, so you could comment in Gerrit itself :D
09:51:09 kashyap Let me post it
09:52:02 stephenfin johnthetubaguy++ Thanks for running through those remove-cellsv1 patches
09:52:38 openstackgerrit Kashyap Chamarthy proposed openstack/nova master: libvirt: Rework 'EBUSY' (SIGKILL) error handling code path https://review.opendev.org/639091
09:52:51 kashyap aspiers: ^ The "broken" unit test
09:53:24 zigo Is there a way to remove an already runningn instance from a server group?
09:55:34 aspiers kashyap: oh nice, didn't know it was possible to refer to abbreviated change-ids
09:57:04 kashyap aspiers: Yeah, I just tried it, based on commit ID trimming I do
09:57:36 aspiers kashyap: what's the FIXME for?
09:58:07 aspiers won't that fail flake8 or something?
09:58:16 kashyap aspiers: As I felt the test was not 100% accurate, although it "passes"
09:58:34 aspiers I think any FIXME needs an explanation
09:58:35 kashyap Wanted someone to double-check it; will remove it on next PS (as I need one more test)
09:58:57 kashyap Yes, yes. I was not going to put in a "naked FIXME" like that. It won't exist.
09:59:35 aspiers Oh, sorry I missed your previous messages
10:00:06 aspiers Nevertheless, I think I'm missing (i.e. probably forgot) some context here
10:00:42 aspiers How are you stuck?
10:01:05 kashyap aspiers: Err, not exactly 'stuck' (bad wording); but just needs a once-over of the test. Is the "mocking" correct, etc
10:01:13 aspiers Oh right
10:01:42 aspiers OK so this one is for testing the >= 4.7.0 behaviour?
10:02:39 kashyap aspiers: Right
10:03:05 kashyap aspiers: Both, test with and without MIN_LIBVIRT_BETTER_SIGKILL_HANDLING
10:03:18 kashyap aspiers: I.e. hit the warining of _SIGKILL_HANDLING isn't satisfied
10:03:29 aspiers I mean the test with the FIXME
10:05:15 kashyap Yeah, it is "supposed" to :D

Earlier   Later