Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2019-05-17
16:44:01 stephenfin Thankfully, tbh. It's already too clever
16:44:09 efried so just copy them into those envs
16:44:58 efried also would have thought having used envdir would be enough
16:45:05 efried but apparently something is *requiring* deps?
16:45:45 openstackgerrit Eric Fried proposed openstack/nova stable/stein: Skip _exclude_nested_providers() if not nested https://review.opendev.org/659206
16:45:45 openstackgerrit Eric Fried proposed openstack/nova stable/stein: DNM: Revert "Use external placement in functional tests" https://review.opendev.org/659682
16:45:55 efried thanks for the look stephenfin
16:58:47 efried aspiers: thanks for the updates. Convince me that LibvirtConfigDomainCapsFeature needs to exist *ever*.
16:59:13 aspiers efried: just saw your comment on the follow-up change about that
16:59:27 aspiers efried: think I see where you're coming from now, maybe
16:59:42 aspiers so your point is that a base class isn't needed here
16:59:58 aspiers even though we expect there to be other feature classes in the future
17:00:16 aspiers or at least, have no reason to believe that there definitely won't be
17:00:20 aspiers right?
17:00:27 efried Right, because the only thing you're doing with that base class is converting a positional 'name' arg into the 'root_name' kwarg.
17:00:40 aspiers Yeah, that's a fair comment
17:00:41 efried which the subclasses can do just as easily.
17:01:34 aspiers but couldn't the same argument apply to LibvirtConfigGuestDeviceAddress?
17:01:50 aspiers I was trying to follow the precedent which already seemed to exist in config.py
17:03:20 aspiers Anyway I'm not religious about the need for that base class
17:03:22 efried Looking... but I tend to be in the camp of "follow precedent thoughtfully"
17:03:37 aspiers We could always reintroduce a base class later if need be
17:03:43 aspiers I'm in the same camp for sure :)
17:03:59 efried no, **DeviceAddress does some actual things in its overrides.
17:04:43 aspiers I don't see any method in the DeviceAddress base class which adds any value
17:04:56 aspiers the subclass overrides do add value, naturally
17:05:24 aspiers but actually there's a much better example which I remember following
17:05:31 aspiers LibvirtConfigGuestFeature
17:05:40 efried https://review.opendev.org/#/c/633855/13/nova/virt/libvirt/config.py@1351 ?
17:05:42 aspiers I was just copying that approach
17:06:21 efried Yes, LibvirtConfigGuestFeature is similarly worthless and could be removed imo.
17:06:25 efried (separately)
17:06:51 aspiers OK, so LibvirtConfigGuestDeviceAddress.__init__() does *one* thing of use: setting self.type
17:07:01 aspiers so not entirely redundant
17:07:03 efried yeah, but the other methods do real things.
17:07:13 aspiers they are overridden by both subclasses though
17:07:23 aspiers oh, super()
17:07:25 aspiers OK
17:07:36 aspiers missed that
17:07:53 efried **kwargs)
17:07:53 efried super(LibvirtConfigGuestFeatureACPI, self).__init__(root_name="acpi",
17:07:53 efried def __init__(self, **kwargs):
17:07:53 efried class LibvirtConfigGuestFeatureACPI(LibvirtConfigObject):
17:07:53 efried but for LibvirtConfigGuestFeature, there's no reason e.g. the next one couldn't just be
17:08:11 efried similarly for the subsequent two.
17:08:12 openstackgerrit Doug Wiegley proposed openstack/nova master: Improve metadata server performance with large security groups https://review.opendev.org/656084
17:08:14 aspiers Now that this conversation jogged my memory, I remember I was definitely emulating LibvirtConfigGuestFeature
17:08:20 efried etc etc
17:08:26 aspiers Yeah
17:08:34 aspiers Well like I said, I'm not religious about the base class at all
17:08:50 aspiers I originaly thought you were saying it was pointless for other reasons
17:08:51 efried yeah, if you were emulating... you could have just used that.
17:08:56 efried but I'd rather kill it.
17:09:01 aspiers fine
17:09:05 aspiers coming right up in PS5
17:09:08 efried In fact, I'm going to propose a patch to get rid of all that other cruft and see if it breaks the world.
17:10:01 sean-k-mooney im expecting an rm -rf of the nova subdiretory
17:10:04 aspiers lol
17:10:17 aspiers sean-k-mooney: that would be one way of getting rid of all the bugs ;)
17:10:43 aspiers "Perfection is achieved, not when there is nothing more to add, but when there is nothing left to take away."
17:11:14 aspiers not sure St Exupery meant it quite like that though
17:12:01 sean-k-mooney well we have almost reached perfrection of cellsv1 in that case
17:14:47 aspiers efried: I can remove that cruft if you want
17:14:55 efried aspiers: I'm already working on it.
17:14:59 aspiers ok
17:15:18 aspiers efried: didn't anyone tell you PTLs aren't allowed to code? ;-p
17:15:24 efried sore point
17:15:30 aspiers strictly no fun allowed
17:15:53 aspiers just feeling smug cos I temporarily escaped endless meetings
17:15:55 aspiers I'm sure it won't last
17:16:57 openstackgerrit Adam Spiers proposed openstack/nova master: Add infrastructure for invoking libvirt's getDomainCapabilities API https://review.opendev.org/655268
17:17:22 aspiers and now a rebase for good measure ...
17:17:30 openstackgerrit Adam Spiers proposed openstack/nova master: Add infrastructure for invoking libvirt's getDomainCapabilities API https://review.opendev.org/655268
17:21:34 aspiers efried: I'm around for a while in case there are any remaining things you want addressed in that
17:21:51 efried aspiers: 2 mins and I'll have another look.
17:22:22 aspiers kewl
17:23:04 openstackgerrit Eric Fried proposed openstack/nova master: Remove no-op intermediary libvirt config classes https://review.opendev.org/659848
17:23:06 efried aspiers: ^
17:24:51 efried aspiers: +2. Now you get to rebase the others on top :)
17:24:58 efried shouldn't be too hard
17:24:59 aspiers efried: already started
17:25:01 aspiers nah it's not
17:41:27 sean-k-mooney aspiers: v6 of https://review.opendev.org/#/c/655268 looks good to me. if i want to reuse this for the device model based schduleing i will need to extend the config parsing logic accordingly but tha that shoudl be quite clean to do
17:41:37 aspiers sean-k-mooney: cool
17:42:42 openstackgerrit Adam Spiers proposed openstack/nova master: Add detection of SEV support from QEMU/AMD-SP/libvirt on AMD hosts https://review.opendev.org/633855
17:42:49 aspiers efried: there's the first rebase ^^^
17:43:15 aspiers sean-k-mooney: ^^^ in case you want to see the first example of a real customer of that API
17:43:36 sean-k-mooney yep ill try an review the full sev series next week.
17:43:47 sean-k-mooney but for now time to go get food
17:43:50 sean-k-mooney o/
17:43:55 aspiers sean-k-mooney: thanks, it's still incomplete but working on it
17:43:58 aspiers o/
17:51:04 efried aspiers: Once kashyap and/or sean-k-mooney have +1ed https://review.opendev.org/#/c/633855/ I'll send it.
17:51:23 openstackgerrit Adam Spiers proposed openstack/nova master: Add new "supports_amd_sev" capability to libvirt driver https://review.opendev.org/638680
17:51:31 aspiers efried: thanks, and there's the next one on top of that ^^^
17:51:36 sean-k-mooney efried: by the way really small change but can you comment on my comment in the commit message regarding bug vs specless blueprint
17:51:38 sean-k-mooney https://review.opendev.org/#/c/658785/4
17:52:18 efried sean-k-mooney: looking
17:56:04 efried sean-k-mooney: I would need a better explanation of wtf this patch is doing.
17:56:30 sean-k-mooney efried: we support hardware offlwoad ovs with kernel ovs today

Earlier   Later