Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2019-05-07
19:03:11 dansmith i.e. list of tests
19:04:42 aspiers Hmm, re-reading the scrollback - did you say nova already exposes some health data on an existing endpoint?
19:05:09 aspiers I wasn't aware of that ... /me checks the API docs
19:05:18 dansmith no
19:05:19 aspiers Maybe it's just using the existing oslo.middleware mechanism
19:05:29 dansmith no, I'm saying we *should* do that
19:05:45 dansmith none of our services (other than API) even have http interfaces, so we need to do that thing
19:05:46 aspiers Ah, wrong interpretation of "this" --> http://eavesdrop.openstack.org/irclogs/%23openstack-nova/%23openstack-nova.2019-05-07.log.html#t2019-05-07T17:53:25
19:05:51 dansmith I'm saying this is what we should be doing
19:06:15 aspiers Yeah OK, that's what I thought. Just got momentarily confused by the scrollback.
19:06:39 aspiers Sorry :)
19:09:14 artom I have to say, opening up internal services with an HTTP endpoint seems dangerous, security wise.
19:09:35 artom Depends on how it's implemented, I guess
19:09:44 artom But being able to DDoS the conductor doesn't seem fun
19:10:16 aspiers artom: I doubt OS-Helm has any intention of carrying out DDoS attacks ;-)
19:10:16 artom Tough I guess any self-respecting operator will firewall the crap out of those
19:10:34 aspiers Exactly. They probably don't even need to listen outside localhost
19:10:53 aspiers Remember this is k8s monitoring from the container host
19:10:56 aspiers or similar
19:11:04 artom aspiers, I don't doubt Helm's intentions, it's others I'm paranoid about
19:11:14 aspiers It won't be open to others
19:11:33 aspiers ... unless the operator wants it to be. We're on the same page :)
19:12:00 dansmith artom: it's read-only, has no real info, and you can make it depth-1, so literally only one request at a time
19:12:11 aspiers Right
19:12:46 artom dansmith, what, you mean dumping a detailed 1MB JSON blob of stats isn't a good idea? ;)
19:13:00 aspiers It actually links up quite nicely with dirk's idea of exposing more internal metrics for consumption by e.g. Prometheus
19:14:18 aspiers Anyway, gotta go. Back tomorrow.
21:49:46 cfriesen is opendev.org down?
22:02:31 cdent cfriesen: looks that way
22:43:49 openstackgerrit John Garbutt proposed openstack/nova master: Move default policy target https://review.opendev.org/657696
22:43:50 openstackgerrit John Garbutt proposed openstack/nova master: Add functional test for admin_actions https://review.opendev.org/657698
22:43:50 openstackgerrit John Garbutt proposed openstack/nova master: Better policy unit tests https://review.opendev.org/657697
22:57:52 openstackgerrit John Garbutt proposed openstack/nova master: WIP: Integrating with unified limits https://review.opendev.org/615180
#openstack-nova - 2019-05-08
00:06:09 openstackgerrit Takashi NATSUME proposed openstack/nova stable/stein: Fix assert methods in unit tests https://review.opendev.org/657708
00:09:15 openstackgerrit Takashi NATSUME proposed openstack/nova stable/rocky: Fix assert methods in unit tests https://review.opendev.org/657709
02:50:52 openstackgerrit melanie witt proposed openstack/nova master: Revert "Fix target_cell usage for scatter_gather_cells" https://review.opendev.org/653894
02:50:52 openstackgerrit melanie witt proposed openstack/nova master: Fix SynchronousThreadPoolExecutorFixture mock of Future https://review.opendev.org/650171
02:50:53 openstackgerrit melanie witt proposed openstack/nova master: Use futurist.ThreadPoolExecutor in scatter_gather_cells https://review.opendev.org/650172
08:02:45 openstackgerrit melanie witt proposed openstack/nova master: Use futurist.ThreadPoolExecutor in scatter_gather_cells https://review.opendev.org/650172
08:02:46 openstackgerrit melanie witt proposed openstack/nova master: Replace eventlet.timeout.Timeout with StopWatch timer https://review.opendev.org/657750
08:27:59 openstackgerrit Tushar Patil proposed openstack/nova-specs master: Allow compute nodes to use DISK_GB from shared storage RP https://review.opendev.org/650188
09:47:18 openstackgerrit Rodolfo Alonso Hernandez proposed openstack/os-vif stable/queens: Prevent "qbr" Linux Bridge from replying to ARP messages https://review.opendev.org/655694
11:14:44 aspiers kashyap: Hope you got back OK. Are you happy with https://review.opendev.org/#/c/655268/ now?
11:15:04 kashyap aspiers: Heya, yes, got back alright.
11:16:50 kashyap aspiers: Will look at it shortly. Doing some urgent paperwork that can't wait
11:16:56 aspiers OK
11:17:00 aspiers Yeah I need to do expenses :-/
11:18:47 kashyap That's nothing compared to what I'm upto :D
11:21:21 aspiers Oh yeah? Buying a house? :)
11:21:38 kashyap No, work-related
11:24:02 openstackgerrit Surya Seetharaman proposed openstack/nova master: Microversion 2.73: Support adding the reason behind a server lock https://review.opendev.org/648662
11:25:00 tssurya easy approval for a doc refactor if any cores are around: https://review.opendev.org/#/c/657624
11:53:24 gibi tssurya: done
11:53:31 tssurya gibi: thanks :)
11:54:20 gibi tssurya: I will get back to your lock reason patch most probably tomorrow
11:54:38 tssurya gibi: no hurries, take your time :)
11:59:44 kashyap aspiers: Thanks for the detailed response there. I will give it my full attention soon.
12:00:10 kashyap aspiers: Also feel free to write to the libvir-list@redhat.com (no subscription needed) to request additional clarification on the API docs
12:00:21 kashyap libvirt docs are "lacking", to put it very very mildly.
12:00:36 kashyap (Particularly sparse on API usage)
12:03:59 openstackgerrit Merged openstack/nova master: [Docs] Change the server query parameter display into a list. https://review.opendev.org/657624
13:05:07 openstackgerrit Balazs Gibizer proposed openstack/nova master: Defaults missing group_policy to 'none' https://review.opendev.org/657796
13:15:20 efried aspiers: discussing os-resource-classes build failure with stephenfin in -placement
13:17:15 openstackgerrit Eric Fried proposed openstack/os-resource-classes master: Use py3 for docs build https://review.opendev.org/657800
13:17:26 efried aspiers: ^ might fix
13:17:30 efried will rebase your patch on that.
13:17:54 openstackgerrit Eric Fried proposed openstack/os-resource-classes master: Add MEM_ENCRYPTION_CONTEXT resource class https://review.opendev.org/655665
13:18:33 efried aspiers: like that ^
13:30:34 openstackgerrit Eric Fried proposed openstack/os-resource-classes master: Propose standard ACCELERATOR_FPGA resource class https://review.opendev.org/657464
13:31:51 openstackgerrit Merged openstack/nova master: Fix SynchronousThreadPoolExecutorFixture mock of Future https://review.opendev.org/650171
13:39:00 openstackgerrit Eric Fried proposed openstack/os-resource-classes master: Use py3 for all* tox targets https://review.opendev.org/657800
14:13:15 openstackgerrit Adam Spiers proposed openstack/os-resource-classes master: Add missing upper-constraints.txt to deps in docs testenv https://review.opendev.org/657815
14:26:40 openstackgerrit Eric Fried proposed openstack/os-resource-classes master: Add MEM_ENCRYPTION_CONTEXT resource class https://review.opendev.org/655665
14:32:12 openstackgerrit John Garbutt proposed openstack/nova master: WIP: add scope check, see tests catch the change https://review.opendev.org/657823
14:37:29 openstackgerrit Merged openstack/os-resource-classes master: Add missing upper-constraints.txt to deps in docs testenv https://review.opendev.org/657815
14:41:34 openstackgerrit Merged openstack/os-resource-classes master: Use py3 for all* tox targets https://review.opendev.org/657800
14:42:47 mriedem crap lee is out for 2 weeks huh
14:44:32 mriedem stable is bizzusted
14:47:37 openstackgerrit Merged openstack/os-resource-classes master: Add MEM_ENCRYPTION_CONTEXT resource class https://review.opendev.org/655665
14:52:21 openstackgerrit Eric Fried proposed openstack/os-resource-classes master: Propose standard ACCELERATOR_FPGA resource class https://review.opendev.org/657464
15:08:54 kashyap Wonder if the Etherpad content from -train-2 and -train-3 is replicated back to to -train
15:09:06 kashyap Okay ... none of the Etherpads load for me.
15:13:12 mriedem fyi we can't land changes on stable until https://review.opendev.org/#/q/topic:bug/1828244+(status:open+OR+status:merged)
15:34:02 openstackgerrit Merged openstack/nova master: Revert "Fix target_cell usage for scatter_gather_cells" https://review.opendev.org/653894
16:28:37 mriedem dansmith: can you send this to its maker https://review.opendev.org/#/c/655800/
16:35:26 dansmith yar
17:31:30 melwitt dansmith: I need some help/ideas on the cell scatter gather native thread patch https://review.opendev.org/650172 if you could take another look please
17:32:40 dansmith melwitt: related to the native threads sticking around that bogdan commented on?
17:33:48 melwitt dansmith: yeah. and gibi's comment. afaict, if the method being run in the thread is going to hang forever, we can't do anything about that. if there is a way, I don't know it
17:34:12 melwitt and figured if anyone would know, it would be you :)
17:34:44 dansmith well, hanging forever and leaving them around isn't an option
17:35:01 dansmith I saw bogdan's comment via email but haven't really looked in detail
17:35:03 dansmith but will in a bit
17:35:24 melwitt dansmith: I'm also wondering about gibi's question about not using the ThreadPoolExecutor in the unit and func tests. I got a deadlock in the unit tests but not the func tests. and I didn't know how to get around it
17:37:35 melwitt dansmith: yeah, I guess I'm confused by what can be done about it. if the call inside the thread is never going to return, how is that different than a non-thread call not ever returning
17:37:53 dansmith you mean an eventlet thread never returning?
17:38:04 dansmith because eventlet threads aren't really threads and you can cancel them at any io sync point
17:38:12 melwitt I mean the method inside, like InstanceList.get_by_filters. if that were to hang forever
17:38:46 melwitt because that's the only way the thread will stay around indefinitely, right?
17:40:02 dansmith well, whatever the thread is blocked on, yeah

Earlier   Later