Posted	Nick	Remark
#openstack-nova - 2019-05-03
20:21:16	mriedem	well resize can reschedule and run on a conductor in the cell
20:22:10	mriedem	bauzas: whether or not that works depends on your cell conductor config being able to hit the api db https://bugs.launchpad.net/nova/+bug/1781286
20:22:11	openstack	Launchpad bug 1781286 in OpenStack Compute (nova) "CantStartEngineError in cell conductor during reschedule - get_host_availability_zone up-call" [Medium,Triaged]
20:22:12	bauzas	I'm confused then, but nevermind, I'll just take my devstack and try
20:22:29	mriedem	bauzas: devstack will fail on ^ during a resize reschedule
20:22:41	mriedem	if there is no reschedule, then yes it's just super-conductor
20:23:12	bauzas	ok, the context is just a resize
20:23:25	bauzas	and yeah, gotcha
20:26:44	gibi_cape	mriedem, tssurya: I don't think we have manpower to transform ceilometer to versioned notifications.
20:29:45	tssurya	gibi_cape: agreed i'm just saying changing this to unversioned by default basically means no one will take efforts to move maybe, I do understand the bug scenario and perf issues which is why we have the workaround option for the deployments to set it to unversioned, I wasn't just sure if we should go out and make that the default
20:30:20	tssurya	but yea its your call :)
20:30:31	openstackgerrit	Merged openstack/nova master: Trivial: use default value in next() func https://review.opendev.org/653362
20:33:31	gibi_cape	tssurya: for me it is OK to keep it 'both' and keep the perf bug open. What I cannot do is to promise I will change ceilometer over to versioned
20:33:56	tssurya	gibi_cape: fair enough
20:34:07	mriedem	it'd be interesting to know if deployers (1) don't even notice the change or (2) noticed and changed to unversioned
20:34:12	mriedem	i know godaddy found out and changed it
20:34:21	mriedem	since they are heavy on notifications for internal stuff
20:34:37	mriedem	by "the change" i mean to 'both' long ago
20:34:51	mriedem	there is a guy 2 over from me from godaddy so he'd probably know better
20:43:34	openstackgerrit	Merged openstack/nova stable/stein: Fix help for ironic.peer_list config https://review.opendev.org/656632
20:56:42	dansmith	\\
21:01:21	openstackgerrit	melanie witt proposed openstack/nova master: Revert "Fix target_cell usage for scatter_gather_cells" https://review.opendev.org/653894
21:01:21	openstackgerrit	melanie witt proposed openstack/nova master: Fix SynchronousThreadPoolExecutorFixture mock of Future https://review.opendev.org/650171
21:01:22	openstackgerrit	melanie witt proposed openstack/nova master: Use futurist.ThreadPoolExecutor in scatter_gather_cells https://review.opendev.org/650172
21:05:29	openstackgerrit	Merged openstack/nova master: libvirt: drop MIN_LIBVIRT_POSTCOPY_VERSION https://review.opendev.org/649671
21:08:15	openstackgerrit	Merged openstack/nova master: libvirt: remove conditional on VIR_DOMAIN_EVENT_SUSPENDED_POSTCOPY https://review.opendev.org/649674
21:08:24	openstackgerrit	Merged openstack/nova master: Add Venn diagram showing taxonomy of traits and capabilities https://review.opendev.org/656032
21:08:32	openstackgerrit	Merged openstack/nova master: libvirt: Stop ignoring unknown libvirtError exceptions during volume attach https://review.opendev.org/655696
21:08:40	openstackgerrit	Merged openstack/nova master: Remove [ironic]api_endpoint option https://review.opendev.org/643483
21:10:42	openstackgerrit	Lee Yarwood proposed openstack/nova stable/stein: libvirt: Stop ignoring unknown libvirtError exceptions during volume attach https://review.opendev.org/657049
21:11:22	openstackgerrit	Lee Yarwood proposed openstack/nova stable/queens: libvirt: Stop ignoring unknown libvirtError exceptions during volume attach https://review.opendev.org/657050
21:14:45	openstackgerrit	Lee Yarwood proposed openstack/nova stable/rocky: libvirt: Stop ignoring unknown libvirtError exceptions during volume attach https://review.opendev.org/657051
21:18:23	mriedem	dansmith: nits in the docs patch https://review.opendev.org/#/c/657025/ not sure if you want to modify, but should probably make that a proper subsection so people can link to it
21:29:59	openstackgerrit	Matt Riedemann proposed openstack/nova master: Enable cross-cell resize in the nova-multi-cell job https://review.opendev.org/656656
21:32:49	lbragstad	johnthetubaguy https://opendev.org/openstack/oslo.policy/src/branch/master/oslo_policy/policy.py#L633
22:05:33	openstackgerrit	Matt Riedemann proposed openstack/nova master: Add InstanceList.get_uuids_by_host_and_node https://review.opendev.org/657070
22:06:28	openstackgerrit	Matt Riedemann proposed openstack/nova master: Optimize SchedulerReportClient.delete_resource_provider https://review.opendev.org/657070
22:11:49	openstackgerrit	Merged openstack/nova master: Include all network devices in nova diagnostics https://review.opendev.org/648123
22:11:56	openstackgerrit	Merged openstack/nova master: Add ids to sections of flavors guide to allow deep-linking https://review.opendev.org/653458
22:15:31	efried	mriedem: where you at? Compute capabilities as traits in 207
22:18:23	mriedem	right next to you
22:26:57	openstackgerrit	Chris Dent proposed openstack/nova master: WIP: Make nova-tox-functional-py36 reusable https://review.opendev.org/657074
22:31:20	openstackgerrit	Dan Smith proposed openstack/nova master: Add a workaround config toggle to refuse ceph image upload https://review.opendev.org/657078
22:35:50	openstackgerrit	Balazs Gibizer proposed openstack/nova master: Log when port resource is leaked during port delete https://review.opendev.org/657079
22:54:50	sean-k-mooney	https://github.com/openstack/nova/blob/master/nova/scheduler/filters/affinity_filter.py#L108-L111
22:55:39	gmann	johnthetubaguy: melwitt this is how currently or in past, we handle the deprecated policy check -L47 https://etherpad.openstack.org/p/ptg-train-xproj-nova-keystone
22:56:28	openstackgerrit	Stephen Finucane proposed openstack/nova master: docs: Rework the PCI passthrough guides https://review.opendev.org/635243
22:57:50	melwitt	gmann: thanks
23:20:03	openstackgerrit	Chris Dent proposed openstack/nova master: Make nova-tox-functional-py36 reusable https://review.opendev.org/657074
#openstack-nova - 2019-05-04
02:22:16	openstackgerrit	Merged openstack/nova master: libvirt: Always disconnect volumes after libvirtError exceptions https://review.opendev.org/655712
03:05:43	openstackgerrit	Merged openstack/nova master: Add nova-status upgrade check for minimum required cinder API version https://review.opendev.org/649759
09:16:43	openstackgerrit	Merged openstack/nova master: Delete the placement code https://review.opendev.org/618215
12:14:59	lyarwood	\o/
12:23:25	openstackgerrit	Lee Yarwood proposed openstack/nova stable/stein: libvirt: Always disconnect volumes after libvirtError exceptions https://review.opendev.org/657109
12:23:55	openstackgerrit	Lee Yarwood proposed openstack/nova stable/rocky: libvirt: Always disconnect volumes after libvirtError exceptions https://review.opendev.org/657110
12:24:32	openstackgerrit	Lee Yarwood proposed openstack/nova stable/queens: libvirt: Always disconnect volumes after libvirtError exceptions https://review.opendev.org/657111
12:58:33	openstackgerrit	sean mooney proposed openstack/nova master: Libvirt: add nfv job https://review.opendev.org/652197
13:21:18	openstackgerrit	sean mooney proposed openstack/nova master: Libvirt: add nfv job https://review.opendev.org/652197
13:39:25	openstackgerrit	Matt Riedemann proposed openstack/nova master: Enable cross-cell resize in the nova-multi-cell job https://review.opendev.org/656656
14:58:25	mriedem	rm_work: do you happen to know if oath needed to disable versioned notifications because of load on the MQ?
15:02:57	rm_work	mriedem: Not positive but I can track down an answer for you easily enough ;)
15:07:18	efried	cfriesen: I put a comment on the TPM patch, if you could take a look please. Unless I'm way off, may require a slight design change...
15:07:21	mriedem	thanks, wasn't sure who to ask
15:08:28	cfriesen	efried: will take a look, thanks
15:16:30	lyarwood	stephenfin: https://review.rdoproject.org/r/#/c/16234/ - now that placement has gone.
15:18:03	lyarwood	stephenfin: cheers
15:18:06	stephenfin	lyarwood: Done
15:18:50	efried	http://paste.openstack.org/raw/750586/ \o/
15:20:55	openstackgerrit	Merged openstack/nova stable/stein: libvirt: Stop ignoring unknown libvirtError exceptions during volume attach https://review.opendev.org/657049
15:24:09	stephenfin	efried: Only three patches standing between us and https://review.opendev.org/#/c/651306/8 too :)
15:24:22	stephenfin	Also, CI /o\
15:24:49	cdent	efried and or mriedem : if you could register an opinion on whether I should do the same changes to all the functional jobs as https://review.opendev.org/#/c/657074/ that would be keen. No rush, simply that it is in flight.
15:25:14	efried	stephenfin: yeah, I need to get back to that series (and a zillion others)
15:25:34	cdent	moar delegation
15:25:44	stephenfin	ack. It'll be back in a runway in a few weeks too
15:25:47	efried	stephenfin: We've also got mox, privsep, and fake-libvirt cleanups which ought to be pretty much ready to go.
15:26:35	stephenfin	efried: Aye, though privsep is blocked by some comments from you that mikal hasn't address yet. I've been tackling the libvirt version enum cleanup ones from mriedem/kashyap already
15:27:02	efried	oh, is that where I left privsep? cool
15:27:03	efried	:)
15:27:34	efried	looks like there are two I could push
15:30:02	cfriesen	efried: is the TPM version actually an issue? given that it's emulated, all hosts can provide both TPM versions. if the guest doesn't care, they can just ask for version 1.2
15:35:29	openstackgerrit	Merged openstack/nova stable/stein: libvirt: Avoid using os-brick encryptors when device_path isn't provided https://review.opendev.org/656462
15:40:40	rm_work	mriedem: seems that we just never enabled notifications to begin with? ¯\_(ツ)_/¯
15:40:52	rm_work	where can I go look in our deployment tooling/config to see? :D
15:41:02	rm_work	what config option is it?
15:41:35	mriedem	rm_work: https://docs.openstack.org/nova/latest/configuration/config.html#notifications
15:41:46	mriedem	https://docs.openstack.org/nova/latest/configuration/config.html#notifications.notification_format specifically is what i'm looking for
15:42:10	efried	cfriesen: Well, that's what I was asking you, I guess.
15:42:18	mriedem	also this https://docs.openstack.org/nova/latest/configuration/config.html#oslo-messaging-notifications
15:42:40	efried	cfriesen: Is it not the case that 2.0 is only available (emulatable) at certain versions of... things (qemu, libvirt, ...)?
15:43:25	mriedem	rm_work: notifications are enabled by default so maybe you're just generating them but not consuming them. to disable them, [oslo_messaging_notifications]/driver=noop
15:43:50	efried	cfriesen: Basically: is the model the thing the user primarily cares about, or is the version?
15:44:11	rm_work	ok, yeah i think that's likely
15:44:56	openstackgerrit	Lee Yarwood proposed openstack/nova stable/stein: Include all network devices in nova diagnostics https://review.opendev.org/657125
15:46:02	cfriesen	efried: the version of libvirt that introduced TPM support adds support for both, and the TPM emulator supports both, so they should always be available. I want to double-check with sean-k-mooney and kashyap but I think the initial concern would be the version as the two versions are quite different.
15:48:45	efried	cfriesen: Oh, so the implementation (which I haven't gotten to yet, sorry) is using the version trait to effect the proper emulated version?
15:48:58	efried	I guess if both versions are available, it would have to.
15:50:22	cfriesen	efried: yeah, the virt driver uses the version trait when generating the libvirt XML
15:51:58	efried	cfriesen: Okay. This was probably already discussed during design and I'm just late to the party. If hosts are advertising both versions, and users care about the version (are in fact locked to just one) then the current design is fine.
15:52:17	mriedem	smcginnis: can you stop in the nova room to talk about openlab for 5 minutes?

Earlier   Later