Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2019-04-25
13:33:55 kashyap efried: Okay, I used the word "validate" too loseely then. Let me add that phrase in.
13:34:11 efried right, I (as the reader) don't know what that means.
13:34:20 kashyap (The word "validate" was supposed to capture that. And I know I will uncover more details as I mull on the implementation.)
13:35:03 openstackgerrit Rodolfo Alonso Hernandez proposed openstack/os-vif stable/rocky: Prevent "qbr" Linux Bridge from replying to ARP messages https://review.opendev.org/655692
13:35:42 gibi efried: I saw the discussion about the lenght of the bandwith PTG slot
13:35:55 gibi efried: I think we can shrink that to 15-20 minutes
13:35:56 efried gibi: ack, I saw your response, will shrink.
13:35:59 efried thanks.
13:36:01 gibi efried: thanks
13:36:41 gibi efried: I also saw that you prepared the commit for the onboarding session. Is there anything I can still help with?
13:38:57 openstackgerrit Eric Fried proposed openstack/nova stable/rocky: Fix {min|max}_version in ironic Adapter setup https://review.opendev.org/655693
13:39:10 openstackgerrit Rodolfo Alonso Hernandez proposed openstack/os-vif stable/queens: Prevent "qbr" Linux Bridge from replying to ARP messages https://review.opendev.org/655694
13:39:11 efried mriedem, melwitt: ^
13:40:04 efried gibi: I'm not completely sure how I'm going to present that. What I would like to do is have my actual IDE running on the projector. Fallback is showing everything in browser.
13:40:26 efried I also don't know if I can fill 40 minutes with that demo :P
13:40:38 efried if you have suggestions, I'm all ears.
13:40:47 efried In any case, I would love to have you around for moral support.
13:41:18 gibi efried: If we run out of things and there are no questions then we can pull out the berlin presentation and talk about some part of it
13:41:38 gibi efried: I will definitly in the room to help
13:41:43 efried cool, thank you.
13:42:20 gibi efried: especially the last slide https://docs.google.com/presentation/d/1T6_CZvDf2eFgbtTecIfbrMBkPiX9-yYRXXKakZjlyXs/edit?usp=sharing
13:42:46 sean-k-mooney efried: kashyap i think https://blueprints.launchpad.net/nova/+spec/libvirt-video-device-models should now be fine?
13:44:00 kashyap sean-k-mooney: I'd use capitalization correctly, but that's a nit :D. Also there is an unwanted line break for the word "graphic"
13:44:05 openstackgerrit Rodolfo Alonso Hernandez proposed openstack/os-vif master: Remove IP proxy methods https://review.opendev.org/655695
13:45:16 sean-k-mooney updated
13:45:47 sean-k-mooney the content is there and anyone can edit so ill leave it to other to fix futher if it bothers them
13:46:04 efried sean-k-mooney, kashyap: Approved, thanks for the follow through.
13:47:33 kashyap efried: Nod
13:47:34 openstackgerrit Kashyap Chamarthy proposed openstack/nova-specs master: Add "CPU selection with hypervisor consideration" spec https://review.opendev.org/645814
13:47:53 kashyap efried: ^ Added the sentence on error logging. Does it look any better?
13:48:15 openstackgerrit Merged openstack/os-traits master: Document policy of never removing traits https://review.opendev.org/655673
13:48:19 efried kashyap: Yes, thank you, except for the typo serice
13:48:21 sean-k-mooney by the way i treied to have https://review.opendev.org/#/c/647733/ more or less be mergable in the first revision but i did wonder is there a place in our docs where the values of hw_video_model would/should be documented
13:48:23 kashyap gibi: You were also +2 on the above. If you want to re-{ACK,NACK} in your copious free time
13:48:26 kashyap Damn
13:48:31 sean-k-mooney stephenfin: ^ any idea
13:48:32 kashyap efried: I corrected it, didn't commit it :-(
13:48:49 gibi kashyap: ack, I will try to go back there today
13:49:16 mriedem adrianc: can you or hamdy (or moshe) start a backport for https://review.opendev.org/#/c/649345/ to stable/stein so we have it lined up?
13:49:30 openstackgerrit Kashyap Chamarthy proposed openstack/nova-specs master: Add "CPU selection with hypervisor consideration" spec https://review.opendev.org/645814
13:49:36 mriedem adrianc: oh nvm wrong patch
13:49:45 kashyap gibi: Thanks. It's largely clarification text added based on the feedback
13:50:03 mriedem adrianc: oh i guess that was right, i was looking at the neutron spec for some reason
13:50:12 efried mriedem: Do you want a final look at ^ ? It had multiple +2s and I just asked kashyap to add detail on what "validate" means (it means refuse to start nova-compute, with a helpful log) so I was going to fast approve it.
13:50:57 openstackgerrit Lee Yarwood proposed openstack/nova master: libvirt: Stop ignoring unknown libvirtError exceptions during volume attach https://review.opendev.org/655696
13:50:58 mriedem if you and gibi and alex_xu and everyone else are fine with it then no i don't need to spend time re-reviewing
13:51:26 efried ack, thx
13:51:43 mriedem lyarwood: thanks
13:52:23 kashyap mriedem: Your comments were useful. I spent 3+ hours thinking and writing a response to it this morning. Thanks for taking time!
13:52:47 stephenfin sean-k-mooney: Hmm, not sure. We have https://docs.openstack.org/nova/latest/admin/flavors.html but no image equivalent
13:53:16 mriedem stephenfin: it's in the glance docs
13:53:29 mriedem oh, that's not the extra spec one
13:53:41 aspiers efried: nova onboarding? maybe I can help with that
13:53:49 sean-k-mooney stephenfin: ya i quickly looked before and didnt fined one so didnt add any
13:54:01 aspiers efried: as a newbie to nova but not newbie to git/gerrit etc.
13:54:02 efried aspiers: Love it. What did you have in mind?
13:54:06 sean-k-mooney i am updating the glance metadef however to track the new values
13:54:19 aspiers efried: nothing, I only just saw your reference to onboarding in the scrollback ;)
13:54:43 sean-k-mooney stephenfin: we also have ovos for the image properties to that also track the allowed values.
13:54:43 efried aspiers: Good perspective: what were the most important things that helped you onboard into nova, being already familiar with openstack and its toolage?
13:54:45 mriedem stephenfin: sean-k-mooney: if you're looking for image metadata docs they are here https://docs.openstack.org/glance/latest/admin/useful-image-properties.html
13:55:05 sean-k-mooney ah they are in glance
13:55:06 efried aspiers: i.e. what would you tell someone to do if they were in a similar position and looking to get onboarded
13:55:06 mriedem managing images via the command line would be something i'd expect to find in the glance admin docs
13:55:17 aspiers efried: hrm, I guess "read the docs and ask a lot of questions on IRC"
13:55:18 sean-k-mooney ill update them when i update the image metadefs
13:55:30 mriedem https://docs.openstack.org/glance/latest/user/glanceclient.html
13:55:37 efried aspiers: If you want to give a brief off-the-cuff/anecdotal talk in the session, that would be most welcome.
13:55:53 aspiers efried: that might be possible. when is it?
13:55:57 efried ...
13:55:58 sean-k-mooney actuly i think these might be auto generated form teh metadefs
13:56:01 mriedem stephenfin: https://docs.openstack.org/glance/latest/admin/manage-images.html
13:56:07 mriedem sean-k-mooney: they are not
13:56:15 mriedem the useful-image-properties page is hand-written
13:56:26 efried aspiers: https://www.openstack.org/summit/denver-2019/summit-schedule/events/23620/nova-project-onboarding
13:56:40 sean-k-mooney oh ok ill update them so. thanks for the pointer
13:56:48 kashyap edleafe: On that traits patch, please see if I've answered your question
13:56:52 mriedem lyarwood: if you fix the alignment here https://review.opendev.org/#/c/655696/1/nova/virt/libvirt/driver.py i'm +2
13:57:21 kashyap edleafe: Ah, you've actually responded; I just needed to refresh it
13:57:36 edleafe kashyap: damn, I'm fast!
13:58:14 kashyap Damn, what I thought was a drive-by is becoming a shaving a farm of yaks :D
13:58:21 efried kashyap: I was going to respond on that one too, with a summary. TLDR, what I said in my last response, do that split and "deprecate" the HW_CPU_AMD_SEV in favor of HW_CPU_X86_AMD_SEV
13:59:13 kashyap efried: By "deprecate", you mean just add a note that it's bogus, right?
13:59:46 efried yes
13:59:48 sean-k-mooney efried: just re reviews kashyap cpu selection spec and im fine with the new verions. thanks kashyap
13:59:59 kashyap sean-k-mooney: Thanks!
14:00:03 edleafe Yeah, since the trait won't ever be removed. More of a "we screwed up; don't use this one" note
14:00:21 kashyap sean-k-mooney: We'll get to debate fun details in the implementation :D I have a WIP post patch to introduce the infra, before it gets lost
14:00:39 efried kashyap: re edleafe's comment on the NO_SSB thing, I thought that wasn't so much a negative trait as advertising that "this CPU has had the horrible thing removed".
14:00:54 efried iow, absent that trait, you can't tell whether it's there or not
14:01:13 efried so we want that trait so the consumer can be sure the horrible thing is gone.
14:01:19 kashyap Exactly
14:01:24 edleafe efried: if that's the case, then rename it to a positive assertion of a capability
14:01:29 kashyap That's why I wanted to mention it. Let me read Ed's comment
14:01:35 efried edleafe: like SSB_REMOVED?
14:01:47 edleafe sure, something along those lines
14:01:51 efried edleafe: Would prefer to retain symmetry with the CPU traits themselves, though.
14:02:07 kashyap "NO_SSB" == No more SSB vulnerability on this host CPU -- isn't that clear enough?
14:02:08 sean-k-mooney kashyap: i would like to see two thing. 1 on sucessful validation print the cpu configurtion the guest will see as an info long. on failure pritn the requested combination, whant the host supports and what could not be supproted as an error log.
14:02:09 efried with the names from the architecture, that is

Earlier   Later