| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2019-04-25 | |||
| 13:19:26 | openstack | bug 1825435 in OpenStack Compute (nova) "TestRPC unit tests intermittently fail with "'>' not supported between instances of 'NoneType' and 'datetime.datetime'" - maybe due to "Fatal Python error: Cannot recover from stack overflow."" [High,Confirmed] https://launchpad.net/bugs/1825435 | |
| 13:20:00 | sean-k-mooney | did we find where that was intoduced yet | |
| 13:20:12 | efried | it seems almost exclusively isolated to py36, so it hits lower-constraints (which runs on py36) and the py36 UT. | |
| 13:20:40 | efried | sean-k-mooney: No. mriedem has been trying to debug it (https://review.opendev.org/#/c/654468/ and its dep) but we can't get it to reproduce with those patches |
|
| 13:20:41 | sean-k-mooney | apparently it started to show up first in stephenfin cells v1 removal patches but that could also be a coincidnces | |
| 13:21:12 | efried | sean-k-mooney: If you can update the video models bp description as requested by kashyap, I'll approve it. | |
| 13:21:34 | sean-k-mooney | am sure ill go do that now. | |
| 13:21:35 | efried | jaypipes: I was specifically asking if those two topics were ones you wanted to be around for. If so, I can try to shuffle things around. | |
| 13:21:39 | efried | thanks sean-k-mooney | |
| 13:21:42 | kashyap | sean-k-mooney: Thank you! | |
| 13:22:25 | efried | aspiers: If you're around and want to fix that one typo in https://review.opendev.org/#/c/655673/ I'll fast approve. | |
| 13:22:36 | sean-k-mooney | i have it more or less in the relse note https://review.opendev.org/#/c/647733/3/releasenotes/notes/extend-libvirt-video-model-support-d630b99ef5039f51.yaml | |
| 13:22:39 | efried | If you're not around, I'll fix it. | |
| 13:22:52 | efried | sean-k-mooney: copy paste, baby | |
| 13:23:05 | efried | kashyap: You okay with the wording there --^ ? | |
| 13:23:35 | sean-k-mooney | i need to change it slightly but to make sense in a blueprint | |
| 13:23:46 | sean-k-mooney | mainly the tense but ill use it as teh basis | |
| 13:23:48 | stephenfin | efried: I don't think it is, actually | |
| 13:23:51 | mriedem | lyarwood: seems like an easy bug to fix, but you should look https://bugs.launchpad.net/nova/+bug/1825882 | |
| 13:23:52 | stephenfin | http://logs.openstack.org/97/651297/4/gate/openstack-tox-lower-constraints/758a74d/job-output.txt.gz | |
| 13:23:52 | openstack | Launchpad bug 1825882 in OpenStack Compute (nova) "Virsh disk attach errors silently ignored" [Undecided,New] | |
| 13:24:16 | kashyap | efried: I'll add a comment there. But the 'none' model should be described. You can copy/paste the phrase I posted earlier | |
| 13:24:28 | stephenfin | It looks like the test never finishes. If you grep for 'test_get_transport_url' the status is inprogress | |
| 13:24:36 | stephenfin | though I could be misreading that | |
| 13:25:31 | efried | mriedem: Is that not the same bug? http://logs.openstack.org/97/651297/4/gate/openstack-tox-lower-constraints/758a74d/job-output.txt.gz#_2019-04-25_07_44_46_919295 | |
| 13:25:40 | stephenfin | I also missed that you'd already rechecked. Oops | |
| 13:26:10 | efried | no takesie backsies | |
| 13:26:13 | kashyap | sean-k-mooney: efried I added the phrasing in the change. | |
| 13:26:38 | mriedem | efried: yes http://logs.openstack.org/97/651297/4/gate/openstack-tox-lower-constraints/758a74d/job-output.txt.gz#_2019-04-25_07_42_59_709756 | |
| 13:27:04 | efried | stephenfin: ^ | |
| 13:27:41 | stephenfin | jaypipes: If you've time, mind glancing over the cpu-resources spec to make sure I haven't cannibalized it too much? https://review.opendev.org/#/c/555081 | |
| 13:28:06 | openstackgerrit | Kashyap Chamarthy proposed openstack/nova-specs master: Add "CPU selection with hypervisor consideration" spec https://review.opendev.org/645814 | |
| 13:28:25 | openstackgerrit | Eric Fried proposed openstack/os-traits master: Document policy of never removing traits https://review.opendev.org/655673 | |
| 13:29:01 | efried | aspiers: FTFY and fast approved ^ | |
| 13:29:15 | stephenfin | efried, mriedem: I saw that but I didn't see the link to the failing tests. I'd have expected to have seen the name of the failing test reported before stacktrace | |
| 13:29:25 | kashyap | efried: Meanwhile, in your copious free time ^ As best as I can addressed remarks from mriedem, sean-k-mooney et al. If you want to fast-approve. | |
| 13:29:42 | efried | stephenfin: It varies which test fails | |
| 13:30:04 | kashyap | (Also I will add / update the spec as I learn other important details, docs while implenenting.) | |
| 13:30:16 | openstackgerrit | Surya Seetharaman proposed openstack/nova master: Microversion 2.73: Support adding the reason behind a server lock https://review.opendev.org/648662 | |
| 13:30:25 | efried | jeebuz, with that big a delta, I doubt I'll be able to fast approve | |
| 13:30:39 | efried | but thanks for updating. | |
| 13:30:59 | kashyap | efried: Nothing fundamental has changed. I largely added clarifying text | |
| 13:31:28 | kashyap | efried: Or removed unnecessary bit. The main work mentioned in the Work Items is still in tact | |
| 13:31:48 | openstackgerrit | Balazs Gibizer proposed openstack/nova-specs master: Server move operations with ports having resource request https://review.opendev.org/652608 | |
| 13:32:13 | lyarwood | mriedem: ack I'll take a look now | |
| 13:33:05 | mriedem | efried: want to continue the backport train? https://review.opendev.org/#/c/655429/ | |
| 13:33:08 | jaypipes | stephenfin: ack. will do that right now. | |
| 13:33:22 | efried | kashyap: Okay, you've said nova will validate, but I'm still not seeing the part where you say: "...and will cause {spawn to fail | nova-compute to refuse to start}, with a helpful log message indicating which combination of thingies was bad" | |
| 13:33:27 | jaypipes | efried: no, not a huge prio for me. | |
| 13:33:29 | stephenfin | ta | |
| 13:33:32 | efried | jaypipes: ack, thx | |
| 13:33:41 | efried | mriedem: Yes, need to do it manually, will get to it asap. | |
| 13:33:55 | kashyap | efried: Okay, I used the word "validate" too loseely then. Let me add that phrase in. | |
| 13:34:11 | efried | right, I (as the reader) don't know what that means. | |
| 13:34:20 | kashyap | (The word "validate" was supposed to capture that. And I know I will uncover more details as I mull on the implementation.) | |
| 13:35:03 | openstackgerrit | Rodolfo Alonso Hernandez proposed openstack/os-vif stable/rocky: Prevent "qbr" Linux Bridge from replying to ARP messages https://review.opendev.org/655692 | |
| 13:35:42 | gibi | efried: I saw the discussion about the lenght of the bandwith PTG slot | |
| 13:35:55 | gibi | efried: I think we can shrink that to 15-20 minutes | |
| 13:35:56 | efried | gibi: ack, I saw your response, will shrink. | |
| 13:35:59 | efried | thanks. | |
| 13:36:01 | gibi | efried: thanks | |
| 13:36:41 | gibi | efried: I also saw that you prepared the commit for the onboarding session. Is there anything I can still help with? | |
| 13:38:57 | openstackgerrit | Eric Fried proposed openstack/nova stable/rocky: Fix {min|max}_version in ironic Adapter setup https://review.opendev.org/655693 | |
| 13:39:10 | openstackgerrit | Rodolfo Alonso Hernandez proposed openstack/os-vif stable/queens: Prevent "qbr" Linux Bridge from replying to ARP messages https://review.opendev.org/655694 | |
| 13:39:11 | efried | mriedem, melwitt: ^ | |
| 13:40:04 | efried | gibi: I'm not completely sure how I'm going to present that. What I would like to do is have my actual IDE running on the projector. Fallback is showing everything in browser. | |
| 13:40:26 | efried | I also don't know if I can fill 40 minutes with that demo :P | |
| 13:40:38 | efried | if you have suggestions, I'm all ears. | |
| 13:40:47 | efried | In any case, I would love to have you around for moral support. | |
| 13:41:18 | gibi | efried: If we run out of things and there are no questions then we can pull out the berlin presentation and talk about some part of it | |
| 13:41:38 | gibi | efried: I will definitly in the room to help | |
| 13:41:43 | efried | cool, thank you. | |
| 13:42:20 | gibi | efried: especially the last slide https://docs.google.com/presentation/d/1T6_CZvDf2eFgbtTecIfbrMBkPiX9-yYRXXKakZjlyXs/edit?usp=sharing | |
| 13:42:46 | sean-k-mooney | efried: kashyap i think https://blueprints.launchpad.net/nova/+spec/libvirt-video-device-models should now be fine? | |
| 13:44:00 | kashyap | sean-k-mooney: I'd use capitalization correctly, but that's a nit :D. Also there is an unwanted line break for the word "graphic" | |
| 13:44:05 | openstackgerrit | Rodolfo Alonso Hernandez proposed openstack/os-vif master: Remove IP proxy methods https://review.opendev.org/655695 | |
| 13:45:16 | sean-k-mooney | updated | |
| 13:45:47 | sean-k-mooney | the content is there and anyone can edit so ill leave it to other to fix futher if it bothers them | |
| 13:46:04 | efried | sean-k-mooney, kashyap: Approved, thanks for the follow through. | |
| 13:47:33 | kashyap | efried: Nod | |
| 13:47:34 | openstackgerrit | Kashyap Chamarthy proposed openstack/nova-specs master: Add "CPU selection with hypervisor consideration" spec https://review.opendev.org/645814 | |
| 13:47:53 | kashyap | efried: ^ Added the sentence on error logging. Does it look any better? | |
| 13:48:15 | openstackgerrit | Merged openstack/os-traits master: Document policy of never removing traits https://review.opendev.org/655673 | |
| 13:48:19 | efried | kashyap: Yes, thank you, except for the typo serice | |
| 13:48:21 | sean-k-mooney | by the way i treied to have https://review.opendev.org/#/c/647733/ more or less be mergable in the first revision but i did wonder is there a place in our docs where the values of hw_video_model would/should be documented | |
| 13:48:23 | kashyap | gibi: You were also +2 on the above. If you want to re-{ACK,NACK} in your copious free time | |
| 13:48:26 | kashyap | Damn | |
| 13:48:31 | sean-k-mooney | stephenfin: ^ any idea | |
| 13:48:32 | kashyap | efried: I corrected it, didn't commit it :-( | |
| 13:48:49 | gibi | kashyap: ack, I will try to go back there today | |
| 13:49:16 | mriedem | adrianc: can you or hamdy (or moshe) start a backport for https://review.opendev.org/#/c/649345/ to stable/stein so we have it lined up? | |
| 13:49:30 | openstackgerrit | Kashyap Chamarthy proposed openstack/nova-specs master: Add "CPU selection with hypervisor consideration" spec https://review.opendev.org/645814 | |
| 13:49:36 | mriedem | adrianc: oh nvm wrong patch | |
| 13:49:45 | kashyap | gibi: Thanks. It's largely clarification text added based on the feedback | |
| 13:50:03 | mriedem | adrianc: oh i guess that was right, i was looking at the neutron spec for some reason | |
| 13:50:12 | efried | mriedem: Do you want a final look at ^ ? It had multiple +2s and I just asked kashyap to add detail on what "validate" means (it means refuse to start nova-compute, with a helpful log) so I was going to fast approve it. | |
| 13:50:57 | openstackgerrit | Lee Yarwood proposed openstack/nova master: libvirt: Stop ignoring unknown libvirtError exceptions during volume attach https://review.opendev.org/655696 | |
| 13:50:58 | mriedem | if you and gibi and alex_xu and everyone else are fine with it then no i don't need to spend time re-reviewing | |
| 13:51:26 | efried | ack, thx | |
| 13:51:43 | mriedem | lyarwood: thanks | |