| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2019-04-24 | |||
| 18:32:12 | melwitt | jaypipes: ok, thanks. I don't want to take up too much of your time on this | |
| 18:32:34 | openstackgerrit | Surya Seetharaman proposed openstack/nova master: Microversion 2.73: Support adding the reason behind a server lock https://review.opendev.org/648662 | |
| 18:32:59 | jaypipes | melwitt: not a worry, Melanie :) | |
| 18:33:05 | melwitt | jaypipes: it's a little complex in that the create() methods will use the object's internal self._context but all the objects self._context are set to the same RequestContext | |
| 18:33:41 | melwitt | but maybe that aspect can cause a break in the decorator nesting-ness? I'm not sure | |
| 18:34:49 | jaypipes | yeah, not entirely sure either :) will dig further. | |
| 18:56:02 | openstackgerrit | Surya Seetharaman proposed openstack/nova master: Microversion 2.73: Support adding the reason behind a server lock https://review.opendev.org/648662 | |
| 19:07:17 | melwitt | jaypipes: based on the code you linked, it really should work to nest it so I went back and tried it all again and it looks like it does indeed work properly. I must have messed something up last time, sorry for that :( being able to nest makes the code 1000x better so thank you for pointing it out. I'm going to respin | |
| 19:12:28 | melwitt | jaypipes++ | |
| 19:12:50 | tssurya | mriedem: following up on our discussion yesterday regarding filters/sorting I have a doubt here: https://review.opendev.org/#/c/648662/6/nova/api/openstack/compute/schemas/servers.py@544 could you leave a comment when you get time ? | |
| 19:21:33 | dansmith | tssurya: see if I answered your question | |
| 19:21:48 | melwitt | turns out what I did wrong was not pass the RequestContext to the decorated outer method. it needs to be passed in for the decorator to start the transaction and then that will get used by the subsequent create() methods | |
| 19:22:14 | tssurya | dansmith: thanks looking | |
| 19:23:15 | tssurya | dansmith: ah you mean do something like 'sort_key': multi_params(VALID_SORT_KEYS_V273) ?, | |
| 19:23:23 | dansmith | tssurya: yeah | |
| 19:23:29 | tssurya | got it, I'll try to update that patch :) thanks! | |
| 19:25:40 | openstackgerrit | melanie witt proposed openstack/nova master: Create request spec, build request and mappings in one transaction https://review.opendev.org/586742 | |
| 19:36:34 | jaypipes | melwitt: no worries, Melanie! :) | |
| 19:40:23 | openstackgerrit | Dan Smith proposed openstack/nova master: Add image type capability flags and trait conversions https://review.opendev.org/652710 | |
| 19:40:24 | openstackgerrit | Dan Smith proposed openstack/nova master: Make libvirt expose supported image types https://review.opendev.org/653454 | |
| 19:40:24 | openstackgerrit | Dan Smith proposed openstack/nova master: Expose Hyper-V supported image types https://review.opendev.org/655137 | |
| 19:42:01 | JamesBenson | hey all | |
| 19:42:04 | JamesBenson | I'm getting a nova_compute issue with this error: https://paste.fedoraproject.org/paste/EZYsQ8eDlp9gDjA8BB1YiA/ | |
| 19:42:12 | JamesBenson | This is with a xen hypervisor | |
| 19:42:38 | JamesBenson | I'm installed os_xenapi with pip | |
| 19:46:27 | dansmith | oh so you're the one! | |
| 19:51:59 | JamesBenson | dansmith??? | |
| 19:52:09 | dansmith | JamesBenson: ...guy still using xen :) | |
| 19:52:43 | JamesBenson | dansmith, trust me, this is the first time and only because we are getting software that is based off of the xen hypervisor. | |
| 19:52:54 | JamesBenson | needless to say, I'm finding bugs. | |
| 19:53:03 | dansmith | I'm assuming this is the nova-compute log, but it looks really strange. definitely seems like you're failing to import os_xenapi for some reason that I can't help you with | |
| 19:53:27 | JamesBenson | yes, nova-compute log | |
| 19:53:31 | dansmith | the db accesses are super strange, but I'd resolve the import issue first in case that is kicking it into some weird state where it's trying to survey the db when it shouldn't | |
| 19:53:33 | JamesBenson | it's coming from kolla-ansible | |
| 19:53:54 | JamesBenson | So in the docker container, I can open python console and import sucessfully | |
| 19:54:49 | JamesBenson | I did have to tar the dir in site-packages, cp it over and expand... but console did work. | |
| 19:55:28 | dansmith | it's hard to tell from the traces, but I guess it's possible that os_xenapi is trying to access the db on init and that is preventing it from being imported, but that has been disallowed for many years | |
| 19:55:32 | dansmith | so I wouldn't know what to say | |
| 20:01:06 | JamesBenson | dansmith, are you familiar with kolla? | |
| 20:02:21 | dansmith | nope | |
| 20:09:04 | JamesBenson | Is it possible to check that nova is using openstack's os-xenapi instead of python-os-xenapi? | |
| 20:09:19 | JamesBenson | I've never played with nova code explicitly. | |
| 20:15:39 | efried | requirements.txt:os-xenapi>=0.3.3 # Apache-2.0 | |
| 20:15:39 | efried | JamesBenson: The nova requirements.txt file lists: | |
| 20:16:02 | efried | which means whatever happens when you say pip install 'os-xenapi>=0.3.3' | |
| 20:16:56 | efried | aspiers: done, thanks for the reminder. | |
| 20:18:51 | efried | sean-k-mooney: re libvirt-video-device-models, the action from last week was for kashyap to have a look at it and I would approve it if he was on board. | |
| 20:19:25 | efried | I know kashyap has been one-armed-wallpaperer busy for the past few days... | |
| 20:36:10 | sean-k-mooney | efried: ya that fine | |
| 20:36:18 | sean-k-mooney | it cna wait until after the ptg | |
| 20:36:37 | sean-k-mooney | i was going to add it to the runway list but noticed it wasnt approved so held off | |
| 20:36:55 | sean-k-mooney | i have set a workflow -1 on the nova patch in the inerim | |
| 20:40:47 | JamesBenson | efried, so I wonder why it wasn't installed by default | |
| 20:41:16 | efried | sorry, I wasn't following the conversation, let me read scrollback... | |
| 20:41:39 | gmann | efried: regarding PT schedule, can we move 'API inconsistency cleanup' L276 on Thursday or friday ? I would not be available on Saturday due to my flight | |
| 20:41:46 | gmann | PTG | |
| 20:42:03 | efried | gmann: Roger that, will shuffle, thanks for the heads up. | |
| 20:42:17 | gmann | efried: thanks . | |
| 20:42:18 | JamesBenson | efried, sean-k-mooney could you provide insight too, I've seen you in kolla :-) | |
| 20:42:36 | efried | you haven't seen *me* in kolla :P | |
| 20:42:52 | JamesBenson | sorry to pick on you explicitly, oh man, sorry efried! | |
| 20:43:00 | sean-k-mooney | JamesBenson: context? | |
| 20:43:16 | efried | (I have nothing against kolla, just completely ignorant/inexperienced there) | |
| 20:43:44 | sean-k-mooney | reading back | |
| 20:43:57 | JamesBenson | sean-k-mooney: I'm doing kolla with xen, the nova_compute container is having issues with os_xenapi and six, I had to manually install them, but still vomits on itself. | |
| 20:44:34 | JamesBenson | sean-k-mooney, check out the paste for the error log... | |
| 20:45:41 | sean-k-mooney | JamesBenson: i honestly did not know kolla-ansible supproted xen i always used it with kvm | |
| 20:45:58 | JamesBenson | likewise, until we got software that needs a xenblanket... | |
| 20:46:48 | sean-k-mooney | i would gues in addtion to installing xen you might need to run some db migrations | |
| 20:47:27 | sean-k-mooney | oh xen server is supported now https://github.com/openstack/kolla-ansible/blob/23415bf8bb8179a966d1c10bd46e6cb9045f2b5d/doc/source/reference/compute/xenserver-guide.rst | |
| 20:47:28 | JamesBenson | doing this little experiment, I'm finding bugs in several different openstack processes... :-( | |
| 20:47:37 | JamesBenson | yeah | |
| 20:47:54 | sean-k-mooney | what version of python are you using | |
| 20:48:02 | sean-k-mooney | i assume python 2 | |
| 20:48:03 | JamesBenson | this is version 2 still | |
| 20:48:24 | sean-k-mooney | ya it 2.7 from the logs cool | |
| 20:49:05 | sean-k-mooney | so this is in the cells scater gather code | |
| 20:49:26 | sean-k-mooney | we indocuded explcitly use fo eventlets there | |
| 20:49:43 | JamesBenson | ? | |
| 20:50:08 | sean-k-mooney | in stien we intoduced a parallel cell list feature | |
| 20:50:14 | JamesBenson | yes, I think it was failing at the cells spot in ansible | |
| 20:50:23 | JamesBenson | I'm deploying using 7.0.1 | |
| 20:50:54 | sean-k-mooney | it was implemented using eventlets expclitly but that means in stien you need to monkey patch the nova api now | |
| 20:51:39 | sean-k-mooney | but some people have been having issue with monkey patched nova api under uwsigi also | |
| 20:51:50 | sean-k-mooney | do you know how this is run in in kolla | |
| 20:52:37 | JamesBenson | honestly, starting to get to the limits of my knowledge here now. | |
| 20:52:59 | sean-k-mooney | im checking the kolla repos to see | |
| 20:54:11 | JamesBenson | I do know this needs to get fixed in kolla-ansible: https://github.com/openstack/kolla-ansible/blob/master/ansible/roles/nova/tasks/bootstrap_xenapi.yml#L3 and L4, | |
| 20:54:24 | efried | mriedem: pike-em good to go at this point? | |
| 20:55:32 | sean-k-mooney | JamesBenson: the command is nova-api so i think it running under pythons built in web server with haproxy in front | |
| 20:56:13 | sean-k-mooney | at least based on https://github.com/openstack/kolla-ansible/blob/7.0.1/ansible/roles/nova/templates/nova-api.json.j2#L2 | |
| 20:58:16 | sean-k-mooney | JamesBenson: what people were seeing was under uwsgi instead of mod_wsig the nova-api was not sending/reciving heartbeats to rabbitmq and teh connect to amqp was dropping | |
| 20:58:34 | sean-k-mooney | although im not sure that is related to your issue | |
| 21:00:05 | sean-k-mooney | JamesBenson: how did you install os_xenapi | |
| 21:00:31 | sean-k-mooney | did you rebuild the images using the template overide file | |
| 21:01:38 | JamesBenson | it was a multistep process.... but tar'ed the package locally from python2.7/site-packages, docker cp, untar... I issued the commands using docker exec -u 0 | |
| 21:02:08 | sean-k-mooney | oh there is a standard way to extend kolla images | |
| 21:02:11 | JamesBenson | I verified inside the container by logging into it, running python, and importing the packages without issue | |
| 21:02:28 | JamesBenson | yeah, I didn't want to rebuild the images as I was sure there would be more issues. | |
| 21:02:43 | sean-k-mooney | https://github.com/openstack/kolla/blob/master/doc/source/admin/image-building.rst#generic-customisation | |