Posted	Nick	Remark
#openstack-nova - 2019-04-23
23:09:40	openstackgerrit	Adam Spiers proposed openstack/nova master: Add infrastructure for invoking libvirt's getDomainCapabilities API https://review.opendev.org/655268
23:12:34	openstackgerrit	Tony Breeds proposed openstack/nova stable/pike: Move legacy-grenade-dsvm-neutron-multinode-live-migration in-tree https://review.opendev.org/640207
23:27:54	openstackgerrit	Adam Spiers proposed openstack/nova master: Add detection of SEV support from QEMU/AMD-SP/libvirt on AMD hosts https://review.opendev.org/633855
23:32:36	aspiers	kashyap: ^^^ I finally gave you what you wanted ;-)
23:32:53	aspiers	you'll note that the SEV patch is extremely readable now
#openstack-nova - 2019-04-24
00:34:27	openstackgerrit	melanie witt proposed openstack/nova master: Fix SynchronousThreadPoolExecutorFixture mock spec https://review.opendev.org/650171
00:34:28	openstackgerrit	melanie witt proposed openstack/nova master: Use futurist.GreenThreadPoolExecutor in scatter_gather_cells https://review.opendev.org/650172
00:34:28	openstackgerrit	melanie witt proposed openstack/nova master: Revert "Fix target_cell usage for scatter_gather_cells" https://review.opendev.org/653894
01:14:01	openstackgerrit	Tetsuro Nakamura proposed openstack/nova master: Don't persist _nova_check_type flag in database https://review.opendev.org/655278
01:45:04	openstackgerrit	Michael Still proposed openstack/nova master: Privsepify ipv4 forwarding enablement. https://review.opendev.org/635431
01:45:05	openstackgerrit	Michael Still proposed openstack/nova master: Privsep the ebtables modification code. https://review.opendev.org/635435
01:45:05	openstackgerrit	Michael Still proposed openstack/nova master: Remove unused FP device creation and deletion methods. https://review.opendev.org/635433
01:45:06	openstackgerrit	Michael Still proposed openstack/nova master: Move iptables rule fetching and setting to privsep. https://review.opendev.org/636508
01:45:06	openstackgerrit	Michael Still proposed openstack/nova master: Move adding vlans to interfaces to privsep. https://review.opendev.org/635436
01:45:07	openstackgerrit	Michael Still proposed openstack/nova master: Move router advertisement daemon restarts to privsep. https://review.opendev.org/639281
01:45:07	openstackgerrit	Michael Still proposed openstack/nova master: Move dnsmasq restarts to privsep. https://review.opendev.org/639280
01:45:08	openstackgerrit	Michael Still proposed openstack/nova master: Move setting of device trust to privsep. https://review.opendev.org/639283
01:45:08	openstackgerrit	Michael Still proposed openstack/nova master: Move calls to ovs-vsctl to privsep. https://review.opendev.org/639282
01:45:09	openstackgerrit	Michael Still proposed openstack/nova master: Cleanup the _execute shim in nova/network. https://review.opendev.org/639581
01:45:09	openstackgerrit	Michael Still proposed openstack/nova master: Move final bridge commands to privsep. https://review.opendev.org/639580
01:45:10	openstackgerrit	Michael Still proposed openstack/nova master: Cleanup no longer required filters and add a release note. https://review.opendev.org/639826
01:45:10	openstackgerrit	Michael Still proposed openstack/nova master: We no longer need rootwrap. https://review.opendev.org/554438
01:45:11	openstackgerrit	Michael Still proposed openstack/nova master: Remove no longer required "inner" methods. https://review.opendev.org/655282
01:45:11	openstackgerrit	Michael Still proposed openstack/nova master: Improve test coverage of nova.privsep.utils. https://review.opendev.org/655281
02:01:05	openstackgerrit	Boxiang Zhu proposed openstack/nova master: Add host and hypervisor_hostname flag to create server https://review.opendev.org/645520
02:08:28	openstackgerrit	Merged openstack/nova master: Fix {min|max}_version in ironic Adapter setup https://review.opendev.org/654457
04:02:09	openstackgerrit	Boxiang Zhu proposed openstack/python-novaclient master: Add host and hypervisor_hostname to create servers https://review.opendev.org/647671
04:54:36	openstackgerrit	Merged openstack/nova master: Fix ProviderUsageBaseTestCase._run_periodics for multi-cell https://review.opendev.org/641179
04:54:44	openstackgerrit	Merged openstack/nova master: Improve CinderFixtureNewAttachFlow https://review.opendev.org/639382
06:00:29	openstackgerrit	zhongshengping proposed openstack/nova master: Replace git.openstack.org URLs with opendev.org URLs https://review.opendev.org/654398
06:46:54	arshad777	Hi everyone, I am trying to create an instance on the controller node on a multinode setup but getting no valid host found in nova log. Please refer nova log http://paste.openstack.org/show/749631/ for more detail. Please let me know if some thing is wrong on my setup
07:05:15	openstackgerrit	Merged openstack/nova stable/queens: libvirt: set device address tag only if setting disk unit https://review.opendev.org/653512
07:19:54	openstackgerrit	Rodolfo Alonso Hernandez proposed openstack/os-vif master: Prevent "qbr" Linux Bridge from replying to ARP messages https://review.opendev.org/655332
07:30:47	kashyap	aspiers: Thank you :-) Noticed it from an e-mail alert on the blueprint. /me opens the change
07:56:19	openstackgerrit	Tetsuro Nakamura proposed openstack/nova master: Don't persist _nova_check_type flag in database https://review.opendev.org/655278
08:03:40	kashyap	aspiers: When you're awake, something unrelated: any reason why you added 'SEV' trait to a separate file, os_traits/hw/cpu/amd.py, instead of appending it to existing os_traits/hw/cpu/x86.py?
08:03:59	aspiers	kashyap: based on feedback in the review
08:04:06	aspiers	I originally proposed the latter
08:05:41	kashyap	I see
08:06:20	kashyap	aspiers: So, I'm wondering if I should add the AMD CPU feature traits I added: https://review.opendev.org/#/c/655193/1/os_traits/hw/cpu/x86.py
08:06:24	kashyap	... to also amd.py
08:06:33	aspiers	definitely
08:06:42	aspiers	I would have thought, anyway
08:07:25	kashyap	Then, I also have to do a "clean up" of moving the existing "SVM" from x86.py to amd.py, too. Will do that in a separate change.
08:14:11	aspiers	kashyap: https://review.opendev.org/#/c/609779/12/specs/stein/approved/amd-sev-libvirt-support.rst@95
08:18:13	gibi	efried: I was about to start putting together the commits for the nova onboarding session. But then I found that you already created the DEMO commits (e.g. https://review.opendev.org/#/c/653504/) Is there something I can help with?
08:18:14	kashyap	aspiers: Hmm, one of the points was about whether it is an instruction set extension or not
08:18:28	aspiers	kashyap: yup
08:18:42	aspiers	s/definitely/I have no clue what I'm talking about/
08:18:51	aspiers	but I can point to people who do ;-)
08:18:58	kashyap	:D
08:19:33	kashyap	I find that too granular. We should stick to one clear approach: if they're AMD-specific, then use amd.py (regardless of whether it an "instruction set extension' or whatever it is)
08:19:52	aspiers	yeah, needs to be clearly documented, e.g. in the README
08:19:52	kashyap	Anyway, not too important.
08:21:16	kashyap	Also, "x86" can mean both Intel and AMD. (Although, the original term derived from Intel's 8086.)
08:21:57	aspiers	right
08:22:29	kashyap	aspiers: So, 'sev' shows up under /proc/cpuinfo on an AMD box yeah?
08:22:40	aspiers	think so but checking
08:22:58	aspiers	yes
08:23:04	aspiers	in the flags
08:23:25	aspiers	as does svm
08:24:44	kashyap	Thanks
08:52:23	openstackgerrit	Adam Spiers proposed openstack/nova master: Add infrastructure for invoking libvirt's getDomainCapabilities API https://review.opendev.org/655268
08:52:29	aspiers	kashyap: ^^^ PEP8 TODO issue should be fixed
08:55:30	kashyap	Ack.
08:56:55	aspiers	kashyap: any thoughts on whether the tests are sufficient as is?
08:57:19	aspiers	kashyap: they're a bit lame but https://review.opendev.org/#/c/633855/ is the immediate follow-up which makes them sensible again
08:57:38	kashyap	aspiers: Yeah, that is fine and more than acceptable.
08:57:44	aspiers	specifically testing that a feature can get added to the .features list
08:57:52	kashyap	The infra patch is ... just that ... the infra :-)
08:57:57	aspiers	right
08:58:01	kashyap	Any sensible reviewer would (and should) understand that.
08:58:27	aspiers	and it does have tests anyway, which do test some aspects of it, just not the <features> bit
08:58:36	aspiers	well even that gets basic testing I guess
09:00:00	kashyap	Right, it's perfectly fine.
10:07:41	openstackgerrit	Artom Lifshitz proposed openstack/nova master: Run revert resize tests in nova-live-migration https://review.opendev.org/653498
10:07:42	openstackgerrit	Artom Lifshitz proposed openstack/nova master: Revert resize: wait for external events in compute manager https://review.opendev.org/644881
10:07:42	openstackgerrit	Artom Lifshitz proposed openstack/nova master: Revert "Wait for network-vif-plugged on resize revert" https://review.opendev.org/639396
10:12:18	kashyap	jaypipes: When you're about -- hope that answers your question: https://review.opendev.org/#/c/506720/8/specs/train/approved/allow-secure-boot-for-qemu-kvm-guests.rst@19
10:13:06	kashyap	artom: When you get time, can you confirm if I answered your questions on PS-11: https://review.opendev.org/#/c/506720/11/specs/train/approved/allow-secure-boot-for-qemu-kvm-guests.rst
10:13:15	kashyap	(On the review is fine.)
10:18:37	openstackgerrit	Artom Lifshitz proposed openstack/nova master: Run revert resize tests in nova-live-migration https://review.opendev.org/653498
10:18:38	openstackgerrit	Artom Lifshitz proposed openstack/nova master: Revert resize: wait for external events in compute manager https://review.opendev.org/644881
10:18:38	openstackgerrit	Artom Lifshitz proposed openstack/nova master: Revert "Wait for network-vif-plugged on resize revert" https://review.opendev.org/639396
10:20:40	artom	kashyap, ya
10:23:34	artom	kashyap, yep, your answers make sense
10:23:47	artom	I'll leave it to your judgment on whether you want to include any of them in the spec proper :)
10:52:01	kashyap	artom: Some of them I will. Next iteration coming soon to a Firefox tab near you :D
11:09:06	jaypipes	kashyap: hmm, didn't I +2 that yesterday? did you push new revs?
11:09:15	jaypipes	or am I confusing with the AMD SEV one...
11:09:33	sean-k-mooney	jaypipes: you did
11:09:50	sean-k-mooney	there was a few tiny nits that were fixed
11:10:43	sean-k-mooney	oh sorry no i confused myself
11:10:43	NewBruce	sean-k-mooney that workaround patch is holding up splendidly; but man is the live migration process dicey - any failure can really leave you messed up at times….
11:11:03	sean-k-mooney	jaypipes: you +2'd the sev one not the secure boot one
11:11:05	NewBruce	but the workaround +1 so thanks for that
11:11:09	sean-k-mooney	jaypipes: ignore me
11:12:10	sean-k-mooney	NewBruce: way we know we can harden that code more, especially in the failure case
11:12:38	sean-k-mooney	NewBruce: ill try and make the code a bit more presentable (pass tests) after the ptg
11:12:57	NewBruce	aye, admittedly the cleanup is a complex beast and really depends on where the failure happens; but if the second ports are set up, you can be in for a bad time in some cases

Earlier   Later