Posted	Nick	Remark
#openstack-nova - 2019-04-23
21:41:01	efried	mriedem: ack, looking.
21:41:20	efried	are you recusing yourself from approving at this point?
21:41:29	sean-k-mooney	mriedem: ya it look like its about half the time
21:41:48	mriedem	efried: not necessarily
21:41:55	mriedem	i just added test stuff and some code comments
21:43:24	openstackgerrit	Merged openstack/python-novaclient master: Updates for OpenDev transition https://review.opendev.org/654429
21:43:45	sean-k-mooney	ya the delta for what you added is mainly non functional changes
21:45:09	sean-k-mooney	so is the main sped up form getting the avilablity zones for jsut the enabled serivces
21:46:27	efried	mriedem: lgtm. Why did you switch from monkeypatch to mock.patch?
21:46:38	mriedem	so i can count the calls
21:46:46	mriedem	silly pants
21:47:10	mriedem	sean-k-mooney: it's that we don't get enabled services across 10K hosts twice
21:47:41	aspiers	did you folks spot the pysnooper tip?
21:48:04	sean-k-mooney	ah
21:48:11	sean-k-mooney	ya
21:48:25	sean-k-mooney	im not sure if ill end up using it or not but we will see
21:48:46	aspiers	it looks pretty nice
21:52:49	sean-k-mooney	ya but im not sure it will actully be helpful fo more complicate things. but next time i ned to debug some thing complex and im not usgin a grapical debugger ill give it a try
21:53:46	efried	mriedem: oh, stub_out doesn't return the fixture. And apparently MonkeyPatch doesn't have a .mock attribute, like MockPatch does. Remind me why we have stub_out?
21:53:51	efried	(rhetorical)
21:55:34	gmann	mriedem: RE: on job, yes it will merge the var from parent and derived jobs.
21:57:25	gmann	mriedem: few zuul var are not append-able for example files, irrelevant-files etc which are regex not array. but devstack var are all merged from all hierarchy of job
21:59:44	mriedem	jaypipes: fat ol -2 on this https://review.opendev.org/#/c/625755/ if you remember it
21:59:56	mriedem	efried: to get off mox?
22:00:24	mriedem	gmann: yup thanks. i'm now just waiting a few days for ci results. :)
22:07:08	sean-k-mooney	mriedem: by the way did you want to review the sriov migrtion stuff or are you happy to leave it to jay and stephen
22:09:00	mriedem	want to?
22:09:11	mriedem	why don't you have it in a runway if you're looking for reviews?
22:09:23	sean-k-mooney	oh good point
22:12:21	sean-k-mooney	its going to take w while form e to get opendev.org into fingre memory. im really glad the got the redirects in place
22:12:52	sean-k-mooney	anyway night all o/
22:15:58	mriedem	speaking of it looks like we have busted jobs on stable branches b/c the openstack-infra/devstack-gate change wasn't made there in our .zuul.yaml
22:19:35	mriedem	eandersson: are you going to work on backports for these? https://review.opendev.org/#/q/topic:bug/1825583+status:open+project:openstack/nova
22:20:36	eandersson	If I get the time this week. Got a busy schedule, and well next week is Denver.
22:20:46	eandersson	So can't promise that I will be able to do it before Denver.
22:20:48	mriedem	minions...
22:20:50	eandersson	=]
22:30:06	openstackgerrit	Matt Riedemann proposed openstack/nova stable/pike: Move legacy-grenade-dsvm-neutron-multinode-live-migration in-tree https://review.opendev.org/640207
22:42:41	efried	o/
22:50:46	openstackgerrit	Merged openstack/nova master: Only set oslo_messaging_notifications.driver if using RPCFixture https://review.opendev.org/653954
22:56:22	openstackgerrit	Adam Spiers proposed openstack/nova-specs master: Re-approve AMD SEV support for Train https://review.opendev.org/641994
23:02:52	aspiers	efried, sean-k-mooney, jaypipes: patch set 12 now up, hopefully the final one https://review.opendev.org/#/c/641994/11..12//COMMIT_MSG
23:02:58	openstackgerrit	Ivens Zambrano proposed openstack/nova-specs master: RMD Plugin: Energy Efficiency using CPU Core P-State control The power state of a core can be setup between a minimum and the maximum frequency on the cores as defined in the factory. Each core on a CPU can be defined individually to perform at specific f https://review.opendev.org/651024
23:09:40	openstackgerrit	Adam Spiers proposed openstack/nova master: Add infrastructure for invoking libvirt's getDomainCapabilities API https://review.opendev.org/655268
23:12:34	openstackgerrit	Tony Breeds proposed openstack/nova stable/pike: Move legacy-grenade-dsvm-neutron-multinode-live-migration in-tree https://review.opendev.org/640207
23:27:54	openstackgerrit	Adam Spiers proposed openstack/nova master: Add detection of SEV support from QEMU/AMD-SP/libvirt on AMD hosts https://review.opendev.org/633855
23:32:36	aspiers	kashyap: ^^^ I finally gave you what you wanted ;-)
23:32:53	aspiers	you'll note that the SEV patch is extremely readable now
#openstack-nova - 2019-04-24
00:34:27	openstackgerrit	melanie witt proposed openstack/nova master: Fix SynchronousThreadPoolExecutorFixture mock spec https://review.opendev.org/650171
00:34:28	openstackgerrit	melanie witt proposed openstack/nova master: Use futurist.GreenThreadPoolExecutor in scatter_gather_cells https://review.opendev.org/650172
00:34:28	openstackgerrit	melanie witt proposed openstack/nova master: Revert "Fix target_cell usage for scatter_gather_cells" https://review.opendev.org/653894
01:14:01	openstackgerrit	Tetsuro Nakamura proposed openstack/nova master: Don't persist _nova_check_type flag in database https://review.opendev.org/655278
01:45:04	openstackgerrit	Michael Still proposed openstack/nova master: Privsepify ipv4 forwarding enablement. https://review.opendev.org/635431
01:45:05	openstackgerrit	Michael Still proposed openstack/nova master: Privsep the ebtables modification code. https://review.opendev.org/635435
01:45:05	openstackgerrit	Michael Still proposed openstack/nova master: Remove unused FP device creation and deletion methods. https://review.opendev.org/635433
01:45:06	openstackgerrit	Michael Still proposed openstack/nova master: Move iptables rule fetching and setting to privsep. https://review.opendev.org/636508
01:45:06	openstackgerrit	Michael Still proposed openstack/nova master: Move adding vlans to interfaces to privsep. https://review.opendev.org/635436
01:45:07	openstackgerrit	Michael Still proposed openstack/nova master: Move router advertisement daemon restarts to privsep. https://review.opendev.org/639281
01:45:07	openstackgerrit	Michael Still proposed openstack/nova master: Move dnsmasq restarts to privsep. https://review.opendev.org/639280
01:45:08	openstackgerrit	Michael Still proposed openstack/nova master: Move setting of device trust to privsep. https://review.opendev.org/639283
01:45:08	openstackgerrit	Michael Still proposed openstack/nova master: Move calls to ovs-vsctl to privsep. https://review.opendev.org/639282
01:45:09	openstackgerrit	Michael Still proposed openstack/nova master: Cleanup the _execute shim in nova/network. https://review.opendev.org/639581
01:45:09	openstackgerrit	Michael Still proposed openstack/nova master: Move final bridge commands to privsep. https://review.opendev.org/639580
01:45:10	openstackgerrit	Michael Still proposed openstack/nova master: Cleanup no longer required filters and add a release note. https://review.opendev.org/639826
01:45:10	openstackgerrit	Michael Still proposed openstack/nova master: We no longer need rootwrap. https://review.opendev.org/554438
01:45:11	openstackgerrit	Michael Still proposed openstack/nova master: Remove no longer required "inner" methods. https://review.opendev.org/655282
01:45:11	openstackgerrit	Michael Still proposed openstack/nova master: Improve test coverage of nova.privsep.utils. https://review.opendev.org/655281
02:01:05	openstackgerrit	Boxiang Zhu proposed openstack/nova master: Add host and hypervisor_hostname flag to create server https://review.opendev.org/645520
02:08:28	openstackgerrit	Merged openstack/nova master: Fix {min|max}_version in ironic Adapter setup https://review.opendev.org/654457
04:02:09	openstackgerrit	Boxiang Zhu proposed openstack/python-novaclient master: Add host and hypervisor_hostname to create servers https://review.opendev.org/647671
04:54:36	openstackgerrit	Merged openstack/nova master: Fix ProviderUsageBaseTestCase._run_periodics for multi-cell https://review.opendev.org/641179
04:54:44	openstackgerrit	Merged openstack/nova master: Improve CinderFixtureNewAttachFlow https://review.opendev.org/639382
06:00:29	openstackgerrit	zhongshengping proposed openstack/nova master: Replace git.openstack.org URLs with opendev.org URLs https://review.opendev.org/654398
06:46:54	arshad777	Hi everyone, I am trying to create an instance on the controller node on a multinode setup but getting no valid host found in nova log. Please refer nova log http://paste.openstack.org/show/749631/ for more detail. Please let me know if some thing is wrong on my setup
07:05:15	openstackgerrit	Merged openstack/nova stable/queens: libvirt: set device address tag only if setting disk unit https://review.opendev.org/653512
07:19:54	openstackgerrit	Rodolfo Alonso Hernandez proposed openstack/os-vif master: Prevent "qbr" Linux Bridge from replying to ARP messages https://review.opendev.org/655332
07:30:47	kashyap	aspiers: Thank you :-) Noticed it from an e-mail alert on the blueprint. /me opens the change
07:56:19	openstackgerrit	Tetsuro Nakamura proposed openstack/nova master: Don't persist _nova_check_type flag in database https://review.opendev.org/655278
08:03:40	kashyap	aspiers: When you're awake, something unrelated: any reason why you added 'SEV' trait to a separate file, os_traits/hw/cpu/amd.py, instead of appending it to existing os_traits/hw/cpu/x86.py?
08:03:59	aspiers	kashyap: based on feedback in the review
08:04:06	aspiers	I originally proposed the latter
08:05:41	kashyap	I see
08:06:20	kashyap	aspiers: So, I'm wondering if I should add the AMD CPU feature traits I added: https://review.opendev.org/#/c/655193/1/os_traits/hw/cpu/x86.py
08:06:24	kashyap	... to also amd.py
08:06:33	aspiers	definitely
08:06:42	aspiers	I would have thought, anyway
08:07:25	kashyap	Then, I also have to do a "clean up" of moving the existing "SVM" from x86.py to amd.py, too. Will do that in a separate change.
08:14:11	aspiers	kashyap: https://review.opendev.org/#/c/609779/12/specs/stein/approved/amd-sev-libvirt-support.rst@95
08:18:13	gibi	efried: I was about to start putting together the commits for the nova onboarding session. But then I found that you already created the DEMO commits (e.g. https://review.opendev.org/#/c/653504/) Is there something I can help with?
08:18:14	kashyap	aspiers: Hmm, one of the points was about whether it is an instruction set extension or not
08:18:28	aspiers	kashyap: yup
08:18:42	aspiers	s/definitely/I have no clue what I'm talking about/
08:18:51	aspiers	but I can point to people who do ;-)
08:18:58	kashyap	:D
08:19:33	kashyap	I find that too granular. We should stick to one clear approach: if they're AMD-specific, then use amd.py (regardless of whether it an "instruction set extension' or whatever it is)
08:19:52	aspiers	yeah, needs to be clearly documented, e.g. in the README
08:19:52	kashyap	Anyway, not too important.
08:21:16	kashyap	Also, "x86" can mean both Intel and AMD. (Although, the original term derived from Intel's 8086.)
08:21:57	aspiers	right
08:22:29	kashyap	aspiers: So, 'sev' shows up under /proc/cpuinfo on an AMD box yeah?

Earlier   Later