| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2019-04-23 | |||
| 14:34:52 | jaypipes | mriedem: yessir | |
| 14:37:11 | openstackgerrit | sean mooney proposed openstack/nova master: [DNM] AUTOPEP8 ignore https://review.opendev.org/655171 | |
| 14:39:47 | jaypipes | efried: can you link me the review I said I'd re-look at that I responded "yessir" to you last evening? my scrollback doesn't have it (and no, I don't log irc) | |
| 14:40:01 | jaypipes | efried: tia | |
| 14:40:16 | efried | jaypipes: It was aspiers' SEV reproposal: https://review.opendev.org/641994 | |
| 14:40:16 | lyarwood | mriedem: sorry missed your ping, yes AFAIK it's the default in CI now | |
| 14:40:41 | jaypipes | danke | |
| 14:40:42 | efried | jaypipes: he said he's responding to my last couple of comments now. | |
| 14:40:51 | jaypipes | k | |
| 14:41:39 | kashyap | jaypipes: Will answer your question shortly on the review. (And interesting pointer on "Shielded VMs", I guess that's the nail on the "use case coffin" :D) | |
| 14:42:07 | kashyap | jaypipes: Also on "stupid questions"...recall what the inimitable Carl Sagan said: | |
| 14:42:11 | kashyap | "There are naive questions, tedious questions, ill-phrased questions, questions put after inadequate self-criticism. But every question is a cry to understand the world. There is no such thing as a dumb question."—Carl Sagan | |
| 14:48:31 | jaypipes | kashyap: the complete quote ends with "unless you're speaking with Jay Pipes. If that's the case, yes, there is definitely such a thing as a stupid question." | |
| 14:48:58 | kashyap | Hehe, go easy on yourself | |
| 14:49:23 | jaypipes | efried: k. to be clear, have all of danpb's concerns been addressed? | |
| 14:49:58 | efried | jaypipes: I definitely want to get a re-ack from danpb before we merge the spec. My review was only in terms of the placement- and nova-isms. | |
| 14:50:24 | efried | aspiers: Any progress on contacting danpb to sign off? | |
| 14:52:04 | efried | jaypipes: Of course you should dig into the SEV-specific gorp as you are able/willing, but I mainly wanted to make sure you were on board with the switchover to quantitative inventorying of SEV context. | |
| 14:52:12 | jaypipes | is there a danpb bat-signal? | |
| 14:52:36 | efried | ^ that should do it | |
| 14:52:36 | efried | "we're going to rewrite nova" | |
| 14:52:50 | jaypipes | efried: ack, lemme focus on those changes. | |
| 14:52:56 | jaypipes | efried: lol | |
| 14:53:08 | jaypipes | efried: danpb long ago gave up the nova ghost. | |
| 14:54:28 | efried | eandersson: I want to backport your region_name fix, so just need a bug associated with it and I think we're good to go. | |
| 14:55:06 | kashyap | jaypipes: Hehe, from what I see Dan is largely back to working on libvirt/QEMU | |
| 14:55:27 | kashyap | (But he's still on #virt, and #qemu OFTC. That's where I ask some gnarly questions.) | |
| 15:04:20 | kashyap | efried: jaypipes: On the SEV thing, DanPB just said: if you stopped using 'hard limit' (for memory) then the important bit is addressed. | |
| 15:07:17 | jaypipes | ack | |
| 15:09:20 | kashyap | artom: BTW, I spent 2-ish hours this morning responding to your (and cfriesen's) comments on the Secure Boot spec. Thanks for your time. When you can, let me know (on the review) if I answered your questions | |
| 15:10:15 | artom | kashyap, yeah, saw your responses in an email, will need to circle back... | |
| 15:10:51 | kashyap | We should fast-track artom into management, he's using the right jargon: "circle back" :D | |
| 15:10:53 | artom | For instance, "Tuesday and Thursday afternoons (or whatever) are for upstream" | |
| 15:11:05 | artom | kashyap, I'm a freaking buzzword bingo generator | |
| 15:11:26 | mnaser | you haven't gone full management till you start "redlining" specs instead of reviewing them | |
| 15:11:27 | mnaser | :P | |
| 15:11:28 | artom | I take synergies and value-add process efficiencies. | |
| 15:11:37 | kashyap | artom: On the off chance, wonder if you've seen Urban Dictionary's definition of "circle back". | |
| 15:12:06 | artom | kashyap, oh, I'm sure it's unspeakable in this channel | |
| 15:12:24 | kashyap | artom: Not quite. But it makes the point well | |
| 15:12:29 | aspiers | https://www.urbandictionary.com/define.php?term=Circle%20Back | |
| 15:12:45 | aspiers | pretty funny, and surprisingly SFW | |
| 15:13:01 | artom | Yeah, I was fully expecting "back" to be, err, backdoor stuff | |
| 15:13:03 | kashyap | artom, Back to work, on your main N->N-1 migration and SMM XML bit: good news! It is a non-problem for us. See my answer on the change | |
| 15:13:34 | kashyap | aspiers: Heh, yeah | |
| 15:14:08 | mriedem | lyarwood: fyi apparently https://review.opendev.org/#/q/I3ed3303309fe2a25c0043fd206f36bada4b3b8f9 broke ceph-backed snapshots | |
| 15:14:11 | artom | kashyap, because we're guaranteed to have a libvirt/qemu that support it, correct? | |
| 15:14:16 | mriedem | https://review.opendev.org/#/c/655167/ | |
| 15:14:19 | lyarwood | mriedem: looking | |
| 15:14:25 | kashyap | artom: Yes | |
| 15:14:34 | mriedem | since the ceph job is non-voting i didn't notice the failure in your backports | |
| 15:14:36 | kashyap | artom: The min libvirt/QEMU versions in Nova are way beyond what's required. | |
| 15:14:39 | artom | kashyap, OK, might be worth writing down in the spec. Unless I | |
| 15:14:39 | mriedem | but indeed the ceph job failed with snapshot tests | |
| 15:14:50 | artom | Unless I'm really the only confused lost soul | |
| 15:15:07 | kashyap | artom: To put things in perspective, first commit to QEMU on SMM support was in 2006 sometime (I was still in college) :D | |
| 15:15:24 | kashyap | artom: Yeah, I've added the versions required already in the spec. | |
| 15:15:43 | artom | kashyap, ack. | |
| 15:15:57 | lyarwood | mriedem: crap, ack. | |
| 15:16:13 | mriedem | just fyi since you might hear about it internally :) | |
| 15:16:21 | mriedem | maybe we should put some effort behind making the ceph job non-voting | |
| 15:16:52 | mriedem | i'm not really sure why it's non-voting now anyway, besides maybe a history of intermittent failures a few releases ago | |
| 15:17:01 | kashyap | artom: Lastly: min QEMU version that has the relevant SB-related features libvirt looks for is 2.4. (Current Nova min versoina take satisfy those too.) | |
| 15:17:13 | kashyap | s/take// | |
| 15:18:42 | lyarwood | mriedem: yeah, happy to help keep it GREEN during Train and on stable if it means we avoid issues like this tbh. | |
| 15:19:53 | kashyap | mriedem: When you get a sec, so if I add a CPU flag 'trait' to `os-traits` library, then I should also add it to CPU_TRAITS_MAPPING dict (https://github.com/openstack/nova/blob/master/nova/virt/libvirt/utils.py#L49,#L81) | |
| 15:21:00 | mriedem | the cpu flag name is literally 'trait'? | |
| 15:23:01 | mriedem | if you want the cpu feature flag to show up as a trait on the compute node resource provider automatically then yeah i guess it goes in that mapping | |
| 15:23:09 | mriedem | alex_xu is probably the authority on that code | |
| 15:23:26 | alex_xu | o/ | |
| 15:23:40 | sean-k-mooney | kashyap: is this realted to secure boot | |
| 15:23:49 | kashyap | sean-k-mooney: No-no, completely unrelated | |
| 15:24:01 | sean-k-mooney | ok i was going to say that is not a cpu flag | |
| 15:24:05 | sean-k-mooney | never mind | |
| 15:24:09 | kashyap | sean-k-mooney: I'm adding PCID, SSBD, etc. | |
| 15:24:16 | kashyap | Of course, it's not. Huh :-) | |
| 15:24:16 | sean-k-mooney | ah ok | |
| 15:25:06 | alex_xu | kashyap: if hope the nova to discover the PCID and report PCID trait to the placement, then you should add it to CPU_TRAITS_MAPPING | |
| 15:25:19 | kashyap | alex_xu: Yes, exactly. Thought so | |
| 15:25:30 | alex_xu | I guess you also need to raise the required version of os-traits | |
| 15:25:52 | kashyap | alex_xu: So, along with adding to /os-traits/os_traits/hw/cpu/x86.py, I will add it to the CPU_TRAITS_MAPPING dict | |
| 15:26:02 | kashyap | (Yes?) | |
| 15:26:06 | alex_xu | yes | |
| 15:26:52 | kashyap | alex_xu: Where do I raise the 'os-traits' version? | |
| 15:27:25 | alex_xu | requirement | |
| 15:28:22 | alex_xu | kashyap: requirement.txt | |
| 15:28:38 | openstackgerrit | Christian Berendt proposed openstack/nova stable/queens: Fix regression in glance client call https://review.opendev.org/655186 | |
| 15:30:03 | kashyap | alex_xu: Thanks! | |
| 15:30:16 | aspiers | efried: after much deliberating I've finally figured out how to articulate my thoughts https://review.opendev.org/#/c/641994/11 | |
| 15:31:00 | kashyap | alex_xu: I see currently 0.9.0 traits is released. And in Nova, we have: os-traits>=0.8.0 | |
| 15:31:04 | kashyap | alex_xu: I am going to make that to: | |
| 15:31:11 | kashyap | - os-traits>=0.8.0 | |
| 15:31:15 | kashyap | + os-traits>=0.10.0 | |
| 15:31:44 | alex_xu | yea, to the version has PCID trait | |
| 15:31:48 | aspiers | kashyap: thanks for relaying the message from danpb - indeed hard_limit is no longer proposed in the latest version of the SEV spec http://logs.openstack.org/94/641994/11/check/openstack-tox-docs/a439f50/html/specs/train/approved/amd-sev-libvirt-support.html#memory-locking-and-accounting | |
| 15:33:10 | kashyap | aspiers: Noted. Thanks for the pointer | |
| 15:33:42 | kashyap | aspiers: BTW, I must say, this is one of the most well-written specs I've evern seen. Nice work. | |
| 15:33:50 | aspiers | kashyap: thanks! :) | |
| 15:35:00 | aspiers | I received a lot of great advice on it over 2 cycles, which has helped hugely | |
| 15:35:55 | kashyap | Yeah, it shows the careful, unhurried effort to think-through the problem and incorporating the feedback. | |