| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2019-04-19 | |||
| 20:54:04 | fried_rice | I was basically paranoid about changing the nature of legacy broken behavior. | |
| 20:54:09 | fried_rice | Yeah, I can get behind a log for sure. | |
| 20:54:11 | eandersson | because it can lead to some bad stuff | |
| 20:54:30 | eandersson | or maybe we can pass on region to the ironic client | |
| 20:55:03 | eandersson | because we are essentially telling the ironic client, hey if I fail, just make the best judgment you can.... but I will not give you all the info you need | |
| 20:55:06 | fried_rice | eandersson: Well, I would rather rip out ironicclient altogether and use the sdk. | |
| 20:55:29 | eandersson | I do like that idea :p | |
| 20:56:07 | fried_rice | eandersson: https://blueprints.launchpad.net/nova/+spec/openstacksdk-in-nova | |
| 20:56:19 | fried_rice | (I wasn't being entirely hypothetical) | |
| 20:56:33 | eandersson | Yep - already commented on the very initial implementation :P | |
| 20:56:59 | fried_rice | cool. I would have known that if I could have referenced the gerrit part of my extended brain. | |
| 21:00:07 | eandersson | https://github.com/openstack/python-ironicclient/blob/master/ironicclient/client.py#L111 | |
| 21:00:32 | eandersson | I still think we should pass on region_name to the client if we keep the current behavior with a possible endpoint = None | |
| 21:01:13 | eandersson | That way at the least the ironicclient can make an educated decision | |
| 21:02:50 | fried_rice | That can be done. I think I would prefer it to be a separate change though. It's clearly a different bug from the bogus min_version thing. | |
| 21:02:57 | eandersson | For sure | |
| 21:03:48 | fried_rice | ugh, this is such a mess | |
| 21:04:35 | fried_rice | ironicclient is doing all this preliminary stuff that's almost (but not quite, and incorrectly) duplicating a subset of the logic in ksa itself. | |
| 21:05:03 | eandersson | Yea - this took me hours to figure out | |
| 21:05:12 | eandersson | Because there was actually 3 separate bugs | |
| 21:05:17 | fried_rice | and for that matter, nova's client_wrapper is *also* doing more of that | |
| 21:05:24 | fried_rice | mainly for backward compatibility | |
| 21:07:55 | eandersson | https://github.com/openstack/python-ironicclient/commit/466be3b6568b643605d826e5aa26d9a344cc74ae | |
| 21:08:01 | eandersson | This bug added A LOT of confusion for me | |
| 21:08:06 | fried_rice | mriedem: Confirmed the test fails when the fix is removed. Something bizarre happening with cached .pyc files maybe, would explain a couple of the weird things that have befallen me today. So I'll be +A on that guy when the world comes back up. | |
| 21:08:44 | fried_rice | eandersson: Oh yeah, that one had a knock-on effect resulting in several other bugs. | |
| 21:09:13 | melwitt | mriedem: re: tripleo, I think it supports neither deploy nor upgrade with extracted placement based on the last I heard from lyarwood and EmelienM. this isn't going to work right now but the relevant patches are https://review.openstack.org/#/c/630644/ and https://review.openstack.org/#/q/topic:tripleo-placement-extraction+status:open and https://review.openstack.org/#/q/topic:tripleo-placement-upgrade-from-nova-placement+status:open | |
| 21:09:29 | fried_rice | eandersson: like https://github.com/openstack/python-ironicclient/commit/ae1743d2c194c690c4d4629e51e860b5f5b84252 | |
| 21:09:49 | melwitt | mriedem: I'm not 100% clear on whether deploy is supported in any capacity or if it's just that it can't deploy it by default yet | |
| 21:12:04 | mriedem | melwitt: ok | |
| 21:16:26 | melwitt | it's being worked on and supposed to ramp up soon. there's an additional person who's going to help who has been taken on the task recently | |
| 21:24:40 | imacdonn | who knows stuff about eventlet monkey-patching and WSGI? Re. the problem I reported on the ML, with nova-API not maintain the heartbeat on AMQP connections when running under uWSGI, I've discovered that the problem goes away when I remove the eventlet monkey-patching | |
| 21:28:50 | fried_rice | imacdonn: isn't mdbooth_ our resident monkey-patching expert, and cdent our resident wsgi expert? I kinda think you might have poor luck raising the former, and I know the latter is on vacation. | |
| 21:30:31 | melwitt | imacdonn: mdbooth_ landed a patch to change eventlet monkey-patching around in train, that you could try to see if it helps if you were up for an experiment, but I can't link it to you right now bc gerrit | |
| 21:31:03 | melwitt | I guess I could find it in github | |
| 21:31:14 | imacdonn | melwitt, Are you sure that didn't make Stein? i.e. this: https://github.com/openstack/nova/commit/3c5e2b0e9fac985294a949852bb8c83d4ed77e04 | |
| 21:31:25 | imacdonn | problem started before that, and continues with that, though | |
| 21:32:02 | melwitt | imacdonn: I'm sure. it's proposed for backport to stein but we wanted to let it bake longer and see if anyone else was having problems first. bc only RHOSP reported the issue | |
| 21:33:58 | imacdonn | melwitt: hmm. Not finding anything beyond the above (which was definitely about "moving it around") | |
| 21:34:33 | imacdonn | melwitt: maybe not merged to master yet? | |
| 21:34:41 | melwitt | imacdonn: no, that's the one, it's just it's not in stein | |
| 21:34:46 | fried_rice | definitely merged in master | |
| 21:34:54 | melwitt | it's in train | |
| 21:35:24 | melwitt | I was saying you could try applying that patch to see if it helps | |
| 21:36:54 | imacdonn | hmm, that's odd .. I seemed to have that change ... which suggests either the RDO Stein packages are not actually Stein, or I'm doing something stupid\ | |
| 21:37:47 | imacdonn | python2-nova-19.0.0-1.el7.noarch | |
| 21:37:47 | imacdonn | # rpm -qf nova/monkey_patch.py | |
| 21:38:52 | melwitt | ohhh | |
| 21:39:12 | melwitt | I bet we (redhat) backported it downstream only. but I wasn't sure we do that for RDO | |
| 21:39:32 | fried_rice | Wow. That seems kinda crazy. | |
| 21:39:49 | melwitt | I guess they did in this case at least bc otherwise it was totally broken for us | |
| 21:39:51 | fried_rice | But I guess this was a special case because RH was busted. | |
| 21:39:53 | fried_rice | yeah | |
| 21:40:42 | fried_rice | but imacdonn you said the problem existed before this commit as well? Or is that erroneous in light of revelations above? | |
| 21:40:44 | imacdonn | so, in any case, my problem is present both with and without that change | |
| 21:40:48 | fried_rice | okay. | |
| 21:41:08 | melwitt | ok, was worth a shot | |
| 21:41:25 | melwitt | I have to run now, I'm off today because it's Spring Holiday™. see yall next week | |
| 21:41:42 | imacdonn | k, have fun ;) | |
| 21:44:05 | fried_rice | Pesach Tov. | |
| 21:51:44 | fried_rice | I'm going to hit the metaphorical road as well. eandersson, I have your fix ready; please add me to that bug once you have it. | |
| 21:52:04 | imacdonn | have a good w/e, efried | |
| 21:52:11 | efried | o/ | |
| 21:55:20 | eandersson | Let me try to create it again | |
| 22:02:28 | eandersson | efried, https://bugs.launchpad.net/nova/+bug/1825583 | |
| 22:02:29 | openstack | Launchpad bug 1825583 in OpenStack Compute (nova) "Region name isn't respected when configuring ironic" [Undecided,New] | |
| 22:02:39 | eandersson | I wish I would have saved the original one I wrote. | |
| 22:18:58 | eandersson | I tried to keep the description searchable. So I didn't actually mention the min/max version stuff. | |
| 22:27:30 | alex_xu | gerrit is down? | |
| 22:47:57 | mnaser | alex_xu: see topic | |
| 22:48:10 | alex_xu | mnaser: thanks | |
| 22:51:58 | mordred | we're having a fun day | |
| #openstack-nova - 2019-04-20 | |||
| 02:52:22 | alex_xu | mordred: hah, enjoy | |
| 03:24:02 | openstackgerrit | Huachang Wang proposed openstack/nova-specs master: Separate the vCPUs into different pools based on priority https://review.opendev.org/649882 | |
| 03:25:19 | openstackgerrit | Brin Zhang proposed openstack/nova-specs master: Change the default value of swap in the show flavor details API https://review.opendev.org/648919 | |
| 03:37:30 | openstackgerrit | Boxiang Zhu proposed openstack/nova master: Add host and hypervisor_hostname flag to create server https://review.opendev.org/645520 | |
| 03:46:49 | openstackgerrit | Boxiang Zhu proposed openstack/nova master: Make evacuation respects anti-affinity rule https://review.opendev.org/649963 | |
| 21:27:06 | openstackgerrit | sean mooney proposed openstack/nova master: [WIP] Libvirt: add nfv job https://review.opendev.org/652197 | |
| 22:07:41 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Add functional recreate test for regression bug 1825537 https://review.opendev.org/654066 | |
| 22:07:42 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Drop source node allocations if finish_resize fails https://review.opendev.org/654067 | |
| 22:07:42 | openstack | bug 1825537 in OpenStack Compute (nova) "finish_resize failures incorrectly revert allocations" [Medium,Triaged] https://launchpad.net/bugs/1825537 - Assigned to Matt Riedemann (mriedem) | |
| 22:14:05 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Improve CinderFixtureNewAttachFlow https://review.opendev.org/639382 | |
| 22:14:05 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Fix ProviderUsageBaseTestCase._run_periodics for multi-cell https://review.opendev.org/641179 | |
| 22:14:06 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Add functional recreate test for bug 1818914 https://review.opendev.org/641521 | |
| 22:14:07 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Add Migration.cross_cell_move and get_by_uuid https://review.opendev.org/614012 | |
| 22:14:07 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Update usage in RT.drop_move_claim during confirm resize https://review.opendev.org/641806 | |
| 22:14:07 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Remove unused context parameter from RT._get_instance_type https://review.opendev.org/641792 | |
| 22:14:07 | openstack | bug 1818914 in OpenStack Compute (nova) "Hypervisor resource usage on source still shows old flavor usage after resize confirm until update_available_resource periodic runs" [Low,In progress] https://launchpad.net/bugs/1818914 - Assigned to Matt Riedemann (mriedem) | |
| 22:14:08 | openstackgerrit | Matt Riedemann proposed openstack/nova master: DNM: Add instance hard delete https://review.opendev.org/650984 | |
| 22:14:08 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Add InstanceAction/Event create() method https://review.opendev.org/614036 | |
| 22:14:09 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Add TargetDBSetupTask https://review.opendev.org/627892 | |
| 22:14:09 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Add Instance.hidden field https://review.opendev.org/631123 | |
| 22:14:10 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Execute TargetDBSetupTask https://review.opendev.org/633853 | |
| 22:14:10 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Add CrossCellMigrationTask https://review.opendev.org/631581 | |
| 22:14:11 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Add prep_snapshot_based_resize_at_dest compute method https://review.opendev.org/633293 | |
| 22:14:11 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Add can_connect_volume() compute driver method https://review.opendev.org/621313 | |
| 22:14:12 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Add prep_snapshot_based_resize_at_source compute method https://review.opendev.org/634832 | |
| 22:14:12 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Add PrepResizeAtDestTask https://review.opendev.org/627890 | |
| 22:14:13 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Add PrepResizeAtSourceTask https://review.opendev.org/627891 | |
| 22:14:13 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Add nova.compute.utils.delete_image https://review.opendev.org/637605 | |