| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2019-04-18 | |||
| 13:22:06 | efried | Is it just this one https://review.openstack.org/#/c/652197/ ? | |
| 13:22:34 | sean-k-mooney | that is the main one | |
| 13:22:52 | efried | can I call on you in the nova meeting to give a brief summary of that effort? | |
| 13:23:05 | sean-k-mooney | am sure | |
| 13:23:22 | sean-k-mooney | i plan to allso add a tempest-dpdk job | |
| 13:23:42 | sean-k-mooney | and i might work with the ovn folk to create a tempest-dpdk-ovn job after | |
| 13:24:05 | sean-k-mooney | i have a dpdk job in my thirdparty ci just need to port it | |
| 13:24:23 | efried | cool. You can say all of that again for the crowd :) | |
| 13:24:37 | sean-k-mooney | hehe yes we have a topic at the ptg too | |
| 13:24:53 | sean-k-mooney | there are related things to talk about but ill give a summary in the meeting | |
| 13:25:10 | openstackgerrit | ya.wang proposed openstack/nova-specs master: Expose auto converge and post copy https://review.openstack.org/651681 | |
| 13:26:03 | efried | mriedem: https://review.openstack.org/#/q/project:openstack/nova+branch:stable/pike+topic:bug/1669054 merged, are we ready to update the pike-em patches and make them go or are we waiting for other things? | |
| 13:27:42 | efried | https://review.openstack.org/#/c/613263/ ? | |
| 13:28:33 | mriedem | i personally don't think we need that change, it was only noticed on newer branches related to some other changes in the RT which aren't backported to queens, not sure why rado is backporting it to pike | |
| 13:28:53 | mriedem | mel wants https://review.openstack.org/#/c/653514/ | |
| 13:29:18 | mriedem | dansmith: this is quite old and we talked about this fix at the last ptg in denver - would be nice to flush it https://review.openstack.org/#/c/581912/ | |
| 13:29:50 | mriedem | efried: so yeah there are still more changes we want in pike | |
| 13:29:57 | mriedem | i'm working on it | |
| 13:30:14 | mriedem | i might just start approving things | |
| 13:30:39 | efried | mriedem: ack; should we make a pike-em-potential etherpad or something, or is it okay for this to be all in your head? | |
| 13:31:26 | efried | mmedvede: I've noticed http://ciwatch.mmedvede.net/project?project=nova&time=7+days is a little wonky lately, some rows seem to be duplicated, are you aware? | |
| 13:31:54 | mriedem | efried: i can do that - one might already exist | |
| 13:32:14 | efried | thanks | |
| 13:32:17 | mriedem | elod: did you create a pike-em potential etherpad for each project? | |
| 13:32:21 | mriedem | or one that was tracking all projects/ | |
| 13:32:22 | mriedem | ? | |
| 13:32:41 | mriedem | ah yes https://etherpad.openstack.org/p/pike-final-release-before-em | |
| 13:32:47 | mriedem | https://etherpad.openstack.org/p/nova-stable-pike-em | |
| 13:34:14 | dansmith | mriedem: hmm, that im=None isn't used huh? | |
| 13:34:32 | openstackgerrit | Ivaylo Mitev proposed openstack/nova master: VMware VMDK detach: get adapter type from instance VM https://review.openstack.org/653738 | |
| 13:36:26 | mriedem | dansmith: been awhile but the logic i think is if we have the api db and get the not found, we should raise b/c that shouldn't happen. if we don't have the api db configured, we assume we're in the cell conductor and we don't need to target the context anyway. | |
| 13:37:14 | mriedem | the latter is the devstack case, the former is like everyone else in real life right now | |
| 13:37:40 | dansmith | mriedem: okay I'm not sure I follow that, but also not sure that's what is here | |
| 13:37:50 | dansmith | not found does not raise | |
| 13:37:56 | gibi | bauzas: I left a question about the GPU weigher in https://review.openstack.org/#/c/650963 | |
| 13:38:17 | mriedem | sorry not the not found, the CantStartEngineError | |
| 13:38:35 | dansmith | mriedem: right, I get that logic, I'm just talking about the line you removed | |
| 13:38:37 | mriedem | if we're in the cell conductor with no api db config, like devstack, reschedules will fail b/c of CantStartEngineError | |
| 13:38:44 | mriedem | that's dead code | |
| 13:38:45 | dansmith | mriedem: the im=None, but I don't know why that was there in the first place | |
| 13:38:57 | mriedem | it's dead, my ide shows it as dead so i removed it most likely | |
| 13:39:24 | dansmith | "my ide made me do it".. jesus, these kids. | |
| 13:40:19 | mriedem | "my text based terminal editor doesn't show me fun stuff like this" jesus these oldies | |
| 13:40:37 | mriedem | <3 | |
| 13:41:08 | dansmith | heh | |
| 13:42:07 | bauzas | gibi: ack, will look | |
| 13:51:27 | gibi | mriedem, dansmith: about the https://review.openstack.org/#/c/652608/4/specs/train/approved/server-move-operations-with-ports-having-resource-request.rst@190 do you have a feeling which one is easier: 1) implement multiple portbinding usage for every server move operation 2) pass around the RequestSpec in the compute RPC API? | |
| 13:52:29 | mriedem | i'm not sure i understand the question | |
| 13:52:49 | mriedem | you need the request spec in methods like unshelve to do the port binding in the networking api methods properly right? | |
| 13:53:27 | mriedem | oh, | |
| 13:53:36 | mriedem | you mean change all move ops to do the port binding stuff that live migration does? | |
| 13:53:39 | gibi | mriedem: cannot set up the portbinding in the conductor for unshelve? | |
| 13:54:04 | mriedem | i'd think you'd still have behavioral changes in the compute if you did that | |
| 13:54:06 | gibi | mriedem: yeah, do multiple portbinding in the conducotr for every move operation then the binding is created in the conductor | |
| 13:54:25 | mriedem | it's really hard for me to say without it being poc'ed first | |
| 13:54:36 | gibi | mriedem: true, we anyhow need a behavior change in the compute either due to the requestspec or due to the multiple portbinding | |
| 13:54:40 | mriedem | for live migration we create the port bindings in the conductor but there were changes in the compute to use those port bindings if they existed | |
| 13:54:54 | gibi | mriedem: yes | |
| 13:55:02 | mriedem | changing the compute rpc api interface is much more straightforward to me | |
| 13:55:38 | gibi | mriedem: OK that is the kind of input I'm looking for as for me both is blackbox now | |
| 13:55:44 | gibi | mriedem: thanks | |
| 13:56:17 | mriedem | if you haven't heard, there is some weird issue sean-k-mooney is working on with the port binding live migratoin stuff too, so until the root cause of that is figured out i'd be nervous about switching everything over | |
| 13:56:50 | gibi | mriedem: yeah I saw that weirdness too | |
| 13:58:51 | efried | Nova meeting real soon in #openstack-meeting | |
| 13:59:53 | kashyap | (Sigh, conflicting call) | |
| 14:00:01 | openstackgerrit | sean mooney proposed openstack/nova master: [WIP] Libvirt: add nfv job https://review.openstack.org/652197 | |
| 14:00:59 | sean-k-mooney | i still have the other gate jobs disabled in ^ but if its clean ill uncomment them and drop the [WIP] | |
| 14:01:41 | sean-k-mooney | ... i have that emacs adds tabs... | |
| 14:03:16 | efried | just reprogram it | |
| 14:03:21 | efried | how's yer lisp? | |
| 14:04:16 | openstackgerrit | sean mooney proposed openstack/nova master: [WIP] Libvirt: add nfv job https://review.openstack.org/652197 | |
| 14:10:24 | mdbooth | efried: Sorry, I did not in the end. I had good intentions :/ | |
| 14:10:54 | efried | mdbooth: Okay. Should I keep you associated with it on my radar or no? | |
| 14:11:18 | mriedem | gibi: replied to the rest of your comments in your spec https://review.openstack.org/#/c/652608/ - question inline about why can't we heal the missing port allocatoins during the _heal_instance_info_cache periodic? | |
| 14:11:48 | gibi | mriedem: ack | |
| 14:11:58 | mdbooth | efried: Given how the next 2-3 weeks looks, it would probably be best not to. | |
| 14:12:22 | efried | mdbooth: okay, thanks. | |
| 14:17:22 | mriedem | sean-k-mooney: can you split the 3rd party NFV / HPC / etc CI testing section out of https://etherpad.openstack.org/p/nova-ptg-train into another etherpad, because it's getting really big in the main one | |
| 14:17:26 | mriedem | ~L99 | |
| 14:18:38 | openstackgerrit | Ghanshyam Mann proposed openstack/nova-specs master: Spec for API inconsistency cleanup https://review.openstack.org/603969 | |
| 14:19:44 | sean-k-mooney | mriedem: yes ill do that and update it with a link | |
| 14:20:31 | mriedem | thanks | |
| 14:32:09 | kashyap | mriedem: I was _just_ about to say that; to split out that giant CI JSON bits away from the main Etherpa | |
| 14:49:02 | kashyap | cfriesen: Heya, mind having a gander at this Secure Boot spec: https://review.openstack.org/#/c/506720 | |
| 14:49:58 | openstackgerrit | Matt Riedemann proposed openstack/nova stable/pike: Add missing libvirt exception during device detach https://review.openstack.org/651642 | |
| 14:50:36 | kashyap | mriedem: Heh, I was referring to this (Hyper-V) commit of yours & Claudiu: http://git.openstack.org/cgit/openstack/nova/commit/?h=master&id=29dab997 | |
| 14:51:38 | kashyap | The stuff I'm adding in the spec is similar, but for the open source hypervisor | |
| 14:52:09 | mriedem | kashyap: don't confuse me as the author there, that was probably due to a bad rebase which changed the author | |
| 14:52:16 | mriedem | i was likely just helping to clean up nits to get it approved | |
| 14:52:33 | kashyap | Yeah, I know Claudiu was driving it | |
| 14:54:21 | mriedem | cdent: if you have hooks to rado, can you ask if we really need this in pike? https://review.openstack.org/#/c/613263/ | |
| 14:54:40 | cdent | i can probalby find him, yeah | |
| 14:55:34 | sean-k-mooney | mriedem: by the way for NewBruce RDO -> OSA bug. they tested my backported fix last night and it worked at least for the test instnace. | |
| 14:56:01 | mriedem | sean-k-mooney: i need to read your commit message to figure out what the problem was | |
| 14:56:16 | mriedem | or we don't know what the problem was, but this works around it | |
| 14:56:33 | mriedem | i'm also doing about 10 other things atm | |
| 14:56:58 | sean-k-mooney | so we know what the problem is and this works fixes it but i still dont know what teh cause is. im going to try and figure out a reporducer | |
| 14:57:31 | elod | mriedem: only that have stable-policy-follows tag | |
| 14:57:37 | cdent | mriedem: i've pinged him, but based on a cursory examination I think your analysis is correct. If we don't hear anything from him, probably safe to kill/ignore | |
| 14:57:50 | sean-k-mooney | mriedem: no worries i just wanted to say im going to be away for a few days due to pulic holidays but ill try to get back to working on it before the ptg | |