| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2019-04-08 | |||
| 10:36:19 | sean-k-mooney | im going to convert them to multinode jobs so that migration/resize tests run and add a whitbox plugin job too i think. | |
| 10:38:17 | sean-k-mooney | i also need to enable more tests. ill proably change the trigger to run atomatically once i come up with a sutible file ignore list but i am going to see if i can run some of these test upstream too in the future. | |
| 10:55:42 | efried | sean-k-mooney: nice! | |
| 11:03:52 | openstackgerrit | Eric Fried proposed openstack/nova-specs master: Re-propose detach root volume spec https://review.openstack.org/650580 | |
| 11:08:24 | openstackgerrit | Eric Fried proposed openstack/nova-specs master: Re-propose volume backed server rebuild https://review.openstack.org/650582 | |
| 11:19:27 | openstackgerrit | Eric Fried proposed openstack/nova master: Hacking N363: Don't use spec[_set]='string' https://review.openstack.org/650370 | |
| 11:20:49 | openstackgerrit | Merged openstack/nova-specs master: Re-propose detach root volume spec https://review.openstack.org/650580 | |
| 11:24:58 | openstackgerrit | Merged openstack/nova-specs master: Re-propose volume backed server rebuild https://review.openstack.org/650582 | |
| 11:38:53 | kashyap | sean-k-mooney: sfinucan: Remind me again: why are we messing with VNC whe configuring live migration here: http://git.openstack.org/cgit/openstack/nova/tree/doc/source/admin/configuring-migrations.rst | |
| 11:40:25 | sean-k-mooney | kashyap by default our install guides did not used to tell people to make vnc listen to 0.0.0.0 i think | |
| 11:40:45 | sean-k-mooney | as a result if you live migrated without haveing mand that change the console would not work on the new host | |
| 11:41:12 | sean-k-mooney | as it defaulted to listening to on the ip of the source host and we dont update that in the libvirt xml on migration | |
| 11:41:42 | sean-k-mooney | so the vnc consle woudl try to bind to a tcp port on a ip that is not on the dstionation and fail | |
| 11:43:15 | kashyap | Ah, I see. I think we should spell that reasoning out in the doc. (I'll send a patch with "Thanks: Sean Mooney") | |
| 11:43:54 | sean-k-mooney | well it says "You must not make the VNC server listen to the IP address of its compute | |
| 11:43:56 | sean-k-mooney | host, since that addresses changes when the instance is migrated. | |
| 11:43:58 | sean-k-mooney | " | |
| 11:44:19 | sean-k-mooney | but ya it could be clearer | |
| 11:45:24 | lyarwood | sean-k-mooney / kashyap ; isn't that out of date now given https://github.com/openstack/nova/blob/65874326404717b58ce4927c21d3502d7e53022b/nova/virt/libvirt/migration.py#L84 | |
| 11:45:41 | kashyap | sean-k-mooney: Yeah, the meaning is implicit. But it can definitely be clearer | |
| 11:45:59 | lyarwood | I thought we did update the listen address now | |
| 11:46:21 | sean-k-mooney | we do according to that code | |
| 11:46:35 | sean-k-mooney | so its nolonger requried but it might be desirable anyway | |
| 11:46:44 | sean-k-mooney | it may not be | |
| 11:46:52 | sean-k-mooney | when was that added | |
| 11:47:15 | sean-k-mooney | 3 years ago | |
| 11:47:36 | sean-k-mooney | there is a slight change that the dock is out dated | |
| 11:48:07 | kashyap | Yeah, definitely making sure that is set does not hurt. | |
| 11:48:18 | kashyap | lyarwood: Thanks for the pointer | |
| 11:56:50 | kashyap | sean-k-mooney: Do we always go through VNC proxy? | |
| 11:57:34 | sean-k-mooney | technically you can connect directly but typically an enduser will always connect via the vnc proxy | |
| 11:57:52 | sean-k-mooney | we do not want endusers connecting directly to the hyperviors | |
| 11:57:55 | sean-k-mooney | host | |
| 12:02:34 | kashyap | Nod; also how about security? Isn't _always_ listening on 0.0.0.0 insecure? | |
| 12:03:04 | sean-k-mooney | yes which is why the note is present in the doc. | |
| 12:03:18 | kashyap | Which note? /me reads | |
| 12:03:29 | kashyap | Ah, this one: | |
| 12:03:30 | kashyap | Since this setting allows VNC clients from any IP address to connect to instance consoles, you must take additional measures like secure networks or firewalls to prevent potential attackers from gaining access to instances. | |
| 12:03:46 | sean-k-mooney | yes | |
| 12:04:02 | kashyap | Okay, thanks again :-) | |
| 12:21:24 | jaypipes | sean-k-mooney: cool, thanks :) | |
| 12:48:32 | openstackgerrit | Tetsuro Nakamura proposed openstack/nova master: Add in_tree field to RequestGroup object https://review.openstack.org/649534 | |
| 12:48:33 | openstackgerrit | Tetsuro Nakamura proposed openstack/nova master: WIP: Add get_compute_nodes_by_host_or_node() https://review.openstack.org/650877 | |
| 12:48:33 | openstackgerrit | Tetsuro Nakamura proposed openstack/nova master: Query `in_tree` to placement https://review.openstack.org/649535 | |
| 12:48:34 | openstackgerrit | Tetsuro Nakamura proposed openstack/nova master: Pass target host to RequestGroup.in_tree https://review.openstack.org/650878 | |
| 12:49:08 | openstackgerrit | François Palin proposed openstack/nova master: WIP - nova diagnostics command is not working with all interfaces https://review.openstack.org/648123 | |
| 13:10:22 | mnaser | https://github.com/openstack/nova/blob/73edcfae7d5ea498fd17fa8e548ae1bd690f408a/nova/db/sqlalchemy/api.py#L5508-L5537 | |
| 13:10:39 | mnaser | so max rows isn't really max rows.. its scanning a full table | |
| 13:29:27 | openstackgerrit | Stephen Finucane proposed openstack/python-novaclient stable/stein: Revert "Fix crashing console-log" https://review.openstack.org/650363 | |
| 13:29:51 | openstackgerrit | Stephen Finucane proposed openstack/python-novaclient stable/rocky: Revert "Fix crashing console-log" https://review.openstack.org/650364 | |
| 13:41:59 | sean-k-mooney | cdent: jaypipes dansmith thanks for your feedback on https://review.openstack.org/#/c/647578/2/specs/train/approved/image-metadata-prefiltering.rst by the way. im gong to rework the spec with your changes today | |
| 13:46:39 | openstackgerrit | Boris Bobrov proposed openstack/nova-specs master: Re-approve AMD SEV support for Train https://review.openstack.org/641994 | |
| 13:50:34 | openstackgerrit | Boris Bobrov proposed openstack/nova-specs master: Re-approve AMD SEV support for Train https://review.openstack.org/641994 | |
| 15:35:06 | openstackgerrit | Matt Riedemann proposed openstack/nova stable/stein: Do not log a warning about not using compute monitors https://review.openstack.org/650929 | |
| 15:36:04 | openstackgerrit | Matt Riedemann proposed openstack/nova stable/stein: libvirt: disconnect volume when encryption fails https://review.openstack.org/650931 | |
| 15:58:43 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Add functional recreate test for bug 1823370 https://review.openstack.org/650424 | |
| 15:58:44 | openstackgerrit | Matt Riedemann proposed openstack/nova master: WIP: Use RequestSpec.requested_destination when rebuilding with new image https://review.openstack.org/650376 | |
| 15:58:44 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Restrict RequestSpec to cell when evacuating https://review.openstack.org/650429 | |
| 15:58:44 | openstack | bug 1823370 in OpenStack Compute (nova) "Evacuations are not restricted to the source cell during scheduling" [Medium,In progress] https://launchpad.net/bugs/1823370 - Assigned to Matt Riedemann (mriedem) | |
| 16:05:07 | openstackgerrit | sean mooney proposed openstack/nova-specs master: add spec for image metadata prefiltering https://review.openstack.org/647578 | |
| 16:09:02 | openstackgerrit | Kashyap Chamarthy proposed openstack/nova-specs master: Re-propose the spec to allow specifying a list of CPU models https://review.openstack.org/642030 | |
| 16:09:02 | efried | gibi: Who creates the bw RPs? Nova or neutron? | |
| 16:10:10 | mriedem | efried: neutron | |
| 16:10:16 | efried | thanks | |
| 16:10:26 | mriedem | https://docs.openstack.org/neutron/latest/admin/config-qos-min-bw.html | |
| 16:10:44 | kashyap | sean-k-mooney: When you get a moment this week, can you please give the latest iteration a "once-over" -- https://review.openstack.org/#/c/642030/5/specs/train/approved/cpu-model-selection.rst | |
| 16:11:34 | kashyap | jackding: ^ You originally proposed it; I made some adjustments. Might want to take a look at it. | |
| 16:13:36 | kashyap | I noticed a few mistakes in the code, which led me to look at the spec, one thing leads to another ... and suddenly I "inherited" the above spec :D | |
| 16:29:40 | stephenfin | lyarwood: Mind taking a look at these if you're still about? https://review.openstack.org/650363 https://review.openstack.org/650364 | |
| 16:31:24 | lyarwood | stephenfin: yarp, I'll take a look before I leave | |
| 16:33:12 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: nova-manage: heal port allocations https://review.openstack.org/637955 | |
| 16:33:12 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Prepare _heal_allocations_for_instance for nested allocations https://review.openstack.org/637954 | |
| 16:33:21 | stephenfin | dansmith, jaypipes: Briefly, do you recall any previous examples of us removing a model/table from 'nova/db/sqlalchemy/models.py'. I assume I need a migration? | |
| 16:33:37 | stephenfin | only example I can see 0951cf3d194edbee213673a525c1291245958264. I assume that's mostly all there is to it? | |
| 16:34:32 | stephenfin | (context is that I want to remove 'nova.db.sqlalchemy.models.Cell' without having the tests b**** at me) | |
| 16:35:24 | sean-k-mooney | stephenfin: quick question | |
| 16:35:36 | sean-k-mooney | http://logs.openstack.org/78/647578/3/check/openstack-tox-docs/38e7bf6/job-output.txt.gz#_2019-04-08_16_20_39_533258 this fails in the gate. | |
| 16:35:41 | sean-k-mooney | i know how to fix it | |
| 16:35:58 | sean-k-mooney | but i get the same error locally but the tox command succeeded | |
| 16:36:26 | stephenfin | sean-k-mooney: The gate doesn't run 'tox -e releasenotes', instead calling 'sphinx-build' directly | |
| 16:36:45 | sean-k-mooney | you mean it does not run tox -e docs | |
| 16:36:53 | stephenfin | Sorry, yeah | |
| 16:37:02 | sean-k-mooney | ok why does the gate not do that | |
| 16:37:26 | stephenfin | So I'd say the 'sphinx-build' call in 'tox.ini' is missing a '-W' flag | |
| 16:37:51 | sean-k-mooney | ah | |
| 16:37:54 | sean-k-mooney | ok | |
| 16:38:07 | sean-k-mooney | any reason i should not fix that in a seperate patch? | |
| 16:38:40 | stephenfin | sean-k-mooney: mordred et al. would have the full context, but I suspect it was to ensure documentation was reproducible. Some projects (including us) use the 'docs' target to do more than simply call 'sphinx-build' | |
| 16:38:46 | openstackgerrit | Lee Yarwood proposed openstack/nova master: libvirt: Avoid using os-brick encryptors when device_path isn't provided https://review.openstack.org/649951 | |
| 16:38:47 | sean-k-mooney | its really unititive for the docs tox env to pass but the docs job to fail | |
| 16:39:31 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Prepare _heal_allocations_for_instance for nested allocations https://review.openstack.org/637954 | |
| 16:39:31 | stephenfin | sean-k-mooney: I _think_ there was a patch from Takashi that fixed that but if not, you should add it, yes | |
| 16:39:31 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Refactor _heal_allocations_for_instance to make place for port healing https://review.openstack.org/637953 | |
| 16:39:32 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: nova-manage: heal port allocations https://review.openstack.org/637955 | |
| 16:39:34 | lyarwood | stephenfin: so regarding the novaclient backports, I'm not even sure that stable/stein is open at the moment | |
| 16:40:12 | sean-k-mooney | stephenfin: ok ill look for Takashi's patch and if i dont find it ill add one | |
| 16:40:22 | mordred | stephenfin: I didnm't do it | |
| 16:40:55 | mriedem | lyarwood: it's not, final release is wednesday | |
| 16:41:03 | sean-k-mooney | mordred: i was just confused by why the docs job on the nova-spec repo did not use the docs tox env | |
| 16:41:38 | sean-k-mooney | the docs tox env does not treat warnings as errors so i was confused by why it "passed" locally but failed in the gate | |