| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2019-04-05 | |||
| 15:55:12 | sean-k-mooney | assuming there are other asyc things we might want to do in the api like this | |
| 16:00:56 | mriedem | dansmith: you know how we restrict the request spec to the cell the instance is in before calling the scheduler during cold/live migrate and unshelve? | |
| 16:01:11 | mriedem | i do'nt see us doing that for evacuate, but seems we should... yeah? | |
| 16:01:37 | mriedem | you can't evacuate across cells | |
| 16:02:43 | dansmith | probably | |
| 16:03:17 | dansmith | I thought it was done in a place that was likely to catch any instance that already exists in the db | |
| 16:03:45 | mriedem | we explicitly lookup and set the cell on the Destination object in unshelve, cold and live migrate methods before calling the scheduler, | |
| 16:03:59 | mriedem | so it's not generic-ified anywhere as far as i know | |
| 16:04:24 | dansmith | hmm, okay it's been a long time since I looked, but okay | |
| 16:04:35 | dansmith | but yeah, if we're not we should for evac | |
| 16:04:59 | mriedem | cern must not do a lot of evacs or they are somehow otherwise restricting the server to a given cell with aggregates or something | |
| 16:05:01 | openstackgerrit | melanie witt proposed openstack/nova master: Use futurist.GreenThreadPoolExecutor in scatter_gather_cells https://review.openstack.org/650172 | |
| 16:05:09 | dansmith | they have tenant aggregates, | |
| 16:05:13 | dansmith | which probably fixes it for them, | |
| 16:05:20 | dansmith | s/,$// | |
| 16:06:12 | mriedem | yar, could probably easily do something with a 2-cell func test that has 1 compute in each and evacuate the server, see what blows pu | |
| 16:06:13 | mriedem | *up | |
| 16:08:50 | openstackgerrit | Eric Fried proposed openstack/nova master: Hacking N363: Don't use spec[_set]='string' https://review.openstack.org/650370 | |
| 16:09:15 | fried_rice | mriedem, melwitt: ^ (will fail until violations are repaired) | |
| 16:11:01 | melwitt | fried_rice: should I roll the fixes into your patch or stack a patch under yours? | |
| 16:14:04 | openstackgerrit | Kashyap Chamarthy proposed openstack/nova-specs master: Add "CPU selection with hypervisor consideration" spec https://review.openstack.org/645814 | |
| 16:14:06 | mriedem | dansmith: sanity check on my logic here would be nice https://bugs.launchpad.net/nova/+bug/1823369 | |
| 16:14:07 | openstack | Launchpad bug 1823369 in OpenStack Compute (nova) "_nova_check_type scheduler hint could be accidentally persisted during a rebuild with image change" [Medium,New] | |
| 16:15:11 | openstackgerrit | sean mooney proposed openstack/nova master: libvirt: auto detach/attach sriov ports on migration https://review.openstack.org/629589 | |
| 16:15:48 | sean-k-mooney | ignore ^ i forgot to run pep8 | |
| 16:18:37 | fried_rice | melwitt: Either way. If you stack under, you get to +2 :P | |
| 16:18:45 | melwitt | heh, yup | |
| 16:19:56 | mriedem | https://bugs.launchpad.net/nova/+bug/1823370 for the evac thing | |
| 16:19:57 | openstack | Launchpad bug 1823370 in OpenStack Compute (nova) stein "Evacuations are not restricted to the source cell during scheduling" [Undecided,New] | |
| 16:21:44 | openstackgerrit | sean mooney proposed openstack/nova master: libvirt: auto detach/attach sriov ports on migration https://review.openstack.org/629589 | |
| 16:29:30 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Use RequestSpec.requested_destination when rebuilding with new image https://review.openstack.org/650376 | |
| 16:31:38 | sean-k-mooney | jaypipes: finucannot sriov patches are updated let me know if i need to do anything else with them :) | |
| 16:34:44 | sean-k-mooney | hum looks like the ibm and other are not happy with the depend on actully since its already merged ill quickly fix that | |
| 16:36:51 | openstackgerrit | sean mooney proposed openstack/nova master: SR-IOV Live migration indirect port support https://review.openstack.org/620115 | |
| 16:44:04 | openstackgerrit | sean mooney proposed openstack/nova master: libvirt: auto detach/attach sriov ports on migration https://review.openstack.org/629589 | |
| 16:49:01 | openstackgerrit | Corey Bryant proposed openstack/nova master: xenapi/agent: Change openssl error handling https://review.openstack.org/635533 | |
| 17:14:41 | dansmith | mriedem: ouch, I guess that one is on me | |
| 17:41:15 | openstackgerrit | Merged openstack/nova master: Added mount fstype based validation of Quobyte mounts https://review.openstack.org/522245 | |
| 17:50:57 | sean-k-mooney | jaypipes: i can look at moving those methods to the RT by the way. i agree it would be nicer to have them there and not spread the locking/resouce tracking code | |
| 17:51:49 | sean-k-mooney | im going to grab soemthing to eat and ill either do it a little later or monday assumin adrianc doesnt get around to it before i do | |
| 17:53:46 | mriedem | dansmith: i have to recreate it first, but i also approved the change i'm sure | |
| 17:54:13 | mriedem | if laura ever asks, just put RequestSpec on my tombstone | |
| 17:54:23 | dansmith | mriedem: roger that | |
| 17:58:08 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Add testing guide for down cells https://review.openstack.org/650167 | |
| 18:15:38 | KH-Jared | heh, I see now I'm going to need a good bit of patience for reviews. Didn't realize the average wait time and how close to stein release it was. I think I can wait now | |
| 18:18:31 | artom | KH-Jared, yeah, reviewer bandwidth, especially core, is a long-standing problem in Nova. We all know about, and there's no real solution. You just have to find the right balance between "politely asking" and "outright pestering" | |
| 18:18:46 | artom | Doing reviews yourself is also an excellent way to get your own patch reviewed | |
| 18:19:25 | KH-Jared | that's fair too | |
| 18:22:22 | melwitt | you can also link the patch in here | |
| 18:22:51 | KH-Jared | that'd be the obvious way, I guess, https://review.openstack.org/#/c/649405/ | |
| 18:24:49 | melwitt | cool, thanks | |
| 18:24:58 | KH-Jared | ty for looking at it | |
| 18:25:09 | KH-Jared | (if you are, just realized the assumption there) | |
| 18:27:33 | melwitt | haha, yes, I'm looking at it | |
| 18:39:19 | openstackgerrit | Merged openstack/nova master: Hacking N362: Don't abbrev/alias privsep import https://review.openstack.org/649190 | |
| 18:49:06 | artom | KH-Jared, well you've done it now | |
| 18:49:19 | artom | How to get artom to review a thing: catch him when he's procrastinating | |
| 18:49:26 | KH-Jared | rofl | |
| 19:09:44 | cdent | my eyes read 'he's procrastinating' as 'hydrocasting' and I thought, "hmmm, new sport?" | |
| 19:12:11 | jaypipes | sean-k-mooney: sure, no worries. | |
| 19:15:25 | artom | cdent, huh, it's actually a thing: https://en.wiktionary.org/wiki/hydrocast#English | |
| 19:15:36 | cdent | artom: yeah, I landed there too | |
| 19:16:12 | cdent | I was afraid to google at first because usually when you google for random word it ends up disturbing | |
| 19:16:37 | artom | *snerk* | |
| 19:18:08 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Add functional recreate test for bug 1823370 https://review.openstack.org/650424 | |
| 19:18:09 | openstack | bug 1823370 in OpenStack Compute (nova) rocky "Evacuations are not restricted to the source cell during scheduling" [Medium,Confirmed] https://launchpad.net/bugs/1823370 | |
| 19:51:22 | fried_rice | blueprint self-contained ✔ | |
| 19:51:22 | fried_rice | blueprint approved ✔ | |
| 19:51:22 | fried_rice | melwitt | |
| 19:51:31 | fried_rice | melwitt: blueprint ready for review? | |
| 19:51:38 | melwitt | yes | |
| 19:51:45 | fried_rice | melwitt: Ready for quick iteration? | |
| 19:51:50 | melwitt | yes | |
| 19:51:52 | fried_rice | melwitt: Are you a good person? | |
| 19:52:05 | melwitt | I think so | |
| 19:52:27 | fried_rice | dansmith: Would you please update the channel topic to point to https://etherpad.openstack.org/p/nova-runways-train ? | |
| 19:52:39 | dansmith | yar | |
| 19:53:21 | dansmith | did I botch the rc potential topic last time? | |
| 19:53:24 | dansmith | mah bad if sorry | |
| 19:53:31 | dansmith | *so | |
| 19:53:36 | dansmith | must be beer o clock | |
| 19:54:05 | melwitt | the link was right but it still said runways. but I think everyone knew what it meant | |
| 19:54:08 | fried_rice | thx | |
| 19:54:12 | dansmith | that's what I meant yeah | |
| 19:54:18 | dansmith | prolly did a link swap | |
| 19:54:57 | fried_rice | melwitt: You are cleared for takeoff. Good luck. | |
| 19:55:02 | melwitt | thanks | |
| 19:56:57 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Add functional recreate test for bug 1823370 https://review.openstack.org/650424 | |
| 19:56:58 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Restrict RequestSpec to cell when evacuating https://review.openstack.org/650429 | |
| 19:56:58 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Use RequestSpec.requested_destination when rebuilding with new image https://review.openstack.org/650376 | |
| 19:56:58 | openstack | bug 1823370 in OpenStack Compute (nova) rocky "Evacuations are not restricted to the source cell during scheduling" [Medium,Confirmed] https://launchpad.net/bugs/1823370 | |
| 19:59:20 | fried_rice | mriedem, jaypipes, dansmith: would y'all mind flushing (at least the bottom two of) these nova-specs meta-patches? https://review.openstack.org/#/c/581914/ | |
| 20:00:56 | mriedem | i am in a deep dark place atm | |
| 20:03:26 | dansmith | I'm trying to get out of here .. is there a rush? | |
| 20:03:38 | jaypipes | fried_rice: depends where you want me to flush it. | |
| 20:04:12 | fried_rice | dansmith: no rush is kind of the problem. Go forth and beer thyself. It'll wait. | |
| 20:05:32 | fried_rice | jaypipes: The blueprint counter has been open and effectively unchanged since last summer. It's not a spec, just tooling, as is the one above it. Just for convenience so those using the tools (melwitt, me) don't have to keep a local fork to do it. | |
| 20:07:57 | jaypipes | ack. will review shortly. | |
| 20:09:34 | mriedem | done | |
| 20:09:36 | mriedem | on the bottom on | |