| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2019-04-05 | |||
| 08:14:10 | openstackgerrit | Theodoros Tsioutsias proposed openstack/nova master: Add requested_networks to RequestSpec https://review.openstack.org/570201 | |
| 08:14:10 | openstackgerrit | Theodoros Tsioutsias proposed openstack/nova master: Add instance hard delete https://review.openstack.org/570202 | |
| 08:14:11 | openstackgerrit | Theodoros Tsioutsias proposed openstack/nova master: Enable rebuild for instances in cell0 https://review.openstack.org/570203 | |
| 08:14:39 | openstackgerrit | Theodoros Tsioutsias proposed openstack/nova master: Introduce the PENDING instance state https://review.openstack.org/566473 | |
| 08:14:40 | openstackgerrit | Theodoros Tsioutsias proposed openstack/nova master: Allow rebuild for instances in PENDING state https://review.openstack.org/637585 | |
| 08:19:33 | openstackgerrit | Merged openstack/os-vif stable/stein: Replace openstack.org git:// URLs with https:// https://review.openstack.org/646869 | |
| 08:27:07 | openstackgerrit | Bhagyashri Shewale proposed openstack/nova master: Ignore root_gb for BFV in simple tenant usage API https://review.openstack.org/612626 | |
| 09:53:43 | openstackgerrit | Michael Still proposed openstack/nova master: Remove fake_libvirt_utils users in functional testing. https://review.openstack.org/644793 | |
| 09:53:43 | openstackgerrit | Michael Still proposed openstack/nova master: Remove remaining vestiges of fake_libvirt_utils from unit tests. https://review.openstack.org/643896 | |
| 09:53:43 | openstackgerrit | Michael Still proposed openstack/nova master: Remove fake_libvirt_utils from libvirt imagebackend tests. https://review.openstack.org/643895 | |
| 09:53:43 | openstackgerrit | Michael Still proposed openstack/nova master: Remove fake_libvirt_utils from virt driver tests. https://review.openstack.org/643894 | |
| 09:53:43 | openstackgerrit | Michael Still proposed openstack/nova master: Remove fake_libvirt_utils from snapshot tests. https://review.openstack.org/642558 | |
| 09:53:43 | openstackgerrit | Michael Still proposed openstack/nova master: Remove fake_libvirt_utils from connection tests. https://review.openstack.org/642557 | |
| 12:17:09 | jaypipes | sean-k-mooney: see my request on https://review.openstack.org/#/c/629589/ please. If you can knock that out quick, I can quick-approve since stephenfin was +2 on it already. | |
| 12:21:38 | sean-k-mooney | jaypipes: thank i will check it in a sec. currently removing utils.lock i do actully think its useful but im happy to update it too | |
| 12:22:34 | jaypipes | sean-k-mooney: ack | |
| 12:23:50 | sean-k-mooney | and ya the change you asked for in https://review.openstack.org/#/c/629589/21 are all pretty straigt forward so ill do those before the end of the day | |
| 13:20:56 | kaisers | fried_rice: good lunch? :) Should you later on have the capacity, would you perhaps take a look at https://review.openstack.org/#/c/522245/ (missing a second +2)? I's a second long hung fix... | |
| 13:23:37 | openstackgerrit | Stephen Finucane proposed openstack/nova master: Remove dead code https://review.openstack.org/650277 | |
| 13:31:45 | openstackgerrit | Kashyap Chamarthy proposed openstack/nova stable/queens: conf: libvirt: Make `/dev/urandom` the default for 'rng_dev_path' https://review.openstack.org/650279 | |
| 13:32:43 | finucannot | fried_rice: I think I've finished removing cells v1 in a local series (running through/fixing tests atm). I want to track the effort somehow though. Is a specless BP suitable for that kind of stuff? | |
| 13:37:16 | sean-k-mooney | well there is no api change so i dont think i spec is techncially required its definetly not a bug so a blueprint seams best | |
| 13:37:49 | sean-k-mooney | some might want want a spec for the upgrade impact/docs bug im not sure | |
| 13:38:42 | sean-k-mooney | its been deprecated for many releases so it wont be a shock to anywon but we will want to get cerns input on it before we actully fully drop it | |
| 13:39:24 | sean-k-mooney | finucannot: by the way does that removal also include nova networks or is that the next thing on your list :) | |
| 13:39:28 | tssurya | sean-k-mooney: oh yea got for it , we have no more ties to cells_v1 | |
| 13:39:33 | tssurya | go* | |
| 13:40:26 | sean-k-mooney | that is good to hear. we proably should still wait until ptg to so we can comunicate it to other operators befoer merging the deletions | |
| 13:40:30 | finucannot | sean-k-mooney: Nah, cells v1 only for now. I was actually trying to strip out nova-network but cells v1 relied on it | |
| 13:40:52 | sean-k-mooney | yes which is why nova net is still a thing | |
| 13:41:35 | finucannot | sean-k-mooney: and it'll be totally separate since this series already weighs in at 34 patches | |
| 13:41:44 | finucannot | Some of which I'll be able to fold in but still | |
| 13:42:26 | sean-k-mooney | ya it should be seperate | |
| 14:16:59 | fried_rice | kaisers: looking... | |
| 14:17:12 | fried_rice | finucannot: Specless BP for cellsv1 removal, hells yeah. | |
| 14:23:14 | dansmith | I think we need a real spec for cellsv1 removal | |
| 14:23:40 | melwitt | finucannot: +1 on removing cells v1 and nova-net separately | |
| 14:28:46 | mriedem | we have had specless bps in the past for nova-net removal | |
| 14:28:58 | fried_rice | kaisers: +A, but a couple of questions inline | |
| 14:29:20 | mriedem | https://blueprints.launchpad.net/nova/+spec/remove-nova-network | |
| 14:29:24 | fried_rice | dansmith: what would the spec say? | |
| 14:29:42 | dansmith | fried_rice: I was totally joking, but you people are slow and the moment was ruined | |
| 14:29:54 | mriedem | note nothing happened in stein https://blueprints.launchpad.net/nova/+spec/remove-nova-network-stein | |
| 14:29:58 | fried_rice | oy | |
| 14:30:40 | mriedem | also note it's not as easy as just deleting some code | |
| 14:30:54 | mriedem | there are still APIs that are nova-net specific that need to be changed to 410s https://etherpad.openstack.org/p/nova-network-removal-rocky | |
| 14:31:42 | finucannot | mriedem: Oh, I know | |
| 14:31:47 | finucannot | that's the first patch in my series | |
| 14:31:57 | finucannot | Sorry, I meant for cells | |
| 14:32:03 | finucannot | same thing for nova-net tho | |
| 14:32:35 | mriedem | i also tend to think the people that are familiar with this code should be doing the removal - i didn't realize you'd already started a removal series | |
| 14:32:54 | kashyap | Hey folks, is there some shortcut to build just _one_ releases's specs? E.g. `tox -e docs train` or something like that | |
| 14:33:10 | mriedem | kashyap: no | |
| 14:33:29 | kashyap | Okido; figured as much | |
| 14:34:13 | finucannot | mriedem: I figured the important bit was that _somebody_ did it | |
| 14:34:25 | fried_rice | kashyap: yes, hold | |
| 14:34:26 | finucannot | Plus, nothing stops those people review the series and provide their insight that way | |
| 14:35:14 | mriedem | finucannot: at the very least i think there needs to be a plan | |
| 14:35:17 | fried_rice | kashyap: http://paste.openstack.org/show/748945/ | |
| 14:35:46 | mriedem | finucannot: like, do you know about the nova-net and cells v1 dependency for startup? | |
| 14:35:52 | fried_rice | kashyap: Haven't actually used it in a while, it's possible some of the path assumptions will need to be tweaked since we've been dorking with tox.ini lately. | |
| 14:35:53 | finucannot | mriedem: That's fair. PTG is only a few weeks away. I drafted this in a day so I'm happy to let it sit in Gerrit til then | |
| 14:35:56 | mriedem | and if so, how are you planning on removing the stuff based on deps? | |
| 14:36:06 | finucannot | mriedem: that nova-net won't start unless cells v1 is enabled? | |
| 14:36:11 | kashyap | fried_rice: Ah, thanks. /me clicks | |
| 14:36:31 | mriedem | right - so going to remove nova-net first? which is harder, or break that dependency and remove cells v1 first | |
| 14:36:46 | kashyap | fried_rice: Yeah, I saw your tox.ini patch fly-by for the 'specs/backlog' thingie | |
| 14:36:53 | dansmith | tssurya: you're done with v1, but are you done with n-net? | |
| 14:36:58 | dansmith | last I heard you weren't | |
| 14:37:00 | fried_rice | kashyap: That one shouldn't affect this at all. | |
| 14:37:05 | finucannot | I just switched that 'if not cells.enabled' check to 'if True:' so nova-net can never start now. It leaves reams of useless code but that's a trivial cleanup exercise now | |
| 14:37:15 | mriedem | dansmith: belmiro said in the ML that we could drop nova-net now too | |
| 14:37:18 | kashyap | fried_rice: Ah, this is a personal hack; nice | |
| 14:37:19 | dansmith | ah okay | |
| 14:37:26 | fried_rice | kashyap: But there was a flurry a few months ago where we changed the names of venvs and stuff. Might not have been in the specs repo though. | |
| 14:37:47 | fried_rice | kashyap: Yeah, looks like it boils down to the sphinx-build line with the right args, while sitting in the venv. | |
| 14:38:14 | mriedem | finucannot: if you're looking for something that needs to be done first but avoid breaking runtime code, fix the functional tests to not rely on nova-net by default https://github.com/openstack/nova/blob/master/nova/tests/functional/integrated_helpers.py#L82 | |
| 14:38:20 | openstackgerrit | Lee Yarwood proposed openstack/nova stable/queens: Delete instance_id_mappings record in instance_destroy https://review.openstack.org/650309 | |
| 14:38:29 | mriedem | https://github.com/openstack/nova/blob/master/nova/tests/functional/integrated_helpers.py#L87 | |
| 14:38:57 | mriedem | and get REQUIRES_LOCKING to default to False (it's True because by default we startup nova-network for functional tests) | |
| 14:39:37 | finucannot | mriedem: Sure, I can take a look at that. It's probably going to come up as I walk through this series fixing tests I've broken along the way | |
| 14:39:41 | finucannot | so. much. coupling. | |
| 14:40:10 | mriedem | finucannot: can you link me? | |
| 14:40:31 | finucannot | mriedem: to? | |
| 14:40:40 | mriedem | you said you had a patch series | |
| 14:40:47 | mriedem | but i don't see it in gerrit | |
| 14:41:07 | fried_rice | finucannot: better upload it before your computer crashes and you lose it. | |
| 14:41:38 | finucannot | mriedem: Nah, local only for now. It's failing from about half way in and I don't want to punish the gate (35 patches) | |
| 14:42:32 | mriedem | jesus | |
| 14:42:44 | mriedem | i really wish you would have brought this up before starting a huge local patch series | |
| 14:42:44 | finucannot | mriedem: https://github.com/stephenfin/nova/commits/cells-v1-removal | |
| 14:43:42 | finucannot | It's only a days work and I'll be folding a lot of that into other patches. If I end up dumping a lot of it, well, I learned stuff about the API | |
| 14:43:51 | finucannot | That's nowhere near final, btw | |
| 14:47:09 | kashyap | fried_rice: Thanks, noted. | |
| 14:47:11 | mriedem | ok so glancing through this you're killing of cells v1 separate from nova-net | |
| 14:47:18 | mriedem | starting with the api and cli entry points | |
| 14:47:22 | mriedem | and then working down | |
| 14:48:22 | finucannot | correct | |
| 14:48:39 | mriedem | if you can get what you have here cleaned up and passing, then i say push that up and let people start to look at it | |
| 14:48:55 | finucannot | Stop people using it so I can slowly break stuff without worrying about screwing up someones deployment | |