| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2019-04-02 | |||
| 17:43:21 | mriedem | well i don't know about all that wackiness but i know you need a test and you could avoid blanket ignoring Exception if you changed to handle PciDeviceNotFoundById | |
| 17:43:27 | mriedem | and add a comment about why it's ok to ignore | |
| 17:44:06 | mriedem | run a spellchecker on your commit message as well :) | |
| 17:44:07 | sean-k-mooney | yep ill do all of the above. i was copying what we do here more or less https://github.com/openstack/nova/blame/2384c41b781a84de98d0932f44d4b3c544c3fe3d/nova/pci/utils.py#L205 | |
| 17:47:17 | mriedem | you also need a nova bug for that and tag it with stein-rc-potential | |
| 17:47:19 | mriedem | and inform the PTL | |
| 17:48:03 | sean-k-mooney | yes cfriesen or one of his coworkers is filing the bug but i guess i can jsut do that and i pingged efried but i think he is away or having lunch | |
| 17:48:20 | sean-k-mooney | or ignoring me that is valid too | |
| 17:48:24 | mriedem | he's out cracking skulls over lunch break i'm sure | |
| 17:49:50 | sean-k-mooney | cool ill get all of this done in the next hour or so. im asummig this qualifies by the way for the rc/stien release | |
| 17:49:55 | dansmith | this is stein ptl anyway right? | |
| 17:50:06 | sean-k-mooney | oh that would be melwitt then | |
| 17:50:11 | efried | I'm back | |
| 17:50:46 | efried | sean-k-mooney: I'm not stable anyway | |
| 17:50:51 | efried | take that however you like | |
| 17:50:56 | dansmith | nice | |
| 17:51:05 | sean-k-mooney | efried: cfriesen/starlingx noticed you cant start nova compute oh host with qat integrated into the cpu/chipset | |
| 17:51:28 | efried | clearly we just need to get rid of the pci subsystem | |
| 17:52:06 | sean-k-mooney | clearly. the fix is trivail and im cleaning it up now. ill ping people when its all ready | |
| 17:52:24 | KH-Jared | optionally | |
| 17:52:24 | KH-Jared | trying to make sure I'm handling my change in the best way. I saw two options for making the addresses happy for libguestfs without changing how they were provided to libvirt, make striping the brackets optional or add them back if it looked like IPv6. Adding them back seemed easier but improper, since it would be removing and adding the brackets for no purpose, so I was going to go with trying to leave the brackets, | |
| 17:52:32 | dansmith | sean-k-mooney: and you're going to spell check the snot out of it right? | |
| 17:52:39 | dansmith | sean-k-mooney: maybe two or three times just to be sure? | |
| 17:52:41 | sean-k-mooney | yes :) | |
| 17:54:35 | efried | sean-k-mooney: So you want that bug assigned to you? | |
| 17:54:59 | sean-k-mooney | well i or cfriesen will file a nova one and ya it can be assigned to me | |
| 17:55:30 | sean-k-mooney | the current bug is against starlingx | |
| 17:55:45 | efried | sean-k-mooney: You can add 'affects' to the same bug, nah? | |
| 17:56:43 | mordred | mriedem: https://review.openstack.org/626949 - patch to osc regarding live migration and arguments | |
| 17:56:49 | efried | I guess the nova fix has to be ported to the stx fork? | |
| 17:57:37 | mriedem | mordred: yeah i added you since i know you're at least aware of there being a few changes for that same issue | |
| 17:57:54 | sean-k-mooney | so i was thinking about just adding nova as a component of the same bug but im not sure how that works with the rc potential tag | |
| 17:57:59 | mriedem | mordred: L18 https://etherpad.openstack.org/p/DEN-osc-compute-api-gaps | |
| 18:01:46 | openstackgerrit | Artem Vasilyev proposed openstack/nova master: systemd detection result caching nit fixes https://review.openstack.org/649229 | |
| 18:02:27 | mriedem | someone tell me how this makes sense: | |
| 18:02:30 | mriedem | pike: https://github.com/openstack/nova/blame/1c6f99dc9aacaea78242561df35957bb711c6161/nova/tests/unit/conductor/test_conductor.py#L1360 | |
| 18:02:35 | mriedem | ocata: https://github.com/openstack/nova/blame/9b76fc7a0a1afbd9f2cd0d5786c37138c1b820f1/nova/tests/unit/conductor/test_conductor.py#L1377 | |
| 18:02:43 | mriedem | the code is different, but the commit on the left in the blame is the same | |
| 18:03:27 | dansmith | code looks the same to me | |
| 18:03:59 | dansmith | wait, I opened the same thing twice :D | |
| 18:04:04 | mriedem | heh | |
| 18:04:38 | mriedem | oh i know, | |
| 18:04:47 | mriedem | something just removed code which is why it's not showing up in the pike blame | |
| 18:05:29 | dansmith | yeah, looks like it | |
| 18:05:33 | openstackgerrit | Artem Vasilyev proposed openstack/nova master: systemd detection result caching nit fixes https://review.openstack.org/649229 | |
| 18:05:38 | dansmith | request_spec={} et al | |
| 18:05:44 | mriedem | yeah | |
| 18:07:50 | mriedem | bingo | |
| 18:07:51 | mriedem | https://github.com/openstack/nova/commit/e211fca55a11c80058d5d78e31dc3ad466d7edfd#diff-df5e04ccff7072ded89c488a5649639e | |
| 18:08:26 | mriedem | https://www.youtube.com/watch?v=YqAyz1coj44 | |
| 18:08:58 | dansmith | heh | |
| 18:14:53 | openstackgerrit | Artom Lifshitz proposed openstack/nova master: Docs: emulator threads: clarify expected behavior https://review.openstack.org/649416 | |
| 18:15:06 | artom | stephenfin, sean-k-mooney ^^ from this morning's downstream discussion | |
| 18:15:56 | sean-k-mooney | oh the Horror https://review.openstack.org/#/c/649416/1/doc/source/user/flavors.rst@576 | |
| 18:16:24 | openstackgerrit | Merged openstack/nova master: Do not persist RequestSpec.ignore_hosts https://review.openstack.org/647512 | |
| 18:17:08 | sean-k-mooney | first glance ignoring the space it looks fine | |
| 18:17:13 | sean-k-mooney | ill wait for the docs job to finish | |
| 18:25:15 | openstackgerrit | Matt Riedemann proposed openstack/nova stable/ocata: Add functional regression test for bug 1669054 https://review.openstack.org/649419 | |
| 18:25:18 | openstackgerrit | Matt Riedemann proposed openstack/nova stable/ocata: Do not persist RequestSpec.ignore_hosts https://review.openstack.org/649420 | |
| 18:25:18 | openstack | bug 1669054 in OpenStack Compute (nova) stein "RequestSpec.ignore_hosts from resize is reused in subsequent evacuate" [Medium,In progress] https://launchpad.net/bugs/1669054 - Assigned to Matt Riedemann (mriedem) | |
| 18:31:54 | openstackgerrit | Artem Vasilyev proposed openstack/nova master: systemd detection result caching nit fixes https://review.openstack.org/649229 | |
| 18:33:08 | openstackgerrit | Matt Riedemann proposed openstack/nova stable/stein: Error out migration when confirm_resize fails https://review.openstack.org/649421 | |
| 18:35:46 | openstackgerrit | sean mooney proposed openstack/nova master: gracefully handle non-nic VFs https://review.openstack.org/649409 | |
| 18:47:37 | openstackgerrit | Eric Fried proposed openstack/nova master: docs: Rework all things metadata'y https://review.openstack.org/640730 | |
| 19:07:28 | openstackgerrit | sean mooney proposed openstack/nova master: Libvirt: gracefully handle non-nic VFs https://review.openstack.org/649409 | |
| 19:08:49 | sean-k-mooney | melwitt: efried i think ^ is now correct? | |
| 19:09:51 | sean-k-mooney | i have added nova to the existing bug and added the stein-rc-potential tag but if you would like a new bug filed i can do that too. | |
| 19:10:17 | sean-k-mooney | im going to have dinner but if you want any changes let me know | |
| 19:10:19 | efried | sean-k-mooney: assuming stx doesn't care about our stein-rc-potential tag, I think this should be fine. | |
| 19:10:21 | efried | Thanks sean-k-mooney | |
| 19:10:37 | sean-k-mooney | cfriesen: any comment on ^ | |
| 19:11:14 | cfriesen | looking | |
| 19:11:17 | sean-k-mooney | i think it should be ok but we should discuss it at the ptg too. e.g. how to tack cross project bugs like this between openstack and starlingx | |
| 19:16:38 | cfriesen | sean-k-mooney: looks reasonable, but why not put the result['parent_ifname'] assignment in the try block and get rid of the initial assignment to None and the conditional? | |
| 19:18:30 | openstackgerrit | Ghanshyam Mann proposed openstack/nova-specs master: Spec for API policy updates https://review.openstack.org/547850 | |
| 19:21:39 | cfriesen | efried: one of our people in charge thinks adding nova (and the tag) to that bug is a good solution for tracking joint issues | |
| 19:21:57 | cfriesen | (i.e. StarlingX, just to be clear) | |
| 19:21:57 | efried | wfm. mriedem may have a stronger opinion. | |
| 19:22:13 | efried | cfriesen: what's not clear to me is whether anything needs to be done on the stx side at all. | |
| 19:22:51 | cfriesen | on our end it'll likely just be picking up a new load once it's fixed in nova and validating the issue is gone | |
| 19:25:19 | sean-k-mooney | cfriesen: ya i think from a souce code point of view it will be a cherrypick or rebase | |
| 19:25:35 | sean-k-mooney | there is obviously the testing aspect too. | |
| 19:26:50 | cfriesen | sean-k-mooney: with your fix we're seeing logs every minute: nova.pci.utils [req-d9c8620e-7990-4b3c-a6b0-88a131852e47 - - - - -] No net device was found for VF 0000:3d:02.2: PciDeviceNotFoundById: PCI device 0000:3d:02.2 not found | |
| 19:27:13 | sean-k-mooney | that is from the other capablities fucntion | |
| 19:27:49 | sean-k-mooney | not adding a second message every minute was why i add the pass in teh except block in stead of logging | |
| 19:29:29 | cfriesen | might make sense to quiet that down, but that's not quite so urgent. | |
| 19:29:36 | sean-k-mooney | cfriesen: that comes form here https://github.com/openstack/nova/blob/master/nova/pci/utils.py#L224-L225 | |
| 19:29:45 | cfriesen | it's 48 logs every minute | |
| 19:30:13 | sean-k-mooney | cfriesen: ya that has been there for 2 or 3 releases | |
| 19:30:32 | sean-k-mooney | im going to work on a followup to fix some comments i notice i can remove that warning too. | |
| 19:30:39 | sean-k-mooney | or make it a debug message | |
| 19:30:58 | cfriesen | debug might be good | |
| 19:31:21 | sean-k-mooney | there is nothing that an operator can do to scilence it if they have non nic VF currently and its not helpful in that case | |
| 19:31:33 | cfriesen | agreed | |
| 19:32:20 | sean-k-mooney | anyway the fact that your nova-compute agent didnt die means the fix is at least minimally working. | |
| 19:35:05 | sean-k-mooney | i might look at optimising this code a bit too. currently we call _get_pcidev_info from _get_pci_passthrough_devices before applying the pci whitelist so we look at way more device then we need too | |
| 19:50:08 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Fix comment in test_attach_with_multiattach_fails_not_available https://review.openstack.org/649440 | |
| 19:52:35 | openstackgerrit | Merged openstack/nova master: Fix a deprecation warning https://review.openstack.org/649234 | |
| 19:54:45 | efried | Seems to hit several different jobs, but always grenade | |
| 19:54:45 | efried | mriedem: How about this one: http://logstash.openstack.org/#dashboard/file/logstash.json?query=message%3A%5C%22ModuleNotFoundError%3A%20No%20module%20named%20'memcache'%5C%22 | |