| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2019-04-02 | |||
| 17:07:16 | sean-k-mooney | which is because of gibis change | |
| 17:07:34 | sean-k-mooney | ya but the other filtering im thinking of could be else where | |
| 17:07:48 | sean-k-mooney | i think we just need to put a guard around that call | |
| 17:08:00 | cfriesen | sean-k-mooney: looks like _get_device_capabilities() also assumes that SRIOV_VF is a NIC | |
| 17:09:12 | sean-k-mooney | yes it does | |
| 17:09:26 | sean-k-mooney | although it is reading form libvirt | |
| 17:09:34 | sean-k-mooney | instead of sysfs | |
| 17:09:38 | sean-k-mooney | so it proably fine | |
| 17:10:21 | cfriesen | sean-k-mooney: _get_pcinet_info calls get_net_name_by_vf_pci_address() | |
| 17:10:26 | cfriesen | so I think it'll choke | |
| 17:10:44 | sean-k-mooney | ill quickly hack something up one sec | |
| 17:12:18 | sean-k-mooney | cfriesen: https://github.com/openstack/nova/blob/master/nova/virt/libvirt/driver.py#L6008-L6010 i think will guard it for that case | |
| 17:12:58 | sean-k-mooney | actully no it wont | |
| 17:14:23 | sean-k-mooney | actully it should be fine | |
| 17:14:24 | sean-k-mooney | https://github.com/openstack/nova/blob/master/nova/pci/utils.py#L205 | |
| 17:14:31 | sean-k-mooney | the exception is caught internally | |
| 17:14:48 | cfriesen | ah, yes | |
| 17:15:13 | sean-k-mooney | am is that the case in the starlingx code? | |
| 17:15:46 | cfriesen | should be, but we were choking earlier in _get_device_type() | |
| 17:16:19 | sean-k-mooney | oh i see the issue | |
| 17:16:30 | sean-k-mooney | we are doing | |
| 17:16:32 | sean-k-mooney | 'parent_ifname': | |
| 17:16:34 | sean-k-mooney | pci_utils.get_ifname_by_pci_address( | |
| 17:16:36 | sean-k-mooney | pci_address, pf_interface=True), | |
| 17:17:01 | sean-k-mooney | so we are calling pci_utils.get_ifname_by_pci_address directly so we dont catch the excpetion | |
| 17:17:02 | cfriesen | yep | |
| 17:17:13 | sean-k-mooney | where as the other code calls get_net_name_by_vf_pci_address which does | |
| 17:17:59 | sean-k-mooney | ok this is a simile fix ill do it now and make it as closing the bug | |
| 17:18:22 | sean-k-mooney | efried: im going to try and fix https://bugs.launchpad.net/starlingx/+bug/1821938 can we land it in stien? | |
| 17:18:23 | cfriesen | I think one of my coworkers is going to open a nova bug | |
| 17:18:23 | openstack | Launchpad bug 1821938 in StarlingX "No nova hypervisor can be enabled on workers with QAT devices" [High,Triaged] | |
| 17:18:46 | sean-k-mooney | ok ill add the starlingx bug as a related bug so | |
| 17:18:54 | sean-k-mooney | or do ye want to fix it | |
| 17:19:11 | cfriesen | go for it | |
| 17:20:53 | cfriesen | I think my guy is having lunch. :) I'll send you the nova bug when I get the number. | |
| 17:24:31 | stephenfin | mriedem: https://review.openstack.org/626949 | |
| 17:26:05 | openstackgerrit | Jared Winborne proposed openstack/nova master: Leave the brackets on Ceph Monitor IPv6 addresses for libguestfs https://review.openstack.org/649405 | |
| 17:31:19 | KH-Jared | I fully expect my change didn't follow some proper practice on the change I just submitted, guess I just have to wait and find out what that is at this point | |
| 17:37:09 | openstackgerrit | sean mooney proposed openstack/nova master: gracefuly handel none nic VFs https://review.openstack.org/649409 | |
| 17:37:34 | sean-k-mooney | cfriesen: ^ | |
| 17:37:56 | mriedem | KH-Jared: commented | |
| 17:38:00 | sean-k-mooney | i need to run the unit test and see if any fail and alsoadd a new one | |
| 17:39:12 | KH-Jared | ty mriedem | |
| 17:39:17 | sean-k-mooney | mriedem: not sure if you were following but ^ is a fix for https://bugs.launchpad.net/starlingx/+bug/1821938 | |
| 17:39:18 | openstack | Launchpad bug 1821938 in StarlingX "No nova hypervisor can be enabled on workers with QAT devices" [High,Triaged] | |
| 17:39:32 | mriedem | sean-k-mooney: i wasn't | |
| 17:39:45 | sean-k-mooney | think we could land it in stien if i get it ready soon | |
| 17:39:52 | mriedem | idk wtf a qat device is | |
| 17:40:10 | sean-k-mooney | intesl Quick assist crypto card | |
| 17:40:13 | mriedem | looks like something gibi_off should be aware of | |
| 17:40:25 | sean-k-mooney | it was the first pci passthough device we supported in nova | |
| 17:41:16 | sean-k-mooney | mriedem: ya so gibi_off added the auto parent interface name lookup feature i suggeted for the bandwidth based schudling | |
| 17:41:29 | sean-k-mooney | but we missed that it shoudl have handeld VF that were not nics | |
| 17:41:47 | sean-k-mooney | so it raise an excpution if you have a pci device that support sriov but is not a nic | |
| 17:42:03 | sean-k-mooney | like a QAT device or a GPU that uses sriov like amd do | |
| 17:43:21 | mriedem | well i don't know about all that wackiness but i know you need a test and you could avoid blanket ignoring Exception if you changed to handle PciDeviceNotFoundById | |
| 17:43:27 | mriedem | and add a comment about why it's ok to ignore | |
| 17:44:06 | mriedem | run a spellchecker on your commit message as well :) | |
| 17:44:07 | sean-k-mooney | yep ill do all of the above. i was copying what we do here more or less https://github.com/openstack/nova/blame/2384c41b781a84de98d0932f44d4b3c544c3fe3d/nova/pci/utils.py#L205 | |
| 17:47:17 | mriedem | you also need a nova bug for that and tag it with stein-rc-potential | |
| 17:47:19 | mriedem | and inform the PTL | |
| 17:48:03 | sean-k-mooney | yes cfriesen or one of his coworkers is filing the bug but i guess i can jsut do that and i pingged efried but i think he is away or having lunch | |
| 17:48:20 | sean-k-mooney | or ignoring me that is valid too | |
| 17:48:24 | mriedem | he's out cracking skulls over lunch break i'm sure | |
| 17:49:50 | sean-k-mooney | cool ill get all of this done in the next hour or so. im asummig this qualifies by the way for the rc/stien release | |
| 17:49:55 | dansmith | this is stein ptl anyway right? | |
| 17:50:06 | sean-k-mooney | oh that would be melwitt then | |
| 17:50:11 | efried | I'm back | |
| 17:50:46 | efried | sean-k-mooney: I'm not stable anyway | |
| 17:50:51 | efried | take that however you like | |
| 17:50:56 | dansmith | nice | |
| 17:51:05 | sean-k-mooney | efried: cfriesen/starlingx noticed you cant start nova compute oh host with qat integrated into the cpu/chipset | |
| 17:51:28 | efried | clearly we just need to get rid of the pci subsystem | |
| 17:52:06 | sean-k-mooney | clearly. the fix is trivail and im cleaning it up now. ill ping people when its all ready | |
| 17:52:24 | KH-Jared | optionally | |
| 17:52:24 | KH-Jared | trying to make sure I'm handling my change in the best way. I saw two options for making the addresses happy for libguestfs without changing how they were provided to libvirt, make striping the brackets optional or add them back if it looked like IPv6. Adding them back seemed easier but improper, since it would be removing and adding the brackets for no purpose, so I was going to go with trying to leave the brackets, | |
| 17:52:32 | dansmith | sean-k-mooney: and you're going to spell check the snot out of it right? | |
| 17:52:39 | dansmith | sean-k-mooney: maybe two or three times just to be sure? | |
| 17:52:41 | sean-k-mooney | yes :) | |
| 17:54:35 | efried | sean-k-mooney: So you want that bug assigned to you? | |
| 17:54:59 | sean-k-mooney | well i or cfriesen will file a nova one and ya it can be assigned to me | |
| 17:55:30 | sean-k-mooney | the current bug is against starlingx | |
| 17:55:45 | efried | sean-k-mooney: You can add 'affects' to the same bug, nah? | |
| 17:56:43 | mordred | mriedem: https://review.openstack.org/626949 - patch to osc regarding live migration and arguments | |
| 17:56:49 | efried | I guess the nova fix has to be ported to the stx fork? | |
| 17:57:37 | mriedem | mordred: yeah i added you since i know you're at least aware of there being a few changes for that same issue | |
| 17:57:54 | sean-k-mooney | so i was thinking about just adding nova as a component of the same bug but im not sure how that works with the rc potential tag | |
| 17:57:59 | mriedem | mordred: L18 https://etherpad.openstack.org/p/DEN-osc-compute-api-gaps | |
| 18:01:46 | openstackgerrit | Artem Vasilyev proposed openstack/nova master: systemd detection result caching nit fixes https://review.openstack.org/649229 | |
| 18:02:27 | mriedem | someone tell me how this makes sense: | |
| 18:02:30 | mriedem | pike: https://github.com/openstack/nova/blame/1c6f99dc9aacaea78242561df35957bb711c6161/nova/tests/unit/conductor/test_conductor.py#L1360 | |
| 18:02:35 | mriedem | ocata: https://github.com/openstack/nova/blame/9b76fc7a0a1afbd9f2cd0d5786c37138c1b820f1/nova/tests/unit/conductor/test_conductor.py#L1377 | |
| 18:02:43 | mriedem | the code is different, but the commit on the left in the blame is the same | |
| 18:03:27 | dansmith | code looks the same to me | |
| 18:03:59 | dansmith | wait, I opened the same thing twice :D | |
| 18:04:04 | mriedem | heh | |
| 18:04:38 | mriedem | oh i know, | |
| 18:04:47 | mriedem | something just removed code which is why it's not showing up in the pike blame | |
| 18:05:29 | dansmith | yeah, looks like it | |
| 18:05:33 | openstackgerrit | Artem Vasilyev proposed openstack/nova master: systemd detection result caching nit fixes https://review.openstack.org/649229 | |