Earlier  
Posted Nick Remark
#openstack-nova - 2019-04-02
00:30:10 melwitt self.path won't have the token in it by the time it gets to the plugin
00:33:41 melwitt mnaser: ok. I did similar locally to come to the same conclusion. the only thing I notice offhand is I think you removed the scheme validation, at best you'd have to have it run in a different order than before (currently it's scheme, token, the rest). with the plugin it would have to be token, scheme, the rest
02:13:08 openstackgerrit Brin Zhang proposed openstack/nova-specs master: Specifying az when restore shelved server https://review.openstack.org/624689
02:53:35 openstackgerrit Takashi NATSUME proposed openstack/nova master: WIP: Add a live migration regression test https://review.openstack.org/641200
03:19:42 openstackgerrit Seyeong Kim proposed openstack/nova stable/rocky: Share snapshot image membership with instance owner https://review.openstack.org/643853
05:12:28 openstackgerrit Takashi NATSUME proposed openstack/nova master: Add a live migration regression test https://review.openstack.org/641200
05:23:40 openstackgerrit Seyeong Kim proposed openstack/nova stable/rocky: Share snapshot image membership with instance owner https://review.openstack.org/643853
05:34:54 openstackgerrit Seyeong Kim proposed openstack/nova stable/rocky: Share snapshot image membership with instance owner https://review.openstack.org/643853
05:59:54 openstackgerrit Brin Zhang proposed openstack/nova-specs master: Specifying az when restore shelved server https://review.openstack.org/624689
06:20:12 openstackgerrit Artem Vasilyev proposed openstack/nova master: systemd detection result caching nit fixes https://review.openstack.org/649229
06:22:00 kaisers mdbooth: Yep, saw that. Will follow up
06:24:29 openstackgerrit Artem Vasilyev proposed openstack/nova master: systemd detection result caching nit fixes https://review.openstack.org/649229
07:21:37 openstackgerrit Takashi NATSUME proposed openstack/nova master: Fix a deprecation warning https://review.openstack.org/649234
08:15:40 openstackgerrit Merged openstack/nova master: Pass --nic when creating servers in evacuate integration test script https://review.openstack.org/649036
08:46:11 openstackgerrit Michael Still proposed openstack/nova master: Remove fake_libvirt_utils from connection tests. https://review.openstack.org/642557
08:46:12 openstackgerrit Michael Still proposed openstack/nova master: Make privsep.chown mocking for libvirt snapshot tests less magic. https://review.openstack.org/642134
08:46:12 openstackgerrit Michael Still proposed openstack/nova master: Remove fake_libvirt_utils from snapshot tests. https://review.openstack.org/642558
08:46:13 openstackgerrit Michael Still proposed openstack/nova master: Remove fake_libvirt_utils from libvirt imagebackend tests. https://review.openstack.org/643895
08:46:13 openstackgerrit Michael Still proposed openstack/nova master: Remove fake_libvirt_utils from virt driver tests. https://review.openstack.org/643894
08:46:14 openstackgerrit Michael Still proposed openstack/nova master: Remove fake_libvirt_utils users in functional testing. https://review.openstack.org/644793
08:46:14 openstackgerrit Michael Still proposed openstack/nova master: Remove remaining vestiges of fake_libvirt_utils from unit tests. https://review.openstack.org/643896
08:46:15 openstackgerrit Michael Still proposed openstack/nova master: Remove write_to_file. https://review.openstack.org/645087
08:46:15 openstackgerrit Michael Still proposed openstack/nova master: Remove usused umask argument to virt.libvirt.utils.write_to_file https://review.openstack.org/645086
08:57:40 openstackgerrit Yongli He proposed openstack/nova master: Clean up orphan instances https://review.openstack.org/627765
08:57:40 openstackgerrit Yongli He proposed openstack/nova master: Clean up orphan instances virt driver https://review.openstack.org/648912
09:31:08 openstackgerrit Seyeong Kim proposed openstack/nova stable/rocky: Share snapshot image membership with instance owner https://review.openstack.org/643853
09:36:40 openstackgerrit Kashyap Chamarthy proposed openstack/nova-specs master: Re-propose the spec to allow specifying a list of CPU models https://review.openstack.org/642030
10:13:16 openstackgerrit Michael Still proposed openstack/nova master: Style corrections for privsep usage. https://review.openstack.org/648615
10:13:17 openstackgerrit Michael Still proposed openstack/nova master: Improve test coverage of nova.privsep.path. https://review.openstack.org/648601
10:13:17 openstackgerrit Michael Still proposed openstack/nova master: Hacking N362: Don't abbrev/alias privsep import https://review.openstack.org/649190
10:13:18 openstackgerrit Michael Still proposed openstack/nova master: Improve test coverage of nova.privsep.fs, continued. https://review.openstack.org/648603
10:13:18 openstackgerrit Michael Still proposed openstack/nova master: Improve test coverage of nova.privsep.fs. https://review.openstack.org/648602
10:13:19 openstackgerrit Michael Still proposed openstack/nova master: Add test coverage for nova.privsep.qemu. https://review.openstack.org/649191
10:13:19 openstackgerrit Michael Still proposed openstack/nova master: Add test coverage for nova.privsep.libvirt. https://review.openstack.org/648616
10:13:20 openstackgerrit Michael Still proposed openstack/nova master: Remove unused FP device creation and deletion methods. https://review.openstack.org/635433
10:13:20 openstackgerrit Michael Still proposed openstack/nova master: Privsepify ipv4 forwarding enablement. https://review.openstack.org/635431
10:13:21 openstackgerrit Michael Still proposed openstack/nova master: Move adding vlans to interfaces to privsep. https://review.openstack.org/635436
10:13:21 openstackgerrit Michael Still proposed openstack/nova master: Privsep the ebtables modification code. https://review.openstack.org/635435
10:13:22 openstackgerrit Michael Still proposed openstack/nova master: Move dnsmasq restarts to privsep. https://review.openstack.org/639280
10:13:22 openstackgerrit Michael Still proposed openstack/nova master: Move iptables rule fetching and setting to privsep. https://review.openstack.org/636508
10:13:23 openstackgerrit Michael Still proposed openstack/nova master: Move calls to ovs-vsctl to privsep. https://review.openstack.org/639282
10:13:23 openstackgerrit Michael Still proposed openstack/nova master: Move router advertisement daemon restarts to privsep. https://review.openstack.org/639281
10:13:24 openstackgerrit Michael Still proposed openstack/nova master: Move final bridge commands to privsep. https://review.openstack.org/639580
10:13:24 openstackgerrit Michael Still proposed openstack/nova master: Move setting of device trust to privsep. https://review.openstack.org/639283
10:13:25 openstackgerrit Michael Still proposed openstack/nova master: Cleanup the _execute shim in nova/network. https://review.openstack.org/639581
10:30:13 sean-k-mooney stephenfin: bauzas care to hit this https://review.openstack.org/#/c/622972/16
10:49:58 stephenfin done
10:50:34 sean-k-mooney :) thank you
10:54:11 NewBruce sean-k-mooney - DM’ing you with an update on the issue re: port binding issue whens live migrating RDO -> OSA
10:54:46 sean-k-mooney NewBruce: oh cool so you made some progress root causing the interaction issues
11:05:31 NewBruce so, i filled that with a bunch of extra debugs - if im migrating from compute28 -> compute29 (both OSA and successful)
11:05:32 NewBruce 2019-02-12 13:09:33.458 59488 INFO nova.network.neutronv2.api [req-8e14a273-fc18-461e-a2de-b8bad835dcd8 a3bee416cf67420995855d602d2bccd3 a564613210ee43708b8a7fc6274ebd63 - default default] [BRUCE](A-8-2): _setup_migration_port_profile: host_id = cc-compute29-kna1
11:12:15 jaypipes stephenfin: you around? I'm having a hell of time trying to run tests in nova now that tox requirements have changed.
11:12:38 jaypipes ERROR: tox version is 2.5, required is at least 3.1.1
11:12:38 jaypipes stephenfin: nothing I seem to do will get me out of the hell that is this: [jaypipes@uberbox nova]$ tox -efunctional
11:12:57 jaypipes I've sudo -H pip install -U pip tox, I've apt purge'd python-tox
11:13:12 jaypipes and still /usr/local/bin/tox persists and is pointing somewhere old
11:13:27 jaypipes and I have no idea why this crap has to just suddenly break :)
11:18:05 jaypipes stephenfin: cdent has graciously helped me. needed to `sudo -H pip uninstall tox && sudo -H pip install tox && reload bash...`
11:32:08 sean-k-mooney jaypipes: ya i was just going to say that you proably need to uninstall first
11:32:46 sean-k-mooney i had the same issue more or less to as i started with tox form my package mangaer and need to swap to pip later
12:03:07 stephenfin jaypipes: Good to hear you got sorted. FWIW, the current guidelines suggest not using 'sudo pip install' since it's way too likely to break distro packages. You need to prepend (or append, I don't recall the order) '~/.local/bin' to PATH then 'pip install --local'
12:03:57 stephenfin jaypipes: fwiw, I was reluctant to merge the patches that required tox 3.1.1+ but I think we decided the benefits outweighed the costs
12:08:46 sean-k-mooney that said it depend on what the thing is that im installing
12:08:58 sean-k-mooney stephenfin: can i get you input on http://logs.openstack.org/33/647733/2/check/nova-tox-functional/72500de/testr_results.html.gz
12:09:40 sean-k-mooney our functional notification tests are asserting behavior of the payloads as json dicts
12:10:16 sean-k-mooney 1st this feals wrong at first glacne to call these fucntional test but i have not looked at the code to see how they work so ill put that aside for a minut
12:11:23 sean-k-mooney should i a.) update these to use the new version of the object b.) convert them to do assertion using the objects or c.) force them to use the old version somehow?
12:13:40 sean-k-mooney by the way these are semi valid failures
12:15:33 sean-k-mooney as i am updating the allowed values in a field in the image metadata object but unlike everywhere else in nova we appearend version bump composed object in this specific case.
12:15:36 sean-k-mooney https://review.openstack.org/#/c/647733/
12:21:23 jaypipes thx stephenfin
12:26:14 sean-k-mooney jaypipes: by the way i dont know if you have time to revew the last two patches in the sriov migrtion blueprint https://review.openstack.org/#/q/topic:bp/libvirt-neutron-sriov-livemigration+(status:open)
12:26:39 jaypipes sean-k-mooney: hmm, my favorite topics, merged into one.
12:26:48 sean-k-mooney it would be nice to get that squared away before the ptg
12:27:00 sean-k-mooney haha all that is missing is numa
12:28:26 jaypipes and FPGAs.
12:29:41 sean-k-mooney live migration with numa affined fpga exposed by sriov passthough... at some point it just gets easier to move the damb server
12:30:24 sean-k-mooney it is the one of the up sides of ironic
12:30:35 artom Or you know, register a new corporation and buy them new machines.
12:32:17 sean-k-mooney im just going to pop out to grab lunch so ill brb
12:37:11 openstackgerrit Artem Vasilyev proposed openstack/nova master: systemd detection result caching nit fixes https://review.openstack.org/649229
12:42:14 stephenfin sean-k-mooney: They look like valid errors to me. I'm guessing we should update the notification samples but gibi_off or mriedem are probably the people to ask
12:58:55 mriedem cdent: question inline https://review.openstack.org/#/c/649068/
13:14:08 kashyap Can anyone remind me again, has upstream Git master opened for Train, yet? (/me is dazed after PTO)
13:14:50 sean-k-mooney yes
13:14:55 sean-k-mooney like a week or two ago
13:15:03 kashyap Thanks
13:15:09 sean-k-mooney it opens after RC1 but we dont then to merge big thing for a few weeks after
13:17:29 gibi_off sean-k-mooney: for notifications we only emit the latest version only
13:17:41 gibi_off sean-k-mooney: so please update the samepl file according to the change in the object
13:18:00 gibi_off sean-k-mooney: the tests are functional ast they call the nova API and assert if notifications are received
13:18:52 sean-k-mooney gibi_off: ok but would they not avoid this issue if they parsed the notificaion into a python object and then checked that
13:19:16 sean-k-mooney gibi_off: also if your off today your doing it wrong :) but thanks ill update it
13:19:41 kashyap efried: When you get a moment, since Train has forked, might want to put this through: https://review.openstack.org/#/c/641981/
13:20:24 efried kashyap: done, thanks for the reminder.
13:21:08 gibi_off sean-k-mooney: the parsed object would have different version
13:21:42 gibi_off sean-k-mooney: also nova cannot assume how the notifications are parsed by the consumer so we assert the json we emmit
13:21:51 sean-k-mooney ah good points
13:22:08 kashyap efried: Tack!

Earlier   Later