Earlier  
Posted Nick Remark
#openstack-nova - 2019-04-01
20:41:36 openstack bug 1815692 in OpenStack Compute (nova) "minimum nova-compute service version is not cached in nova-api when running under wsgi" [Low,Triaged] https://launchpad.net/bugs/1815692
20:42:12 mriedem making nova.compute.api.API or nova.compute.rpcapi.ComputeAPI a singleton might help
20:42:12 efried is making the thing a singleton an option?
20:42:27 efried Is there any evidence that that's actually a problem though?
20:42:31 mnaser melwitt: https://bugs.launchpad.net/nova/+bug/1822676
20:42:32 openstack Launchpad bug 1822676 in OpenStack Compute (nova) "novnc no longer sets token inside cookie" [Undecided,New]
20:42:38 melwitt mnaser: you know, while I was looking at the websockify source, I was thinking maybe in code we could append to our self.path earlier in the call path. I can try something out
20:42:42 efried the devstack log just says n-api doesn't start.
20:42:51 efried I guess that means "within a certain amount of time"
20:42:53 melwitt mnaser: thanks for the bug report
20:42:55 mriedem efried: it's a timeout
20:42:58 mnaser melwitt: all yours :) I don't think I can take more time on this :X
20:43:04 mnaser I will "work-around" it in osa
20:43:12 melwitt mnaser: yeah, I'll try this out and let you know
20:43:36 mriedem efried: the non-singleton nature with locks can definitely cause slowness ala https://review.openstack.org/#/c/623246/
20:43:56 melwitt mnaser: if what I'm thinking doesn't end up working, I can ask the novnc folks if they can revert the nova part
21:00:49 openstackgerrit Eric Fried proposed openstack/nova master: Hacking N362: Don't abbrev/alias privsep import https://review.openstack.org/649188
21:02:59 efried this f'in thing is never going to merge. Now it's failed py37
21:15:11 mriedem dansmith: you know how on nova-api startup we check for the minimum nova-compute service version in order to set the rpc pin if [upgrade_levels]/compute=auto https://github.com/openstack/nova/blob/master/nova/compute/rpcapi.py#L408 ?
21:16:09 mriedem the comment above that says we don't cache it because "we will get a better answer next time." - but next time would have to be on restart of the service right? because we only call _determine_version_cap once in order to construct the ClientRouter
21:18:11 openstackgerrit Michael Still proposed openstack/nova master: Style corrections for privsep usage. https://review.openstack.org/648615
21:18:12 openstackgerrit Michael Still proposed openstack/nova master: Improve test coverage of nova.privsep.fs. https://review.openstack.org/648602
21:18:12 openstackgerrit Michael Still proposed openstack/nova master: Improve test coverage of nova.privsep.path. https://review.openstack.org/648601
21:18:13 openstackgerrit Michael Still proposed openstack/nova master: Add test coverage for nova.privsep.libvirt. https://review.openstack.org/648616
21:18:13 openstackgerrit Michael Still proposed openstack/nova master: Improve test coverage of nova.privsep.fs, continued. https://review.openstack.org/648603
21:18:14 openstackgerrit Michael Still proposed openstack/nova master: Remove unused FP device creation and deletion methods. https://review.openstack.org/635433
21:18:14 openstackgerrit Michael Still proposed openstack/nova master: Privsepify ipv4 forwarding enablement. https://review.openstack.org/635431
21:18:15 openstackgerrit Michael Still proposed openstack/nova master: Move adding vlans to interfaces to privsep. https://review.openstack.org/635436
21:18:15 openstackgerrit Michael Still proposed openstack/nova master: Privsep the ebtables modification code. https://review.openstack.org/635435
21:18:16 openstackgerrit Michael Still proposed openstack/nova master: Move dnsmasq restarts to privsep. https://review.openstack.org/639280
21:18:16 openstackgerrit Michael Still proposed openstack/nova master: Move iptables rule fetching and setting to privsep. https://review.openstack.org/636508
21:18:17 openstackgerrit Michael Still proposed openstack/nova master: Move router advertisement daemon restarts to privsep. https://review.openstack.org/639281
21:18:18 openstackgerrit Michael Still proposed openstack/nova master: Move final bridge commands to privsep. https://review.openstack.org/639580
21:18:18 openstackgerrit Michael Still proposed openstack/nova master: Move setting of device trust to privsep. https://review.openstack.org/639283
21:18:18 openstackgerrit Michael Still proposed openstack/nova master: Move calls to ovs-vsctl to privsep. https://review.openstack.org/639282
21:18:19 openstackgerrit Michael Still proposed openstack/nova master: We no longer need rootwrap. https://review.openstack.org/554438
21:18:19 openstackgerrit Michael Still proposed openstack/nova master: Cleanup the _execute shim in nova/network. https://review.openstack.org/639581
21:18:20 openstackgerrit Michael Still proposed openstack/nova master: Cleanup no longer required filters and add a release note. https://review.openstack.org/639826
21:47:48 openstackgerrit Matt Riedemann proposed openstack/nova master: Make nova.compute.rpcapi.ComputeAPI.router a singleton https://review.openstack.org/649197
22:17:07 openstackgerrit Matt Riedemann proposed openstack/nova master: Improve CinderFixtureNewAttachFlow https://review.openstack.org/639382
22:17:07 openstackgerrit Matt Riedemann proposed openstack/nova master: Fix ProviderUsageBaseTestCase._run_periodics for multi-cell https://review.openstack.org/641179
22:17:08 openstackgerrit Matt Riedemann proposed openstack/nova master: Add functional recreate test for bug 1818914 https://review.openstack.org/641521
22:17:09 openstackgerrit Matt Riedemann proposed openstack/nova master: Add Migration.cross_cell_move and get_by_uuid https://review.openstack.org/614012
22:17:09 openstackgerrit Matt Riedemann proposed openstack/nova master: Update usage in RT.drop_move_claim during confirm resize https://review.openstack.org/641806
22:17:09 openstackgerrit Matt Riedemann proposed openstack/nova master: Remove unused context parameter from RT._get_instance_type https://review.openstack.org/641792
22:17:09 openstack bug 1818914 in OpenStack Compute (nova) "Hypervisor resource usage on source still shows old flavor usage after resize confirm until update_available_resource periodic runs" [Low,In progress] https://launchpad.net/bugs/1818914 - Assigned to Matt Riedemann (mriedem)
22:17:10 openstackgerrit Matt Riedemann proposed openstack/nova master: Add Instance.hidden field https://review.openstack.org/631123
22:17:10 openstackgerrit Matt Riedemann proposed openstack/nova master: Add InstanceAction/Event create() method https://review.openstack.org/614036
22:17:11 openstackgerrit Matt Riedemann proposed openstack/nova master: Add CrossCellMigrationTask https://review.openstack.org/631581
22:17:11 openstackgerrit Matt Riedemann proposed openstack/nova master: Add TargetDBSetupTask https://review.openstack.org/627892
22:17:12 openstackgerrit Matt Riedemann proposed openstack/nova master: Add can_connect_volume() compute driver method https://review.openstack.org/621313
22:17:12 openstackgerrit Matt Riedemann proposed openstack/nova master: Execute TargetDBSetupTask https://review.openstack.org/633853
22:17:13 openstackgerrit Matt Riedemann proposed openstack/nova master: Add PrepResizeAtDestTask https://review.openstack.org/627890
22:17:13 openstackgerrit Matt Riedemann proposed openstack/nova master: Add prep_snapshot_based_resize_at_dest compute method https://review.openstack.org/633293
22:17:14 openstackgerrit Matt Riedemann proposed openstack/nova master: Add nova.compute.utils.delete_image https://review.openstack.org/637605
22:17:14 openstackgerrit Matt Riedemann proposed openstack/nova master: Add prep_snapshot_based_resize_at_source compute method https://review.openstack.org/634832
22:17:15 openstackgerrit Matt Riedemann proposed openstack/nova master: Refactor ComputeManager.remove_volume_connection https://review.openstack.org/642183
22:17:15 openstackgerrit Matt Riedemann proposed openstack/nova master: Add PrepResizeAtSourceTask https://review.openstack.org/627891
22:17:27 openstackgerrit Matt Riedemann proposed openstack/nova master: Confirm cross-cell resize while deleting a server https://review.openstack.org/638268
22:17:27 openstackgerrit Matt Riedemann proposed openstack/nova master: Revert cross-cell resize from the API https://review.openstack.org/638048
22:17:28 openstackgerrit Matt Riedemann proposed openstack/nova master: Add cross-cell resize policy rule and enable in API https://review.openstack.org/638269
22:17:28 openstackgerrit Matt Riedemann proposed openstack/nova master: Add CrossCellWeigher https://review.openstack.org/614353
22:34:24 openstackgerrit Eric Fried proposed openstack/nova master: Mock time.sleep() in unit tests https://review.openstack.org/648762
#openstack-nova - 2019-04-02
00:28:23 mnaser melwitt: https://review.openstack.org/#/c/649204/2 I don't think I have time to actually get this to merge, but I tried working on it and I think it works.. so threw it up there if you wanna get it merged or if someone else wants to pick it up
00:29:47 melwitt mnaser: I don't think that helps with the brokenness from novnc though
00:30:09 mnaser melwitt: oh yeah it doesn't, but I did the shuffling so I figured if someone was interested in making that code base a bit neater.. :P
00:30:10 melwitt self.path won't have the token in it by the time it gets to the plugin
00:33:41 melwitt mnaser: ok. I did similar locally to come to the same conclusion. the only thing I notice offhand is I think you removed the scheme validation, at best you'd have to have it run in a different order than before (currently it's scheme, token, the rest). with the plugin it would have to be token, scheme, the rest
02:13:08 openstackgerrit Brin Zhang proposed openstack/nova-specs master: Specifying az when restore shelved server https://review.openstack.org/624689
02:53:35 openstackgerrit Takashi NATSUME proposed openstack/nova master: WIP: Add a live migration regression test https://review.openstack.org/641200
03:19:42 openstackgerrit Seyeong Kim proposed openstack/nova stable/rocky: Share snapshot image membership with instance owner https://review.openstack.org/643853
05:12:28 openstackgerrit Takashi NATSUME proposed openstack/nova master: Add a live migration regression test https://review.openstack.org/641200
05:23:40 openstackgerrit Seyeong Kim proposed openstack/nova stable/rocky: Share snapshot image membership with instance owner https://review.openstack.org/643853
05:34:54 openstackgerrit Seyeong Kim proposed openstack/nova stable/rocky: Share snapshot image membership with instance owner https://review.openstack.org/643853
05:59:54 openstackgerrit Brin Zhang proposed openstack/nova-specs master: Specifying az when restore shelved server https://review.openstack.org/624689
06:20:12 openstackgerrit Artem Vasilyev proposed openstack/nova master: systemd detection result caching nit fixes https://review.openstack.org/649229
06:22:00 kaisers mdbooth: Yep, saw that. Will follow up
06:24:29 openstackgerrit Artem Vasilyev proposed openstack/nova master: systemd detection result caching nit fixes https://review.openstack.org/649229
07:21:37 openstackgerrit Takashi NATSUME proposed openstack/nova master: Fix a deprecation warning https://review.openstack.org/649234
08:15:40 openstackgerrit Merged openstack/nova master: Pass --nic when creating servers in evacuate integration test script https://review.openstack.org/649036
08:46:11 openstackgerrit Michael Still proposed openstack/nova master: Remove fake_libvirt_utils from connection tests. https://review.openstack.org/642557
08:46:12 openstackgerrit Michael Still proposed openstack/nova master: Make privsep.chown mocking for libvirt snapshot tests less magic. https://review.openstack.org/642134
08:46:12 openstackgerrit Michael Still proposed openstack/nova master: Remove fake_libvirt_utils from snapshot tests. https://review.openstack.org/642558
08:46:13 openstackgerrit Michael Still proposed openstack/nova master: Remove fake_libvirt_utils from libvirt imagebackend tests. https://review.openstack.org/643895
08:46:13 openstackgerrit Michael Still proposed openstack/nova master: Remove fake_libvirt_utils from virt driver tests. https://review.openstack.org/643894
08:46:14 openstackgerrit Michael Still proposed openstack/nova master: Remove fake_libvirt_utils users in functional testing. https://review.openstack.org/644793
08:46:14 openstackgerrit Michael Still proposed openstack/nova master: Remove remaining vestiges of fake_libvirt_utils from unit tests. https://review.openstack.org/643896
08:46:15 openstackgerrit Michael Still proposed openstack/nova master: Remove write_to_file. https://review.openstack.org/645087
08:46:15 openstackgerrit Michael Still proposed openstack/nova master: Remove usused umask argument to virt.libvirt.utils.write_to_file https://review.openstack.org/645086
08:57:40 openstackgerrit Yongli He proposed openstack/nova master: Clean up orphan instances https://review.openstack.org/627765
08:57:40 openstackgerrit Yongli He proposed openstack/nova master: Clean up orphan instances virt driver https://review.openstack.org/648912
09:31:08 openstackgerrit Seyeong Kim proposed openstack/nova stable/rocky: Share snapshot image membership with instance owner https://review.openstack.org/643853
09:36:40 openstackgerrit Kashyap Chamarthy proposed openstack/nova-specs master: Re-propose the spec to allow specifying a list of CPU models https://review.openstack.org/642030
10:13:16 openstackgerrit Michael Still proposed openstack/nova master: Style corrections for privsep usage. https://review.openstack.org/648615
10:13:17 openstackgerrit Michael Still proposed openstack/nova master: Improve test coverage of nova.privsep.path. https://review.openstack.org/648601
10:13:17 openstackgerrit Michael Still proposed openstack/nova master: Hacking N362: Don't abbrev/alias privsep import https://review.openstack.org/649190
10:13:18 openstackgerrit Michael Still proposed openstack/nova master: Improve test coverage of nova.privsep.fs, continued. https://review.openstack.org/648603
10:13:18 openstackgerrit Michael Still proposed openstack/nova master: Improve test coverage of nova.privsep.fs. https://review.openstack.org/648602
10:13:19 openstackgerrit Michael Still proposed openstack/nova master: Add test coverage for nova.privsep.qemu. https://review.openstack.org/649191
10:13:19 openstackgerrit Michael Still proposed openstack/nova master: Add test coverage for nova.privsep.libvirt. https://review.openstack.org/648616

Earlier   Later