| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2019-03-29 | |||
| 13:18:07 | tssurya | stephenfin: thanks for the fix ! | |
| 13:20:09 | sean-k-mooney | fried_rice: yes | |
| 13:21:05 | fried_rice | sean-k-mooney: Then yes please, let's get a bp on the docket | |
| 13:21:32 | sean-k-mooney | fried_rice: put simplely if we want to ensure that networking is configured correclty for all instance lifecycle operations and not just spawn/power on then we need to wait for the netwrok events in several placees in the code | |
| 13:21:52 | fried_rice | several places in the nova code | |
| 13:21:55 | sean-k-mooney | fried_rice: we cant today simpley because we dont know what neutron backend is being used and if it will send them | |
| 13:22:04 | sean-k-mooney | fried_rice: its all in the virt dirvres | |
| 13:22:34 | fried_rice | interesting problem. | |
| 13:23:10 | sean-k-mooney | interesting proablem i have been trinig to fix for 4 years... but yes :) | |
| 13:24:15 | sean-k-mooney | fried_rice: we have some comments like https://github.com/openstack/nova/blob/master/nova/virt/libvirt/driver.py#L2846-L2855 in the code where we know we would like to wait but cant | |
| 13:24:51 | sean-k-mooney | but https://bugs.launchpad.net/nova/+bug/1813789 is also jsut another sideffect of the same large problem | |
| 13:24:53 | openstack | Launchpad bug 1813789 in OpenStack Compute (nova) "Evacuate test intermittently fails with network-vif-plugged timeout exception" [Medium,In progress] - Assigned to Artom Lifshitz (notartom) | |
| 13:35:38 | openstackgerrit | Theodoros Tsioutsias proposed openstack/nova-specs master: Enable rebuild for instances in cell0 https://review.openstack.org/648686 | |
| 13:36:15 | openstackgerrit | Theodoros Tsioutsias proposed openstack/nova-specs master: Add PENDING vm state https://review.openstack.org/648687 | |
| 13:37:04 | alex_xu | gibi: yea, I'm ok with another fix | |
| 13:38:12 | gibi | alex_xu: cool, I pushed the test fix below the actual bugfix | |
| 13:38:42 | alex_xu | gibi: thanks, checking now | |
| 13:38:54 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Delete allocations even if _confirm_resize raises https://review.openstack.org/647566 | |
| 13:38:55 | openstackgerrit | Matt Riedemann proposed openstack/nova master: api-ref: add more details to confirmResize troubleshooting https://review.openstack.org/647741 | |
| 13:39:25 | gibi | stephenfin: did you missed a depends-on in https://review.openstack.org/#/c/648670/ ? | |
| 13:39:36 | gibi | stephenfin: the doc job fails | |
| 13:41:13 | openstackgerrit | Matt Riedemann proposed openstack/nova stable/stein: Temporarily mutate migration object in finish_revert_resize https://review.openstack.org/648688 | |
| 13:44:00 | stephenfin | gibi: Nope, just saw that. It's _another_ dependency that's borked (yasfb) | |
| 13:44:06 | stephenfin | working on a fix for that now | |
| 13:45:38 | gibi | stephenfin: ack | |
| 13:48:25 | openstackgerrit | Matt Riedemann proposed openstack/nova stable/rocky: Temporarily mutate migration object in finish_revert_resize https://review.openstack.org/648691 | |
| 13:54:54 | bauzas | finucannot: the change is broken, right? https://review.openstack.org/#/c/648670/1 | |
| 13:55:02 | bauzas | oh, nevermind, haven't seen above | |
| 13:55:05 | finucannot | bauzas: See above :) | |
| 13:56:37 | bauzas | finucannot: yeah I'm tired | |
| 13:57:16 | bauzas | and I'm torn in between using PapaOurs or bauwser for my Friday nick | |
| 13:57:24 | bauzas | people should vote | |
| 13:57:53 | artom | Because of the implication | |
| 14:06:09 | bauzas | temka: DaddyBear has many more implications than PapaOurs | |
| 14:06:22 | temka | bauzas, quite | |
| 14:07:29 | bauzas | hum, DaddyBear isn't registered | |
| 14:08:13 | temka | They tend to be on a different sort of register | |
| 14:08:16 | temka | (I'm so sorry) | |
| 14:09:59 | DaddyBear | there, registered | |
| 14:10:12 | DaddyBear | but I'm still the real PapaOurs | |
| 14:18:37 | Zara | had to check what channel I was in for a sec, there | |
| 14:18:48 | dansmith | heh | |
| 14:18:56 | dansmith | "different sort of register" .. that was a good one | |
| 14:19:10 | dansmith | I normally don't like to encourage temka but that one was worth it | |
| 14:19:14 | cdent | temka++ | |
| 14:19:29 | temka | I said I was sorry! | |
| 14:34:38 | edleafe | temka: I'm just glad I wasn't the only one who thought that! | |
| 14:34:56 | temka | \o/ | |
| 14:49:03 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Handle placement error during re-schedule https://review.openstack.org/639608 | |
| 14:57:52 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Only call _fill_provider_mapping if claim succeeds https://review.openstack.org/648676 | |
| 15:06:42 | openstackgerrit | Surya Seetharaman proposed openstack/nova-specs master: Support adding the reason behind a server lock https://review.openstack.org/638629 | |
| 15:11:39 | openstackgerrit | Eric Fried proposed openstack/nova master: Poison sleep() in tests https://review.openstack.org/643763 | |
| 15:16:56 | openstackgerrit | Stephen Finucane proposed openstack/nova-specs master: docs: Resolve issues with Sphinx 2.0 https://review.openstack.org/648670 | |
| 15:18:01 | finucannot | PapaOurs, gibi, gmann: This should fix the nova-specs build issues for good now (I'd to fix an issue with yasfb too) https://review.openstack.org/#/c/648670/ | |
| 15:18:06 | openstackgerrit | Magnus Bergman proposed openstack/nova master: Adding tests to demonstrate bug #1821824 https://review.openstack.org/647957 | |
| 15:18:07 | openstackgerrit | Magnus Bergman proposed openstack/nova master: Fix bug preventing forbidden traits from working https://review.openstack.org/648653 | |
| 15:18:07 | openstack | bug 1821824 in OpenStack Compute (nova) "Forbidden traits in flavor properties don't work" [Undecided,In progress] https://launchpad.net/bugs/1821824 - Assigned to Magnus Bergman (magnusbe) | |
| 15:18:17 | gibi | finucannot: ack | |
| 15:19:22 | gmann | finucannot: thanks | |
| 15:20:52 | trident | gibi: There. Thanks for bearing with me. This is one of my first non-trivial contributions - and my first to nova. | |
| 15:21:34 | gibi | trident: thanks for putting the effort to fix it properly | |
| 15:21:39 | gibi | trident: I will look at it shortly | |
| 15:21:47 | gibi | trident: and welcome in nova! | |
| 15:26:34 | trident | gibi: Thanks! | |
| 15:29:43 | gibi | fried_rice: trident put together the reproduction and the bugfix as well. I think it is good to go now. So if you have time: https://review.openstack.org/#/c/648653 | |
| 15:36:17 | openstackgerrit | Stephen Finucane proposed openstack/nova-specs master: docs: Resolve issues with Sphinx 2.0 https://review.openstack.org/648670 | |
| 15:43:02 | fried_rice | gibi, trident: on it | |
| 15:46:02 | finucannot | PapaOurs: CI was happy with https://review.openstack.org/#/c/648670/. I fixed your nit if you want to rehit that | |
| 15:46:12 | PapaOurs | finucannot: yup, just sax | |
| 15:46:13 | PapaOurs | sa | |
| 15:46:17 | PapaOurs | graaah | |
| 15:46:19 | PapaOurs | saw* | |
| 16:02:24 | openstackgerrit | Rodolfo Alonso Hernandez proposed openstack/os-vif master: Refactor functional base test classes https://review.openstack.org/643101 | |
| 16:05:39 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: nova-manage: heal port allocations https://review.openstack.org/637955 | |
| 16:07:16 | fried_rice | gibi, trident: responded. Do you agree? | |
| 16:08:38 | gibi | fried_rice: do you mean adding another test where we see that the boot succeeds to a host that has the trait? | |
| 16:10:16 | gibi | fried_rice: I have to run. I'm not against adding that extra test, just add a note in the test that it can produce false positives | |
| 16:10:47 | fried_rice | gibi_off: sure, that wfm | |
| 16:10:50 | fried_rice | trident: ^^ | |
| 16:11:33 | fried_rice | gibi_off, trident: In that case, I suggest it would be best to do both paths in a single test method. | |
| 16:16:51 | openstackgerrit | Eric Fried proposed openstack/nova master: Poison sleep() in tests https://review.openstack.org/643763 | |
| 16:23:06 | openstackgerrit | Eric Fried proposed openstack/nova master: Poison sleep() in tests https://review.openstack.org/643763 | |
| 16:26:40 | openstackgerrit | Merged openstack/nova master: Fix exception type in test_boot_reschedule_fill_provider_mapping_raises https://review.openstack.org/648651 | |
| 16:27:16 | openstackgerrit | Merged openstack/nova-specs master: docs: Resolve issues with Sphinx 2.0 https://review.openstack.org/648670 | |
| 16:33:42 | dansmith | fried_rice: how much time does that actually save? | |
| 16:33:42 | trident | fried_rice: Thanks. Good points. Will take care of it during the weekend or worst case on monday. | |
| 16:33:51 | dansmith | (not sleeping) | |
| 16:37:28 | fried_rice | dansmith: In the gate, I don't know, probably not significant, thirty seconds at best is my guess. That would only be for the unit test suites, which run fast anyway. But IIUC each suite runs on its own node, so getting done some amount of time earlier would free that node up for other runs. | |
| 16:37:34 | fried_rice | dansmith: It's really for local tox | |
| 16:38:08 | dansmith | it saves you a lot locally? | |
| 16:39:05 | fried_rice | "a lot", meh. If I'm working on a test or a whole module or class or whatever, and it's got 7-12s worth of sleeps (which is typical for the cases I fixed) and I have to run it 10x while I'm developing whatever, it can save me minutes. | |
| 16:39:08 | dansmith | the gate workers are only 4T IIRC, so I would expect it to save you less locally | |
| 16:39:47 | dansmith | and what are those sleeps doing? polling a fake cinder or something? | |
| 16:39:56 | fried_rice | mostly retries in the actual code. | |
| 16:40:05 | fried_rice | the functional tests really need to sleep | |
| 16:40:11 | fried_rice | that's like wait_for_state_change stuff | |
| 16:40:19 | fried_rice | it's the sleeps in real code that I'm trying to poison | |
| 16:40:24 | dansmith | right, I mean what are the real code sleeps doing | |
| 16:40:32 | fried_rice | oh, mostly sleeps between retries | |
| 16:40:57 | fried_rice | so a unit test that tests retries is eating all that sleep time, when it really doesn't need that; it can just spin the retries immediately. | |