Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2019-03-22
19:52:04 mriedem yeah maybe
19:52:08 mriedem i've not followed the ML thread
19:52:11 dansmith mdbooth also said it was fine for train
19:53:01 fried_rice dansmith: At this point I'm waiting for you to re+2
19:53:19 fried_rice since you had done it before
19:53:22 melwitt ok... I was just thinking if it's a regression it would be nice to fix it for stein ppl but if most think it should be train-only, then I'll go with the consensus
19:53:23 dansmith fried_rice: I haven't reviewed it in its current form and you said you'd ping me if you needed something
19:53:30 fried_rice okay. ping.
19:53:40 dansmith fried_rice: I'm not super comfortable with it at this point (I reviewed it initially a while ago)
19:53:57 dansmith so I say let melwitt do it if she thinks it's a good idea
19:54:00 melwitt cool gmann, thanks
19:54:24 mriedem i have to spend my requisite 2 hours per month to look at fixing https://launchpad.net/bugs/1790204 before writing up my monthly internal report...
19:54:25 openstack Launchpad bug 1790204 in OpenStack Compute (nova) "Allocations are "doubled up" on same host resize even though there is only 1 server on the host" [High,Triaged]
19:54:35 dansmith ten revisons ago and a week prior
19:55:30 mriedem honestly my +2 on that is mostly, (1) it's not in rc1, (2) it's eventlet and i'm not ever comfortable with eventlet stuff, (3) lots of people have been working on it and say it fixes the problem in a reproduction system so (4) i'm going to trust mdbooth on it
19:56:12 fried_rice yes, and I'm willing to do the same, but I wanted to give dansmith the opportunity to look at it again because he seemed to understand it (10 patch sets and a week ago).
19:56:15 melwitt yeah, I was going to say, that's the best my +2 could be too, for the same reasons
19:56:44 melwitt eventlet monkey patch ordering is not really my forte
19:56:48 dansmith fried_rice: don't wait on me
19:56:55 fried_rice okay.
19:57:32 fried_rice EmilienM: +A
19:58:12 EmilienM fried_rice: thank you
20:00:44 mriedem i'm still not really comfortable with pushing this into an rc2
20:01:18 mriedem i'd be much cooler with landing it in train, and then if non-OSP people come along after stein GA saying they have the same issue (maybe zigo - he tends to tickle weird stuff like this), then we say ok let's backport and do a quick 19.0.1 on stable
20:02:09 mriedem or thode or coreycb
20:02:19 mriedem you know, other distro gremlins :)
20:02:33 mriedem i say that with the utmost affection
20:14:45 coreycb mriedem: we'll be ramping up our testing including SSL in the next couple of weeks. so we haven't hit that yet.
20:17:36 mriedem coreycb: ack cool
20:18:08 coreycb mriedem: will keep you posted. we're py3 only at this point so i imagine that we'll hit it as well. grrr eventlet.
20:21:12 mriedem py3 what?
20:21:14 mriedem 3.5?
20:21:20 mriedem or bionic 3.6?
20:21:28 mriedem oh you mean just py3 support
20:21:41 mriedem yeah apparently osp didn't hit issues with py3.5
20:22:59 coreycb py3.6 for bionic-stein. and py3.7 too but that is for disco-stein so not a common target.
20:41:52 openstackgerrit Merged openstack/nova master: Fix return param docstring in check_can_live_migrate* methods https://review.openstack.org/645610
21:35:07 mriedem so i guess if your cloud supports strict affinity groups + resize, you *have* to enable allow_resize_to_same_host yeah? otherwise you could just never resize any servers in an affinity group
21:35:08 mriedem which is fun
21:35:40 mriedem seems allow_resize_to_same_host should really just be a weigher rather than a true/false config
22:09:32 openstackgerrit Merged openstack/nova stable/queens: Fix resource tracker updates during instance evacuation https://review.openstack.org/643219
22:14:40 mriedem dansmith: i don't suppose you remember off the top of your head why we used force_hosts/nodes for the rebuild to same host run through the scheduler where we still want to use the filters, iow, why didn't we use requested_destination?
22:14:55 mriedem the former skips filters, the later restricts to a host but runs filters
22:15:21 mriedem i think we could have avoided this https://github.com/openstack/nova/blob/master/nova/scheduler/host_manager.py#L584
22:15:43 mriedem i know that was all a crazy mess at the time and we were just trying to get something working
22:28:16 dansmith mriedem: because we have to run the numa filter right?
22:28:55 dansmith I mean, I barely remember this, but I remember we needed to run the numa filter even though we knew where it was going to validate that the new image still works with the requested numa topology on the host or whatever
22:29:09 mriedem yeah that's not my point, i'm just wondering why we used force_hosts over requested_destination
22:29:17 mriedem requested_destination will still run the filters
22:29:30 mriedem and avoid needing to look for that secret hint here https://github.com/openstack/nova/blob/master/nova/scheduler/host_manager.py#L584
22:29:38 dansmith oh I thought you said one doesn't run the filters
22:29:45 mriedem force_hosts doesn't normally
22:29:52 mriedem which is why that condition had to be added
22:29:57 dansmith [15:14:55] <mriedem>the former skips filters, the later restricts to a host but runs filters
22:29:59 mriedem we could have just avoided that by using requested_destination
22:30:00 dansmith oh I see
22:30:01 dansmith then I dunno
22:30:03 dansmith :D
22:30:10 mriedem just rushing i'm guessing
22:30:14 dansmith could be
22:30:30 mriedem i'm basically needing to do some similar hackery for resize to same host and got digging into that code is all
22:30:34 dansmith we did that in dublin under threat of snowpocalypse (i.e. 1" of snow)
22:31:14 openstackgerrit Merged openstack/nova master: Eventlet monkey patching should be as early as possible https://review.openstack.org/626952
22:37:06 openstackgerrit melanie witt proposed openstack/nova-specs master: Move Stein implemented specs https://review.openstack.org/645749
22:48:54 openstackgerrit Matt Riedemann proposed openstack/nova master: WIP: Alternative fix to bug 1790204 (does not work yet) https://review.openstack.org/645954
22:48:55 openstack bug 1790204 in OpenStack Compute (nova) "Allocations are "doubled up" on same host resize even though there is only 1 server on the host" [High,Triaged] https://launchpad.net/bugs/1790204
22:48:57 mriedem fried_rice: i tried my alternative and it just blasted me right in my stupid face ^
22:49:17 mriedem dansmith: oh yeah teehee https://review.openstack.org/#/c/645954/1/nova/compute/api.py
22:54:16 mriedem i think it's time for me to start working on a project where i'm just doing application development on top of something else where the shit can roll downhill rather than breaking my head working on essentially an operating system
#openstack-nova - 2019-03-23
02:50:26 openstackgerrit Merged openstack/nova master: Stop running tempest-multinode-full https://review.openstack.org/645456
03:50:56 openstackgerrit melanie witt proposed openstack/nova-specs master: Move Stein implemented specs https://review.openstack.org/645749
10:01:18 openstackgerrit Chris Dent proposed openstack/nova master: Delete the placement code https://review.openstack.org/618215
11:09:30 openstackgerrit Chris Dent proposed openstack/nova master: Remove last use of rc_fields https://review.openstack.org/645991
11:09:30 openstackgerrit Chris Dent proposed openstack/nova master: Delete the placement code https://review.openstack.org/618215
11:44:45 openstackgerrit Merged openstack/nova-specs master: Move Stein implemented specs https://review.openstack.org/645749
11:48:57 openstackgerrit Chris Dent proposed openstack/nova master: Delete the placement code https://review.openstack.org/618215
16:05:31 openstackgerrit Matt Riedemann proposed openstack/nova master: Add functional regression test for bug 1669054 https://review.openstack.org/646006
16:05:33 openstack bug 1669054 in OpenStack Compute (nova) "RequestSpec.ignore_hosts from resize is reused in subsequent evacuate" [Medium,Confirmed] https://launchpad.net/bugs/1669054
17:56:39 openstackgerrit Chris Dent proposed openstack/nova master: Delete the placement code https://review.openstack.org/618215
#openstack-nova - 2019-03-24
04:12:18 openstackgerrit Tetsuro Nakamura proposed openstack/nova-specs master: Spec: Use in_tree getting allocation candidates https://review.openstack.org/646029
09:28:39 openstackgerrit Tetsuro Nakamura proposed openstack/nova-specs master: Spec: Use in_tree getting allocation candidates https://review.openstack.org/646029
10:29:04 openstackgerrit Tetsuro Nakamura proposed openstack/nova-specs master: Spec: Use in_tree getting allocation candidates https://review.openstack.org/646029
11:36:54 ivve hey, i have a wierd symptom in nova, "compute service list" and "hypervisor list" show duplicates of all hosts. running master on ubuntu 16.04 (containers are ubuntu 18.04, source). i have checked the DB and can't find any duplicate entires.. any pointer on where i should look?
11:37:24 ivve i haven't changed hostnames names.
12:31:29 openstackgerrit Tetsuro Nakamura proposed openstack/nova-specs master: Spec: Use in_tree getting allocation candidates https://review.openstack.org/646029
21:42:57 openstackgerrit Ian Wienand proposed openstack/nova master: Replace openstack.org git:// URLs with https:// https://review.openstack.org/646682
21:43:03 openstackgerrit Ian Wienand proposed openstack/nova stable/ocata: Replace openstack.org git:// URLs with https:// https://review.openstack.org/646683
21:43:11 openstackgerrit Ian Wienand proposed openstack/nova stable/pike: Replace openstack.org git:// URLs with https:// https://review.openstack.org/646684
21:43:18 openstackgerrit Ian Wienand proposed openstack/nova stable/queens: Replace openstack.org git:// URLs with https:// https://review.openstack.org/646685
21:43:26 openstackgerrit Ian Wienand proposed openstack/nova stable/rocky: Replace openstack.org git:// URLs with https:// https://review.openstack.org/646686
21:43:33 openstackgerrit Ian Wienand proposed openstack/nova stable/stein: Replace openstack.org git:// URLs with https:// https://review.openstack.org/646688
21:44:12 openstackgerrit Ian Wienand proposed openstack/nova-specs master: Replace openstack.org git:// URLs with https:// https://review.openstack.org/646695
22:00:08 openstackgerrit Ian Wienand proposed openstack/os-vif master: Replace openstack.org git:// URLs with https:// https://review.openstack.org/646867
22:00:13 openstackgerrit Ian Wienand proposed openstack/os-vif stable/rocky: Replace openstack.org git:// URLs with https:// https://review.openstack.org/646868
22:00:18 openstackgerrit Ian Wienand proposed openstack/os-vif stable/stein: Replace openstack.org git:// URLs with https:// https://review.openstack.org/646869
22:18:14 openstackgerrit Ian Wienand proposed openstack/python-novaclient stable/rocky: Replace openstack.org git:// URLs with https:// https://review.openstack.org/647074
22:18:19 openstackgerrit Ian Wienand proposed openstack/python-novaclient stable/stein: Replace openstack.org git:// URLs with https:// https://review.openstack.org/647075
#openstack-nova - 2019-03-25
01:14:44 openstackgerrit Takashi NATSUME proposed openstack/nova stable/rocky: Replace glance command with openstack command https://review.openstack.org/637060
01:15:28 openstackgerrit Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (4) https://review.openstack.org/574106
01:15:46 openstackgerrit Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (5) https://review.openstack.org/574110

Earlier   Later