| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2019-03-21 | |||
| 23:46:14 | sean-k-mooney | http://codesearch.openstack.org/?q=install_command%20%3D%20pip%20install%20-c%7Benv%3AUPPER_CONSTRAINTS_FILE%3A&i=nope&files=&repos= | |
| 23:46:32 | sean-k-mooney | i should also send a mail to the list about this tomorow | |
| 23:50:08 | melwitt | sean-k-mooney: ++ good idea | |
| 23:50:48 | sean-k-mooney | does this fall under the remite or the requireemtn team, qa team or relase team. | |
| 23:51:14 | sean-k-mooney | i think its the same people more or less on all of them but ill chat to them on irc too | |
| 23:52:59 | melwitt | sean-k-mooney: I would think #openstack-requirements | |
| 23:58:15 | sean-k-mooney | ya so apparently lower-constraints is not actully requried by the PTI which explaing why many of the proejct with the prolematic install command have not seen this issue as they are not testing with lower constratints | |
| #openstack-nova - 2019-03-22 | |||
| 00:00:25 | sean-k-mooney | placement is broken by this however as are a few other i have seen so far | |
| 00:00:46 | sean-k-mooney | oh actully no playment has the fix | |
| 00:02:30 | smcginnis | sean-k-mooney: What is the issue with the codesearch and upper constraints? | |
| 00:02:41 | smcginnis | Nearly every repo should have that. | |
| 00:03:34 | sean-k-mooney | smcginnis: yes but if you have that and you have a lower-constrats tox env and dont overwrive the install_command the the lower-constratis env uses upper-constratits | |
| 00:04:49 | sean-k-mooney | so novas lower-constraints job is broken as is congresses git.openstack.org/cgit/openstack/congress/tree/tox.ini | |
| 00:05:18 | sean-k-mooney | and tripleo-validations | |
| 00:05:44 | sean-k-mooney | there are not that many project that actully have a lower-constraints tox env | |
| 00:06:24 | smcginnis | Really? Most should have that. It was one of those big blasts out to update the world. | |
| 00:06:27 | smcginnis | https://review.openstack.org/#/q/topic:requirements-stop-syncing+(status:open+OR+status:merged) | |
| 00:06:59 | smcginnis | Congress does. At the bottom of tox.ini | |
| 00:07:11 | sean-k-mooney | yes i know | |
| 00:07:27 | smcginnis | https://opendev.org/openstack/congress/src/branch/master/tox.ini#L103-L108 | |
| 00:07:42 | sean-k-mooney | yes but its broken | |
| 00:07:53 | sean-k-mooney | https://opendev.org/openstack/congress/src/branch/master/tox.ini#L9 | |
| 00:08:24 | sean-k-mooney | that install command means its lower-constrtis is actully installing the upper-constrats instead | |
| 00:09:44 | smcginnis | I believe with the deps set there, that makes sure it also uses the lower-constraints.txt | |
| 00:10:10 | sean-k-mooney | smcginnis: it does not | |
| 00:10:12 | smcginnis | At least it has been working that way for nearly a year now. | |
| 00:10:19 | smcginnis | Where do you see it not? | |
| 00:10:45 | sean-k-mooney | in the output of the gate logs | |
| 00:10:53 | sean-k-mooney | give me a sec an ill grab some | |
| 00:12:16 | sean-k-mooney | so this is a random nova change | |
| 00:12:18 | sean-k-mooney | http://logs.openstack.org/52/626952/12/check/openstack-tox-lower-constraints/7bc660b/tox/lower-constraints-1.log | |
| 00:12:40 | sean-k-mooney | if you scroll to the end you will see its installing zVMCloudConnector-1.4.0 | |
| 00:12:51 | sean-k-mooney | the lower-constrating is 1.1.1 | |
| 00:14:10 | sean-k-mooney | the lower constrait of psycopg2 is 2.6.8 its using psycopg2-2.7.7 | |
| 00:16:37 | sean-k-mooney | doing the same with congress | |
| 00:16:39 | sean-k-mooney | http://logs.openstack.org/13/643113/1/check/openstack-tox-lower-constraints/b00ac73/tox/lower-constraints-1.log | |
| 00:17:06 | sean-k-mooney | that job used testtools-2.3.0 | |
| 00:17:17 | sean-k-mooney | there lower-constrating is 2.2.0 https://github.com/openstack/congress/blob/master/lower-constraints.txt#L139 | |
| 00:17:54 | smcginnis | Hmm, this had been working fine. I wonder if a tox upgrade or something like that has caused a change in behavior. | |
| 00:18:22 | sean-k-mooney | smcginnis: im not sure if it has been working fine or not | |
| 00:18:42 | sean-k-mooney | the issue is we are pasing two constratit files to pip | |
| 00:18:54 | sean-k-mooney | cmdargs: '/home/zuul/src/git.openstack.org/openstack/congress/.tox/lower-constraints/bin/pip install -c/home/zuul/src/git.openstack.org/openstack/requirements/upper-constraints.txt -U -c/home/zuul/src/git.openstack.org/openstack/congress/lower-constraints.txt -r/home/zuul/src/git.openstack.org/openstack/congress/test-requirements.txt | |
| 00:18:56 | sean-k-mooney | -r/home/zuul/src/git.openstack.org/openstack/congress/requirements.txt' | |
| 00:19:18 | sean-k-mooney | i dont think that is actully allowed | |
| 00:19:38 | smcginnis | It had been working. | |
| 00:19:57 | melwitt | sean-k-mooney: doesn't lower constraint mean the lower bound? how can you tell it's not working if it installs a version newer than the lower bound? | |
| 00:20:57 | sean-k-mooney | melwitt: the lower-constrating job is ment to install the oldest version that we say should work | |
| 00:21:09 | melwitt | oh, the job. I see | |
| 00:22:05 | sean-k-mooney | right so the job has not been running using our actual lower bound so we dont actully know the lower bound work. | |
| 00:22:16 | melwitt | gotcha. thanks | |
| 00:22:48 | sean-k-mooney | and in nova case i know our mocking is broken on the lower bound as we are actully trying to connect to rabbitmq in some of the test and its not mocked | |
| 00:24:35 | sean-k-mooney | if i bumped the version of oslo.messaging we have in lower bound our tests would pass with the fix to the tox.ini but i dont think we actully need the newer version is just broken tests | |
| 00:25:41 | gmann | it seems few deps are taken from lower-constraints.txt like hacking | |
| 00:25:46 | sean-k-mooney | smcginnis: anyway this is either a change in pips behavior or this was always broken unfortunetly | |
| 00:26:29 | sean-k-mooney | gmann: i think what is happening is any dep that is not n upper-consrtraitng but is in lower-constratits is being honered | |
| 00:26:46 | sean-k-mooney | but i think ip is takeing the constraint form the first file it finds it in | |
| 00:26:52 | sean-k-mooney | that is jsut a guess | |
| 00:28:59 | gmann | seems so. and that is why we have upper-constraints.txt also in dep list but picking order might have changed on tox/pip side | |
| 00:29:33 | sean-k-mooney | well tox just runs pip so tox is not really invoved | |
| 00:30:27 | sean-k-mooney | but for this env specifcially we should not include upper-constraints.txt or at least if we did it should be after lower | |
| 00:31:00 | sean-k-mooney | looking at the pip change log i dont imediatly see something related to this | |
| 00:32:31 | sean-k-mooney | the -U flag proably isnt helping much either in this case | |
| 00:41:24 | gmann | sean-k-mooney: we might need upper-constraints.txt pkg not in lower-constraints.txt, in case latest pip version of them would create issue. | |
| 00:42:36 | sean-k-mooney | gmann: we may yes but we need to validate the ordering we pass them | |
| 00:42:47 | gmann | yeah ordering is imp | |
| 00:43:36 | sean-k-mooney | the docs for pip dont state anything about orderign so im going to look at the code tomorow | |
| 00:44:18 | sean-k-mooney | that said its alreay tomorow i.e. its after mindnight so i should proable leave this untill after i sleep for selveral hours | |
| 00:54:57 | sean-k-mooney | gmann: ok im actully going now but i think this is the isue. https://github.com/pypa/pip/blob/d4217f0cc30ea2012911be1cb22a74d8cc4a365a/src/pip/_internal/req/req_set.py#L133-L136 | |
| 00:55:33 | sean-k-mooney | the way i processses constratits if a constraint is repeated the first one is used | |
| 00:59:38 | sean-k-mooney | looking at git blame the logic seam to be unchange bar minor change for at least 4 years | |
| 00:59:40 | sean-k-mooney | https://github.com/pypa/pip/blame/0bc7a974fac35ebc0b38beeba4de59017166b1bc/src/pip/_internal/req/req_set.py#L109-L130 | |
| 01:02:35 | gmann | humm, i think added upper-constraints.txt dep in tox before lower-constraints.txt things happened. which means it never worked as expected | |
| 01:16:44 | openstackgerrit | Ghanshyam Mann proposed openstack/nova master: WIP: Make os-services policies granular https://review.openstack.org/645427 | |
| 01:29:32 | openstackgerrit | melanie witt proposed openstack/nova master: DNM Re-enable testing of console with TLS in nova-next job https://review.openstack.org/645432 | |
| 01:45:46 | openstackgerrit | Ghanshyam Mann proposed openstack/nova master: WIP: Make os-services policies granular https://review.openstack.org/645427 | |
| 02:28:29 | openstackgerrit | Ghanshyam Mann proposed openstack/nova master: WIP: Make os-services policies granular https://review.openstack.org/645427 | |
| 02:29:26 | openstackgerrit | Ghanshyam Mann proposed openstack/nova master: WIP: Make os-services policies granular https://review.openstack.org/645427 | |
| 02:46:05 | openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Introduce scope_types in os-services, lock policies https://review.openstack.org/645452 | |
| 02:55:15 | openstackgerrit | Merged openstack/nova master: Require python-ironicclient>=2.7.0 https://review.openstack.org/642863 | |
| 03:21:45 | openstackgerrit | Ghanshyam Mann proposed openstack/nova master: WIP:Introduce scope_types in os-services, lock policies https://review.openstack.org/645452 | |
| 03:24:14 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Stop running tempest-multinode-full https://review.openstack.org/645456 | |
| 03:24:49 | mriedem | keeel it ^ | |
| 03:30:19 | openstackgerrit | Boxiang Zhu proposed openstack/nova-specs master: Scheduler filters evaluated even forced host https://review.openstack.org/645458 | |
| 03:46:54 | openstackgerrit | Boxiang Zhu proposed openstack/nova-specs master: Scheduler filters evaluated even forced host https://review.openstack.org/645458 | |
| 03:50:05 | openstackgerrit | OpenStack Release Bot proposed openstack/nova stable/stein: Update .gitreview for stable/stein https://review.openstack.org/645461 | |
| 03:50:10 | openstackgerrit | OpenStack Release Bot proposed openstack/nova stable/stein: Update UPPER_CONSTRAINTS_FILE for stable/stein https://review.openstack.org/645462 | |
| 03:50:16 | openstackgerrit | OpenStack Release Bot proposed openstack/nova master: Update master for stable/stein https://review.openstack.org/645463 | |
| 06:22:40 | openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove deprecated 'default_flavor' config option https://review.openstack.org/645476 | |
| 06:26:32 | openstackgerrit | OpenStack Proposal Bot proposed openstack/nova master: Imported Translations from Zanata https://review.openstack.org/645478 | |
| 06:33:16 | openstackgerrit | Takashi NATSUME proposed openstack/nova master: Add description about sort order in API ref guideline https://review.openstack.org/627282 | |
| 06:33:21 | openstackgerrit | Takashi NATSUME proposed openstack/nova master: Add description about sort order in API ref guideline https://review.openstack.org/627282 | |
| 09:27:39 | openstackgerrit | Matthew Booth proposed openstack/nova master: Eventlet monkey patching should be as early as possible https://review.openstack.org/626952 | |
| 09:28:28 | openstackgerrit | Lee Yarwood proposed openstack/nova master: Use migration_status during volume migrating and retyping https://review.openstack.org/637224 | |
| 09:45:07 | openstackgerrit | Boxiang Zhu proposed openstack/nova master: [WIP] Scheduler filters evaluated even forced host https://review.openstack.org/645520 | |
| 09:50:20 | kashyap | mdbooth_: Nice work on that eventlet patch (although I'm not fully qualified to comment on it). | |
| 09:50:23 | kashyap | "I started with what seemed like the simplest and most obvious change, and moved on as I discovered more interactions which broke." | |
| 09:50:26 | kashyap | :D | |
| 09:51:01 | kashyap | (Also kudos for the "commit message mini essay") | |
| 09:51:22 | mdbooth | kashyap: Heh, thanks. The commit message has also grown over time :) | |
| 09:51:42 | kashyap | Yes, I can see. I'm sure you spent many hours fine-tuning it as you discovered things. | |