| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2019-03-20 | |||
| 23:32:34 | mriedem | efried: cdent: thanks got both | |
| 23:55:38 | mriedem | sorrison: if you can't make the next nova meeting, you could add https://bugs.launchpad.net/nova/+bug/1819568 to the open discussion agenda as a potential specless blueprint | |
| 23:55:39 | openstack | Launchpad bug 1819568 in OpenStack Compute (nova) "RFE: network_data.json doesn't contain information about floating IPs" [Wishlist,Opinion] | |
| #openstack-nova - 2019-03-21 | |||
| 03:29:03 | openstackgerrit | Ghanshyam Mann proposed openstack/nova-specs master: Spec for API policy updates https://review.openstack.org/547850 | |
| 03:29:54 | openstackgerrit | Ghanshyam Mann proposed openstack/nova-specs master: Spec for API policy updates https://review.openstack.org/547850 | |
| 04:55:22 | openstackgerrit | Yongli He proposed openstack/nova master: Clean up orphan instances https://review.openstack.org/627765 | |
| 05:15:05 | openstackgerrit | Merged openstack/python-novaclient stable/stein: Update UPPER_CONSTRAINTS_FILE for stable/stein https://review.openstack.org/644182 | |
| 05:15:05 | openstackgerrit | Merged openstack/python-novaclient stable/stein: Update .gitreview for stable/stein https://review.openstack.org/644181 | |
| 05:42:34 | openstackgerrit | Merged openstack/os-vif stable/stein: Update .gitreview for stable/stein https://review.openstack.org/644034 | |
| 07:51:22 | kashyap | sean-k-mooney: Hi, just saw the ping in the scrollback; there's a lot of text. Hope klindgren's problem is resolved :-) | |
| 08:00:22 | openstackgerrit | Kashyap Chamarthy proposed openstack/nova master: libvirt: Use 'writeback' QEMU cache mode when 'none' is not viable https://review.openstack.org/641981 | |
| 08:00:23 | openstackgerrit | Kashyap Chamarthy proposed openstack/nova master: libvirt: vzstorage: Use 'writeback' QEMU cache mode https://review.openstack.org/643376 | |
| 08:00:24 | openstackgerrit | Kashyap Chamarthy proposed openstack/nova master: libvirt: smbfs: Use 'writeback' QEMU cache mode https://review.openstack.org/643377 | |
| 08:04:05 | kashyap | efried: When you get a moment, lost yours / SylvainB's +2s & +W; appreciate if you can re-ACK|NACK it. | |
| 08:39:48 | kashyap | bauzas: ^ When you get a moment :-) | |
| 08:40:17 | kashyap | (It already had +W, just lost the ACK due to rebase) | |
| 09:24:03 | kashyap | bauzas: Docs will be fixed in a separate change | |
| 09:24:12 | kashyap | To not let the core patch be blocked | |
| 09:24:15 | bauzas | cool with me then | |
| 09:24:25 | kashyap | bauzas: Please see the review comments :-) MattR and MattB both agreed on the change | |
| 09:24:35 | kashyap | That to let this merge, and I fix the rest of the documenation | |
| 09:24:39 | bauzas | just comment and say you'll add a fup | |
| 09:24:49 | bauzas | sorry, fup == follow-up change | |
| 09:24:52 | kashyap | Yeah, it's actually added | |
| 09:24:58 | kashyap | bauzas: Also at the end of the commit message I noted as such | |
| 09:25:10 | kashyap | [quote] | |
| 09:25:11 | kashyap | Do the minimum required update to the `disk_cachemodes` config help text. (In a future patch, rewrite the cache modes documentation to fix confusing fragments and outdated information.) | |
| 09:25:15 | kashyap | [/quote | |
| 09:27:15 | bauzas | kashyap: sure, but I still feel we need to document in the relnote why we now recommend writeback as default | |
| 09:27:27 | kashyap | bauzas: Rel Note is also there | |
| 09:27:35 | bauzas | basically because modern OSes fsync | |
| 09:27:38 | kashyap | bauzas: The default depends on what file system one is using | |
| 09:27:59 | bauzas | but if operators are scary about that, they should just keep writethrough and not use default | |
| 09:28:13 | bauzas | kashyap: yup, but you're not telling it in the relnote | |
| 09:28:22 | kashyap | bauzas: The documentation fix follow right after that. | |
| 09:28:24 | bauzas | operators litterally have to load a lot of context | |
| 09:28:35 | kashyap | bauzas: No need for the operators to be "scary" here. There are lots of myths about cache modes | |
| 09:28:36 | bauzas | again, I'm talking about relnotes | |
| 09:28:50 | kashyap | Let me re-read it | |
| 09:29:14 | bauzas | tbc, my -1 is due to https://review.openstack.org/#/c/641981/13/releasenotes/notes/writeback-cache-mode-for-guests-a7e4d2806c956164.yaml@8 | |
| 09:29:17 | kashyap | bauzas: Okay, saw your comment on the rel note -- again, not required to add your comment | |
| 09:29:46 | kashyap | bauzas: Really, that's not required. The guest OSes that don't fsync() are really really really horribly old and we don't support | |
| 09:30:10 | bauzas | kashyap: I mean, we're making an opinionated choice, right? If so, let's just capture it in the relnote | |
| 09:30:22 | bauzas | and not just in the commit msg, which is bad for operators | |
| 09:30:42 | bauzas | and technically, I accepted it as a fix, but this isn't really a fix | |
| 09:30:46 | kashyap | bauzas: Huh. That's what the rel note says | |
| 09:30:58 | bauzas | it's a performance improvement | |
| 09:30:59 | kashyap | bauzas: I don't follow you. What is not really a fix? | |
| 09:31:06 | kashyap | Well, it's both. | |
| 09:31:23 | bauzas | let's take an example | |
| 09:31:28 | bauzas | I have a car which is running | |
| 09:31:29 | kashyap | (1) Fixing wrong assumption in Nova; (2) And (1) brings performance improvement | |
| 09:31:41 | bauzas | for sure, the engine is running | |
| 09:32:01 | bauzas | but I can make sure that I can improve the engine by changing some, say, injector | |
| 09:32:23 | bauzas | that will possibly make my engine having trouble when I stop, for example, but that's depending on my driving | |
| 09:32:36 | bauzas | so, I like to know that I can improve my engine by changing my driving | |
| 09:33:07 | bauzas | kashyap: again, the relnote doesn't mention a bit about guest OSes | |
| 09:33:28 | bauzas | it's just litterally saying "heh, we're changing a default value" | |
| 09:33:48 | bauzas | there is no other contextual information | |
| 09:34:14 | bauzas | if you say "ok, I'm going to amend the relnote in a fup", fine with me | |
| 09:34:22 | bauzas | or I could just do it | |
| 09:34:36 | bauzas | but I just want to make sure operators know about the reasons we decided | |
| 09:34:55 | kashyap | bauzas: Mentioning guest OSes really confuses at this point. | |
| 09:35:09 | kashyap | If an operator has longer attention span, they will carefully read the documentation | |
| 09:35:49 | sean-k-mooney | kashyap: if it was just for perfromance we would not be changing the default however right | |
| 09:36:08 | sean-k-mooney | that is just a side benifit | |
| 09:36:11 | kashyap | Huh, who said it was just for performance? | |
| 09:36:33 | bauzas | kashyap: don't expect operators to load contect on every relnote | |
| 09:36:36 | bauzas | context* | |
| 09:36:51 | bauzas | it's a massive amount of information they have to digest | |
| 09:37:07 | bauzas | and we suffered some pain in the past by overexpecting their knowledge | |
| 09:37:27 | kashyap | bauzas: I know very well about that. I take great care in not assuming people will have context. | |
| 09:37:56 | gibi | stephenfin: do you have any suggestion about the table issue in https://review.openstack.org/#/c/644810/1/specs/stein/approved/bandwidth-resource-provider.rst@624 | |
| 09:37:57 | bauzas | anyway, I don't want to spend more time on it, will spin a new revision | |
| 09:38:12 | bauzas | gibi: stephenfin is mostly eaten by meetings all week | |
| 09:38:31 | gibi | bauzas: thanks I will try to fight sphinx alone then :) | |
| 09:38:36 | bauzas | kashyap: let me just provide a new revision | |
| 09:38:47 | kashyap | bauzas: Hang on | |
| 09:38:53 | sean-k-mooney | kashyap could you update the release not with the explaning you gave to me about the 3 booleans that the cachemodes set to explain why its safe to ues writeback | |
| 09:39:00 | kashyap | bauzas: Just post your new text as a comment | |
| 09:39:34 | sean-k-mooney | kashyap: that is the context that ops will be missing. it was the context i was missing when i saw the commit first | |
| 09:39:59 | sean-k-mooney | ops wont see the commit message so all they have is the release note | |
| 09:40:35 | bauzas | sean-k-mooney: yeah I agree | |
| 09:41:01 | bauzas | sean-k-mooney: kashyap did a great work on documenting it in a docstring https://review.openstack.org/#/c/641981/13/nova/virt/libvirt/driver.py@410 | |
| 09:41:11 | bauzas | but we don't take the opportunity to explain it to ops | |
| 09:41:28 | bauzas | while it could be scary "heh, wtf, now I could loose data integrity?" | |
| 09:42:27 | sean-k-mooney | right well quickly looking at that it could be more or less copied into the release note | |
| 09:42:55 | sean-k-mooney | it might be a little verbose but that is not a bad thing | |
| 09:43:39 | sean-k-mooney | i think all of the context is already in the patch just need to duplicate some of it into the release note | |
| 09:55:18 | bauzas | mdbooth: kashyap: sean-k-mooney: so, I provided an example of what I'd like to see in the relnote | |
| 09:55:48 | bauzas | if operators don't want to expect modern OSes, it's their choices | |
| 09:55:51 | mdbooth | bauzas: I saw that. Honestly, though, this hasn't been an issue for at least a decade, maybe 2. | |
| 09:56:11 | bauzas | mdbooth: not really, you can enable caching on some OSes that don't flush, right? | |
| 09:56:13 | mdbooth | I think it just increases cognitive load on the reader for no practical benefit. | |
| 09:56:28 | bauzas | from my recall, W2K is one of those | |
| 09:56:28 | sean-k-mooney | mdbooth: there are still people running centos 5 | |
| 09:56:41 | mdbooth | sean-k-mooney: Centos 5 definitely flushes! | |
| 09:56:42 | sean-k-mooney | mdbooth: didnt it have issue with flushing | |
| 09:56:45 | sean-k-mooney | ok | |
| 09:57:16 | sean-k-mooney | that was the distro that i always worried about for this kind of thing | |