Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2019-03-18
07:50:39 openstackgerrit Yongli He proposed openstack/nova master: Clean up orphan instances https://review.openstack.org/627765
08:02:54 openstackgerrit zhangyangyang proposed openstack/python-novaclient master: Drop py35 tests https://review.openstack.org/643873
08:55:20 bauzas good morning folks
08:58:26 gibi bauzas: good morning bauzas
08:59:12 bauzas I'll try to look at the bugs
09:04:11 tssurya good morning nova!
09:06:01 tssurya alex_xu, gmann and other API experts : would you have a look at https://review.openstack.org/#/c/638629/ when you have the time ? we would like to have the nova lock description info downstream
09:06:56 alex_xu tssurya: yea, copy that, will try it soon
09:07:07 tssurya thanks alex_xu :)
09:07:18 alex_xu np
09:22:29 openstackgerrit Michael Still proposed openstack/nova master: Remove fake_libvirt_utils from snapshot tests. https://review.openstack.org/642558
09:22:29 openstackgerrit Michael Still proposed openstack/nova master: Remove fake_libvirt_utils from connection tests. https://review.openstack.org/642557
09:22:30 openstackgerrit Michael Still proposed openstack/nova master: Remove fake_libvirt_utils from virt driver tests. https://review.openstack.org/643894
09:22:30 openstackgerrit Michael Still proposed openstack/nova master: Make privsep.chown mocking for libvirt snapshot tests less magic. https://review.openstack.org/642134
09:22:31 openstackgerrit Michael Still proposed openstack/nova master: Remove remaining vestiges of fake_libvirt_utils from unit tests. https://review.openstack.org/643896
09:22:31 openstackgerrit Michael Still proposed openstack/nova master: Remove fake_libvirt_utils from libvirt imagebackend tests. https://review.openstack.org/643895
09:22:32 openstackgerrit Michael Still proposed openstack/nova master: Complete remove fake_libvirt_utils. https://review.openstack.org/643897
10:03:15 lyarwood bauzas: https://review.openstack.org/#/c/628726/ - morning, mind taking another look at this now I've had to revert to the original change, with conflicts etc?
10:03:24 bauzas sure
10:04:28 bauzas lyarwood: haha, zuul gave you again my -1 because you rebased to PS3 :)
10:05:29 lyarwood bauzas: yeeeeeeeeeah, fun times :)
10:06:48 kashyap bauzas: alex_xu: Morning, can either of you put this simple 4-patch series through? -- https://review.openstack.org/#/q/topic:bug/1818847+(status:open+OR+status:merged)
10:07:00 bauzas queuing
10:09:15 kashyap Thanks!
10:13:52 bauzas lyarwood: I'm confused with the gerrit ordering
10:15:41 openstackgerrit Kashyap Chamarthy proposed openstack/nova master: qemu: Make disk image conversion dramatically faster https://review.openstack.org/640781
10:15:42 openstackgerrit Kashyap Chamarthy proposed openstack/nova master: libvirt: vzstorage: Use 'writeback' QEMU cache mode https://review.openstack.org/643376
10:15:42 openstackgerrit Kashyap Chamarthy proposed openstack/nova master: libvirt: Use 'writeback' QEMU cache mode for Nova instances https://review.openstack.org/641981
10:15:43 openstackgerrit Kashyap Chamarthy proposed openstack/nova master: libvirt: smbfs: Use 'writeback' QEMU cache mode https://review.openstack.org/643377
10:27:16 bauzas is it me or gerrit is in the weeds ?
10:28:10 openstackgerrit Balazs Gibizer proposed openstack/nova master: Documentation for bandwidth support https://review.openstack.org/642064
10:28:15 kashyap bauzas: Loads fine for me
10:28:25 bauzas graaaah
10:28:26 gibi bauzas: gerrit was down for me too for a while
10:28:46 bauzas I also have a super bad DSL connection
10:29:15 kashyap gibi: If you have time, would appreciate your quick eyes on this: https://review.openstack.org/#/q/topic:bug/1818847+(status:open+OR+status:merged)
10:29:26 kashyap Already has +2s from efried
10:29:33 gibi kashyap: ack
10:29:53 bauzas kashyap: you were next in the queue
10:30:22 kashyap Thank you, both.
10:31:11 kashyap bauzas: The first patch in the series, I only fixed my own OCD nit-pick (remove a needless comma); so it might fall into the "fast-approve" zone.
10:31:56 bauzas gtk
10:57:12 openstackgerrit Merged openstack/nova master: Pass kwargs to exception to get better format of error message https://review.openstack.org/643501
11:07:37 bauzas kashyap: just provide a note and fix the commit msg and I'm +2/+W
11:07:45 bauzas kashyap: for https://review.openstack.org/#/c/640781/8
11:17:57 kashyap bauzas: On the full SHA-1, note how I also put in the commit _summary_ -- so there is no confusion at all :-)
11:18:31 kashyap If one is not putting the one-line commit summary next to the short SHA-1, then I agree that adding a full SHA-1 would be useful
11:21:58 kashyap Can do the rel note, if you think it's useful
11:42:59 openstackgerrit Kashyap Chamarthy proposed openstack/nova master: qemu: Make disk image conversion dramatically faster https://review.openstack.org/640781
11:43:00 openstackgerrit Kashyap Chamarthy proposed openstack/nova master: libvirt: vzstorage: Use 'writeback' QEMU cache mode https://review.openstack.org/643376
11:43:00 openstackgerrit Kashyap Chamarthy proposed openstack/nova master: libvirt: Use 'writeback' QEMU cache mode for Nova instances https://review.openstack.org/641981
11:43:01 openstackgerrit Kashyap Chamarthy proposed openstack/nova master: libvirt: smbfs: Use 'writeback' QEMU cache mode https://review.openstack.org/643377
11:43:28 kashyap bauzas: ^ Added the rel note, and the full SHA1
11:49:49 kashyap Thanks for the review!
12:45:26 yaawang kashyap: hi, have you seen the review of https://review.openstack.org/#/c/642030/ :)
12:46:52 kashyap yaawang: Will look at it shortly.
12:50:07 yaawang Thanks
13:30:05 bauzas efried: when you're back, please look at https://review.openstack.org/#/c/640781/
13:36:51 efried bauzas: looking...
13:37:48 efried bauzas, kashyap: +A
13:37:54 bauzas ta
13:40:52 mriedem efried: bauzas: kashyap: https://review.openstack.org/#/c/641981/
13:40:56 mriedem the default changed right?
13:41:29 bauzas mriedem: lemme look
13:41:45 kashyap mriedem: Yes, mea culpa
13:41:56 kashyap That's why I was badgering other reviewers if I missed anything else
13:42:05 kashyap efried: Let me quickly update the help file
13:42:15 bauzas mriedem: ah, good point about the conf opt
13:42:18 kashyap mriedem: There's already a rel note in the other patch; but I'll expand for this, too
13:42:28 bauzas mriedem: I already asked for a relnote in the below change
13:42:35 bauzas yeah this
13:42:39 mriedem they are different changes though
13:42:50 kashyap True
13:42:58 kashyap One is for image conversion, the other is for Nova instances.
13:43:27 bauzas okay, passing a new PS
13:43:42 kashyap Also that help text needs an update (as a separate change, later). I had a lengthy e-mail chain with the QEMU Block Layer folks. Based on that our docs can do an update
13:43:43 bauzas for stopping the CI
13:43:53 efried I didn't realize there was a conf option. It wasn't apparent in the code.
13:44:06 openstackgerrit Sylvain Bauza proposed openstack/nova master: libvirt: Use 'writeback' QEMU cache mode for Nova instances https://review.openstack.org/641981
13:44:20 bauzas kashyap: ^
13:44:30 bauzas it blocks the CI
13:44:59 efried wow, I'm still not seeing how that attribute gets set from that conf option.
13:45:52 kashyap Also the whole cache modes help text needs an update (as a separate change), based on a lengthy e-mail chain with the QEMU Block Layer folks.
13:46:09 kashyap Err, disregard that duplicate
13:51:58 kashyap efried: See this:
13:51:59 kashyap LOG.warning('Invalid cachemode %(cache_mode)s specified '
13:51:59 kashyap if cache_mode not in self.valid_cachemodes:
13:51:59 kashyap disk_type, sep, cache_mode = mode_str.partition('=')
13:51:59 kashyap for mode_str in CONF.libvirt.disk_cachemodes:
13:52:02 kashyap 'for disk type %(disk_type)s.',
13:52:04 kashyap {'cache_mode': cache_mode, 'disk_type': disk_type})
13:52:07 kashyap continue
13:52:10 kashyap self.disk_cachemodes[disk_type] = cache_mode
13:52:12 efried n-sch meeting in 8 minutes in #openstack-meeting-alt
13:52:50 efried kashyap: Yeah, but I still don't see how that's feeding into the self._disk_cachemode attr
13:57:05 mriedem is it just me or does this seem somewhat risky to be rushing in right before rc1?
13:57:14 mriedem given the complication
13:57:39 openstackgerrit Lance Bragstad proposed openstack/nova master: Remove obsolete policy configuration details from docs https://review.openstack.org/643949
13:59:15 mriedem in other news, i'm +2 on gibi's bw provider nova docs https://review.openstack.org/#/c/642064/
13:59:31 bauzas mriedem: what do you make you feel rushing ?

Earlier   Later