Posted	Nick	Remark
#openstack-nova - 2019-03-14
20:23:42	openstackgerrit	Matt Riedemann proposed openstack/nova master: Confirm cross-cell resize from the API https://review.openstack.org/637316
20:23:43	openstackgerrit	Matt Riedemann proposed openstack/nova master: WIP: Add finish_revert_snapshot_based_resize_at_source compute method https://review.openstack.org/637647
20:23:43	openstackgerrit	Matt Riedemann proposed openstack/nova master: Deal with cross-cell resize in _remove_deleted_instances_allocations https://review.openstack.org/639453
20:23:44	openstackgerrit	Matt Riedemann proposed openstack/nova master: Add revert_snapshot_based_resize conductor RPC method https://review.openstack.org/638047
20:23:44	openstackgerrit	Matt Riedemann proposed openstack/nova master: WIP: Add RevertResizeTask https://review.openstack.org/638046
20:23:45	openstackgerrit	Matt Riedemann proposed openstack/nova master: Confirm cross-cell resize while deleting a server https://review.openstack.org/638268
20:23:45	openstackgerrit	Matt Riedemann proposed openstack/nova master: Revert cross-cell resize from the API https://review.openstack.org/638048
20:23:46	openstackgerrit	Matt Riedemann proposed openstack/nova master: Add cross-cell resize policy rule and enable in API https://review.openstack.org/638269
20:23:46	openstackgerrit	Matt Riedemann proposed openstack/nova master: Add CrossCellWeigher https://review.openstack.org/614353
20:23:47	openstackgerrit	Matt Riedemann proposed openstack/nova master: Add zones wrinkle to TestMultiCellMigrate https://review.openstack.org/643450
20:23:48	openstackgerrit	Matt Riedemann proposed openstack/nova master: Add negative test for cross-cell finish_resize failing https://review.openstack.org/643451
20:30:34	mriedem	sob, time to rebase
20:30:37	mriedem	44 changes
20:34:33	openstackgerrit	Matt Riedemann proposed openstack/nova master: Improve CinderFixtureNewAttachFlow https://review.openstack.org/639382
20:34:33	openstackgerrit	Matt Riedemann proposed openstack/nova master: Fix ProviderUsageBaseTestCase._run_periodics for multi-cell https://review.openstack.org/641179
20:34:33	openstackgerrit	Matt Riedemann proposed openstack/nova master: Update usage in RT.drop_move_claim during confirm resize https://review.openstack.org/641806
20:34:33	openstackgerrit	Matt Riedemann proposed openstack/nova master: Remove unused context parameter from RT._get_instance_type https://review.openstack.org/641792
20:34:33	openstack	bug 1818914 in OpenStack Compute (nova) "Hypervisor resource usage on source still shows old flavor usage after resize confirm until update_available_resource periodic runs" [Low,In progress] https://launchpad.net/bugs/1818914 - Assigned to Matt Riedemann (mriedem)
20:34:33	openstackgerrit	Matt Riedemann proposed openstack/nova master: Add functional recreate test for bug 1818914 https://review.openstack.org/641521
20:34:34	openstackgerrit	Matt Riedemann proposed openstack/nova master: Add InstanceAction/Event create() method https://review.openstack.org/614036
20:34:34	openstackgerrit	Matt Riedemann proposed openstack/nova master: Add Migration.cross_cell_move and get_by_uuid https://review.openstack.org/614012
20:34:35	openstackgerrit	Matt Riedemann proposed openstack/nova master: Add TargetDBSetupTask https://review.openstack.org/627892
20:34:35	openstackgerrit	Matt Riedemann proposed openstack/nova master: Add Instance.hidden field https://review.openstack.org/631123
20:34:36	openstackgerrit	Matt Riedemann proposed openstack/nova master: Execute TargetDBSetupTask https://review.openstack.org/633853
20:34:36	openstackgerrit	Matt Riedemann proposed openstack/nova master: Add CrossCellMigrationTask https://review.openstack.org/631581
20:34:37	openstackgerrit	Matt Riedemann proposed openstack/nova master: Add prep_snapshot_based_resize_at_dest compute method https://review.openstack.org/633293
20:34:37	openstackgerrit	Matt Riedemann proposed openstack/nova master: Add can_connect_volume() compute driver method https://review.openstack.org/621313
20:34:38	openstackgerrit	Matt Riedemann proposed openstack/nova master: Add prep_snapshot_based_resize_at_source compute method https://review.openstack.org/634832
20:34:38	openstackgerrit	Matt Riedemann proposed openstack/nova master: Add PrepResizeAtDestTask https://review.openstack.org/627890
20:34:39	openstackgerrit	Matt Riedemann proposed openstack/nova master: Add PrepResizeAtSourceTask https://review.openstack.org/627891
20:34:39	openstackgerrit	Matt Riedemann proposed openstack/nova master: Add nova.compute.utils.delete_image https://review.openstack.org/637605
20:34:40	openstackgerrit	Matt Riedemann proposed openstack/nova master: Refactor ComputeManager.remove_volume_connection https://review.openstack.org/642183
20:34:51	openstackgerrit	Matt Riedemann proposed openstack/nova master: Deal with cross-cell resize in _remove_deleted_instances_allocations https://review.openstack.org/639453
20:34:53	openstackgerrit	Matt Riedemann proposed openstack/nova master: WIP: Add RevertResizeTask https://review.openstack.org/638046
20:34:53	openstackgerrit	Matt Riedemann proposed openstack/nova master: WIP: Add finish_revert_snapshot_based_resize_at_source compute method https://review.openstack.org/637647
20:34:54	openstackgerrit	Matt Riedemann proposed openstack/nova master: Add revert_snapshot_based_resize conductor RPC method https://review.openstack.org/638047
20:34:55	openstackgerrit	Matt Riedemann proposed openstack/nova master: Confirm cross-cell resize while deleting a server https://review.openstack.org/638268
20:34:55	openstackgerrit	Matt Riedemann proposed openstack/nova master: Revert cross-cell resize from the API https://review.openstack.org/638048
20:34:56	openstackgerrit	Matt Riedemann proposed openstack/nova master: Add CrossCellWeigher https://review.openstack.org/614353
20:34:57	openstackgerrit	Matt Riedemann proposed openstack/nova master: Add cross-cell resize policy rule and enable in API https://review.openstack.org/638269
20:37:45	mgoddard	hi nova. Hitting an issue on ubuntu bionic where libvirt has a guest arch (armv6l) unknown to nova, causing nova-compute to error
20:38:02	mgoddard	InvalidArchitectureName: Architecture name 'armv6l' is not recognised
20:38:11	mgoddard	http://logs.openstack.org/08/643308/4/check/kolla-ansible-ubuntu-source/eee856d/primary/logs/kolla/nova/nova-compute.txt.gz#_2019-03-14_19_11_31_709
20:38:27	mgoddard	Is this a known issue?
20:42:03	mgoddard	qemu 2.11.1
20:42:21	mgoddard	libvirt 4.0.0
20:43:40	melwitt	looks like it, if the arch isn't in this list, calls to canonicalize() will raise that exception https://github.com/openstack/nova/blob/master/nova/objects/fields.py#L102
20:44:49	mgoddard	melwitt: better hope no one invents any new arches after a nova release then :)
20:45:00	melwitt	haha, yeah
20:45:14	melwitt	I don't know the story behind it, dansmith or someone might know
20:45:28	dansmith	the story behind why we have enums?
20:45:39	mgoddard	melwitt: I'll push a patch for armv6l, but maybe an item for the nova team TODO list to make it a bit more resilient to the unknown?
20:46:04	melwitt	dansmith: yeah, why it's a limited set that has to be added to when new arch arrive
20:46:15	dansmith	melwitt: kindof the definition of an enum right?
20:46:32	melwitt	dansmith: well, ok, then yes, why we have enum. you know what I mean
20:46:38	dansmith	we have enums for known image properties so one we don't support doesn't sneak into place, and we have enums for virt drivers for ...
20:47:18	dansmith	I mean, everything on the wire could just be strings and dicts, but, the whole point of this stuff was to nail it down so we could tell when something changed
20:47:37	melwitt	mgoddard: in what way, a better error maybe? like ArchitectureUnknown?
20:47:57	mgoddard	the problem here is that a new arch in libvirt capabilities causes nova-compute to fail
20:48:22	mgoddard	it doesn't have to support the arch, but it shouldn't break everything else
20:49:15	dansmith	sure, so the driver maybe should catch the failure to set the enum, log an error and exit on startup
20:50:21	mgoddard	exit?
20:50:30	melwitt	nova meeting in 10 min
20:51:05	mgoddard	I don't think that libvirt adding an obscure new arch should break nova
20:51:24	dansmith	mgoddard: I haven't clicked on your link so I don't know what's happening specifically
20:51:46	dansmith	mgoddard: obviously if it's just a new supported emulated arch, then the driver just needs to not fail when it can't set that on an object, for sure
20:51:54	mgoddard	dansmith: +1
20:51:58	melwitt	ok, looks like update_available_resource is raising because of the unknown arch
20:52:08	dansmith	mgoddard: if it's something more fundamental like it's the native system arch or something, it would make sense for it to not start if it isn't going to function
20:52:56	melwitt	I know we've talked before about whether we should except-continue for things that raise during update_available_resource. maybe this would be an acceptable one. for anything else, we let it halt
20:53:19	openstackgerrit	Eric Fried proposed openstack/nova master: WIP/PoC: Bypass ironicclient for node.get https://review.openstack.org/642899
20:53:28	dansmith	it of course depends on the context of the issue
20:53:38	dansmith	if it's unable to do something fundamental, it should abort
20:54:05	dansmith	if it just can't expose support for some thing because of a new libvirt (which is sounds like in this case) then of course it should just not break on forward compat
20:54:07	melwitt	yeah, I mean in update_available_resource, if InvalidArchitectureName is raised
20:55:02	dansmith	it's some virt specific place it's crashing I imagine, so it would be in there, not directly in update_available_resource()
20:55:17	dansmith	you surely don't want the resource tracker ignoring something like ArchNotSupported
20:55:32	dansmith	but the libvirt driver can know if it's okay to skip that
20:55:45	melwitt	oh
20:56:00	dansmith	_get_instance_capabilities()
20:56:11	dansmith	just needs to catch and ignore that
20:56:13	openstackgerrit	Mark Goddard proposed openstack/nova master: Add armv6l to Architecture enum https://review.openstack.org/643455
20:56:15	mriedem	this is why it breaks https://review.openstack.org/#/c/356067/
20:56:45	mriedem	i mean, there is no major reason for that change except "use the enums we have"
20:56:50	mriedem	w/o considering side effects
20:57:39	mgoddard	I'll leave this one in your capable hands - it's long past home time here. Thanks for your input
20:57:45	dansmith	mriedem: one reason (even if presumptive) so that each driver doesn't call the arches something slightly different causing the api to return inconsistent results
20:57:46	mriedem	it would blow up before that as well https://review.openstack.org/#/c/356067/12/nova/compute/arch.py
20:57:57	mriedem	so this is super latent behavior
20:58:26	mriedem	dansmith: like the 50 different ways to describe power
20:58:32	dansmith	point being, the bug (aside from the missing arch) is just in the libvirt driver being stupid
20:59:39	dansmith	we need a catch and ignore right here, is all: https://github.com/openstack/nova/blob/master/nova/virt/libvirt/driver.py#L5942-L5945
20:59:42	melwitt	mgoddard: ok, thanks for letting us know. I can open a bug for that and propose a patch, if no one else wants to
21:00:23	dansmith	melwitt: I'm already rage typing it
21:00:34	mriedem	i would not be surprised if that value is used elsewhere though
21:00:39	mriedem	and could blow up elsewhere
21:00:39	melwitt	dansmith: cool
21:01:08	dansmith	mriedem: could be, but it's clearly wrong for that loop to not continue
21:01:32	mriedem	yeah sure
21:01:39	mriedem	just exclude that one with a warning i guess

Earlier   Later