Earlier  
Posted Nick Remark
#openstack-nova - 2019-03-12
19:00:12 efried mriedem: fixed ^
19:00:57 mriedem +W thanks
19:01:22 efried thanks
19:02:33 mriedem efried: actually one question about the release note https://review.openstack.org/#/c/640879/11/releasenotes/notes/set-endpoint-interface-for-ironicclient-a0b6b8f8dedc7341.yaml
19:03:00 efried ahcrap, I didn't even look at the reno.
19:03:11 dansmith busted
19:03:21 mriedem time for your spanking
19:03:45 efried considering this isn't my patch, I'd like to bring in my whipping boy.
19:03:54 mriedem the gimp?
19:04:27 efried Is that what he is? I've been thinking of him as "leather ninja"
19:04:41 mriedem hey it's taco tuesday right? https://media.giphy.com/media/ToMjGpHaUPwqzAVaxoI/giphy.gif
19:05:21 efried That's obscene in a way I can't begin to define
19:05:25 dansmith oh...mahgod.
19:05:54 dansmith man mikal just barely missed that one
19:06:18 openstackgerrit Eric Fried proposed openstack/nova master: pass endpoint interface to Ironic client https://review.openstack.org/640879
19:06:21 efried mriedem: ^
19:08:40 openstackgerrit Matt Riedemann proposed openstack/nova master: pass endpoint interface to Ironic client https://review.openstack.org/640879
19:08:47 mriedem let's all touch that patch
19:11:29 openstackgerrit Matt Riedemann proposed openstack/nova master: Require python-ironicclient>=2.7.0 https://review.openstack.org/642863
19:11:31 mriedem efried: right? ^
19:12:28 efried mriedem: in master only, yeah.
19:13:39 efried +2
19:14:29 efried o right, we load ironicclient dynamically, swhy it's not in requirements.txt
19:36:11 cfriesen I assume this is a test-tool problem, not a problem with my change? http://logs.openstack.org/63/631363/22/check/nova-grenade-live-migration/1a03cbc/job-output.txt.gz#_2019-03-11_07_51_09_359608
19:36:48 mriedem it means live migration failed
19:36:54 mriedem u'status': u'error'
19:37:29 mriedem http://logs.openstack.org/63/631363/22/check/nova-grenade-live-migration/1a03cbc/logs/screen-n-cpu.txt.gz?level=TRACE#_Mar_11_07_50_39_506220
19:40:57 mriedem cfriesen: so yeah i assume that's not your fault
19:41:02 mriedem libvirt randomly puked
19:44:40 melwitt mriedem: yeah, I guess you're right it's latent since rocky
20:12:09 openstackgerrit Matt Riedemann proposed openstack/nova master: Don't warn on network-vif-unplugged event during live migration https://review.openstack.org/642877
20:15:11 openstackgerrit Matt Riedemann proposed openstack/nova master: Don't warn on network-vif-unplugged event during live migration https://review.openstack.org/642877
20:16:09 mriedem bunch of stable/queens changes with a +2 that need approval https://review.openstack.org/#/q/status:open+project:openstack/nova+branch:stable/queens+label:Code-Review=2
20:57:54 openstackgerrit melanie witt proposed openstack/nova master: Count instances from mappings and cores/ram from placement https://review.openstack.org/638073
20:57:54 openstackgerrit melanie witt proposed openstack/nova master: Add get_counts() to InstanceMappingList https://review.openstack.org/638072
20:57:55 openstackgerrit melanie witt proposed openstack/nova master: Use instance mappings to count server group members https://review.openstack.org/638324
21:14:56 mriedem we should probably change the channel topic from the runways etherpad link to the rc potential etherpad link
21:16:10 melwitt yeah, we should. dansmith ^
21:16:39 melwitt https://etherpad.openstack.org/p/nova-stein-rc-potential
21:16:41 dansmith link me? it's
21:16:42 dansmith thanks
21:17:33 melwitt thanks
21:33:29 mriedem got a bunch of pike backports that need a +W https://review.openstack.org/#/q/status:open+project:openstack/nova+branch:stable/pike+label:Code-Review=2
21:33:53 mriedem there are also several pike backports from me which haven't had core review, and i probably shouldn't approve my own backports
21:33:58 mriedem melwitt: ^
21:34:12 melwitt k, I'll go through them
21:35:06 openstackgerrit Merged openstack/nova master: Revert "Fixes race condition with privsep utime" https://review.openstack.org/641038
21:35:14 mriedem feel free to proxy my backports as an implicit +2
21:35:40 melwitt copy that
21:42:07 openstackgerrit Matt Riedemann proposed openstack/nova master: Add functional test to delete a server while in VERIFY_RESIZE https://review.openstack.org/615644
21:43:10 mriedem melwitt: this is another old change that you've reviewed at one point https://review.openstack.org/#/c/541420/ but without it is going to make our eventual data migration for old volume attachments take that much longer
21:44:42 openstackgerrit Eric Fried proposed openstack/nova master: WIP/PoC: Bypass ironicclient for node.get https://review.openstack.org/642899
21:45:03 efried TheJulia, jroll, dtantsur|afk: This should interest you ^
21:45:24 melwitt mriedem: oh yeah, I remember that one. it fell off my radar a long time ago. I'll re-queue it
21:45:53 openstackgerrit Matt Riedemann proposed openstack/nova master: Add retry_on_deadlock to migration_update DB API https://review.openstack.org/633075
21:45:55 efried TheJulia, jroll, dtantsur|afk: I decided that other thing - getting ironicclient to accept a pre-made Adapter - was going to be pretty heinous and an unnecessary step on the road to getting ironicclient out of the picture. This is a different approach.
21:46:25 TheJulia efried: ++++++++++++++++++=
21:47:42 openstackgerrit Matt Riedemann proposed openstack/nova master: Create volume attachment during boot from volume in compute https://review.openstack.org/541420
21:48:18 openstackgerrit Eric Fried proposed openstack/nova master: WIP/PoC: Bypass ironicclient for node.get https://review.openstack.org/642899
21:49:34 mriedem efried: now that you're an oslo.policy master https://review.openstack.org/#/c/624185/
21:49:42 efried ayfkm?
21:51:08 melwitt mriedem: speaking of old patches, I have an old patch bug fix that I've been wanting review on, if you could add it to your list. the patch has been verified by an operator https://review.openstack.org/611974
21:51:32 efried mriedem: I'm not touching it until I see lbragstad's +1
21:52:32 mriedem melwitt: that looks like something for lyarwood and/or mdbooth to look at first
21:53:46 mriedem hell or even cfriesen since he reported the bug
21:54:30 melwitt ok. I guess I forgot to ask them
21:56:10 melwitt looks like I added them to the review but didn't bug them. I'll do that
21:56:14 cfriesen I can probably confirm that it works, but I don't know the code
21:56:25 melwitt oh, no I didn't. you did. guh
22:01:20 lbragstad mriedem oh - i forgot about that guy
22:01:30 lbragstad looked again, left comments
22:08:29 mriedem oh boy ok that's enough policy for me for one day
22:23:37 openstackgerrit Sam Morrison proposed openstack/nova-specs master: add spec "flavor-classes" https://review.openstack.org/635408
#openstack-nova - 2019-03-13
00:12:00 openstack Launchpad bug 1819794 in OpenStack Compute (nova) "nova-next job fail on Ubuntu Bionic" [Undecided,New]
00:12:00 gmann nova-next job is failing on Bionic migration. i think for TLS console proxy - https://bugs.launchpad.net/nova/+bug/1819794
00:13:00 gmann Bionic migration will happen tomorrow EOD, either we need to make this job as n-v till fix the issue or fix it before that.
00:14:54 gmann melwitt: efried dansmith bauzas gibi stephenfin ^^ if any one of you know or figure out the issue.
00:15:05 melwitt gmann: thanks. I didn't realize the tls-proxy service was old and to not be used anymore
00:15:57 gmann melwitt: it is enable and working fine for devstack based job but i think nova-next is the only legacy job (running on xenial) which enbale tls-proxy
00:16:25 melwitt we added it as an "easy" way to get tls certs setup in the env, for testing console proxies with tls enabled. BUT, it's been several months that I noticed the job was no longer running console proxies with tls ("cannot find cert") so we're not gaining anything by enabling it for a long time now
00:17:06 gmann yeah it run on xenial. my patch move the job to run on bionic.
00:19:09 gmann rest all legacy job like nova-live-migration, nova-lvm etc run fine but nova-next fail
00:19:40 melwitt ok, I think we need to stop enabling it on nova-next and leave a TODO that we need to find out what's the right way to configure tls certs in test env today
00:20:21 gmann melwitt: ok. let me give try with that if failure is only because of tls cert
00:21:37 melwitt gmann: to be clear, the only reason we were including tls-proxy service was to get the automatic setup tasks that devstack did when it was enabled
00:22:34 gmann melwitt: i see.
00:22:47 melwitt it used to copy the certs to right directories etc. but several months ago, maybe even a year ago, those setup tasks no longer worked and we found our console proxies running without tls (they couldn't find cert that they used to be able to find)
00:23:05 melwitt probably related to the legacy/deprecated nature of tls-proxy service
00:23:45 melwitt so tls-proxy isn't really related directly to our testing in nova-next, so since it's causing a problem, we can take it out. it wasn't helping us anymore anyway
00:23:55 gmann may be, we need to check if it is working in tempest-full. if so then we can wait to move nova-next on devstack based job
00:24:08 gmann sure.
00:24:48 melwitt gmann: nova-next is the only place where we try to test console proxy with tls. because the tls certs etc has to be setup
00:25:15 openstackgerrit Merged openstack/nova master: Allow utime call to fail on qcow2 image base file https://review.openstack.org/641315
00:25:23 openstackgerrit Merged openstack/nova stable/rocky: Handle missing exception in instance creation code https://review.openstack.org/641401
00:25:30 openstackgerrit Merged openstack/nova stable/rocky: Fix WeighedHost logging regression https://review.openstack.org/641355
00:25:31 melwitt we just don't know the right way to do that nowadays. we used to piggyback on tls-proxy to do it
00:26:04 gmann ok
00:26:57 openstackgerrit Ghanshyam Mann proposed openstack/nova master: DNM: Testing nova legacy jobs on bionic https://review.openstack.org/639017
00:27:08 gmann melwitt: ^^ if it work then, i will mark nova OK in https://etherpad.openstack.org/p/legacy-job-bionic
00:27:45 melwitt gmann: OK, sounds good. thanks

Earlier   Later