| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2019-03-12 | |||
| 16:38:44 | mordred | mriedem: ok. happy to help fixing that | |
| 16:39:02 | mriedem | dansmith: that's this part https://github.com/openstack/nova/blob/e608568518ed91a0cbf08f779c5adb851762d80a/nova/conductor/tasks/live_migrate.py#L111 | |
| 16:40:42 | dansmith | mriedem: ack eyah | |
| 16:42:17 | mriedem | so it sounds like you want me to change https://review.openstack.org/#/c/567701/ to at the very least save off the current instance.availabilty_zone before setting it based on the new dest host selection and then if we hit rollback to set it back to the saved off value? | |
| 16:42:27 | mriedem | which would only happen if i guess the rpc cast blew up? | |
| 16:43:15 | mriedem | dansmith: doing it on the compute when we change instance.host is a non-starter if you care about up-calls | |
| 16:44:22 | dansmith | mriedem: you can do it in the cell on the instance :) | |
| 16:44:46 | dansmith | as long as we pass the az into compute so it doesn't have to look it up, which is what I was saying was likely an rpc change | |
| 16:45:21 | dansmith | mriedem: I don't know what I want really.. what you're doing seems wrong, but what I did was equally wrong although slightly less concerning because of how those actions work | |
| 16:45:44 | dansmith | so I dunno, do we justify it with prior sins? | |
| 16:45:45 | mriedem | i can't backport an rpc change | |
| 16:46:32 | openstack | Launchpad bug 1781286 in OpenStack Compute (nova) "CantStartEngineError in cell conductor during reschedule - get_host_availability_zone up-call" [Medium,Triaged] | |
| 16:46:32 | mriedem | we already have several places where we know we need to pass the az down to compute to avoid up-calls https://bugs.launchpad.net/nova/+bug/1781286 | |
| 16:47:40 | mriedem | which reminds me https://review.openstack.org/#/c/581912/ | |
| 16:48:20 | dansmith | how about we just toss a grenade in this mofo and run? | |
| 16:48:47 | mriedem | wfm | |
| 16:50:54 | cfriesen | what's the current behaviour for resizing from a flavor with swap to one without swap? Do we allow it? | |
| 16:51:19 | mriedem | cfriesen: i'm fairly certain you ask this once per quarter | |
| 16:51:25 | mriedem | it's time for a tattoo | |
| 16:51:56 | cfriesen | as of last year it was supposed to work, but one of our testers just said it was busted | |
| 16:52:24 | cfriesen | I'm looking for automated tests of it | |
| 16:52:32 | openstack | Launchpad bug 1762423 in OpenStack Compute (nova) "Resize to swapless flavor still looking for swap" [Low,In progress] - Assigned to jichenjc (jichenjc) | |
| 16:52:32 | mriedem | https://bugs.launchpad.net/nova/+bug/1762423 | |
| 16:53:56 | openstack | Launchpad bug 1552777 in OpenStack Compute (nova) "resizing from flavor with swap to one without swap puts instance into Error status" [Medium,Fix released] - Assigned to Kam Nasim (knasim-wrs) | |
| 16:53:56 | cfriesen | according to my comment at the bottom of https://bugs.launchpad.net/nova/+bug/1552777 it was working in Pike | |
| 16:55:00 | mriedem | cfriesen: were you testing nova or starlingx? | |
| 16:55:46 | cfriesen | mriedem: pretty sure it was devstack, but can't say for sure now | |
| 16:56:51 | mriedem | dansmith: unrelated softball https://review.openstack.org/#/c/642611/ | |
| 16:57:17 | dansmith | *crack* | |
| 17:05:17 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Documentation for bandwidth support https://review.openstack.org/642064 | |
| 17:43:04 | mriedem | efried: i'm mostly ok with https://review.openstack.org/#/c/640879/ but comments inline - the ironicclient valid_interfaces patch | |
| 17:45:27 | mriedem | i don't know if you can wordsmith something in as a code comment and commit message details, or if it's not worth it... | |
| 18:04:28 | openstackgerrit | Matt Riedemann proposed openstack/nova master: RT: replace _instance_in_resize_state with _is_trackable_migration https://review.openstack.org/560467 | |
| 18:09:11 | openstackgerrit | Jeremy Stanley proposed openstack/nova stable/rocky: [DNM] Exercising base-test for a rocky change https://review.openstack.org/642582 | |
| 18:10:15 | mriedem | stephenfin: regarding https://review.openstack.org/#/c/641653/ - if that feature *never worked* since queens, doesn't backporting this stuff now essentially mean we're backporting a feature? | |
| 18:10:39 | openstackgerrit | Jeremy Stanley proposed openstack/nova master: [DNM] Exercising base-test for a master change https://review.openstack.org/642580 | |
| 18:16:21 | openstackgerrit | Jeremy Stanley proposed openstack/nova stable/rocky: [DNM] Exercising base-test for a master change https://review.openstack.org/642582 | |
| 18:17:37 | dansmith | mriedem: hmm.. "claiming will always fail" | |
| 18:18:05 | dansmith | mriedem: I'm trying to figure out what the upgrade impact of this is | |
| 18:21:20 | dansmith | ah, so I guess it's not that terrible upgrade-wise, since we had blob pci requests before without this field | |
| 18:21:28 | dansmith | so this makes us save it, and load it from the request if it's there | |
| 18:21:50 | dansmith | which it might not be because the request was old, or because we were running the code for this and not saving it | |
| 18:22:04 | dansmith | definitely sounds fishy though, I'm not sure how this could have passed tests | |
| 18:22:38 | mriedem | "tests" | |
| 18:22:43 | mriedem | it's enabling a feature as far as i can tell | |
| 18:23:43 | dansmith | I mean according to the bug it doesn't work _at_all_ | |
| 18:24:00 | mriedem | looking back on the blueprint code that merged in queens, the only tests are unit tests | |
| 18:24:51 | dansmith | but I mean, I expected this was being tested on real hardware with an "it's too hard to automate that" sort of justification | |
| 18:25:17 | mriedem | one would hope | |
| 18:25:46 | mriedem | something something this is why we push for at least functional tests with stubs | |
| 18:27:10 | mriedem | dansmith: want to just fast approve this backport https://review.openstack.org/#/c/641401/ | |
| 18:27:15 | mriedem | i'm trying to flush stable queues | |
| 18:27:30 | mriedem | and https://review.openstack.org/#/c/641355/ | |
| 18:28:36 | dansmith | kewwwwwisssshh | |
| 18:29:16 | mriedem | i'm not sure what that sound is, you flushing a toilet? | |
| 18:29:23 | mriedem | oh right, flush | |
| 18:29:24 | mriedem | heh | |
| 18:29:25 | dansmith | um, duh | |
| 18:29:37 | mriedem | at first i was thinking about basketball and sinking a shot... | |
| 18:29:42 | mriedem | i.e. swisssshhh | |
| 18:29:48 | mriedem | but then i thought, "dan making basketball references?" | |
| 18:29:53 | dansmith | hahaah, right | |
| 18:36:42 | mriedem | ok rocky is ready for a few more if some stable cores want to look https://review.openstack.org/#/q/status:open+project:openstack/nova+branch:stable/rocky+label:Code-Review=2 | |
| 18:43:13 | openstackgerrit | Merged openstack/nova master: Share snapshot image membership with instance owner https://review.openstack.org/630769 | |
| 18:57:29 | openstackgerrit | Eric Fried proposed openstack/nova master: pass endpoint interface to Ironic client https://review.openstack.org/640879 | |
| 18:57:33 | efried | mriedem: howzat ^ | |
| 18:58:33 | efried | ah crap, I didn't use enough digits in my change IDs. | |
| 19:00:07 | openstackgerrit | Eric Fried proposed openstack/nova master: pass endpoint interface to Ironic client https://review.openstack.org/640879 | |
| 19:00:12 | efried | mriedem: fixed ^ | |
| 19:00:57 | mriedem | +W thanks | |
| 19:01:22 | efried | thanks | |
| 19:02:33 | mriedem | efried: actually one question about the release note https://review.openstack.org/#/c/640879/11/releasenotes/notes/set-endpoint-interface-for-ironicclient-a0b6b8f8dedc7341.yaml | |
| 19:03:00 | efried | ahcrap, I didn't even look at the reno. | |
| 19:03:11 | dansmith | busted | |
| 19:03:21 | mriedem | time for your spanking | |
| 19:03:45 | efried | considering this isn't my patch, I'd like to bring in my whipping boy. | |
| 19:03:54 | mriedem | the gimp? | |
| 19:04:27 | efried | Is that what he is? I've been thinking of him as "leather ninja" | |
| 19:04:41 | mriedem | hey it's taco tuesday right? https://media.giphy.com/media/ToMjGpHaUPwqzAVaxoI/giphy.gif | |
| 19:05:21 | efried | That's obscene in a way I can't begin to define | |
| 19:05:25 | dansmith | oh...mahgod. | |
| 19:05:54 | dansmith | man mikal just barely missed that one | |
| 19:06:18 | openstackgerrit | Eric Fried proposed openstack/nova master: pass endpoint interface to Ironic client https://review.openstack.org/640879 | |
| 19:06:21 | efried | mriedem: ^ | |
| 19:08:40 | openstackgerrit | Matt Riedemann proposed openstack/nova master: pass endpoint interface to Ironic client https://review.openstack.org/640879 | |
| 19:08:47 | mriedem | let's all touch that patch | |
| 19:11:29 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Require python-ironicclient>=2.7.0 https://review.openstack.org/642863 | |
| 19:11:31 | mriedem | efried: right? ^ | |
| 19:12:28 | efried | mriedem: in master only, yeah. | |
| 19:13:39 | efried | +2 | |
| 19:14:29 | efried | o right, we load ironicclient dynamically, swhy it's not in requirements.txt | |
| 19:36:11 | cfriesen | I assume this is a test-tool problem, not a problem with my change? http://logs.openstack.org/63/631363/22/check/nova-grenade-live-migration/1a03cbc/job-output.txt.gz#_2019-03-11_07_51_09_359608 | |
| 19:36:48 | mriedem | it means live migration failed | |
| 19:36:54 | mriedem | u'status': u'error' | |
| 19:37:29 | mriedem | http://logs.openstack.org/63/631363/22/check/nova-grenade-live-migration/1a03cbc/logs/screen-n-cpu.txt.gz?level=TRACE#_Mar_11_07_50_39_506220 | |
| 19:40:57 | mriedem | cfriesen: so yeah i assume that's not your fault | |
| 19:41:02 | mriedem | libvirt randomly puked | |
| 19:44:40 | melwitt | mriedem: yeah, I guess you're right it's latent since rocky | |
| 20:12:09 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Don't warn on network-vif-unplugged event during live migration https://review.openstack.org/642877 | |
| 20:15:11 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Don't warn on network-vif-unplugged event during live migration https://review.openstack.org/642877 | |