Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2019-03-07
19:53:25 dansmith # The process group for a foreground process will match the
19:54:02 dansmith if systemd is running us with a pty for stdio, that will assume we're in interactive mode and say we're not a daemon, which means sighup->restarts (for some reason which I'm not even sure is legit)
19:54:28 mnaser ok let me just drop that python code in a simple systemd unit and see what happens
19:58:11 dansmith also would be useful to just take a system running like this and put a debug print() in that thing to see if we're returning !daemon for any reason
19:59:51 mnaser bleh, returning true
20:00:51 mnaser http://paste.openstack.org/show/747426/
20:01:19 dansmith not sure that's a really legit test,
20:01:31 dansmith because any other service startup stuff could impact that
20:01:44 dansmith like chdir(), close existing fds, logging setup, etc
20:01:56 dansmith I think it'd be more useful to just instrument a misbehaving openstack service
20:01:59 mnaser ok so let me do it on a machine i have here then
20:02:03 mnaser on an actual nova-compute
20:04:28 mnaser _is_sighup_and_daemon: True
20:04:50 mnaser which means
20:04:56 mnaser if not True: .. so it doesn't break and does a restart
20:05:05 mnaser wait what, shouldn't that be if _is_sighup_and_daemon(signo): break ?
20:05:26 mnaser given that we don't want to restart if we get a sighup and running in daemon mode?
20:06:22 dansmith hrm, yeah
20:06:25 mnaser https://github.com/openstack/oslo.service/commit/94e76035c627e003f601c6501c0f414a13160f1f#diff-49ecd82bf041c1fd494a0bc4a96782deR195
20:06:28 dansmith tbh, I don't know why this logic is here regardless
20:06:55 dansmith ...newton
20:07:00 mnaser yeah it's been a hot minute
20:07:05 mnaser lol
20:07:05 mnaser i really hope it hasn't been broken that whole time
20:07:15 dansmith that was around the time of the great systemdification of devstack, and because sdague
20:07:17 dansmith so really fishy
20:07:26 dansmith but sounds like something is broken to me
20:08:05 mnaser ok ill try to ping doug
20:09:19 dansmith I don't really agree with the assertion made in the commit message of that
20:09:33 dansmith because it assumes that we're only a long-lived service if we've daemonized ourselves
20:09:59 dansmith mnaser: also note that systemd can handle self-daemonizing services, so it depends on how your particular unit is running nova-compute too
20:11:08 mnaser dansmith: yeah, afaik we use type=simple so it's the "run in foreground mode forever" model
20:11:15 dansmith ack
20:11:46 openstackgerrit Artom Lifshitz proposed openstack/nova master: Dont' wait for VIF plugging during revert resize https://review.openstack.org/639396
20:12:09 dansmith mnaser: assume you don't have a bug open for this yet right?
20:19:22 mriedem someone should uh, put some time into figuring out what to do about this old ass statement https://github.com/openstack/nova/blob/master/nova/compute/resource_tracker.py#L1380
20:19:47 mnaser bug
20:19:53 mnaser gah ctrl+f doesnt exist i guess
20:25:56 openstackgerrit Chris Dent proposed openstack/nova master: Integration tests using gabbi-tempest https://review.openstack.org/613386
20:26:57 openstackgerrit Matt Riedemann proposed openstack/nova master: Remove unused context parameter from RT._get_instance_type https://review.openstack.org/641792
20:41:05 openstackgerrit Merged openstack/nova master: Separate methods to free claimed and allocated devs https://review.openstack.org/616120
21:10:47 openstackgerrit Matt Riedemann proposed openstack/nova master: Update usage in RT.drop_move_claim during confirm resize https://review.openstack.org/641806
21:13:34 openstackgerrit Matt Riedemann proposed openstack/nova master: Update usage in RT.drop_move_claim during confirm resize https://review.openstack.org/641806
21:16:09 mikal Given the sudden burst of interest in the privsep patches, is it worth asking for a FFE?
21:17:45 mriedem nope
21:17:54 mikal Fair enough.
21:18:04 mikal I wont rush to deal with new review comments then.
21:19:31 openstackgerrit Matt Riedemann proposed openstack/nova master: Set min=0 for block_device_allocate_retries option https://review.openstack.org/641770
21:19:57 mriedem mikal: i don't mean to be terse, we just have 2 weeks to rc1 and a lot of other stuff to focus on.
21:20:38 mikal mriedem: sure. So I'll just go back to pottering along at my own pace and being mildly surprised when something merges.
21:24:24 mriedem efried: i'm not sure how i feel about linking to release-specific docs
21:24:30 mriedem since those are only published for so long
21:27:10 efried mriedem: responded. I'm fine either way, hence the +2.
21:27:23 efried mriedem: Add 'h' in https://review.openstack.org/#/c/641770/ and I'm +2 there too.
21:32:24 openstackgerrit Matt Riedemann proposed openstack/nova master: Set min=0 for block_device_allocate_retries option https://review.openstack.org/641770
21:33:52 mriedem dansmith: jaypipes: looks like the nova-grenade-live-migration playbook change screwed up mel's series in the gate, so i'm going to rebase and re-approve, just fyi
21:34:19 openstackgerrit Matt Riedemann proposed openstack/nova master: Add user_id column to the instance_mappings table https://review.openstack.org/633349
21:34:20 openstackgerrit Matt Riedemann proposed openstack/nova master: Populate InstanceMapping.user_id during migrations and schedules https://review.openstack.org/638574
21:34:20 openstackgerrit Matt Riedemann proposed openstack/nova master: Add user_id field to InstanceMapping https://review.openstack.org/633350
21:34:21 openstackgerrit Matt Riedemann proposed openstack/nova master: Add online data migration for populating user_id https://review.openstack.org/633351
21:38:45 mriedem artom: replied in https://review.openstack.org/#/c/641806/
21:38:49 mriedem but good questions
21:41:55 mriedem this RT code dealing with adding/removing usage from flavors during a resize is way too f'ing magical
21:42:11 mriedem and i've done too much staring at it while working on the cross-cell resize stuff
21:42:34 mriedem it also *loves* to fail silently
21:42:41 mriedem SBD
21:42:47 dansmith mriedem: ack
21:45:53 openstackgerrit Adam Spiers proposed openstack/nova master: Add detection of SEV support from QEMU/AMD-SP/libvirt on AMD hosts https://review.openstack.org/633855
21:46:11 openstackgerrit Adam Spiers proposed openstack/nova master: Add new "supports_amd_sev" capability to libvirt driver https://review.openstack.org/638680
21:51:38 jaypipes mriedem: ++
21:51:46 jaypipes mriedem: and thank you
22:15:39 cfriesen is it a known issue that during a resize/migrate the resource audit will choke trying to find the instance disk on the source node?
22:25:29 mriedem i think so
22:25:38 mriedem i've tried to whack that mole before
22:27:53 mriedem cfriesen: https://review.openstack.org/#/q/Icec2769bf42455853cbe686fb30fda73df791b25
22:28:36 mriedem cfriesen: https://bugs.launchpad.net/nova/+bug/1774249 is the resize sister to that
22:28:37 openstack Launchpad bug 1774249 in OpenStack Compute (nova) "update_available_resource will raise DiskNotFound after resize but before confirm" [Medium,In progress] - Assigned to Vladyslav Drok (vdrok)
22:29:19 mriedem vdrok: are you working on a fix for ^?
22:37:38 openstackgerrit Adam Spiers proposed openstack/nova master: Use assertXmlEqual() helper for all XML comparison tests https://review.openstack.org/641852
22:41:38 cfriesen anyone else run into issues with unstack.sh hanging in neutron_ovs_base_cleanup?
22:44:24 cfriesen I had to repeatedly ctrl-C it and rerun it...it was like it wasn't realizing that the command had finished
22:47:25 gmann mriedem: lyarwood FYI: tempest-slow (voting) and tempest-multinode-full(n-v) are running on stable branch gate also - http://lists.openstack.org/pipermail/openstack-discuss/2019-March/003604.html
22:48:15 mriedem cfriesen: unstack is not maintained as far as i know
22:48:33 mriedem gmann: yeah i saw that email but hadn't parsed it yet
22:49:23 gmann mriedem: ssh issue has been fixed on stable branch which i talked to you few days back. now all good and they are running on stable branch too
22:49:41 mriedem what was the ssh issue?
22:50:40 gmann few of the backport fixes - passwordless ssh with stack between nodes
22:59:16 mriedem prepare for impact
22:59:51 openstackgerrit Matt Riedemann proposed openstack/nova master: Add functional recreate test for bug 1818914 https://review.openstack.org/641521
22:59:53 openstackgerrit Matt Riedemann proposed openstack/nova master: Improve CinderFixtureNewAttachFlow https://review.openstack.org/639382
22:59:53 openstackgerrit Matt Riedemann proposed openstack/nova master: Fix ProviderUsageBaseTestCase._run_periodics for multi-cell https://review.openstack.org/641179
22:59:53 openstackgerrit Matt Riedemann proposed openstack/nova master: Update usage in RT.drop_move_claim during confirm resize https://review.openstack.org/641806
22:59:53 openstackgerrit Matt Riedemann proposed openstack/nova master: Remove unused context parameter from RT._get_instance_type https://review.openstack.org/641792
22:59:53 openstack bug 1818914 in OpenStack Compute (nova) "Hypervisor resource usage on source still shows old flavor usage after resize confirm until update_available_resource periodic runs" [Low,In progress] https://launchpad.net/bugs/1818914 - Assigned to Matt Riedemann (mriedem)
22:59:54 openstackgerrit Matt Riedemann proposed openstack/nova master: Add InstanceAction/Event create() method https://review.openstack.org/614036
22:59:54 openstackgerrit Matt Riedemann proposed openstack/nova master: Add Migration.cross_cell_move and get_by_uuid https://review.openstack.org/614012
22:59:55 openstackgerrit Matt Riedemann proposed openstack/nova master: Add TargetDBSetupTask https://review.openstack.org/627892
22:59:55 openstackgerrit Matt Riedemann proposed openstack/nova master: Add Instance.hidden field https://review.openstack.org/631123
22:59:56 openstackgerrit Matt Riedemann proposed openstack/nova master: Execute TargetDBSetupTask https://review.openstack.org/633853
22:59:56 openstackgerrit Matt Riedemann proposed openstack/nova master: Add CrossCellMigrationTask https://review.openstack.org/631581

Earlier   Later