Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2019-03-07
15:26:54 mriedem kashyap: uh...
15:27:08 mriedem kashyap: if that change isn't going to land in stein, the spec has to be re-proposed for train anyway,
15:27:20 mriedem so why not just make that change in the re-proposed spec with a note in the history abou the change?
15:28:03 kashyap Whatever works; alex_xu was also onboard with the above, FWIW.
15:28:09 kashyap mriedem: Will it / can it land for Stein?
15:28:37 kashyap mriedem: So, to be clear: you want me to repropose the whole spec fo Train?
15:28:44 mriedem kashyap: it would have to merge today
15:28:57 kashyap mriedem: Ah ... right, the freeze
15:29:14 mriedem i see alex_xu and stephenfin were reviewing it, but stephenfin was only reviewing docs
15:29:17 mriedem it looks like
15:29:36 kashyap See Alex's comment on line 548.
15:30:05 stephenfin Nah, it was just the docs/config opt naming that I had comments on
15:30:11 stephenfin rest of it is noddy
15:30:14 stephenfin (IMO)
15:31:00 kashyap stephenfin: Did you see this: https://review.openstack.org/#/c/640866/3
15:31:04 kashyap dansmith: LOL
15:31:30 kashyap dansmith: Typing: 'define noddy' in Google shows this:
15:31:39 kashyap (1) [DATED] a foolish person.
15:31:46 kashyap (2) a tropical tern with mainly dark-coloured plumage.
15:31:56 stephenfin oops. noddy = easy or simple
15:32:10 dansmith kashyap: yes, I know how to use google and did.. still don't know
15:32:33 kashyap dansmith: Wasn't daring to tell you to LMGTFY ... just sharing the amusement
15:32:41 dansmith stephenfin: as in "something you nod (in agreement) at" ?
15:32:58 kashyap (That's how I read it)
15:32:58 dansmith stephenfin: homonym-wise, sounds like "naughty" as in "not good"
15:33:29 mriedem i want to say something about being offended as an american that i don't understand the language being used here
15:33:34 stephenfin I guess? I've never really though about it, to be honest
15:33:55 mriedem and how i need to take to social media to express my language victimizatoin
15:33:57 mriedem *ion
15:34:10 kashyap mriedem: Do you do social media besides IRC? I doubt that
15:34:20 dansmith I could sue stephenfin in portland for micro-aggression
15:34:35 dansmith (and probably win)
15:34:45 kashyap Yes, you will be quarantined into a "safe space"
15:35:02 mriedem kashyap: i have a linkedin account
15:35:05 mriedem does that count?
15:35:23 dansmith and he treats it like facebook
15:35:23 kashyap mriedem: Nah ... unless you're actively talking about marketecture there
15:35:39 mriedem dansmith claims to be an angry old man, but i think i have him beat
15:35:41 dansmith mriedem: so what's the deal with the user_id patch? what's the plan?
15:35:52 dansmith I don't want to be around late into the afternoon dealing with this
15:36:28 mriedem dansmith: i agree with what you said earlier,
15:36:29 mriedem "(8:49:57 AM) dansmith: mriedem: yeah I think we've been over that before.. definitely doesn't seem like something we can change on a whim regardless of the reason"
15:36:50 dansmith so, we add user_id, and user_id/project_id then yeah?
15:37:21 mriedem if we assume the server group member quota count is going to continue to be user_id only yeah
15:37:33 mriedem even if we don't, the additional index doesn't hurt does it?
15:37:37 mriedem jaypipes: ^
15:37:39 dansmith no
15:37:58 jaypipes no, it doesn't really hurt anyuthing
15:38:07 dansmith I've got the set pulled down, I'll fix up the index
15:38:12 mriedem ok so the actual counting functions later in the series don't need to merge in stein
15:38:55 dansmith right, so maybe I'll just orphan them
15:40:36 mriedem sure
15:40:41 mriedem i'm targeting to get to https://review.openstack.org/#/c/633351/
15:49:33 jaypipes +1
15:52:19 bauzas mriedem: thanks for giving us the path to the legacy job for comparing, it helps
15:52:27 bauzas context being https://review.openstack.org/#/c/640181
15:53:15 openstackgerrit Dan Smith proposed openstack/nova master: Add user_id field to InstanceMapping https://review.openstack.org/633350
15:53:15 openstackgerrit Dan Smith proposed openstack/nova master: Add user_id column to the instance_mappings table https://review.openstack.org/633349
15:53:16 openstackgerrit Dan Smith proposed openstack/nova master: Add online data migration for populating user_id https://review.openstack.org/633351
15:53:16 openstackgerrit Dan Smith proposed openstack/nova master: Populate InstanceMapping.user_id during migrations and schedules https://review.openstack.org/638574
15:54:19 bauzas mriedem: I guess you just copy/pasted the job definition YAML ?
15:54:57 bauzas or do I really need to do my job and diff the files ?
15:56:29 sean-k-mooney luksky: sorry i was on a call. im just runnig to another one but you only need to run discover hosts wehn you add new nodes
15:57:07 efried mriedem, bauzas: done
15:57:18 sean-k-mooney luksky: and you only need to run nova-manage cellv2 discover_hosts on the contoler nodes not on the compute nodes
16:02:46 mriedem dansmith: i just went through https://review.openstack.org/#/c/633351/24 again while you rebased, see if my comments make sense
16:03:05 mriedem bauzas: yes i copied the playbook
16:03:10 mriedem and changed the name/description
16:03:53 bauzas mriedem: yeah so blame on you, you forced me to diff
16:04:19 jaypipes dansmith: sorry if I wasn't clear about the multi-column index earlier.
16:04:49 jaypipes dansmith: I've added a comment to the revision you just pushed. If we go with a (user_id, project_id) multi-column index, there's no need for a single-column (user_id) index.
16:05:08 dansmith jaypipes: oh I was sure you said to add both
16:06:08 jaypipes dansmith: tried to explain in that comment, sorry. if you added a (project_id, user_id) index, you'd also want a (user_id) single-column index.
16:06:27 dansmith wait, what?
16:06:39 dansmith oh, it matters the ordering of them?
16:06:45 jaypipes dansmith: yep
16:06:49 dansmith jesus
16:06:52 jaypipes :)
16:06:58 dansmith so, surely these will also be looked up via project only right?
16:07:06 dansmith oh, but we already have one on project
16:07:07 dansmith okay
16:07:12 jaypipes yes, but there is already a single-column on (project_id)
16:07:16 jaypipes single-column index
16:07:18 jaypipes yeagh
16:08:05 jaypipes dansmith: good article on the concepts here: https://www.vividcortex.com/blog/the-left-prefix-index-rule
16:08:48 luksky <sean-k-mooney>: thank You
16:08:52 dansmith jaypipes: don't push your progressive indexes on me
16:09:03 jaypipes heh :)
16:09:12 jaypipes dansmith: sorry for the misunderstanding
16:09:32 dansmith I guess I have to update this test now and fix the nova-manage too
16:14:42 openstackgerrit Balazs Gibizer proposed openstack/nova master: Use Selection object to fill request group mapping https://review.openstack.org/638711
16:20:36 mriedem efried: +1 thanks
16:21:25 mriedem stephenfin: this has you written all over it https://review.openstack.org/#/c/640181/
16:21:56 stephenfin sure thing
16:25:46 efried mriedem: updated with more information (mostly copy/paste) in the commit message.
16:27:25 openstackgerrit Matt Riedemann proposed openstack/nova master: Allow utime call to fail on qcow2 image base file https://review.openstack.org/641315
16:27:41 mriedem mdbooth: do you fancy addressing review comments on https://review.openstack.org/#/c/641315/ ?
16:27:51 mriedem i'd like to make sure people are on board with that before approving your revert
16:28:45 mriedem efried: beautiful
16:28:58 openstackgerrit Dan Smith proposed openstack/nova master: Add user_id column to the instance_mappings table https://review.openstack.org/633349

Earlier   Later