| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2019-03-07 | |||
| 12:06:44 | openstackgerrit | Michael Still proposed openstack/nova master: Cleanup the _execute shim in nova/network. https://review.openstack.org/639581 | |
| 12:06:45 | openstackgerrit | Michael Still proposed openstack/nova master: Cleanup no longer required filters and add a release note. https://review.openstack.org/639826 | |
| 12:52:04 | openstackgerrit | Stephen Finucane proposed openstack/nova stable/rocky: tests: Move mocking to setUp https://review.openstack.org/641651 | |
| 12:52:05 | openstackgerrit | Stephen Finucane proposed openstack/nova stable/rocky: objects: Store InstancePCIRequest.numa_policy in DB https://review.openstack.org/641653 | |
| 12:52:05 | openstackgerrit | Stephen Finucane proposed openstack/nova stable/rocky: tests: Create functional libvirt test base class https://review.openstack.org/641652 | |
| 12:56:16 | artom | ~o~ | |
| 13:00:29 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Test macvtap port with resource request https://review.openstack.org/641309 | |
| 13:09:11 | openstackgerrit | Surya Seetharaman proposed openstack/nova master: Delete orphaned RS and IM records of archived instances https://review.openstack.org/560042 | |
| 13:23:56 | yaawang | kashyap: Hi, will you continue doing https://review.openstack.org/#/c/640866/? I want to fix some pep8 issues to pass the test :) | |
| 13:27:31 | kashyap | yaawang: Oh, yes. Let me fix that right away | |
| 13:27:34 | kashyap | yaawang: Sorry :-) | |
| 13:28:16 | yaawang | kashyap: thk :) | |
| 13:31:20 | mriedem | gibi: are you running today's meeting? | |
| 13:31:31 | gibi | mriedem: yes, I can do that | |
| 13:32:11 | gibi | mriedem: I read that melwitt is not here today, and that you will take care of the FF | |
| 13:33:43 | mriedem | yeah that's why i was wondering who was running the meeting | |
| 13:34:23 | gibi | mriedem: if you would like to run the meeting too then I have no problem with that either | |
| 13:34:40 | mriedem | i shouldn't since i have to get my kid to the bus in about an hour | |
| 13:34:51 | gibi | mriedem: OK, then I will run it | |
| 13:35:02 | mriedem | thanks | |
| 13:35:06 | gibi | np | |
| 13:36:04 | jaypipes | guten morgen | |
| 13:37:11 | mriedem | maybe i should make efried do all the FF stuff today... | |
| 13:37:17 | mriedem | jaypipes: question about indexes for you | |
| 13:37:30 | mriedem | jaypipes: in https://review.openstack.org/#/c/633349/ | |
| 13:37:40 | mriedem | need to add just a user_id index or both user_id + project_id | |
| 13:37:41 | efried | mriedem: I would be down, with coaching. | |
| 13:37:56 | openstackgerrit | Boxiang Zhu proposed openstack/nova master: Raise error when force_raw_images and images_type are incompatible https://review.openstack.org/640271 | |
| 13:38:28 | mriedem | efried: well the good news is we don't do milestone tags anymore so there is no need to tag s-3 for nova, right smcginnis? | |
| 13:38:37 | mriedem | mel already released osc-placement last night, | |
| 13:38:47 | mriedem | so i think the only release we have today is novaclient | |
| 13:39:17 | efried | okay, just propose a novaclient release? | |
| 13:39:31 | mriedem | yeah, will need this first https://review.openstack.org/#/c/637234/ | |
| 13:39:35 | efried | ...after checking if there's anything... yeah | |
| 13:41:36 | openstackgerrit | Merged openstack/python-novaclient master: Add support for microversion v2.72 https://review.openstack.org/637234 | |
| 13:42:14 | gibi | and it is merged ^^ | |
| 13:43:07 | openstackgerrit | Kashyap Chamarthy proposed openstack/nova-specs master: cpu-model-selection: s/cpu_models/cpu_model_list/ https://review.openstack.org/640866 | |
| 13:43:14 | kashyap | yaawang: ^ Hope that fixes it | |
| 13:43:34 | jaypipes | mriedem: answered. | |
| 13:43:49 | jaypipes | mriedem: fine to put a single index on user_id. was a good catch from dansmith | |
| 13:44:08 | jaypipes | mriedem: in a future patch, we can add a dual index if that is something we see is needed. | |
| 13:44:45 | jaypipes | mriedem: as melwitt stated, the server group members query is on user only, not project, so a dual index on (project_id, user_id) would not help that query. | |
| 13:45:21 | mriedem | jaypipes: but this one does use both https://review.openstack.org/#/c/638072/17/nova/objects/instance_mapping.py@407 | |
| 13:45:47 | jaypipes | ffs... | |
| 13:46:05 | mriedem | so i guess we'd want a user_id and user_id+project_id index? | |
| 13:46:19 | jaypipes | mriedem: no, it doesn't actually. | |
| 13:46:25 | jaypipes | mriedem: it's two queries :( | |
| 13:46:40 | jaypipes | mriedem: that ffs wasn't directed at you. | |
| 13:46:55 | jaypipes | mriedem: each .scalar() is a sep query. | |
| 13:47:00 | mriedem | yeah i realize | |
| 13:47:11 | mriedem | this is a pattern in the quota qounting query code... | |
| 13:47:13 | mriedem | in a few places | |
| 13:47:19 | jaypipes | oh, I see.. | |
| 13:47:25 | jaypipes | hrmph | |
| 13:48:36 | jaypipes | mriedem: ok, well if the pattern is that user_id is always queries along with project_id, then yes, the index should be on (project_id, user_id) | |
| 13:49:06 | mriedem | well project_id isn't always in there https://review.openstack.org/#/c/638324/19/nova/objects/instance_mapping.py@466 | |
| 13:49:57 | mriedem | the first one above is a replacement for the "instances" quota counting which is over project and user, | |
| 13:50:09 | mriedem | the latter is the server group members query which is just on user_id | |
| 13:50:20 | mriedem | "server_group_members" quota count query i should say | |
| 13:50:22 | jaypipes | does it need to be, though? | |
| 13:50:37 | jaypipes | in other words, can we add a project filter to the query? | |
| 13:50:40 | openstackgerrit | ya.wang proposed openstack/nova master: Select cpu model from a list of cpu models https://review.openstack.org/637834 | |
| 13:50:58 | gibi | nova meeting starts in 9 minutes on #openstack-meeting | |
| 13:50:59 | mriedem | server group member quota is enforced at the user, not project, level | |
| 13:51:22 | mriedem | jaypipes: https://github.com/openstack/nova/blob/master/nova/quota.py#L1075 | |
| 13:52:42 | bauzas | any urgent code review before FF ? | |
| 13:52:53 | bauzas | I looked at the etherpad, but it's a bit messy :( | |
| 13:53:10 | mriedem | it is yes | |
| 13:53:14 | bauzas | disclaimer: long series can't be honestly reviewed | |
| 13:53:17 | mriedem | i'm just trying to sort out the index question on https://review.openstack.org/#/c/633349/ | |
| 13:53:28 | jaypipes | good lord that is an expensive quota check :( | |
| 13:53:45 | mriedem | i don't know if we'll try to merge part of this instance mapping user_id series or not | |
| 13:54:00 | mriedem | it's getting to be too late to be having these types of questions | |
| 13:54:18 | bauzas | mriedem: do you want some other eye's lookup ? | |
| 13:54:59 | bauzas | I saw this series in the etherpad, but I was thinking it was a bit difficult to review it by only 6 hours | |
| 13:55:08 | openstackgerrit | Rodolfo Alonso Hernandez proposed openstack/nova-specs master: Boot a VM with an unaddressed port https://review.openstack.org/641670 | |
| 13:55:16 | mriedem | the bottom 4-5 changes have had a lot of review from me and dansmith actually | |
| 13:55:30 | bauzas | there is a -W from melwitt, can we still review ? | |
| 13:55:40 | jaypipes | mriedem: is there a technical reason why we couldn't still filter by project as well as user on that server group members quota query? | |
| 13:55:52 | mriedem | bauzas: that was procedural while waiting for approval of the changes above | |
| 13:55:54 | jaypipes | (seems like it's just a mistake in the original code) | |
| 13:56:04 | bauzas | mriedem: okay, then I'll look | |
| 13:56:41 | mriedem | jaypipes: i don't think it's an oversight | |
| 13:56:55 | jaypipes | mriedem: why not? | |
| 13:57:03 | mriedem | anyway, i wouldn't want to have to go down that rathole on FF | |
| 13:57:10 | jaypipes | ack | |
| 13:57:48 | mriedem | i'd have to dig into when server group member quota was added | |
| 13:57:57 | mriedem | we do have some per-user quota checks on purpose, | |
| 13:57:59 | mriedem | like keypairs i think | |
| 13:59:19 | mriedem | efried: https://review.openstack.org/#/c/637234/ is merged now if you want to start a novaclient release, or after the meeting | |
| 13:59:33 | efried | argh, meeting, thanks for the reminder. | |
| 13:59:38 | efried | mriedem: was just starting the release. | |
| 14:01:00 | jaypipes | mriedem: I understand the keypairs being user_id-specific. not so much the server groups one. | |
| 14:09:10 | efried | mriedem: So microversion parity changes don't count as major bump-worthy? | |
| 14:09:32 | mriedem | efried: no, since they are opt-in features | |
| 14:09:39 | mriedem | major is for backward incompatible changes | |
| 14:09:43 | efried | okay. | |
| 14:09:45 | mriedem | semver baby | |
| 14:10:12 | openstackgerrit | Rodolfo Alonso Hernandez proposed openstack/nova-specs master: Boot a VM with an unaddressed port https://review.openstack.org/641670 | |
| 14:18:53 | mriedem | yikun: efried: i saw yikun posted a topic proposal for nova/cyborg integration https://etherpad.openstack.org/p/DEN-train-nova-brainstorming - question is if that should be a forum or ptg session? it might be fine to have both. | |