| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2019-03-06 | |||
| 19:36:08 | dansmith | I haven't gotten to any of the actual counting stuff | |
| 19:36:19 | dansmith | I figure best case, | |
| 19:36:28 | dansmith | we merge the data model and migration stuff | |
| 19:36:42 | dansmith | so we can get the things migrated in stein and then we're looking at train for the actual counting stuff | |
| 19:36:52 | dansmith | as I haven't looked over any of that other than to go answer one question for myself | |
| 19:37:00 | melwitt | +1 my initial thought is to be conservative and count the queued_for_delete=None ones | |
| 19:37:53 | mriedem | yeah i haven't gotten into the api changes that actually use the new counting stuff, and at this rate it's too late for me to be comfortable with that, | |
| 19:38:00 | mriedem | so i'd be happy to get the data model change and migration in stein | |
| 19:38:05 | mriedem | so there is less to migrate in train | |
| 19:38:32 | dansmith | yeah, having it migrated in stein before makes that stuff a lot better | |
| 19:38:39 | melwitt | I can't argue with that. it's a bummer, but I take responsibility for not having this all ready for review earlier in the cycle | |
| 19:39:36 | melwitt | I appreciate the review you're doing now and glad to be able to land some of it because of it | |
| 19:40:24 | melwitt | s/some of it/the migration stuff/ | |
| 19:44:38 | melwitt | I don't know why, but the whole unset non-nullable ovo field thing really confuses me :x | |
| 19:45:19 | dansmith | I don't know why either :) | |
| 19:45:40 | melwitt | :P | |
| 19:50:00 | mriedem | melwitt: i'm +2 on the rbd extend volume change now https://review.openstack.org/#/c/613039/ | |
| 19:51:22 | melwitt | +W | |
| 19:56:08 | dansmith | melwitt: comment for you on the base patch.. I dare not -1 against that raft of positive votes, but.. genuine question | |
| 19:58:04 | melwitt | dansmith: good question -- I think probably so. we added indexes for the quotas re-work in pike | |
| 19:58:21 | dansmith | YES | |
| 19:58:34 | dansmith | oh sweet sweet -1 vote | |
| 19:58:41 | melwitt | hah | |
| 19:58:53 | melwitt | I'd ask jaypipes to confirm but he's not around atm | |
| 19:59:38 | dansmith | it should be free to add since it's defaulted to null at add time, so .. I can't really imagine we don't want one | |
| 20:01:22 | melwitt | yeah...I'll see what the indexes look like for the current counting stuff we have and model after that. I don't know that much about database stuff | |
| 20:04:00 | dansmith | should be fairly straightforward..nothing really to configure afaik | |
| 20:06:18 | openstackgerrit | Merged openstack/nova master: Test live migration with config drive https://review.openstack.org/567860 | |
| 20:06:33 | melwitt | dansmith: IIUC, we would need two right? one on project_id and one that is on project_id and user_id? | |
| 20:07:33 | dansmith | I'm not sure you need both, but maybe.. I guess I would think one on each is as good as one on (a) and one on (a,b) but not positive | |
| 20:08:24 | dansmith | I was focused on the userid bit, but since I haven't really looked at how this is used, I wasn't thinking about it being queried as (a,b) | |
| 20:08:33 | dansmith | so yeah maybe.. Guess we do need some expertise | |
| 20:08:38 | melwitt | I think I'm thinking that because of what jaypipes recommended to be done on the consumers table: https://github.com/openstack/nova/blob/master/nova/db/sqlalchemy/api_models.py#L646-L648 | |
| 20:09:01 | melwitt | if the queries are going to be project_id and project_id + user_id | |
| 20:09:30 | dansmith | right, but there isn't a bare one on project there, just composite ones | |
| 20:09:42 | dansmith | but yeah I dunno | |
| 20:09:47 | melwitt | yeah, true | |
| 20:10:50 | melwitt | I'm not sure there's another example. but yeah the pattern is going to be (a) and (a,b) | |
| 20:16:20 | efried | mriedem: done | |
| 20:16:55 | efried | sean-k-mooney: not at all surprised it failed, good deal that it's hitting the changes. Thanks again. | |
| 20:18:40 | sean-k-mooney | efried: it looks like the functional job that runs the ironic api tempest test dose not help so you could drop that job | |
| 20:19:17 | efried | sean-k-mooney: I guess it "proves" (or at least suggests) that I didn't f up backward compatibility | |
| 20:19:27 | efried | assuming of course that the func tests actually exercise the paths I dorked with. | |
| 20:19:56 | sean-k-mooney | ya i guess. | |
| 20:21:02 | sean-k-mooney | im just going to go grab some gorceries. ill be back online a bit later | |
| 20:22:00 | efried | wow, grocery stores are open after 6pm? Things have changed since I lived over there:) | |
| 20:22:28 | cdent | efried: the best part is that the sign says "open 24 hours" | |
| 20:22:36 | cdent | but it means except saturday evening or sunday | |
| 20:23:03 | efried | heh | |
| 20:23:21 | cdent | I have anger about that because there was this one, not at band camp, when I needed to pee | |
| 20:23:49 | cdent | and because I saw the "24 hours" I had let myself relax that little bit you do when you know that safety approaches | |
| 20:23:52 | cdent | but no | |
| 20:25:30 | efried | mriedem: Popping https://review.openstack.org/#/c/639854/ off the stack - did you say you were going to address both issues in a fup (and therefore consider this one done)? | |
| 20:26:11 | efried | if you're loaded I can do it, no biggie | |
| 20:26:15 | efried | (and by loaded I mean...) | |
| 20:27:15 | mriedem | i can't hardly stand | |
| 20:27:46 | mriedem | so i was going to start working on a fup patch for some of my comments in the earlier reshaper patches and then stack yours on top of that, but then ran out of steam to start doing that yesterday, | |
| 20:27:57 | mriedem | and really kind of need to be working more on the cross-cell stuff | |
| 20:28:04 | mriedem | so if you're looking for fun things to fup on, go nuts | |
| 20:29:46 | efried | fup my nuts | |
| 20:33:46 | openstackgerrit | Chris Friesen proposed openstack/nova master: Add missing libvirt exception during device detach https://review.openstack.org/641480 | |
| 20:34:42 | cfriesen | melwitt: this is for the bug you took a look at a few weeks ago. ^ | |
| 20:34:43 | mriedem | whoa | |
| 20:35:07 | melwitt | cfriesen: ack | |
| 20:35:17 | melwitt | on my list | |
| 20:42:33 | openstackgerrit | Eric Fried proposed openstack/nova master: Test proper allocation of devices during reshape https://review.openstack.org/639854 | |
| 20:42:45 | efried | mriedem: There's that one with the implicit comma thingy removed. | |
| 20:42:58 | efried | now fupping helper method for mdev name | |
| 20:44:46 | mriedem | efried: did you see my comment about that earlier in the series? | |
| 20:45:02 | mriedem | https://review.openstack.org/#/c/599208/18/nova/virt/libvirt/driver.py@6835 | |
| 20:45:11 | efried | yes | |
| 20:45:13 | mriedem | i think we should just make _get_mediated_device_information handle the dash to underscore conversion | |
| 20:45:21 | mriedem | so the caller (like your test) doesn't need to care | |
| 20:45:24 | efried | ack | |
| 20:46:54 | mriedem | do you want to just also fix those temporarily/PR typos in the test code in the same change as your test wrinkle or a new generic follow up? | |
| 20:46:58 | efried | mriedem: one caller only has the name. Want the method to be smart and figure out which one it got, or take one of two kwargs, or... | |
| 20:47:35 | mriedem | i don't follow | |
| 20:48:24 | efried | _get_mediated_device_information is called in two places. In one of them, the one you pointed out, I have the UUID and convert to the name, which is the part that sucks. In the other, I only have the name and would have to do the reverse if I wanted the arg to be uuid. | |
| 20:48:25 | mriedem | i guess you could add a helper method if that's more clear | |
| 20:49:06 | mriedem | i figured at the start of _get_mediated_device_information it would just dev_name = dev_name.replace('-', '_') | |
| 20:49:10 | mriedem | and then it doesn't matter | |
| 20:50:14 | efried | the method uses both the name and the uuid. I think a pair of helpers might be clearest. | |
| 20:50:46 | mriedem | oh you're talking about this right? https://review.openstack.org/#/c/599208/18/nova/virt/libvirt/driver.py@6161 | |
| 20:51:16 | mriedem | whatever, a simple _get_mdev_name(uuid) is also easy | |
| 21:01:35 | openstackgerrit | Eric Fried proposed openstack/nova master: FUP for test_reshape https://review.openstack.org/641482 | |
| 21:01:40 | efried | mriedem: gathered them together ^ | |
| 21:02:48 | efried | 'cept I seem to have f'ed that up somehow. | |
| 21:03:16 | mriedem | dos2unix nice | |
| 21:04:06 | efried | whaaa | |
| 21:04:33 | efried | oh | |
| 21:04:47 | efried | thought you were saying my line feeds were wrong | |
| 21:06:17 | mriedem | so is this ok or are tests failing? | |
| 21:07:03 | efried | failing. We must be monkey patching libvirt/utils somewhere | |
| 21:07:33 | efried | f it, I'll move the utils into the driver. | |
| 21:07:35 | mriedem | fakelibvirt... | |
| 21:07:57 | mriedem | https://github.com/openstack/nova/blob/master/nova/tests/unit/virt/libvirt/fake_libvirt_utils.py | |
| 21:09:39 | efried | that's... crazy | |
| 21:10:16 | mikal | There's heaps of that stuff from back before we understood how unit testing worked. | |
| 21:10:32 | mikal | Most of its removable with conversion to mock patches now. | |
| 21:10:43 | mikal | (i.e. that's now been done for most of nova-net because I like doomed projects) | |