| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2019-03-06 | |||
| 17:09:45 | artom | sean-k-mooney, heh, that's true for literally *all* of the bugs :D | |
| 17:10:00 | sean-k-mooney | a good first step is proably jsut to break the fucntion into smaller functions so its eaier to grock | |
| 17:10:11 | artom | sean-k-mooney, that too | |
| 17:10:19 | artom | It's actually on our downstream squad backlog | |
| 17:10:53 | sean-k-mooney | ya i know its on my personal white board backlog too for after i get done with sriov. | |
| 17:11:10 | sean-k-mooney | i didnt wnat to go messing with the post live migrtation stuff in parallel | |
| 17:19:25 | openstackgerrit | Theodoros Tsioutsias proposed openstack/nova master: Add requested_networks to RequestSpec https://review.openstack.org/570201 | |
| 17:19:26 | openstackgerrit | Theodoros Tsioutsias proposed openstack/nova master: Enable rebuild for instances in cell0 https://review.openstack.org/570203 | |
| 17:31:04 | sean-k-mooney | adrianc: mind if i fix https://review.openstack.org/#/c/620115/27/nova/compute/manager.py@89 and rebase everyting | |
| 17:33:45 | openstackgerrit | Matt Riedemann proposed openstack/nova master: De-cruft compute manager live migration https://review.openstack.org/641449 | |
| 17:42:03 | sean-k-mooney | is it my imaginaiton or does devstack no longer delete exsiting libvirt instances when it stacks? | |
| 17:42:43 | sean-k-mooney | i keep hitting domain already exists errors lately if i dont delete instance before i unstack and stack | |
| 17:48:07 | cdent | sean-k-mooney: I haven't experienced that, I rarely created actual vms from devstack, but I'm not surprised if it is happening: maintenance of devstack as a _dev_ tool, rather than the thing that happens in the gate is getting nowhere near the attention it used to | |
| 17:49:18 | sean-k-mooney | i think someone removed it | |
| 17:50:01 | sean-k-mooney | ill check the logs but after 5+ years of knowing that stack will clean up any vms you forgot about its hard to unlearn | |
| 17:50:07 | dansmith | sean-k-mooney: I experienced that a while ago.. probably more than a year | |
| 17:50:44 | dansmith | tbh, I'm not sure why it would do that for you, and it'd need to be real careful about any non-nova vms that were there | |
| 17:50:46 | sean-k-mooney | well i always found it strange it did it on stack not unstack but i have only noticed it lately | |
| 17:50:56 | dansmith | unstack is really not maintained, AFAIK | |
| 17:50:58 | melwitt | meanwhile, I never knew it cleaned up anything because I always deleted mine or destroyed the entire env and start over. not much unstack/stack | |
| 17:51:02 | dansmith | it's missing a ton of crap | |
| 17:51:32 | sean-k-mooney | dansmith: it used to use the instance name prefix that you have cofigred to delete any vm that matched | |
| 17:51:52 | dansmith | sean-k-mooney: okay, that's surprising to me, but ... | |
| 17:51:54 | sean-k-mooney | dansmith: ya i have a todo to fix wsgi config cleanup | |
| 17:52:16 | sean-k-mooney | there are a few other unstack/clean things i need to do. | |
| 17:52:28 | sean-k-mooney | dansmith: it woudl be nice to keep it but make it conditional | |
| 17:52:32 | bauzas | sean-k-mooney: yup, I saw the same behaviour, even with a ./clean.sh | |
| 17:53:28 | sean-k-mooney | one of the hack we did in the intel nfv ci to make it more reliable back when i was invoved in runing it is we never called unstack | |
| 17:54:07 | sean-k-mooney | nodepool was going to delete the vm so it saved time and sometime the cinder loop device clean woudl randomly fail | |
| 17:55:03 | sean-k-mooney | if i find a commit that removed it for a reason i might revert and make it condional but off by default. | |
| 17:55:50 | openstackgerrit | guang-yee proposed openstack/nova master: pass endpoint interface to Ironic client https://review.openstack.org/640879 | |
| 17:57:11 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Refactor pre-live-migration work out of _do_live_migration https://review.openstack.org/641453 | |
| 17:57:34 | openstackgerrit | Ken'ichi Ohmichi proposed openstack/nova master: doc: cleanup pci.alias references https://review.openstack.org/640882 | |
| 17:59:29 | openstackgerrit | Matt Riedemann proposed openstack/nova master: doc: cleanup pci.alias references https://review.openstack.org/640882 | |
| 17:59:49 | mriedem | efried: you want to just fast approve ^ since ken'ichi updated it and +2ed but his updated need tweaking | |
| 18:04:05 | sean-k-mooney | huh its still there https://github.com/openstack-dev/devstack/blob/master/lib/nova#L230-L239 | |
| 18:04:16 | sean-k-mooney | i must be broken | |
| 18:05:29 | dansmith | heh that's a pretty brute-force thing.. would be wrong if you ever redefined the pattern to not be a prefix | |
| 18:05:34 | dansmith | not that anyone would, but.. | |
| 18:06:15 | sean-k-mooney | well people sometimes change the pattern to just use the uuid but ya its pretty dumb code | |
| 18:06:45 | sean-k-mooney | that sad its 2-7 years old and mostly just worked so its not terible | |
| 18:06:57 | melwitt | mriedem: I'm going to review the rbd volume extend patch. anything else you'd recommend for review today? | |
| 18:07:00 | sean-k-mooney | ill debug this later. | |
| 18:07:03 | dansmith | I mean unlikely to change it on devstack | |
| 18:07:47 | sean-k-mooney | right operators change it for reasons but devs dont really have a need too | |
| 18:08:22 | eandersson | frickler, thanks will double check | |
| 18:08:59 | sean-k-mooney | i was getting migration failure because i had stoped domains and got an error saying the domain already existed | |
| 18:09:35 | sean-k-mooney | nova rolled back the live-migration and everything was fine | |
| 18:21:18 | sean-k-mooney | ok finished testing the sriov migration stuff again. im going rebase it all to the head of master but it seams to work locally | |
| 18:40:46 | mriedem | melwitt: not really, i'm just waiting for another run of the ceph change on that one | |
| 18:41:46 | eandersson | frickler, that was indeed it | |
| 18:43:01 | melwitt | mriedem: ok, thanks. I just went through it, also lgtm | |
| 18:45:22 | mriedem | melwitt: the rebuild from cell0 stuff could probably use more eyes but i've already been over it in parts and continued to find issues, so i'm just not really comfortable with pushing for that on the last day | |
| 18:46:01 | openstackgerrit | Merged openstack/nova master: Warn if group_policy is missing from flavor https://review.openstack.org/641289 | |
| 18:46:30 | melwitt | mriedem: got it | |
| 18:46:47 | openstackgerrit | sean mooney proposed openstack/nova master: Allow per-port modification of vnic_type and profile https://review.openstack.org/607365 | |
| 18:46:47 | openstackgerrit | sean mooney proposed openstack/nova master: Sep methods to free claimed and allocated devs https://review.openstack.org/616120 | |
| 18:46:48 | openstackgerrit | sean mooney proposed openstack/nova master: SR-IOV Live migration indirect port support https://review.openstack.org/620115 | |
| 18:46:48 | openstackgerrit | sean mooney proposed openstack/nova master: Add get_instance_pci_request_from_vif https://review.openstack.org/619929 | |
| 18:46:49 | openstackgerrit | sean mooney proposed openstack/nova master: libvirt: auto detach/attach sriov ports on migration https://review.openstack.org/629589 | |
| 18:46:56 | dansmith | melwitt: what's the party line on the privsep stuff? | |
| 18:47:21 | sean-k-mooney | stephenfin: ^ they are all rebased and typos adressed. | |
| 18:47:56 | sean-k-mooney | stephenfin: i tested it before the rebase so it should all be working but ill restack and test again | |
| 18:49:04 | melwitt | dansmith: I don't know the details but from earlier chat it looked like there's a lot of questions/issues. I'll re-read | |
| 18:49:29 | dansmith | melwitt: well, there are questions on a class of them, but that's a small subset | |
| 18:49:48 | dansmith | melwitt: re-ordering the patches would free up a bunch that are already +W | |
| 18:50:07 | dansmith | I'm mostly interested in whether or not we care about the current half-baked situation we're in (I do) | |
| 18:50:28 | dansmith | they're not fixes, so kinda seem like they should go in front of FF to me, and they're not no-risk | |
| 18:50:47 | dansmith | it'd be nice to make some more progress, especially since mikal just updated them (IMHO) | |
| 18:51:12 | sean-k-mooney | there is what 7-10 left | |
| 18:51:13 | melwitt | dansmith: ah, I see. I agree they should go in front of FF and I think it would be good to merge the straightforward ones by ore-ordering | |
| 18:52:04 | dansmith | melwitt: okay I hadn't seen you in that stack much so wasn't sure if you were ignoring them for specific reasons or just because they're not interesting.. maybe a ptl statement on the bottom one about "let's try to get a chunk of these merged before FF tomorrow" then ? | |
| 18:52:10 | sean-k-mooney | oh 18 but 3 are +w and could merge if we reorder | |
| 18:52:30 | dansmith | I guess I could also reorder a few for mikal and we could do some before he wakes up even | |
| 18:52:47 | melwitt | dansmith: no, I recently went in there and approved one, which unblocked a small stack of them. haven't been ignoring them purposely | |
| 18:52:51 | dansmith | sean-k-mooney: yeah and more proabably I just stopped walking up the stack | |
| 18:52:58 | dansmith | okay | |
| 18:53:15 | dansmith | lemme reorder them and see what I can free up easily | |
| 18:53:20 | eandersson | mriedem, the soft-anti-affinity issue was because the keystone endpoint was still v2/ and not v2.1/ | |
| 18:53:23 | eandersson | just fyi | |
| 18:54:01 | mriedem | melwitt: why create a new test class for this? https://review.openstack.org/#/c/633350/12/nova/tests/functional/db/test_instance_mapping.py | |
| 18:54:04 | melwitt | dansmith: I think they're valuable and want to get what progress we can there. I'll add a comment | |
| 18:54:20 | mriedem | eandersson: ah..yeah we even have a troubleshooting entry for that in our docs from when oath upgraded to ocata | |
| 18:54:43 | mriedem | eandersson: https://docs.openstack.org/nova/latest/admin/support-compute.html#requested-microversions-are-ignored | |
| 18:54:55 | mriedem | eandersson: heh for that exactly same problem :) | |
| 18:55:04 | mriedem | *exact | |
| 18:55:08 | eandersson | It was just an odd one, as it worked before. =] | |
| 18:55:31 | eandersson | Plus does not help that we haven't had a weekend yet :p | |
| 18:55:40 | eandersson | Upgrading from Mitaka to Rocky... not easy lol | |
| 18:56:11 | melwitt | mriedem: don't have a great reason. at first, I had modeled it after the bdm uuid addition/migration, which used a separate class for the test cases. and I wasn't sure if it was sufficiently different from the rest of the tests and should be separated or not. I can lump it with the rest, no problem | |
| 18:56:14 | eandersson | Moving to Cells V2 has been super smooth so far thou | |
| 18:56:29 | mriedem | eandersson: that's good to hear | |
| 18:56:34 | mriedem | the cells thing that is | |
| 18:56:38 | eandersson | :p | |
| 18:56:50 | eandersson | We still have a lot of unaccounted performance issues that we are troubleshooting. | |
| 18:56:52 | mriedem | too bad you're late to submit a "upgrading from mitaka to rocky at blizzzzard" talk at the summit | |
| 18:56:57 | eandersson | haha | |
| 18:57:33 | mriedem | its not just cells v2 you're biting off, it's also placement | |
| 18:57:45 | mriedem | so you might be hitting some perf issues due to not scaling that out enough, | |
| 18:57:51 | mriedem | or nova-compute being way too chatty | |