| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2019-03-06 | |||
| 14:25:03 | adrianc | already addressed the comments will upload a PS soon | |
| 14:25:40 | adrianc | sean-k-mooney, shall i rebase the direct and indirect patches on top ? | |
| 14:25:40 | sean-k-mooney | adrianc: ah cool. i was distracted in neutron land the last 2 days | |
| 14:25:50 | sean-k-mooney | am sure | |
| 14:25:58 | adrianc | promise not to loose a PS :) | |
| 14:27:00 | sean-k-mooney | hehe i trust you not to :) i generally work my way from the bottom up and cherrypick the later patches when working on a chain like this | |
| 14:27:28 | sean-k-mooney | that or use interactive rebases if its just my own patches | |
| 14:28:22 | jaypipes | ok, thanks adrianc and sean-k-mooney. will review it as soon as I see the new patches. | |
| 14:28:34 | sean-k-mooney | :) | |
| 14:30:08 | adrianc | sean-k-mooney: gotcha thanks ! | |
| 14:30:29 | adrianc | jaypipes: thanks for the inputs | |
| 14:36:57 | openstackgerrit | Adrian Chiris proposed openstack/nova master: Allow per-port modification of vnic_type and profile https://review.openstack.org/607365 | |
| 14:36:57 | openstackgerrit | Adrian Chiris proposed openstack/nova master: Sep methods to free claimed and allocated devs https://review.openstack.org/616120 | |
| 14:36:58 | openstackgerrit | Adrian Chiris proposed openstack/nova master: Add get_instance_pci_request_from_vif https://review.openstack.org/619929 | |
| 14:39:20 | mriedem | https://www.youtube.com/watch?v=jk8SToEQPGw | |
| 14:40:44 | openstackgerrit | Matt Riedemann proposed openstack/nova stable/pike: Fix WeighedHost logging regression https://review.openstack.org/641398 | |
| 14:42:04 | mtreinish | mriedem: I like that the top comments on that are trying to explain the joke... | |
| 14:43:25 | mriedem | mtreinish: i like that you are gone for weeks at a time and only show up, in this channel of all places, when i drop a simpsons video | |
| 14:45:14 | mtreinish | I think that I have my priorities straight | |
| 14:45:31 | mriedem | i don't disagree | |
| 14:46:04 | sean-k-mooney | adrianc: by the way i am assuming you are crurrently rebasing https://review.openstack.org/#/c/620115 on the ohter changes. the final change in the seriese does not use any of the funcitions you modified so that should be a straight cherrypick at the end | |
| 14:46:41 | openstackgerrit | Matt Riedemann proposed openstack/nova stable/rocky: Handle missing exception in instance creation code https://review.openstack.org/641401 | |
| 14:46:54 | openstackgerrit | Adrian Chiris proposed openstack/nova master: SR-IOV Live migration indirect port support https://review.openstack.org/620115 | |
| 14:47:46 | adrianc | sean-k-mooney: yes | |
| 14:47:52 | sean-k-mooney | :) | |
| 14:48:11 | mriedem | takashin: when you get a chance can you backport https://review.openstack.org/#/c/636271/ please? | |
| 14:52:35 | mriedem | mtreinish: while you're here, see how this job runs tempest with --concurrency=4 http://logs.openstack.org/72/638072/14/check/nova-next/c8ecf61/job-output.txt.gz#_2019-03-06_08_18_20_021174 | |
| 14:52:43 | mriedem | but yet it looks like a lot of the tests are running serially | |
| 14:52:58 | mriedem | the first 7 are on the same worker | |
| 14:53:19 | mriedem | unless that just means the other workers were running slower tests at the same time? | |
| 14:53:48 | mriedem | yeah i suppose that's all it is | |
| 14:54:43 | mtreinish | mriedem: yeah I think that's what's going on | |
| 14:54:46 | mriedem | man there are tests in tempest that really just don't belong there | |
| 14:54:47 | mriedem | tempest.api.compute.servers.test_list_server_filters.ListServerFiltersTestJSON.test_list_servers_filter_by_shutoff_status [72.172009s] ... ok | |
| 14:54:54 | mtreinish | the stackviz view is good for visualizing that: http://logs.openstack.org/72/638072/14/check/nova-next/c8ecf61/logs/stackviz/#/stdin/timeline | |
| 14:54:56 | mriedem | create a server, stop it, wait for it to be stopped | |
| 14:55:05 | HD|Laptop | hey all | |
| 14:55:08 | openstackgerrit | Jose Castro Leon proposed openstack/nova master: Extend volume for libvirt network volumes (RBD) https://review.openstack.org/613039 | |
| 14:55:13 | mriedem | we could test shutoff server filtering in functional tests | |
| 14:56:01 | mtreinish | I'd support moving that test out of tempest | |
| 14:56:19 | mriedem | cripes these dualnet scenario tests are also long as hell | |
| 14:56:19 | HD|Laptop | how do I convince nova-compute to not include the NFS storage under "local disk store" in Horizon? | |
| 14:56:26 | mriedem | 3+ minutes | |
| 14:57:55 | openstackgerrit | Adrian Chiris proposed openstack/nova master: Sep methods to free claimed and allocated devs https://review.openstack.org/616120 | |
| 14:58:10 | mriedem | HD|Laptop: you mean a single compute is showing local storage for the entire nfs share rather? | |
| 14:58:14 | mriedem | that's not really a horizon thing | |
| 14:58:27 | mriedem | e.g. compute1 is showing like 2TB of "local" disk | |
| 14:58:58 | HD|Laptop | mriedem: under horizon/admin/hypervisors/, each hypervisor shows with 68TB local storage | |
| 14:59:24 | HD|Laptop | probably this is because its instance_path is set to a shared folder on said NFS server | |
| 14:59:28 | mriedem | yes | |
| 14:59:48 | mtreinish | mriedem: iirc those tests make multiple servers and networks, login to them with an ipv4 network and test connectivity between servers over different ipv6 configurations. It takes forvever just waiting for things to come up | |
| 14:59:48 | HD|Laptop | and horizon seems to sum up all the disks... to "Lokale Festplattenbelegung | |
| 14:59:51 | HD|Laptop | 120GB von 582,8TB benutzt | |
| 15:00:01 | mriedem | HD|Laptop: that comes from the libvirt driver in here https://github.com/openstack/nova/blob/dfaa513fe1329aabe6e5d83b6ac42e0e25ad9eb6/nova/virt/libvirt/driver.py#L5747 | |
| 15:00:11 | mriedem | https://github.com/openstack/nova/blob/dfaa513fe1329aabe6e5d83b6ac42e0e25ad9eb6/nova/virt/libvirt/driver.py#L5762 | |
| 15:00:26 | mriedem | since instances_path is on shared storage, it's going to show the entire storage pool for that path | |
| 15:00:31 | mriedem | i'm not aware of a way around that | |
| 15:00:40 | HD|Laptop | ah okay. damn :'D | |
| 15:01:07 | mriedem | mtreinish: time for an "extra-slow" tag soon | |
| 15:01:41 | mriedem | mtreinish: will openstack health show me how long on average the entire TestGettingAddress class takes? | |
| 15:01:57 | openstackgerrit | sean mooney proposed openstack/nova master: libvirt: auto detach/attach sriov ports on migration https://review.openstack.org/629589 | |
| 15:02:29 | mtreinish | it doesn't let you filter the averages by class iirc | |
| 15:02:46 | mtreinish | but if you give me a sec I can hack together a graph for you manually | |
| 15:05:57 | mriedem | took ~35 minutes in logs.openstack.org/72/638072/14/check/nova-next/c8ecf61/job-output.txt.gz | |
| 15:06:00 | mriedem | 8 tests | |
| 15:14:07 | efried | mriedem: where/how can I run a CI that exercises ironic-in-nova? | |
| 15:14:18 | mriedem | efried: we have a non-voting job on all nova changes | |
| 15:14:23 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Do not run tempest.scenario.test_network* tests in nova-next https://review.openstack.org/641416 | |
| 15:14:26 | mriedem | ironic-tempest-ipa-wholedisk-bios-agent_ipmitool-tinyipa | |
| 15:14:47 | mriedem | and i think there are a couple in the experimental queue as well for multinode and neutron stuff | |
| 15:14:59 | efried | aha, okay. | |
| 15:15:26 | efried | mriedem: background: I finally bit the bullet and started hacking up a way for ironicclient to use the ksa adapter we go through all the trouble of building up on the nova side, only to throw it away. | |
| 15:15:30 | sean-k-mooney | efried: the other way to do it is a DNM change to ironic that depends on the nova change | |
| 15:15:51 | sean-k-mooney | that will runn the ironcis jobset and pull in the relevent nova patch | |
| 15:16:03 | efried | sean-k-mooney: and that exercises the nova side? | |
| 15:16:26 | sean-k-mooney | assuming they have jobs that boot ironic instances via nova | |
| 15:16:43 | sean-k-mooney | it just depends on what you want to test | |
| 15:16:47 | efried | in case you care. | |
| 15:16:47 | efried | nova: https://review.openstack.org/#/c/641170/ | |
| 15:16:47 | efried | ironicclient: https://review.openstack.org/641169 | |
| 15:16:49 | mriedem | melwitt: looks like functional test failures at the end of your counting quotas series are real https://review.openstack.org/#/c/638324/ | |
| 15:17:41 | mriedem | efried: the one thing i'm not sure about is if that nova change will pull in the ironicclient code dependency or if it will pull in ironicclient from upper-constraints | |
| 15:17:53 | mriedem | might depend on if the job is zuul v3-ified | |
| 15:18:03 | efried | o | |
| 15:18:40 | mriedem | http://logs.openstack.org/70/641170/1/check/ironic-tempest-ipa-wholedisk-bios-agent_ipmitool-tinyipa/0e5cd32/controller/logs/pip2-freeze.txt.gz indicates it doesn't | |
| 15:18:44 | mriedem | python-ironicclient==2.6.0 | |
| 15:18:47 | sean-k-mooney | efried: mriedem looks like the ironic base job is a zullv3 native job but it does not list openstack/nova as a required project | |
| 15:18:48 | mriedem | doesn't pull in the source dep | |
| 15:18:55 | openstackgerrit | Surya Seetharaman proposed openstack/nova master: Block automatic transport_url update for cell0 https://review.openstack.org/605414 | |
| 15:19:10 | efried | well crap | |
| 15:19:20 | mriedem | so, | |
| 15:19:41 | mriedem | the "legacy" way to do this is a devstack change which depends on the nova/ironicclient changes and you configure devstack to pull in the client from source | |
| 15:19:47 | mriedem | assuming devstack has an ironic job... | |
| 15:20:09 | efried | and if it doesn't, make the devstack change and then make a nova change that depends on it. | |
| 15:20:13 | mriedem | or, your nova change depends on a devstack change that pulls in ironicclient from source which depends on the ironicclient patch | |
| 15:20:18 | mriedem | yeah | |
| 15:20:19 | efried | yeah | |
| 15:20:20 | efried | whee | |
| 15:20:50 | mriedem | https://github.com/openstack-dev/devstack/blob/master/stackrc#L345 | |
| 15:21:16 | sean-k-mooney | efried: i can mock up a quick test patch that ill pull in one of the ironic jobs and force it to use nova and ironcic client form source if iyou like | |