Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2019-03-05
21:08:25 sean-k-mooney i know we made the DriverBlockDevice inherit from dict to make tanstioning to it simpler but at some point it would be better to bit the bullet and just make it a reall nova object/ovo
21:45:04 openstackgerrit Chris Friesen proposed openstack/nova master: Validate PCI aliases early in resize https://review.openstack.org/641131
21:45:38 cfriesen mriedem: ^
21:46:07 openstackgerrit Adam Spiers proposed openstack/nova master: Add new "supports_amd_sev" capability to libvirt driver https://review.openstack.org/638680
21:49:24 mriedem cfriesen: comments inline
21:50:15 cfriesen mriedem: wasn't sure whether to copy the other docstring or refer to it. :)
21:51:07 cfriesen will update based on other comments...do you think I should test that pci is not validated by default?
21:51:47 mriedem well, if you changed validate_pci=True, i'm guessing some existing tests for create/rebuild would fail b/c they haven't mocked something out?
21:52:03 mriedem if so, then you probably don't need an explicit test for that
21:52:19 cfriesen works
21:59:09 openstackgerrit Matt Riedemann proposed openstack/nova master: De-cruftify the finish_resize methods https://review.openstack.org/635349
21:59:10 openstackgerrit Matt Riedemann proposed openstack/nova master: neutron: make migrate_instance_finish call setup_instance_network_on_host https://review.openstack.org/635343
21:59:10 openstackgerrit Matt Riedemann proposed openstack/nova master: Delete the obj_as_admin context manager https://review.openstack.org/635351
21:59:11 openstackgerrit Matt Riedemann proposed openstack/nova master: Use errors_out_migration decorator on finish_resize https://review.openstack.org/641138
21:59:11 openstackgerrit Matt Riedemann proposed openstack/nova master: Temporarily mutate migration object in finish_revert_resize https://review.openstack.org/641137
22:05:45 mriedem dansmith: you might want to gander at https://bugs.launchpad.net/nova/+bug/1818239
22:05:46 openstack Launchpad bug 1818239 in nova (Ubuntu) "scheduler: build failure high negative weighting" [High,Triaged]
22:18:49 openstackgerrit Matt Riedemann proposed openstack/nova master: Fix WeighedHost logging regression https://review.openstack.org/641143
22:18:50 mriedem super easy regression fix that i've now seen in 2 reported bugs ^
22:29:45 mriedem someone want to send the bw provider microversion change to it's watery grave? https://review.openstack.org/#/c/636360/
22:30:16 dansmith mriedem: I think I give up
22:30:46 mriedem on that build failure weigher? heh i know
22:30:55 mriedem "this seems bad if you have build failures...."
22:31:29 mriedem coreycb: maybe you and/or jamespage want to talk with us about bug 1818239
22:31:30 openstack bug 1818239 in nova (Ubuntu) "scheduler: build failure high negative weighting" [High,Triaged] https://launchpad.net/bugs/1818239
22:31:34 dansmith it also seems to assume that you can deploy with the completely standard config and expect everything to be fine, regardless of size or the bits of config you want to tweak
22:31:48 dansmith totally cool with charms defaulting it off
22:32:05 dansmith I tried to make the rationale for the default weight completely sane based on other default weighers and such
22:32:29 dansmith but I dunno what else to do, other than engineer the periodic de-de-prioritizing in the compute manager we discussed
22:35:10 dansmith the latter of course will demand some config option to allow tweaking the bleed rate
22:35:12 openstackgerrit Chris Friesen proposed openstack/nova master: Validate PCI aliases early in resize https://review.openstack.org/641131
22:35:20 mriedem i tried to summarize https://bugs.launchpad.net/ubuntu/+source/nova/+bug/1818239/comments/16
22:35:21 openstack Launchpad bug 1818239 in nova (Ubuntu) "scheduler: build failure high negative weighting" [High,Triaged]
22:35:57 openstackgerrit Michael Still proposed openstack/nova master: Move DHCP releasing to privsep. https://review.openstack.org/624230
22:35:57 openstackgerrit Michael Still proposed openstack/nova master: Move set_vf_interface_vlan to be with its only caller. https://review.openstack.org/624229
22:35:58 openstackgerrit Michael Still proposed openstack/nova master: Move route management to privsep. https://review.openstack.org/624232
22:35:58 openstackgerrit Michael Still proposed openstack/nova master: Convert additional IP management calls to privsep. https://review.openstack.org/624231
22:35:59 openstackgerrit Michael Still proposed openstack/nova master: Move slight bonkers IP management to privsep. https://review.openstack.org/624592
22:35:59 openstackgerrit Michael Still proposed openstack/nova master: Move additional IP address management to privsep. https://review.openstack.org/624591
22:36:00 openstackgerrit Michael Still proposed openstack/nova master: Move cleaning conntrack to privsep. https://review.openstack.org/624594
22:36:00 openstackgerrit Michael Still proposed openstack/nova master: Move arping to privsep. https://review.openstack.org/624593
22:36:01 openstackgerrit Michael Still proposed openstack/nova master: Move killing processes to privsep. https://review.openstack.org/635432
22:36:01 openstackgerrit Michael Still proposed openstack/nova master: Privsepify ipv4 forwarding enablement. https://review.openstack.org/635431
22:36:02 openstackgerrit Michael Still proposed openstack/nova master: Cleanup the exec_ebtables code a little. https://review.openstack.org/635434
22:36:02 openstackgerrit Michael Still proposed openstack/nova master: Move FP device creation and deletion to privsep. https://review.openstack.org/635433
22:36:03 openstackgerrit Michael Still proposed openstack/nova master: Move adding vlans to interfaces to privsep. https://review.openstack.org/635436
22:36:03 openstackgerrit Michael Still proposed openstack/nova master: Privsep the ebtables modification code. https://review.openstack.org/635435
22:36:04 openstackgerrit Michael Still proposed openstack/nova master: Move dnsmasq restarts to privsep. https://review.openstack.org/639280
22:36:04 openstackgerrit Michael Still proposed openstack/nova master: Move iptables rule fetching and setting to privsep. https://review.openstack.org/636508
22:36:05 openstackgerrit Michael Still proposed openstack/nova master: Move calls to ovs-vsctl to privsep. https://review.openstack.org/639282
22:36:05 openstackgerrit Michael Still proposed openstack/nova master: Move router advertisement daemon restarts to privsep. https://review.openstack.org/639281
22:36:08 dansmith mriedem: ack thanks
22:37:01 mriedem no one puts mikal in a corner
22:39:27 openstackgerrit Matt Riedemann proposed openstack/nova master: Validate PCI aliases early in resize https://review.openstack.org/641131
22:40:22 cfriesen mriedem: gah...thanks for the fixup
22:58:41 efried Do we allow backports of fixes to client libs, and corresponding requirements bumps in nova??
22:59:52 mriedem yes on the former, no on the latter
23:00:21 efried swhat I thought, thanks.
23:00:35 efried mriedem: fyi https://review.openstack.org/#/c/640879/2/nova/virt/ironic/client_wrapper.py@106
23:01:39 efried mriedem: I guess deployers wanting the bug fix can pull in the updated client lib version, even though it exceeds upper constraints for that release?
23:01:52 efried or do we bump upper constraints for the release? /me confused.
23:02:05 mriedem we can bump upper-constraints in stalbe
23:02:06 mriedem *stalbe
23:02:08 mriedem gah
23:02:14 mriedem we don't bump lower-constraints
23:02:23 mriedem because those could be frozen for people at GA
23:03:09 efried okay, got it.
23:03:23 mriedem so yeah they can backport the ironicclient fix and release it with a patch version on stable
23:03:32 mriedem but we can't depend on it with a requirements/lower-constraints update on stable
23:03:59 mriedem if we can hack around it in a backportable way and then fix on master-only with a lower-constraints bump on ironicclient, then sure
23:05:01 efried ack
23:53:58 mriedem WOO F TO THE HOO
23:55:02 mriedem time to fix a multi-cell bug in our functional tests
23:56:26 openstackgerrit Merged openstack/nova master: Parse elements from virConnectGetCapabilities() https://review.openstack.org/640483
23:56:58 eandersson Anyone else having issues with soft-anti-affinity etc in Rocky?
23:57:17 eandersson > Invalid input for field/attribute 0. Value: soft-anti-affinity. u'soft-anti-affinity' is not one of ['anti-affinity', 'affinity']
23:57:25 eandersson > openstack --os-compute-api-version 2.15 server group create anti-affinity-test --policy soft-anti-affinity
23:57:33 openstackgerrit Merged openstack/nova master: Correct instance port binding for rebuilds https://review.openstack.org/603844
23:57:39 eandersson Tested both with openstack client and terraform
23:57:51 openstackgerrit Merged openstack/nova master: Fix resetting non-persistent fields when saving obj https://review.openstack.org/636271
23:58:14 mriedem eandersson: that looks correct https://docs.openstack.org/python-openstackclient/latest/cli/command-objects/server-group.html#server-group-create
23:58:17 mriedem which version of osc?
23:58:21 eandersson 3.16.3
23:58:52 eandersson It was working before the upgrade with the same clients
23:59:18 mriedem hmm, this is the last change to the server groups module in osc https://github.com/openstack/python-openstackclient/commit/d0917cd14b94ce13fd92237490efb5722761eda4#diff-f8f1dd5d07b16e47671071cb4fede85d
23:59:38 eandersson We havne't changed osc version
23:59:41 eandersson just the nova version
23:59:48 eandersson went to nova rocky
23:59:57 eandersson brb
23:59:58 mriedem that error isn't from nova
#openstack-nova - 2019-03-06
00:00:03 eandersson interesting
00:00:05 mriedem oh wait...
00:00:07 eandersson terraform had the same issue
00:00:17 eandersson and we double checked that we had a version that supports it
00:00:20 eandersson brb
00:00:23 mriedem can you run the osc command with --debug?
00:00:31 mriedem after you're rb
00:08:03 openstackgerrit Merged openstack/nova master: Ensure that bandwidth and VF are from the same PF https://review.openstack.org/623543
00:08:14 openstackgerrit Merged openstack/nova master: api-ref: typo service.disable_reason https://review.openstack.org/640956
00:08:24 openstackgerrit Merged openstack/nova master: Handle missing exception in instance creation code https://review.openstack.org/641082

Earlier   Later