| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2019-03-05 | |||
| 13:36:50 | sean-k-mooney | anyway having it work for flat and vlan networks i still a good step forward | |
| 13:38:02 | openstackgerrit | Chris Dent proposed openstack/nova master: Correct lower-constraints.txt and the related tox job https://review.openstack.org/622972 | |
| 13:40:40 | mdbooth | lyarwood: It has failed again. Investigating. | |
| 13:43:43 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Use Selection object to fill request group mapping https://review.openstack.org/638711 | |
| 13:43:56 | lyarwood | mdbooth: ack thanks | |
| 13:47:41 | mdbooth | It seems to be the py3 version which fails | |
| 14:08:37 | cdent | mriedem: the openstack-dev archives are still there, but not longer reachable by the usual paths: http://lists.openstack.org/pipermail/openstack-dev/ | |
| 14:10:02 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Handle templated cell mappings in nova-status https://review.openstack.org/641021 | |
| 14:10:03 | mriedem | lyarwood: try throwing that as a dependency in your tripleo change ^; dansmith fyi ^ | |
| 14:10:11 | mriedem | cdent: google failed me | |
| 14:10:28 | cdent | aye, it often does | |
| 14:13:26 | lyarwood | mriedem: ack thanks | |
| 14:18:20 | yonglihe | mriedem: what can i do for https://review.openstack.org/#/c/621476/39 | |
| 14:27:04 | dansmith | mriedem: ah, dangit | |
| 14:27:26 | openstackgerrit | Tim Rozet proposed openstack/nova stable/rocky: Fixes race condition with privsep utime https://review.openstack.org/641023 | |
| 14:29:22 | HD|Laptop | hey | |
| 14:29:42 | HD|Laptop | yesterday I asked if it was possible for nova to use cinder as backing storage for images/instances... now I had an idea | |
| 14:29:58 | HD|Laptop | can I just go ahead and mount /var/lib/nova/instances as a NFS directory? | |
| 14:30:08 | HD|Laptop | that would serve the same purpose | |
| 14:30:45 | HD|Laptop | even better would be if I could share instances/_base, but I guess that this could lead to locking issues if e.g. two compute nodes try to convert the same vmdk image to qcow2? | |
| 14:30:58 | openstackgerrit | Merged openstack/nova master: libvirt: Omit needless check on 'CONF.serial_console' https://review.openstack.org/637578 | |
| 14:39:10 | mriedem | HD|Laptop: yes you can put the instances_path config on shared storage, many people do | |
| 14:39:15 | mriedem | note that has it's own perils, like https://review.openstack.org/641023 | |
| 14:39:41 | mriedem | and https://review.openstack.org/#/c/633042/ | |
| 14:40:07 | mriedem | https://docs.openstack.org/nova/latest/configuration/config.html#workarounds.ensure_libvirt_rbd_instance_dir_cleanup | |
| 14:40:55 | efried | mriedem: Review the "stop using PlacementDirect" changes with whitespace ignores on in gerrit | |
| 14:41:01 | efried | mriedem, cdent, sean-k-mooney: but let me rebase it first... | |
| 14:41:20 | mriedem | what if i don't want to? | |
| 14:41:59 | efried | mriedem: Then it's a bigger review that will make you sad | |
| 14:42:15 | efried | oh, what if you don't want to wait until I've rebased? Sure, then you can +2 it now, I don't mind. | |
| 14:42:28 | mriedem | strike 2 | |
| 14:45:47 | openstackgerrit | Eric Fried proposed openstack/nova master: Stop using PlacementDirect https://review.openstack.org/640887 | |
| 14:45:55 | efried | cdent, mriedem, sean-k-mooney: ^ | |
| 14:46:06 | cdent | one moment please caller | |
| 14:46:23 | HD|Laptop | mriedem: thanks. I'll just give every instance its own nfs base directory then, that should keep me safe from that shit | |
| 14:46:56 | openstackgerrit | Eric Fried proposed openstack/nova master: Stop using PlacementDirect https://review.openstack.org/640887 | |
| 14:47:09 | efried | ^ fix whitespace | |
| 14:48:37 | efried | cdent, sean-k-mooney: for a change, the 1..3 diff is actually empty, because the patch removes the whole class that was conflicting. | |
| 14:49:41 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Support server create with ports having resource request https://review.openstack.org/636360 | |
| 14:49:41 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Ensure that bandwidth and VF are from the same PF https://review.openstack.org/623543 | |
| 14:49:51 | gibi | bauzas: I've fixed up your comments ^^ | |
| 14:50:16 | sean-k-mooney | efried: right cdent change modified one line in schdulerReportClientTEstBase and you are deleteing it out right | |
| 14:52:35 | cdent | efried: other than me continuing to think it is keen and worth doing soon than later, you after anything in particular? | |
| 14:52:39 | efried | sean-k-mooney: three or four lines, but yeah. | |
| 14:53:31 | efried | cdent: no, just letting you know it needed a rebase and that's done now. I agree there's no reason to wait for Train. And I don't want reviewers intimidated by it because it's really like a 20LOC change. | |
| 14:53:47 | gibi | stephenfin: you were +2 before on https://review.openstack.org/623543 bauzas put +2 on the previous PS. Can you meet on PS 41 and combine your votes? :) | |
| 14:54:45 | cdent | efried: I suppose if you wanted to make it really obvious you could do it in two steps: extracted the indented chunks to their own methods in 1, remove placement direct in 2, but personally I think that's overkill, the diff is readable enough as is | |
| 14:55:06 | bauzas | gibi: I was about +2ing it | |
| 14:55:36 | efried | cdent: Yeah, when I was developing the change, I started off by creating a null _interceptor context manager. I didn't want to go to the effort of removing and outdenting if I wasn't going to be able to get it to work. | |
| 14:56:45 | lyarwood | mriedem: your nova-status cell_mappings change works on a local env btw | |
| 14:57:23 | lyarwood | mriedem: thanks for turning that around so quickly! | |
| 14:57:37 | mriedem | anything for you lee | |
| 15:03:01 | gibi | bauzas: thanks a lot | |
| 15:06:49 | mriedem | mdbooth: fyi that https://review.openstack.org/#/c/625741/ just merged on master | |
| 15:06:53 | openstackgerrit | Chris Dent proposed openstack/nova master: Correct lower-constraints.txt and the related tox job https://review.openstack.org/622972 | |
| 15:07:17 | mdbooth | mriedem: Oh, dear. | |
| 15:07:24 | mdbooth | mriedem: Didn't spot that was a backport. | |
| 15:07:35 | sean-k-mooney | efried: i assume you rebased the patch due to a merge confilt with cdents patch? | |
| 15:07:45 | efried | sean-k-mooney: yes | |
| 15:07:52 | mdbooth | mriedem: Lemme read the review comments on there, perhaps my concern was already addressed. | |
| 15:08:10 | mriedem | mdbooth: i doubt it, no one thinks of the image cache besides you :) | |
| 15:08:41 | sean-k-mooney | ok just +1'd it again i havent used it locally but it makes sense to me | |
| 15:09:14 | mdbooth | mriedem: Hmm. I'd consider reverting that, tbh. | |
| 15:10:05 | mdbooth | mriedem: The other solution proposed was much more targetted and presumably also works around the same issue. | |
| 15:11:06 | mdbooth | I'd rather fail than risk leaving an empty file in the image cache. | |
| 15:11:19 | mdbooth | The former you can just retry. | |
| 15:11:58 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Handle placement error during re-schedule https://review.openstack.org/639608 | |
| 15:12:11 | mriedem | mdbooth: are you talking about this? https://review.openstack.org/#/c/633493/2 | |
| 15:12:27 | sean-k-mooney | any objections to me repoposing the numa and sriov migration specs for train. i think we should be ablt to wrap those up by train m1 so im hoping we can just fast appove the stien specs again? | |
| 15:13:26 | sean-k-mooney | there is 3 days to ff so they are not going to get reivewed betwen now and then anyway and that will give us plenty fo time to work on func tests for both | |
| 15:16:38 | mriedem | sean-k-mooney: no one will object to reproposing specs to train for things that will not land in stein | |
| 15:16:51 | mriedem | and no one is going to review those train specs for awhile either | |
| 15:17:10 | sean-k-mooney | ya i just want to have them up before the ptg | |
| 15:17:54 | sean-k-mooney | i know peopel are going to be focusing on getting RC1 ready for the next few weeks and finalising stien | |
| 15:18:53 | sean-k-mooney | on that note im hoping we can land https://review.openstack.org/#/c/602432/ in stein/rc1 its not a change i think many would want to backport so i would like to close that bug in stien if we can | |
| 15:20:50 | mdbooth | mriedem: Yeah | |
| 15:21:23 | mdbooth | mriedem: Although obviously as you say you wouldn't fix that on a stable branch. | |
| 15:21:37 | mriedem | gibi: random thought on the instance_has_port_with_resource_request check in the API - could we replace the neutron GET /ports call in there now with checking the instance info cache for any VIFs whose profile has the 'allocation' key? | |
| 15:24:47 | openstackgerrit | Matthew Booth proposed openstack/nova master: Revert "Fixes race condition with privsep utime" https://review.openstack.org/641038 | |
| 15:24:56 | mdbooth | mriedem: Proposed a revert ^^^ | |
| 15:25:08 | openstackgerrit | Chris Dent proposed openstack/nova master: Correct lower-constraints.txt and the related tox job https://review.openstack.org/622972 | |
| 15:25:22 | mdbooth | Eurgh. | |
| 15:26:59 | sean-k-mooney | mriedem: your suggesting modifying https://github.com/openstack/nova/blob/6516038dea5b80af2d83906a7e23f33e76061a42/nova/api/openstack/common.py#L571-L582 to check the instance info cache. | |
| 15:27:15 | openstackgerrit | Matthew Booth proposed openstack/nova master: Revert "Fixes race condition with privsep utime" https://review.openstack.org/641038 | |
| 15:28:21 | sean-k-mooney | assuming its only ever called after the info cache is populated then maybe. if not we might be able to make it condtional | |
| 15:28:55 | sean-k-mooney | e.g. if the instance is not in the info cache when this is called hit neutron otherwise us cache versions | |
| 15:29:33 | mriedem | gibi: https://review.openstack.org/#/c/636360/ | |
| 15:29:42 | gibi | mriedem: looking | |
| 15:30:14 | sean-k-mooney | mriedem: it looks like its only called on move operations | |
| 15:30:52 | mriedem | sean-k-mooney: correct | |
| 15:30:55 | mriedem | so the cache should be there | |
| 15:31:00 | mriedem | and ports would already be bound | |
| 15:31:32 | sean-k-mooney | yep so i guess it might be safe to always used the cache values. | |
| 15:33:08 | sean-k-mooney | we are just checkign if a port has allocation too not where they are from and since that should not change over the lifetime of a port it "should" not matter if the allcoation were stale for example because we justed moved. | |
| 15:33:18 | sean-k-mooney | im ignoring that move wont work in stien | |
| 15:33:32 | mriedem | bauzas: are you good with this now? https://review.openstack.org/#/c/509206/ | |
| 15:33:51 | mriedem | you previously approved | |
| 15:33:56 | mriedem | and then we had to fix something for tempest | |
| 15:34:05 | mriedem | Sylvain Bauza Feb 18 5:34 AM Patch Set 10: Code-Review+2 Workflow+1 | |
| 15:34:06 | sean-k-mooney | mriedem: could we have issue with unshelve? | |