| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2019-03-04 | |||
| 17:20:17 | gibi | bauzas: understood | |
| 17:20:25 | bauzas | sorry but I have to bail out | |
| 17:20:28 | bauzas | ++ | |
| 17:24:54 | gibi | bauzas: thanks a lot | |
| 17:24:59 | gibi | bauzas: I will bail soon as well | |
| 17:25:09 | gibi | bauzas: I will finish updating the patch tomorrow morning | |
| 17:29:20 | openstackgerrit | Stephen Finucane proposed openstack/nova master: fakelibvirt: Add ability to generate fake PCI devices https://review.openstack.org/640409 | |
| 17:29:21 | openstackgerrit | Stephen Finucane proposed openstack/nova master: tests: Create PCI tests for NUMA'y tests https://review.openstack.org/640826 | |
| 17:31:41 | openstackgerrit | Chris Friesen proposed openstack/nova master: Flavor extra spec and image properties validation https://review.openstack.org/620706 | |
| 17:32:09 | cfriesen | mriedem: this addresses almost all your comments. will split out the hardware.py stuff as you asked in the next revision | |
| 17:56:59 | openstackgerrit | Chris Dent proposed openstack/nova master: Correct lower-constraints.txt and the related tox job https://review.openstack.org/622972 | |
| 17:57:19 | openstackgerrit | Kashyap Chamarthy proposed openstack/nova master: qemu: Make disk image conversion dramatically faster https://review.openstack.org/640781 | |
| 17:58:52 | mriedem | cfriesen: wouldn't a deactivate image (even if it doesn't change) on resize fail the resize if the dest host can't download the image (and it's not cached)? | |
| 18:00:08 | cfriesen | mriedem: good question. I seem to remember some scenarios where it copies it from the cache on the source...but let me check. | |
| 18:04:52 | mriedem | maybe if you're using shared storage? | |
| 18:04:55 | mriedem | but not everyone does | |
| 18:05:13 | mriedem | i believe the libvirt driver code falls back to pull from the source if it's not in the dest image cache | |
| 18:05:16 | mriedem | or tries to | |
| 18:05:22 | mriedem | mdbooth probably knows better | |
| 18:18:04 | aspiers | gah, looks like functional tests for https://review.openstack.org/#/c/538498/ failed in the gate | |
| 18:18:23 | aspiers | http://logs.openstack.org/98/538498/22/gate/nova-tox-functional/d76478b/testr_results.html.gz has a bunch of errors like "oslo_config.cfg.NoSuchOptError: no such option sync_on_startup in group [placement_database]" | |
| 18:18:28 | aspiers | does that make sense to anyone | |
| 18:18:30 | aspiers | ? | |
| 18:24:47 | cdent | aspiers: that's interesting, it should default to false | |
| 18:25:07 | cdent | except that's not what the error says, it says the conf option doesn't exist | |
| 18:25:11 | aspiers | right | |
| 18:25:19 | aspiers | totally weird that this should appear in the gate but not in the check | |
| 18:25:41 | cdent | which means the gate doesn't have the right code... | |
| 18:25:56 | sean-k-mooney | aspiers ist it posble that it was usign the inrepo placement? | |
| 18:26:43 | sean-k-mooney | it does not exist here https://github.com/openstack/nova/blob/master/nova/conf/placement.py | |
| 18:27:11 | cdent | sean-k-mooney: the fix should be using an indepdent conf | |
| 18:27:34 | cdent | and according to the failures it's using the external placement | |
| 18:27:47 | cdent | however | |
| 18:27:57 | cdent | it might be that the fixture needs to be tweakd. | |
| 18:28:15 | cdent | aspiers: if you have the time can you try to run the functional tests locally on a clean tox? | |
| 18:28:32 | aspiers | cdent: sure | |
| 18:28:51 | sean-k-mooney | well looking at code search it only exists in placement http://codesearch.openstack.org/?q=sync_on_startup&i=nope&files=&repos= | |
| 18:28:58 | aspiers | right | |
| 18:29:24 | aspiers | cdent: but the zuul check already did that and passed ... | |
| 18:30:10 | cdent | aspiers: yes, but that change (to add that config) merged to placement several minutes ago so maybe it wasn't there in check | |
| 18:31:40 | sean-k-mooney | cdent: if it only merged a few minuts ago its not in pypi | |
| 18:31:56 | sean-k-mooney | the last relase was feb 13th https://pypi.org/project/osc-placement/#history | |
| 18:32:05 | sean-k-mooney | sorry wrong repo | |
| 18:32:25 | sean-k-mooney | january 7th https://pypi.org/project/openstack-placement/#history | |
| 18:32:32 | cdent | sean-k-mooney: it should be installed a tox-sibling, not from pypi | |
| 18:32:48 | cdent | otherwise it wouldn't work as a fixture-to-use-master | |
| 18:32:57 | cdent | aspiers: i've repeated here | |
| 18:33:04 | cdent | so I reckon it's a bug in the fixture | |
| 18:33:05 | sean-k-mooney | perhaps in which case then ya it could be jsut a a timing window | |
| 18:33:12 | aspiers | ah | |
| 18:33:15 | sean-k-mooney | aspiers: do you have a depends on on that placmenet change | |
| 18:33:25 | sean-k-mooney | aspiers: that would have prevented any race | |
| 18:33:32 | aspiers | no I didn't know about the change until just now | |
| 18:33:34 | cdent | sean-k-mooney: not in the case | |
| 18:33:37 | cdent | the fixture has a real bug | |
| 18:33:52 | sean-k-mooney | cdent: oh ok | |
| 18:34:08 | sean-k-mooney | aspiers: generally depens on helps bug not in all cases | |
| 18:34:38 | aspiers | is it possible to do rechecks on the gate? | |
| 18:34:43 | sean-k-mooney | yep | |
| 18:34:48 | sean-k-mooney | just a normal recheck | |
| 18:34:59 | sean-k-mooney | we used to have reverify years ago but not anymore | |
| 18:35:03 | sean-k-mooney | reverify just ran gate | |
| 18:35:20 | sean-k-mooney | recheck will run check and gate | |
| 18:38:12 | cdent | aspiers: I'll see about fixing this | |
| 18:38:20 | cdent | as in, now | |
| 18:39:39 | sean-k-mooney | im going to grab dinner. be back in an hour or so | |
| 18:49:49 | cdent | ah. aspiers, kind of figured it out. Those tests which are failing are using the placement database fixture directly, not through the Placement fixture, thus the the config opt is not registered, leading to plenty of confusion | |
| 18:53:34 | cdent | aspiers: https://bugs.launchpad.net/nova/+bug/1818560 | |
| 18:53:35 | openstack | Launchpad bug 1818560 in OpenStack Compute (nova) "Nova's use of the placement database fixture from test_report_client doesn't register opts" [Critical,Confirmed] | |
| 18:53:50 | cdent | in case I wasn't clear there, the fix is on the placement side | |
| 19:15:06 | cdent | aspiers: there are two levels of problem here | |
| 19:16:43 | cdent | requires fixes in both placement and nova, mabye | |
| 19:16:51 | cdent | still looking to try to figure out the cleanest way | |
| 19:19:24 | aspiers | cdent: awesome, thanks! | |
| 19:19:45 | mriedem | dansmith: am i missing what you're asking for here? https://review.openstack.org/#/c/636412/1/nova/scheduler/client/report.py@1758 | |
| 19:20:56 | dansmith | mriedem: ah, sorry I missed that the original change was already including one direction | |
| 19:21:39 | mriedem | i love one direction | |
| 19:21:46 | aspiers | X-D | |
| 19:22:00 | cfriesen | mriedem: in the case of resize, I think the fact that sometimes it *can* go through (if the image is already cached, or we're using "raw") means that we can't fail the operation due to image inactivity. | |
| 19:22:17 | mriedem | cfriesen: sure | |
| 19:22:22 | mriedem | not a huge sticking point for me | |
| 19:25:08 | openstackgerrit | Chris Friesen proposed openstack/nova master: Flavor extra spec and image properties validation https://review.openstack.org/620706 | |
| 19:25:09 | openstackgerrit | Chris Friesen proposed openstack/nova master: Improve existing flavor and image metadata validation https://review.openstack.org/640841 | |
| 19:26:44 | openstackgerrit | Chris Friesen proposed openstack/nova master: Flavor extra spec and image properties validation from API https://review.openstack.org/620706 | |
| 19:27:06 | cfriesen | figured I'd differentiate the two titles a bit better | |
| 19:27:16 | eandersson | nova-hostname (from metadata) is set by dhcp_domain right? | |
| 19:27:25 | eandersson | That is deprecated | |
| 19:27:30 | eandersson | What is supposed to populate that field? | |
| 19:28:30 | mriedem | eandersson: you just stepped into something | |
| 19:29:40 | mriedem | eandersson: https://bugs.launchpad.net/nova/+bug/1698010 | |
| 19:29:42 | openstack | Launchpad bug 1698010 in OpenStack Compute (nova) "neutron-based instances should not use the nova-network 'dhcp_domain' option" [High,In progress] - Assigned to Stephen Finucane (stephenfinucane) | |
| 19:30:30 | sean-k-mooney | eandersson: if you dont have designate deployed i dont think neutron will populate that value. | |
| 19:30:43 | sean-k-mooney | ignoring the nova bug | |
| 19:32:11 | melwitt | dansmith, mriedem: I updated the user_id patch to make the field non-nullable. unit tests are all broken and some/all of the next patch need to be squashed in, but the next patch passes grenade/tempest. I hoped for a sanity check from you before I go ahead and do any commit squashing and unit test fixing https://review.openstack.org/633350 | |
| 19:32:44 | cdent | aspiers: you should be proud, you've found a hole in the space time continuium, I'm looping back on myself | |
| 19:33:07 | aspiers | cdent: just don't destroy the universe in the process | |
| 19:35:05 | cdent | efried: are you back yet? I think I might need to consult with you on this | |
| 19:36:15 | cdent | the issue I'm trying to contend with this that at https://github.com/openstack/nova/blob/master/nova/tests/functional/test_report_client.py#L124 that CONF is a nova conf, not a placement CONF | |
| 19:36:33 | cdent | so now that we've added a new conf item to placement things are awry | |
| 19:40:39 | openstackgerrit | Adam Spiers proposed openstack/nova master: Parse |
|