| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2019-03-01 | |||
| 14:53:24 | giblet | fried_rice: resize is just a cold_migrate with a changing flavor https://github.com/openstack/nova/blob/68d4cb44edfe7b5f85618254cc906dcef44f7ce3/nova/conductor/tasks/migrate.py#L134 | |
| 14:53:52 | fried_rice | hm | |
| 14:54:22 | giblet | fried_rice: here is the select_destination call https://github.com/openstack/nova/blob/68d4cb44edfe7b5f85618254cc906dcef44f7ce3/nova/conductor/tasks/migrate.py#L235 | |
| 14:55:21 | fried_rice | okay. | |
| 15:00:34 | mriedem | fried_rice: yes resize to same host does GET /a_c | |
| 15:00:45 | fried_rice | okay. | |
| 15:01:10 | fried_rice | mriedem: Then something I just sent on the ML may be entirely wrong. | |
| 15:01:18 | fried_rice | o/ leakypipes | |
| 15:02:43 | tssurya | mriedem: thanks! | |
| 15:03:22 | cfriesen | mdbooth_: no worries. thanks for fixing it up. | |
| 15:09:40 | cfriesen | mdbooth: I assume that change has your approval since you resubmitted it? | |
| 15:12:56 | melwitt | o/ | |
| 15:13:07 | fried_rice | jroll: Thanks for that email. Turns out this will affect (at least) nova-powervm's OOT driver https://github.com/openstack/nova-powervm/blob/master/nova_powervm/virt/powervm/driver.py#L230 | |
| 15:13:16 | fried_rice | o/ melwitt | |
| 15:15:29 | melwitt | fried_rice: we were considering adding a warning log to the patch if a driver needs to be updated. do you think that would be useful or do you think the reno alone is good enough? | |
| 15:15:57 | fried_rice | melwitt: I think it's a good idea. | |
| 15:16:17 | fried_rice | since we're going to the trouble of being nice about changing the interface. | |
| 15:20:07 | kashyap | mriedem: Thanks for bringing this to my attention: https://review.openstack.org/#/c/637834/ (Select cpu model from a list of cpu models) | |
| 15:20:22 | kashyap | mriedem: Reviewed it this morning. And it needs a lot more rework | |
| 15:20:46 | kashyap | It is doing several things that are terribly ineffective, even poorly duplicating libvirt's work | |
| 15:22:08 | kashyap | Wonder if you (dis)agree with my remarks there | |
| 15:30:51 | mriedem | kashyap: i'll defer to you | |
| 15:30:55 | mriedem | i haven't been reviewing the change | |
| 15:31:00 | mriedem | bigger fires to fight | |
| 15:31:09 | mriedem | jroll: so i guess you're going to add a log message? | |
| 15:31:11 | mriedem | for the TypeError? | |
| 15:32:08 | kashyap | mriedem: I think all the points I (and Alex Xu) raised should be addressed. | |
| 15:32:27 | kashyap | I'll follow through | |
| 15:43:33 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Stop using "nova" in API samples when creating a server https://review.openstack.org/639874 | |
| 15:45:29 | openstackgerrit | Ben Nemec proposed openstack/nova master: Add oslo.privsep to config-generator list https://review.openstack.org/640404 | |
| 15:46:19 | mriedem | bauzas: so what changed with the reboot issue you were holding https://review.openstack.org/#/c/599208/ up for? | |
| 15:49:01 | openstackgerrit | Lee Yarwood proposed openstack/nova master: Use migration_status during volume migrating and retyping https://review.openstack.org/637224 | |
| 15:50:57 | openstackgerrit | Merged openstack/nova master: Remove port allocation during detach https://review.openstack.org/622421 | |
| 15:51:47 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Ensure that bandwidth and VF are from the same PF https://review.openstack.org/623543 | |
| 15:51:47 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Add pf_interface_name tag to passthrough_whitelist https://review.openstack.org/625311 | |
| 15:51:48 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Support server create with ports having resource request https://review.openstack.org/636360 | |
| 15:53:09 | giblet | stephenfin: added an extra sentence about grouping multiple PF in a single expression in https://review.openstack.org/#/c/625311 | |
| 15:53:39 | stephenfin | giblet: Sounds good. I'll get to it before EOD. Been working on adding functional tests for https://review.openstack.org/#/c/624444/2 | |
| 15:54:45 | giblet | stephenfin: thanks. hit me with the link of the functional test and I will review it | |
| 15:55:06 | sean-k-mooney | do you think we will land that in stein by the way. it would be good to backport if we do | |
| 15:55:43 | jroll | fried_rice: mriedem: yeah, I'll add it shortly here | |
| 15:55:45 | jroll | thanks | |
| 15:55:58 | openstackgerrit | Stephen Finucane proposed openstack/nova master: objects: Store InstancePCIRequest.numa_policy in DB https://review.openstack.org/624444 | |
| 15:55:59 | openstackgerrit | Stephen Finucane proposed openstack/nova master: WIP: fakelibvirt: Add ability to generate fake PCI devices https://review.openstack.org/640409 | |
| 15:56:01 | fried_rice | ight | |
| 15:56:26 | giblet | sean-k-mooney: the actual fix looked good to me so I can help pushing it through | |
| 15:56:31 | stephenfin | giblet: There you go. I was trying to fix some TODOs in the tests but that can be done some other time https://review.openstack.org/624444 | |
| 15:56:43 | giblet | stephenfin: looking | |
| 15:59:24 | sean-k-mooney | on a slightly unrelated note i would like to land this bugfix in stien too if we can https://review.openstack.org/#/c/602432/7 but i need to do some more testing of it locally. i think it is correct but i want to be certin before we merge it and say the bugs are closed. | |
| 16:01:31 | openstackgerrit | Adam Spiers proposed openstack/nova master: fix bug with XML matcher handling missing children https://review.openstack.org/640411 | |
| 16:02:48 | sean-k-mooney | actully stephenfin giblet should i add a release note for that | |
| 16:02:53 | aspiers | sean-k-mooney: ^^^ | |
| 16:02:57 | stephenfin | sean-k-mooney: For? | |
| 16:05:17 | stephenfin | sean-k-mooney: Can you take a look at https://review.openstack.org/#/c/625311/25/doc/source/admin/networking.rst ? | |
| 16:05:44 | stephenfin | sean-k-mooney: Just because I know you've expressed concerns about using device names as identifiers in the past | |
| 16:06:17 | sean-k-mooney | stephenfin: https://review.openstack.org/#/c/602432/7 since it close https://bugs.launchpad.net/neutron/+bug/1734320 and https://bugs.launchpad.net/neutron/+bug/1815989 | |
| 16:06:19 | openstack | Launchpad bug 1734320 in OpenStack Compute (nova) "Eavesdropping private traffic" [Undecided,In progress] - Assigned to sean mooney (sean-k-mooney) | |
| 16:06:20 | openstack | Launchpad bug 1815989 in neutron "OVS drops RARP packets by QEMU upon live-migration causes up to 40s ping pause in Rocky" [Undecided,In progress] - Assigned to sean mooney (sean-k-mooney) | |
| 16:06:21 | stephenfin | sean-k-mooney: though I am imagining the ship has sailed based on giblet's comments about neutron using them for RP IDs | |
| 16:06:23 | sean-k-mooney | sure ill take a look now | |
| 16:08:24 | stephenfin | sean-k-mooney: I love release notes and think we should have them for all (user-facing) bugs. However, there's a user visible change being introduced here so I'd definitely say add one, yeah | |
| 16:08:28 | sean-k-mooney | stephenfin: if the pf is directly assignied to a guest and then readdd to the host its may or may not have a netdev associated with it and it may our may not have the same name | |
| 16:08:51 | stephenfin | So | |
| 16:09:36 | sean-k-mooney | so the sriov agent already depend on the pci address in the port profile so why not use that instad of a dev name | |
| 16:10:08 | giblet | sean-k-mooney: the sriov agent is configured with device names in neutron | |
| 16:10:11 | sean-k-mooney | i have not read the full spec | |
| 16:10:21 | lyarwood | mdbooth_: https://review.openstack.org/#/q/topic:bug/1803961+(status:open+OR+status:merged) - would you mind clearing your reviews out of that topic and hitting mine again early next week? | |
| 16:10:24 | sean-k-mooney | giblet: yes and it looks up the pci address | |
| 16:10:35 | stephenfin | Could we add code that says if 'pf_interface_name': 'eth0' is set, that same device can't be included whitelisted itself? | |
| 16:10:47 | sean-k-mooney | giblet: nova passes only the pci address to neutron in the port profile for the vf | |
| 16:11:03 | giblet | sean-k-mooney: yes, that is true | |
| 16:12:04 | giblet | sean-k-mooney: I need the neutron devs of this feature to argue why the device name was choosen for the RP nameing | |
| 16:12:37 | giblet | stephenfin: you want some kind of sanity check on the configured value to see if there are contradictions? | |
| 16:13:00 | sean-k-mooney | probaly becasue fo the connetx-3 nic form mellononx which has two pfs on teh same pciaddress | |
| 16:13:20 | stephenfin | giblet: I'm not sure yet. I'm trying to decide if it's a good idea or not :) | |
| 16:13:40 | sean-k-mooney | but that didnt work with openstack until verry verry recently and has been supperseeded | |
| 16:13:52 | mdbooth | lyarwood: phase 1 complete | |
| 16:13:52 | sean-k-mooney | maybe it was connectx-2 | |
| 16:14:41 | giblet | stephenfin: if the check only depends on the actula configured value and does not need to call out to the virt driver or other 3rd parties then I can be convinced to add a check | |
| 16:14:41 | sean-k-mooney | giblet: there may also be confusion between teh existing "devname" field and teh new "pf_interface_name" | |
| 16:14:52 | lyarwood | mdbooth: ack thanks | |
| 16:15:11 | cfriesen | can anyone figure out why this is failing in zuul? http://logs.openstack.org/63/631363/14/check/openstack-tox-py27/f6aa9a3/testr_results.html.gz It works fine for me locally. | |
| 16:15:11 | giblet | sean-k-mooney: jeah the existing devname is a filtering field while the new pf_interface_name is a tag | |
| 16:15:41 | sean-k-mooney | giblet: ya didnt we say we were not going to add more tag to the whitelist like 3 or 4 cycles ago | |
| 16:15:46 | giblet | sean-k-mooney: if there is devname provided in the filter nova could copy that as a pf_inteface_name tag automatically | |
| 16:16:11 | giblet | sean-k-mooney: I did not know about that rule. what should I use instead to drive the pci claim? | |
| 16:16:15 | stephenfin | giblet: The devname would only match a single PF or VF though | |
| 16:16:16 | sean-k-mooney | giblet: well we can also lookup the pf name via sysfs | |
| 16:16:45 | giblet | sean-k-mooney: if there is more devname for a PF then we don't know which one to use | |
| 16:16:47 | stephenfin | sean-k-mooney: Yeah, but as giblet pointed out, there can be a mismatch for those ConnectX-3 NICs | |
| 16:17:19 | sean-k-mooney | yes that is true but do we want to cater for that edgecase | |
| 16:17:21 | stephenfin | bauzas: Before you knock off for the weekend, fancy hitting https://review.openstack.org/#/c/626932/ up? | |
| 16:17:32 | stephenfin | sean-k-mooney: Aye, that was going to be my question | |
| 16:17:40 | bauzas | stephenfin: looking | |
| 16:17:43 | sean-k-mooney | we could but it feels like we are workign around a silicon/driver bug | |
| 16:17:49 | bauzas | ah this one | |
| 16:17:51 | bauzas | +d | |
| 16:17:51 | stephenfin | yuuup. | |
| 16:18:36 | sean-k-mooney | giblet: stephenfin by the way only the PF had a duplicate pci adress | |
| 16:18:50 | giblet | sean-k-mooney: if nova looks up the name form sysfs and then selects one then the neutron admin needs to use the same one in the config, but we cannot really tell the admin which one nova selected | |