| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2019-02-28 | |||
| 07:41:15 | cfriesen | and calling it from the resize code path | |
| 07:43:01 | alex_xu | great, I will take a look at | |
| 07:51:37 | cfriesen | gotta go to bed. goodnight. | |
| 08:15:44 | openstackgerrit | Zhenyu Zheng proposed openstack/nova master: Detach/Attach root volume API changes https://review.openstack.org/623981 | |
| 08:21:00 | gibi | bauzas: i've started looking into mriedem's questions in the reshape functional test patch. Let me know if you are about to change something in that patch | |
| 08:21:39 | bauzas | gibi: I first need to look at those | |
| 08:28:15 | gibi | bauzas: If you are OK with that then I will go and fix mriedem's comments in there | |
| 08:31:46 | gibi | bauzas: or shall I post the fix as a followup? | |
| 08:33:03 | bauzas | gibi: /me looking | |
| 08:33:28 | bauzas | given I already updated your change, which is on top, I'm fine with you updating it | |
| 08:33:45 | bauzas | no need for a FUP unless those are nits and we already have a +2 | |
| 08:34:55 | gibi | bauzas: we already have +2 from efried | |
| 08:35:19 | bauzas | oh my bad | |
| 08:35:24 | bauzas | well, your choice | |
| 08:35:38 | gibi | bauzas: OK | |
| 08:35:44 | bauzas | I think we can certainly get efried approving it again | |
| 08:36:40 | bauzas | gibi: ideally, we could also squash efried's patch into it | |
| 08:38:46 | gibi | bauzas: I would ask efried about before we squash | |
| 08:38:55 | bauzas | yup, i agree | |
| 08:39:08 | bauzas | or add him as co-author if you wanna be quick | |
| 08:40:47 | bauzas | gibi: I also need to write a new change, so I -W'd https://review.openstack.org/#/c/599208/18 | |
| 08:40:50 | bauzas | I'm on it | |
| 08:40:55 | bauzas | should be quick hopefully | |
| 08:41:17 | gibi | bauzas: OK | |
| 09:37:11 | openstackgerrit | Bhagyashri Shewale proposed openstack/nova master: Ignore root_gb for BFV in simple tenant usage API https://review.openstack.org/612626 | |
| 09:45:30 | openstackgerrit | Stephen Finucane proposed openstack/nova master: objects: Remove legacy '_from_dict' functions https://review.openstack.org/537414 | |
| 09:47:37 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Add functional test for libvirt vgpu reshape https://review.openstack.org/631559 | |
| 09:48:16 | openstackgerrit | Stephen Finucane proposed openstack/nova master: Modify PciDevice.uuid generation code https://review.openstack.org/530487 | |
| 09:48:17 | openstackgerrit | Stephen Finucane proposed openstack/nova master: Add an online migration for PciDevice.uuid https://review.openstack.org/530905 | |
| 09:49:04 | stephenfin | gibi, bauzas: Fancy putting this through? https://review.openstack.org/#/c/608407/ | |
| 09:49:30 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: FUP: docs nit https://review.openstack.org/639647 | |
| 09:49:57 | gibi | stephenfin: looking | |
| 09:51:14 | gibi | stephenfin: done | |
| 09:51:20 | stephenfin | \o/ ta | |
| 09:51:55 | openstackgerrit | Stephen Finucane proposed openstack/nova master: Summarize output of sample configuration generator https://review.openstack.org/625014 | |
| 09:52:09 | bauzas | hah, got one hour meeting from some tax credit https://www.impots.gouv.fr/portail/international-professionnel/tax-incentives | |
| 09:52:26 | bauzas | folks, in case you wanna relocate in France, consider it twice before moving | |
| 09:53:07 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Test proper allocation of devices during reshape https://review.openstack.org/639854 | |
| 09:53:49 | stephenfin | lyarwood: Fancy taking a look at this today? https://review.openstack.org/#/c/626369/ | |
| 09:54:33 | gibi | bauzas: if you have any idea about https://review.openstack.org/#/c/631559/13/nova/tests/unit/virt/libvirt/fakelibvirt.py@1548 then tell me. The current test works if I return nothing but I shoudl return some nvidia-11 mdev_type there | |
| 09:55:44 | bauzas | gibi: looking | |
| 09:56:02 | bauzas | hah | |
| 09:56:34 | bauzas | gibi: it's because of https://github.com/openstack/nova/blob/master/nova/virt/libvirt/host.py#L893 | |
| 09:56:53 | lyarwood | stephenfin: sure | |
| 10:00:59 | bauzas | gibi: sec, giving you the right XML that I used for my UTs | |
| 10:02:33 | bauzas | gibi: try this one https://github.com/openstack/nova/blob/master/nova/tests/unit/virt/libvirt/test_driver.py#L298-L322 | |
| 10:02:56 | bauzas | gibi: AFAIR, the libvirt docs is probably badly writtent | |
| 10:03:00 | bauzas | written* | |
| 10:04:07 | openstackgerrit | Stephen Finucane proposed openstack/nova master: Summarize output of sample configuration generator https://review.openstack.org/625014 | |
| 10:06:32 | openstackgerrit | Stephen Finucane proposed openstack/nova master: conf: Remove 'disable_libvirt_livesnapshot' option https://review.openstack.org/626932 | |
| 10:10:44 | gibi | bauzas: thanks. let me try | |
| 10:12:39 | openstackgerrit | Stephen Finucane proposed openstack/nova master: Update docs, API samples for noVNC 1.0.0 https://review.openstack.org/550173 | |
| 10:13:11 | openstackgerrit | Zhenyu Zheng proposed openstack/nova master: Detach/Attach root volume API changes https://review.openstack.org/623981 | |
| 10:14:18 | stephenfin | lyarwood: Looks like Ubuntu 19.04 will finally switch to noVNC 1.0, but that leaves this patch in limbo til 20.04 is out at least. I wonder if I should just abandon it or insert a TODO instead? https://review.openstack.org/#/c/550173/ | |
| 10:14:31 | stephenfin | (Ubuntu 19.04 assertion made based on https://packages.ubuntu.com/search?keywords=novnc) | |
| 10:15:21 | lyarwood | stephenfin: I've already bumped the package in Fedora 28 FWIW | |
| 10:16:18 | openstackgerrit | garyk proposed openstack/nova master: Better handle live migration abort https://review.openstack.org/635440 | |
| 10:16:44 | lyarwood | stephenfin: so with the fedora package at least both URLs should still work | |
| 10:17:40 | stephenfin | lyarwood: Oh, really? Symlink? | |
| 10:17:42 | lyarwood | stephenfin: I'd abandon and return to this with 20.04 | |
| 10:17:45 | lyarwood | stephenfin: yeah | |
| 10:18:13 | lyarwood | stephenfin: https://src.fedoraproject.org/rpms/novnc/blob/master/f/novnc.spec#_36 | |
| 10:18:55 | stephenfin | Nice. I'll abandon that for now so. Trying to clean up my list of open patches (there are a few) | |
| 10:20:56 | openstackgerrit | garyk proposed openstack/nova master: Better handle live migration abort https://review.openstack.org/635440 | |
| 10:21:08 | gibi | bauzas: still seeing some strange behavior, I will push a separate patch up so you can also look at it in parallel | |
| 10:21:16 | bauzas | gibi: okay | |
| 10:21:27 | bauzas | gibi: thanks for helping out | |
| 10:22:26 | stephenfin | bauzas, gibi: Actually, input time. I've done two different things in similar scenarios https://review.openstack.org/#/c/626932/ https://review.openstack.org/#/c/608407/ | |
| 10:22:52 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: handle mdev_type device in fakelibvirt https://review.openstack.org/639974 | |
| 10:22:56 | gibi | bauzas: ^^ | |
| 10:23:15 | stephenfin | bauzas, gibi: Both refer to config options that workaround bugs in older libvirt versions that we no longer support. In the former, I just dropped it. In the latter, I did the full deprecation cycle. Thoughts on which is preferable? | |
| 10:23:42 | bauzas | stephenfin: I'm in favor of being gentle with our ops | |
| 10:25:21 | bauzas | stephenfin: what's the libvirt min version we support ? | |
| 10:25:24 | bauzas | kashyap: ^? | |
| 10:25:49 | stephenfin | bauzas: 3.0 | |
| 10:25:49 | gibi | stephenfin: the config driver format config still works even if it is not needed to set to vfat | |
| 10:25:58 | gibi | stephenfin: so there keeping the config is meaningful | |
| 10:26:32 | gibi | stephenfin: would disable_libvirt_livesnapshot still disable the snapshot in Stein if we keep it? | |
| 10:26:44 | gibi | if yes, then I would just deprecate that config too | |
| 10:26:55 | stephenfin | gibi: Yeah, it would. I'll deprecate that instead so | |
| 10:26:59 | bauzas | stephenfin: the problem is that we provided a flag which, even if tied to a specific version, allows a specific behaviour | |
| 10:27:17 | bauzas | stephenfin: so people can use it even if they have newer libvirt | |
| 10:37:34 | openstackgerrit | Stephen Finucane proposed openstack/nova master: conf: Deprecate 'disable_libvirt_livesnapshot' option https://review.openstack.org/626932 | |
| 10:37:59 | stephenfin | bauzas, gibi: Updated to deprecate instead of remove outright, if you fancy hitting that too ^ | |
| 10:39:25 | openstackgerrit | Yongli He proposed openstack/nova master: Adds the server group info into show server detail API. https://review.openstack.org/621474 | |
| 10:42:05 | kashyap | bauzas: Hi | |
| 10:42:18 | kashyap | bauzas: Was briefly AFK; it's documented in the driver.py :-) | |
| 10:42:20 | openstackgerrit | Yongli He proposed openstack/nova master: Adds the server group info into show server detail API. https://review.openstack.org/621474 | |
| 10:43:26 | openstackgerrit | Stephen Finucane proposed openstack/nova master: docs: Dedupe controller install guides https://review.openstack.org/638715 | |
| 10:43:27 | openstackgerrit | Stephen Finucane proposed openstack/nova master: docs: Dedupe compute install guides https://review.openstack.org/638716 | |
| 10:43:51 | kashyap | MIN_LIBVIRT_VERSION = (3, 0, 0) | |
| 10:43:51 | kashyap | bauzas: Currently these: | |
| 10:43:52 | kashyap | MIN_QEMU_VERSION = (2, 8, 0) | |
| 10:44:43 | openstackgerrit | Stephen Finucane proposed openstack/nova master: conf: Call out where pci.alias should be set https://review.openstack.org/624445 | |
| 11:46:02 | mkarpiarz | Hi. Can someone please take a look at https://bugs.launchpad.net/nova/+bug/1780225/comments/3? | |
| 11:46:04 | openstack | Launchpad bug 1780225 in OpenStack Compute (nova) "Libvirt error when using --max > 1 with vGPU" [High,Confirmed] - Assigned to Sylvain Bauza (sylvain-bauza) | |
| 11:46:45 | mkarpiarz | I can see 2 ways of fixing this | |
| 11:48:02 | mkarpiarz | 1. Store the list of available mediated devices in some global structure. | |
| 11:49:54 | mkarpiarz | 2. Let the instance fail in launch and return back to spawn(), so it can check available devices again. | |
| 11:51:52 | mkarpiarz | Any other ideas? | |