Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2019-02-27
16:43:17 efried YAGNI?
16:43:30 cdent there's a growing movement to make sure we have contributors who will own that stuff
16:44:18 cdent I guess yagni's a factor, sure, but more: let's not add extra work without adding extra people. If people don't show up, they must not want it.
16:44:35 cdent making that void more visible is a thing I care about quite a bit
16:44:47 mriedem artom: ^ sound familiar?
16:45:04 artom mriedem, heh, I was gonna say
16:45:10 jaypipes jroll: sorry, yes, please go ahead
16:45:18 cdent mriedem: ?
16:45:45 mriedem cdent: artom and i were just talking about that, in a closet
16:45:57 artom Yeah, we've come out of the closet just now
16:46:05 cdent congrats
16:47:20 cdent so how to visibilate things/
16:47:40 cdent (not including hickies)
16:47:48 edleafe add extra work without adding extra people. If people don't show up,
16:47:48 edleafe This should be added somewhere in the OpenStack charter: "let's not
16:47:51 edleafe they must not want it."
16:48:10 artom edleafe, people *do* show up. Once.
16:48:33 artom And as mriedem was saying, in 2 years of deployers upgrade to the new thing, those people are gone.
16:48:38 artom *when
16:48:42 mriedem i'm not in my 20s anymore, i'm looking for a long-term commitment with contributors
16:50:18 artom o/` If you want it better put a ring on it o/`
16:56:37 openstackgerrit Lee Yarwood proposed openstack/nova master: WIP status: Ensure templated connection URLs are rendered before use https://review.openstack.org/639607
17:03:54 efried mriedem_away, jaypipes, bauzas, gibi: I think https://review.openstack.org/#/c/538498/ is ready to go now, if you want to give it another look-see.
17:04:02 efried (convert compute caps to traits)
17:08:44 openstackgerrit Balazs Gibizer proposed openstack/nova master: Remove port allocation during detach https://review.openstack.org/622421
17:08:44 openstackgerrit Balazs Gibizer proposed openstack/nova master: Add remove_resources_from_instance_allocation to report client https://review.openstack.org/639653
17:08:45 openstackgerrit Balazs Gibizer proposed openstack/nova master: Add pf_interface_name tag to passthrough_whitelist https://review.openstack.org/625311
17:08:45 openstackgerrit Balazs Gibizer proposed openstack/nova master: Record requester in the InstancePCIRequest https://review.openstack.org/625310
17:08:46 openstackgerrit Balazs Gibizer proposed openstack/nova master: Support server create with ports having resource request https://review.openstack.org/636360
17:08:46 openstackgerrit Balazs Gibizer proposed openstack/nova master: Ensure that bandwidth and VF are from the same PF https://review.openstack.org/623543
17:08:47 openstackgerrit Balazs Gibizer proposed openstack/nova master: Refactor _heal_allocations_for_instance (2) https://review.openstack.org/637954
17:08:47 openstackgerrit Balazs Gibizer proposed openstack/nova master: Refactor _heal_allocations_for_instance to make place for port healing https://review.openstack.org/637953
17:08:48 openstackgerrit Balazs Gibizer proposed openstack/nova master: cache neutron ports in heal allocation https://review.openstack.org/638207
17:08:48 openstackgerrit Balazs Gibizer proposed openstack/nova master: nova-manage: heal port allocations https://review.openstack.org/637955
17:09:52 gibi mriedem_away: I fixed up https://review.openstack.org/#/c/639653 but I run out of time on https://review.openstack.org/#/c/622421 so I have to do that tomorrow
17:13:07 openstackgerrit Merged openstack/nova master: Fup for the bandwidth series https://review.openstack.org/639159
17:15:25 jaypipes efried: still says cannot merge on that patch...
17:15:30 jroll jaypipes: oops, I meant I left a question in gerrit, sorry
17:15:40 efried oh?
17:15:56 efried oh.
17:16:20 efried aspiers: ^ looks like needs rebase. Which ugh probably means need to wait until predecessor finishes merging.
17:18:00 melwitt does anyone know what's the correct way to unit test code that calls placement? I found the PlacementFixture nova/tests/functional/fixtures.py but was thinking that's not appropriate for unit tests
17:22:33 efried melwitt: "unit" and "calls placement" don't really gel. If it's a true unit test, the placement calls ought to be mocked.
17:23:31 melwitt efried: right.. I wondered if there was a specific way to mock them (like a fixture I don't know about) or if it's just ad-hoc
17:23:48 efried melwitt: Do you have a specific example?
17:23:50 melwitt I didn't find any example yet. still looking
17:23:53 efried okay.
17:24:11 melwitt I'm working on quota check code that calls placement, so once I added the placement call, lots of unit tests fail
17:24:29 melwitt and if someone happened to know the recommended way to mock placement, that would help me
17:24:48 efried melwitt: See nova.tests.unit.scheduler.client.test_report
17:25:17 efried melwitt: Those tests mock SchedulerReportClient.<http primitive like get/put/post/delete>
17:25:18 melwitt thank you
17:26:24 efried melwitt: Whereas nova.tests.functional.test_report_client uses the placement fixture to create an interceptor context manager with which to wrap "real" calls to placement.
17:27:01 efried the latter, for functional tests, gets you real placement behavior. The former just lets you pretend you got a certain Response object.
17:27:17 melwitt efried: got it. thanks for the help
17:27:23 efried np, enjoy.
17:31:27 efried melwitt: correction: test_report_client uses PlacementDirect. The difference in usage between that and PlacementFixture is the context manager-ness.
17:31:55 efried but it sounds like you want the unit level stuff in any case.
17:33:24 melwitt right. but that's good info to know anyway. I'll need to use that too for the functional tests I think
17:34:10 openstackgerrit sean mooney proposed openstack/os-vif master: add addtion check and gate jobs for os-vif https://review.openstack.org/639732
17:34:32 efried melwitt: In case I don't otherwise notice, lmk when you've got code up, would like to review.
17:35:47 melwitt efried: the patch that adds placement calls is here https://review.openstack.org/638073 implementation done, test coverage is what I'm working on now
17:36:33 efried ack
17:45:32 efried melwitt: left a comment. So yeah, if you take that advice, you'll probably want a functional test in test_report_client; and you may decide a unit test isn't necessary.
17:46:30 melwitt efried: sweet, thanks
17:46:57 efried yw
18:33:38 openstackgerrit Merged openstack/nova master: Change LibvirtDriver.capabilities to an instance variable https://review.openstack.org/638677
18:34:04 openstackgerrit Ghanshyam Mann proposed openstack/python-novaclient master: DNM: Testing legacy jobs on bionic https://review.openstack.org/639768
18:37:30 efried aspiers: predecessor merged ^ -- The rebase is trivial, I would be happy to do that and address artom's nits at the same time, unless you're already working on it
18:38:00 aspiers efried: already working on it
18:38:05 efried okay
18:38:06 aspiers efried: I've already fixed his nits
18:38:15 aspiers however I think I may have noticed a missing test case
18:38:38 openstackgerrit Ghanshyam Mann proposed openstack/os-vif master: DNM: Testing legacy jobs on bionic https://review.openstack.org/639769
18:39:17 aspiers efried: if someone uses the placement API to put a capability trait on a compute host, and then at the next periodic the driver declares that cap is unsupported, it needs to be removed, right?
18:39:35 efried yes
18:39:45 efried that's, like, the primary use case here
18:39:51 efried That's not already covered by the tests?
18:39:59 aspiers I think I only tested removal of traits which were put there by the driver
18:40:04 aspiers I'm just checking now
18:40:30 efried okay. It would be one of the test cases with a compute manager reset() in it, if that helps you narrow it down.
18:42:10 aspiers Yeah, it's not there
18:42:51 openstackgerrit Merged openstack/nova master: remove deprecated os_brick import from ScaleIO driver https://review.openstack.org/638592
18:43:23 efried aspiers: be easy to fold it into test_report_cpu_traits
18:44:10 aspiers efried: I think it needs to go in test_servers.TraitsTrackingTests
18:44:19 aspiers that's where all the others are
18:44:21 efried either way.
18:44:40 aspiers unfortunately I've gotta go but I'll push the rebase as soon as I've covered this test case
18:45:39 efried okay.
18:54:45 mriedem efried: jaypipes: +2 on https://review.openstack.org/#/c/639653/ - bottom of the bw series now, adds report client functionality for removing part of allocations from the whole
19:06:31 openstackgerrit sean mooney proposed openstack/os-vif master: Add "master" parameter to ip.set() API function https://review.openstack.org/639702
19:06:32 openstackgerrit sean mooney proposed openstack/os-vif master: add addtional check and gate jobs for os-vif https://review.openstack.org/639732
19:10:04 sean-k-mooney jaypipes: melwitt ^ should fix the os-vif bug and add new gate jobs that will catch them in the future.
19:10:41 openstackgerrit Chris Friesen proposed openstack/nova master: Flavor extra spec and image properties validation https://review.openstack.org/620706
19:10:44 sean-k-mooney we will need to a do a 1.15.1 release to pick up that change. ill do that after teh ci reports back but i have tested it locally with iptables
19:11:28 efried mriedem: I can't remember why we decided to use retrying instead of the home-grown @retries in https://review.openstack.org/#/c/556669/, can you?
19:11:55 efried because I'm inclined to push for same in gibi's
19:12:30 mriedem https://review.openstack.org/#/c/556669/17/nova/utils.py@1301
19:12:59 mriedem i guess that's not what you're looking for
19:13:45 sean-k-mooney im going to grab dinner and kick off a devstack build of a linux bridge env and validated locally too.

Earlier   Later