Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2019-02-26
19:37:37 dansmith so we added that for the future backlash
19:37:59 dansmith not sure why we expose it in the api though, it's supposed to be a "do we display this in the api or not" flag
19:38:09 mriedem hmm, but GET /os-migrations is admin-only anyway
19:38:45 dansmith by default
19:38:48 mriedem sure
19:38:53 dansmith just sayin'
19:38:56 dansmith that was the reasoning
19:39:03 mriedem anyway, it's come up in https://review.openstack.org/#/c/636224/ as an alternative to filtering duplicate migrations by updated_at
19:39:29 mriedem because with cross-cell resize i'm hiding the instance using this instance.hidden field, and it would be pretty simple to do the same for migration.hidden,
19:39:35 mriedem but i'd have to thnk about implications to that API
19:40:35 mriedem especially because we have changes-since and changes-before filters on GET /os-migrations now too, so filtering duplicates based on updated_at is error prone
19:42:15 dansmith yeah I mean, hiding them using that flag until you're ready for them to be seen is probably reasonable I would think
19:47:57 mriedem jaypipes: we should probably sort this out before yonglihe is back online http://lists.openstack.org/pipermail/openstack-discuss/2019-February/003166.html
19:48:38 sean-k-mooney cfriesen: i am not sure. i woudl assume it is the operators responcibilty to install any helper functions needed
19:51:29 cfriesen sean-k-mooney: I just put the check in...you can see what you think when I push the next iteration. It's unfortunate but I couldn't find a way to query libvirt itself about support.
20:14:26 jaypipes mriedem: by "sort this out" I presume you mean that you convince me I'm wrong? :)
20:16:26 mriedem not necessarily
20:16:36 mriedem i understand your point
20:16:51 mriedem i also remember server group 'policies' being only exactly ever one
20:16:56 mriedem which seems pretty gross to me
20:18:00 mriedem and writing code to use the server group api i always have to remember that little wart
20:20:34 openstackgerrit Artom Lifshitz proposed openstack/nova master: New objects for NUMA live migration https://review.openstack.org/634827
20:20:34 openstackgerrit Artom Lifshitz proposed openstack/nova master: Introduce live_migration_claim() https://review.openstack.org/635669
20:20:35 openstackgerrit Artom Lifshitz proposed openstack/nova master: LM: add support for updating NUMA-related XML on the source https://review.openstack.org/635229
20:20:35 openstackgerrit Artom Lifshitz proposed openstack/nova master: LM: add support for sending NUMAMigrateData to the source https://review.openstack.org/634828
20:20:36 openstackgerrit Artom Lifshitz proposed openstack/nova master: [WIP needs more tests] Full NUMA live migration support https://review.openstack.org/634606
20:20:36 openstackgerrit Artom Lifshitz proposed openstack/nova master: RPC changes to prepare for NUMA live migration https://review.openstack.org/634605
20:20:37 openstackgerrit Artom Lifshitz proposed openstack/nova master: Make the use of the CastAsCall fixture configurable https://review.openstack.org/639428
20:20:46 mriedem not sure if edleafe or cdent (api sig) would have an opinion
20:26:12 jaypipes mriedem: well, having more than one policy for the same server group is bonkers. however, having an instance in more than one server group is, IMHO, *not* bonkers and is actually something we'd like to see at Oath. e.g. a user wants to add instances to two server groups, where server group one is a rack anti-affinity and server group two is a power-domain affinity, etc.
20:28:41 mriedem lots of people over time have tried to add support for adding/removing servers to/from groups, and it's just been rejected every time, so i don't see it happening anytime soon
20:28:44 mriedem i get the request
20:29:03 jaypipes mriedem: ack
20:29:40 jaypipes mriedem: well, like you said, we can always mod the API in the future if ever we support >1 server group on boot.
20:29:49 jaypipes mriedem: I'll relinquish
20:30:53 mriedem up to you, i just know our existing server groups stuff is very flaky so adding support for >1 group would be a big deal
20:30:59 mriedem which i just don't see happening anytime soon
20:32:07 jaypipes ack
21:13:00 openstackgerrit Chris Friesen proposed openstack/nova master: Add emulated TPM support to Nova https://review.openstack.org/631363
21:13:33 cfriesen sean-k-mooney: with this version ^ I can boot instances after setting the version/model in either flavor or image.
21:53:23 openstackgerrit Artom Lifshitz proposed openstack/nova master: Introduce live_migration_claim() https://review.openstack.org/635669
21:53:24 openstackgerrit Artom Lifshitz proposed openstack/nova master: LM: add support for sending NUMAMigrateData to the source https://review.openstack.org/634828
21:53:24 openstackgerrit Artom Lifshitz proposed openstack/nova master: New objects for NUMA live migration https://review.openstack.org/634827
21:53:25 openstackgerrit Artom Lifshitz proposed openstack/nova master: RPC changes to prepare for NUMA live migration https://review.openstack.org/634605
21:53:25 openstackgerrit Artom Lifshitz proposed openstack/nova master: LM: add support for updating NUMA-related XML on the source https://review.openstack.org/635229
21:53:26 openstackgerrit Artom Lifshitz proposed openstack/nova master: [WIP needs more tests] Full NUMA live migration support https://review.openstack.org/634606
21:53:26 openstackgerrit Artom Lifshitz proposed openstack/nova master: Make the use of the CastAsCall fixture configurable https://review.openstack.org/639428
21:53:45 artom ^^ actually pass my integration tests
21:54:33 openstackgerrit Merged openstack/os-vif master: Add native implementation OVSDB API https://review.openstack.org/482226
22:03:16 aspiers efried: wow, turns out that testtools.assertItemsEqual is horribly misleading
22:03:27 aspiers efried: I wasted about 5 hours before finding that
22:04:03 aspiers it fails miserably when comparing unicode traits with string traits
22:16:50 openstackgerrit Matt Riedemann proposed openstack/nova master: Add Migration.cross_cell_move and get_by_uuid https://review.openstack.org/614012
22:16:50 openstackgerrit Matt Riedemann proposed openstack/nova master: Improve CinderFixtureNewAttachFlow https://review.openstack.org/639382
22:16:51 openstackgerrit Matt Riedemann proposed openstack/nova master: Add Instance.hidden field https://review.openstack.org/631123
22:16:51 openstackgerrit Matt Riedemann proposed openstack/nova master: Add InstanceAction/Event create() method https://review.openstack.org/614036
22:16:52 openstackgerrit Matt Riedemann proposed openstack/nova master: Add CrossCellMigrationTask https://review.openstack.org/631581
22:16:52 openstackgerrit Matt Riedemann proposed openstack/nova master: Add TargetDBSetupTask https://review.openstack.org/627892
22:16:53 openstackgerrit Matt Riedemann proposed openstack/nova master: Add can_connect_volume() compute driver method https://review.openstack.org/621313
22:16:53 openstackgerrit Matt Riedemann proposed openstack/nova master: Execute TargetDBSetupTask https://review.openstack.org/633853
22:16:54 openstackgerrit Matt Riedemann proposed openstack/nova master: Add PrepResizeAtDestTask https://review.openstack.org/627890
22:16:54 openstackgerrit Matt Riedemann proposed openstack/nova master: Add prep_snapshot_based_resize_at_dest compute method https://review.openstack.org/633293
22:16:55 openstackgerrit Matt Riedemann proposed openstack/nova master: Add nova.compute.utils.delete_image https://review.openstack.org/637605
22:16:55 openstackgerrit Matt Riedemann proposed openstack/nova master: Add prep_snapshot_based_resize_at_source compute method https://review.openstack.org/634832
22:16:56 openstackgerrit Matt Riedemann proposed openstack/nova master: WIP: Add finish_snapshot_based_resize_at_dest compute method https://review.openstack.org/635080
22:16:56 openstackgerrit Matt Riedemann proposed openstack/nova master: Add PrepResizeAtSourceTask https://review.openstack.org/627891
22:16:57 openstackgerrit Matt Riedemann proposed openstack/nova master: Add Destination.allow_cross_cell_move field https://review.openstack.org/614035
22:16:57 openstackgerrit Matt Riedemann proposed openstack/nova master: Add FinishResizeAtDestTask https://review.openstack.org/635646
22:16:58 openstackgerrit Matt Riedemann proposed openstack/nova master: Plumb allow_cross_cell_resize into compute API resize() https://review.openstack.org/635684
22:16:58 openstackgerrit Matt Riedemann proposed openstack/nova master: Execute CrossCellMigrationTask from MigrationTask https://review.openstack.org/635668
22:16:59 openstackgerrit Matt Riedemann proposed openstack/nova master: Change HostManager to allow scheduling to other cells https://review.openstack.org/614037
22:16:59 openstackgerrit Matt Riedemann proposed openstack/nova master: Filter duplicates from compute API get_migrations_sorted() https://review.openstack.org/636224
22:17:51 mriedem i feel robbed when i push up 33 changes but gerrritbot only shows 20
22:17:56 aspiers haha
22:18:08 aspiers don't worry, stackalytics will get them all
22:24:43 efried aspiers: wow. Any idea why that other test was interfering?
22:25:50 aspiers efried: COMPUTE_VOLUME_MULTI_ATTACH is present when the SRIOV test is run first, I haven't figured out why yet
22:26:00 efried yeah, that's weird.
22:26:04 aspiers I was chasing completely the wrong trait thanks to testtools
22:28:21 aspiers efried: https://bugs.launchpad.net/testtools/+bug/1817800
22:28:22 openstack Launchpad bug 1817800 in testtools "assertItemsEqual output is misleading when comparing unicode with str" [Undecided,New]
22:29:37 mriedem aspiers: is the driver.capabilities at the class or member level?
22:29:42 mriedem for the LibvirtDriver?
22:29:54 mriedem or FakeDriver - whatever you're using
22:30:15 aspiers in this case it's at the class level, so yeah that would explain the lack of test isolation
22:30:27 aspiers however https://review.openstack.org/#/c/638677/1
22:30:44 mriedem are your tests using the FakeDriver though?
22:30:48 aspiers no
22:30:57 aspiers functional tests use libvirt driver
22:31:26 aspiers (probably foolishly) I stacked that fix on top of your rebased capabilities-to-traits patch which is currently failing
22:31:37 aspiers if I'd put it underneath, it would probably have fixed this
22:31:40 aspiers let me try that now
22:42:30 aspiers BOOM. Works!
22:45:38 openstackgerrit Adam Spiers proposed openstack/nova master: Change LibvirtDriver.capabilities to an instance variable https://review.openstack.org/638677
22:52:14 openstackgerrit Adam Spiers proposed openstack/nova master: Convert driver supported capabilities to compute node provider traits https://review.openstack.org/538498
23:02:34 openstackgerrit Theodoros Tsioutsias proposed openstack/nova master: Add requested_networks to RequestSpec https://review.openstack.org/570201
23:02:35 openstackgerrit Theodoros Tsioutsias proposed openstack/nova master: Enable rebuild for instances in cell0 https://review.openstack.org/570203
23:03:24 openstackgerrit Theodoros Tsioutsias proposed openstack/nova master: Allow rebuild for instances in PENDING state https://review.openstack.org/637585
23:03:24 openstackgerrit Theodoros Tsioutsias proposed openstack/nova master: Introduce the PENDING instance state https://review.openstack.org/566473
23:05:33 melwitt jaypipes: thanks for the reviews :D nice point in patch 2, I replied. maybe I need to redo the whole thing with user_id as non-nullable, and try to populate it in _from_db_object (the way that queued_for_delete does). I began that way originally, but didn't think of using build request for the case where cell_id=NULL :(

Earlier   Later