Earlier  
Posted Nick Remark
#openstack-nova - 2019-02-25
01:16:32 openstackgerrit Zhenyu Zheng proposed openstack/nova master: Add method to allow reset fields for root bdm in BDM obj https://review.openstack.org/614672
01:17:04 openstackgerrit Zhenyu Zheng proposed openstack/nova master: Bump compute service to indicate attach/detach root volume is supported https://review.openstack.org/614750
01:58:34 openstackgerrit Yongli He proposed openstack/nova master: Add server subresouce topology API https://review.openstack.org/621476
02:00:42 yonglihe mriedem: runway seems already got 3 items, i did not put https://review.openstack.org/#/c/621474/21 in the run way for now.
02:02:11 yonglihe do i still allow to add more?
02:03:51 openstackgerrit Zhenyu Zheng proposed openstack/nova master: Bump compute service to indicate attach/detach root volume is supported https://review.openstack.org/614750
02:07:23 openstackgerrit Zhenyu Zheng proposed openstack/nova master: Bump compute service to indicate attach/detach root volume is supported https://review.openstack.org/614750
05:18:53 zhubx007 Can anyone help to take a look at this https://review.openstack.org/#/c/638080/? Thanks.
05:24:14 openstackgerrit melanie witt proposed openstack/nova master: Populate InstanceMapping.user_id during migrations and schedules https://review.openstack.org/638574
05:24:15 openstackgerrit melanie witt proposed openstack/nova master: WIP Add get_counts() to InstanceMappingList https://review.openstack.org/638072
05:24:15 openstackgerrit melanie witt proposed openstack/nova master: WIP Add online data migration for populating user_id https://review.openstack.org/633351
05:24:16 openstackgerrit melanie witt proposed openstack/nova master: Use instance mappings to count server group members https://review.openstack.org/638324
05:24:16 openstackgerrit melanie witt proposed openstack/nova master: WIP Count instances from mappings and cores/ram from placement https://review.openstack.org/638073
05:38:36 openstackgerrit Brin Zhang proposed openstack/nova master: Creating a flavor only supports the integer type https://review.openstack.org/639012
06:09:26 openstackgerrit Yongli He proposed openstack/nova master: Add server subresouce topology API https://review.openstack.org/621476
06:17:29 yonglihe alex_xu: Updated the topology subresource per your comments, please check it. and should i put 2 of them on the stein-runway? There is already 3 items.
06:21:43 openstackgerrit Yongli He proposed openstack/nova master: Add server sub-resource topology API https://review.openstack.org/621476
06:27:57 openstackgerrit Ghanshyam Mann proposed openstack/nova master: WIP: Testing nova legacy jobs on bionic https://review.openstack.org/639017
06:36:40 openstackgerrit Ghanshyam Mann proposed openstack/nova master: WIP: Testing nova legacy jobs on bionic https://review.openstack.org/639017
08:05:02 openstackgerrit Yongli He proposed openstack/nova master: Adds the server group info into show server detail API. https://review.openstack.org/621474
08:06:39 kashyap sean-k-mooney: Hi, when you're about, what is the URL again to see if there's a pattern/trend of this bug: https://bugs.launchpad.net/nova/+bug/1817324
08:06:40 openstack Launchpad bug 1817324 in OpenStack Compute (nova) "Intermittent "Failed to start libvirt guest: libvirt.libvirtError: monitor socket did not show up: No such file or directory" failures in the gate" [Undecided,Confirmed]
08:06:55 kashyap "Ara" reports I guess
08:14:06 kashyap Hmm, I see indexing is behind by 76 hours: http://status.openstack.org/elastic-recheck/
08:16:45 openstackgerrit Zhenyu Zheng proposed openstack/nova master: Detach/Attach root volume API changes https://review.openstack.org/623981
08:56:45 openstackgerrit Tetsuro Nakamura proposed openstack/nova-specs master: Update alloc-candidates-in-tree https://review.openstack.org/639033
09:35:03 openstackgerrit Yongli He proposed openstack/nova master: Add server sub-resource topology API https://review.openstack.org/621476
09:37:30 openstackgerrit Yongli He proposed openstack/nova master: Add server sub-resource topology API https://review.openstack.org/621476
10:03:18 openstackgerrit Surya Seetharaman proposed openstack/nova master: [Doc] Best practices for effectively tolerating down cells https://review.openstack.org/638173
10:49:40 openstackgerrit Adam Spiers proposed openstack/nova master: Add new "supports_amd_sev" capability to libvirt driver https://review.openstack.org/638680
11:00:33 openstackgerrit Adam Spiers proposed openstack/nova master: Add new "supports_amd_sev" capability to libvirt driver https://review.openstack.org/638680
11:02:36 openstackgerrit ya.wang proposed openstack/nova master: Select cpu model from a list of cpu models https://review.openstack.org/637834
11:06:35 sean-k-mooney kashyap: you can go directly into logstack's kiban instance http://logstash.openstack.org/#/dashboard/file/logstash.json
11:08:43 kashyap sean-k-mooney: Yep, noted
11:13:55 lyarwood mdbooth: https://review.openstack.org/#/c/637527/ - If you have time today would you mind going over this again given our discussion on Friday?
11:18:14 mdbooth lyarwood: Yep, sure. Will do it now.
11:18:48 lyarwood mdbooth: thanks
11:19:44 mdbooth lyarwood: Although... Hmm. I wonder if my comments are still relevant, despite my previous misunderstanding.
11:20:33 mdbooth lyarwood: Backend_names != hosts, right?
11:21:13 lyarwood mdbooth: they should form part of the hostname itself
11:21:19 lyarwood mdbooth: host@backend#type
11:22:02 mdbooth Ok, so if there's 1 c-vol and 2 backend_names then there are 2 'hosts' as reported by list_hosts()?
11:22:37 lyarwood correct
11:23:11 lyarwood c-api is all over the place tbh
11:25:57 mdbooth https://developer.openstack.org/api-ref/block-storage/v3/index.html?expanded=list-all-hosts-for-a-project-detail#hosts-extension-os-hosts
11:26:19 mdbooth The 'cinder-volume' in that case has host@backend
11:29:04 lyarwood mdbooth: right sorry, src_host is coming from os-vol-host-attr:host on the volume and that's host@backend#type
11:29:17 lyarwood mdbooth: or at least that can be host@backend#type
11:29:50 lyarwood mdbooth: thus the host_name not in src_host check when trying to find a destination host
11:33:59 mdbooth lyarwood: Does host *always* have #type appended?
11:34:14 mdbooth Because you're doing a straight string comparison
11:39:46 lyarwood mdbooth: volume['os-vol-host-attr:host'] appears to, again I was wrong about host['host_name'], it doesn't contain #type
11:44:47 mdbooth lyarwood: Ok, does that mean you need to parse #type out of the former?
11:45:09 mdbooth It would be nice if this was consistent
11:46:14 lyarwood mdbooth: I don't think so, we only care about the host@backend part here for migrations
11:46:45 lyarwood mdbooth: we are just checking that the host@backend isn't hosting the volume at present
11:46:57 lyarwood mdbooth: the type isn't a factor here
11:47:05 mdbooth lyarwood: Right, but if I've understood what you've just told me, you're doing a string comparson between node@backend#type and node@backend, which is going to fail
11:47:36 lyarwood mdbooth: other way around, node@backend not in node@backend#type
11:48:05 mdbooth Ah, you're doing a not in, not a string comparison...
11:48:22 mdbooth Eww
11:48:28 mdbooth But I see
11:49:14 lyarwood yeah I can spell that out more in a comment
11:56:26 mdbooth lyarwood: Updated.
11:56:39 lyarwood mdbooth: thanks, would you mind hitting the actual nova bugfix while you're at it
11:56:45 lyarwood mdbooth: https://review.openstack.org/#/c/637224/
11:56:57 mdbooth lyarwood: I've asked for additional assertions, but I think you can cut/paste them out of my old patch.
11:57:57 openstackgerrit Zhenyu Zheng proposed openstack/nova master: Detach/Attach root volume API changes https://review.openstack.org/623981
11:58:04 lyarwood mdbooth: ack thanks
11:58:34 openstackgerrit Merged openstack/nova stable/rocky: Avoid redundant initialize_connection on source post live migration https://review.openstack.org/636895
11:58:47 lyarwood finally
11:58:56 mdbooth lyarwood: Thinking about it, you might need to split up the tempest test into the familiar 'assert incorrect behaviour', 'fix incorrect behaviour' 2 part series.
11:59:04 mdbooth lyarwood: Nice :)
11:59:33 lyarwood mdbooth: I don't think we do that with tempest test additions tbh
12:00:04 mdbooth Because I think we want the nova fix to Depends-On the change which asserts the correct behaviour in retype so as to avoid a regression.
12:00:47 mdbooth But once you've landed the assertions I asked for against migration, the tempest test will fail until the nova fix lands.
12:01:23 mdbooth (Which highlights why the assertions are required, btw)
12:02:12 lyarwood mdbooth: The tempest changes will depend on the Nova fix
12:02:43 lyarwood mdbooth: we can land some updates to the existing retype assertions outside of that
12:02:46 mdbooth lyarwood: So you want to add the assertions to *retype* before landing the Nova change, because that asserts that you're not regressing retype
12:03:03 lyarwood mdbooth: yeah that's simple enough to land first
12:04:00 lyarwood mdbooth: so retype assertions update, nova fix and finally tempest migration test right?
12:04:07 mdbooth lyarwood: Yeah
12:05:07 mdbooth So the Nova change will depends-on the retype tempest addition. The full tempest test will depends-on the nova change.
12:05:18 lyarwood correct
12:05:44 lyarwood zuul++
12:40:27 mdbooth lyarwood: Done. -1 is for discussed tempest change. Unit test change could be a nit, but one I really think we should fix. I'd like to see +1 from a cinder dev before anybody +2s it.
12:48:47 openstackgerrit Zhenyu Zheng proposed openstack/nova master: Detach/Attach root volume API changes https://review.openstack.org/623981
13:02:59 openstackgerrit Merged openstack/os-vif master: remove brctl from vif_plug_ovs https://review.openstack.org/636821
13:10:36 zhubx007 Can anyone help to take a look at this https://review.openstack.org/#/c/638080/? A bug fix. Thanks.
13:19:54 mdbooth zhubx007: That isn't going to fly for a few reasons. One of which is that by using automatic format detection it opens a potential security hole in image import.
13:19:54 jaypipes sean-k-mooney: trying to get through all os-vif patches you list in your email today.
13:20:40 mdbooth zhubx007: In fact I'm almost certain that would open a major security hole.
13:20:48 sean-k-mooney jaypipes: thanks. im respinning "make functional tests run on python 3" based on the feedback
13:21:29 mdbooth zhubx007: Allowing any authenticated tenant to read all data from the compute host.
13:21:57 jangutter jaypipes: I think that bridge+routing code is the classic monkeys+bananas thing.
13:24:18 sean-k-mooney jaypipes: does the timeline and porities make sense. once the final brctl patch merges we have reached the mvp for stien the rest are nice to have but dont block features
13:31:02 gibi jaypipes: hi! the next couple of patches in the bandwidth series (staring here https://review.openstack.org/#/c/616240) has mriedem's +2 on it. I'm working on a fup to fix his comments. So if you have time could you look at the series again?
13:34:27 jaypipes sean-k-mooney: I'd like to get the native ovslib stuff in if possible.
13:34:36 jaypipes gibi: yup

Earlier   Later