| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2019-02-22 | |||
| 17:27:50 | mriedem | oh yeah this https://github.com/openstack/nova/blob/master/nova/scheduler/client/report.py#L172 | |
| 17:27:57 | mriedem | umm, i think that's probably true | |
| 17:28:10 | mriedem | so rather than me remove that comment, just remove the code | |
| 17:28:24 | fried_rice | meaning L169-179 can be reduced to L170-171 | |
| 17:28:43 | fried_rice | but only if we can prove that we only call this method for evacuate. | |
| 17:28:57 | mriedem | i'll fart with it | |
| 17:29:14 | mriedem | any opinions on the brain dump in https://bugs.launchpad.net/nova/+bug/1790204/comments/14 are also appreciated | |
| 17:29:15 | openstack | Launchpad bug 1790204 in OpenStack Compute (nova) "Allocations are "doubled up" on same host resize even though there is only 1 server on the host" [High,Triaged] | |
| 17:29:28 | mriedem | because there have been several "what if we did this?" talking to myselfs in that bug report by now | |
| 17:32:19 | cdent | a) i'm glad mriedem is looking into this and playing the what if game, b) i'm sad that we have some many what ifs in this part of the code, c) let's rewrite the whole thing! | |
| 17:32:57 | mriedem | if we rewrote the whole thing, we'd just (d) regress some other shit corner case we didn't think about | |
| 17:33:34 | mriedem | the retrospective on this is probably that we are not good about testing at-capacity hosts | |
| 17:33:51 | mriedem | our functoinal tests are always building and migrating to hosts with near infinite capacity | |
| 17:33:56 | cdent | regressions is how we create new contributors :D | |
| 17:35:07 | mriedem | our public cloud ops team is super anal about packing as much as possible, so that's how they noticed this | |
| 17:36:06 | melwitt | any new contributors want to write at-capacity test coverage? :P | |
| 17:36:44 | mriedem | well we have https://review.openstack.org/#/c/619123/ for this bug at least | |
| 17:36:49 | melwitt | (either way, we need it) | |
| 17:37:06 | mriedem | not really sure we have new contributors | |
| 17:37:12 | mriedem | we have old grizzled contributors | |
| 17:37:14 | melwitt | yeah. I was just kidding | |
| 17:37:20 | mriedem | aspiers is new i guess | |
| 17:37:22 | mriedem | full of hope | |
| 17:37:29 | mriedem | (new to nova) | |
| 17:37:42 | melwitt | haha (it's true) | |
| 17:37:51 | temka | So you're saying we should break him by making him convert mox to mock? | |
| 17:38:01 | mriedem | no i never suggested anyone do that | |
| 17:38:05 | mriedem | i actively lobbied against that | |
| 17:38:08 | mriedem | to no avail | |
| 17:38:40 | cdent | too old. too grizzled. to no avail. | |
| 17:38:46 | temka | mriedem, btw, I think we need to put the brakes on https://review.openstack.org/#/c/636210/9 for now - the changed unit tests are failing in the patch above it: http://logs.openstack.org/05/634605/16/check/openstack-tox-lower-constraints/83c2d08/testr_results.html.gz | |
| 17:38:56 | temka | Is my -W enough? | |
| 17:39:04 | mriedem | nope | |
| 17:39:12 | mriedem | you'll have to change the commit message or something to pull it from zuul | |
| 17:39:59 | kashyap | mriedem: Since you politely implied `git blame` on the version bump patch ... :-) I'd want to certinly tell you that the failure was _not_ related to it. | |
| 17:40:57 | openstackgerrit | Artom Lifshitz proposed openstack/nova master: [DERP] Remove _legacy_dict methods https://review.openstack.org/636210 | |
| 17:40:58 | openstackgerrit | Artom Lifshitz proposed openstack/nova master: Introduce live_migration_claim() https://review.openstack.org/635669 | |
| 17:40:58 | openstackgerrit | Artom Lifshitz proposed openstack/nova master: Add migration param to check_can_live_migrate_destination https://review.openstack.org/634605 | |
| 17:40:59 | openstackgerrit | Artom Lifshitz proposed openstack/nova master: Use live_migration_claim() to check dest resources https://review.openstack.org/634606 | |
| 17:41:00 | openstackgerrit | Artom Lifshitz proposed openstack/nova master: LM: update NUMA-related XML on the source https://review.openstack.org/635229 | |
| 17:41:00 | openstackgerrit | Artom Lifshitz proposed openstack/nova master: LM: Make dest send NUMAMigrateData to the source https://review.openstack.org/634828 | |
| 17:41:00 | openstackgerrit | Artom Lifshitz proposed openstack/nova master: New objects to transmit NUMA config from dest to source https://review.openstack.org/634827 | |
| 17:41:01 | openstackgerrit | Artom Lifshitz proposed openstack/nova master: [WIP] Drop MoveClaim in rollback_live_migration_at_destination https://review.openstack.org/638654 | |
| 17:41:24 | mriedem | kashyap: ok ok | |
| 17:41:56 | kashyap | I just spent 2 hours talking to the QEMU guys to carefully go through all the logs. I've got a couple of nice action items for DevStack, though :-) | |
| 17:42:18 | kashyap | I'll write a comment from the investigation. And see if a "trend" shows up on Monday. (1 failure is not a trend :D) | |
| 17:51:01 | aspiers | haha | |
| 17:51:24 | aspiers | mriedem: I wish I could say I'm young and naive but I'm just ... naive | |
| 17:51:29 | mriedem | kashyap: logstash is also behind so i'm not sure if it's rare or new | |
| 17:52:01 | melwitt | dansmith: as one of the primary reviewers on the spec, you might fancy reviewing the patch for ironic conductor groups. has one +2 already https://review.openstack.org/635006 | |
| 17:52:16 | dansmith | guhhhh | |
| 17:52:21 | dansmith | it's friday, don't make me work | |
| 17:52:24 | aspiers | OK it's time for the weekend. Thanks all for your help, catch you next week o/ | |
| 17:52:39 | temka | dansmith, don't be so edgy | |
| 17:52:46 | melwitt | haha | |
| 17:53:27 | kashyap | mriedem: Yeah, I saw your comment on indexing; I'm really curious now, after all the time I spent tongiht | |
| 17:53:38 | kashyap | mriedem: Monday I should get to know I suppose, if there's a pattern | |
| 17:54:06 | kashyap | dansmith: You'll like this: https://basecamp.com/books/calm | |
| 17:54:36 | openstackgerrit | Stephen Finucane proposed openstack/nova-specs master: Add 'flavor-extra-spec-image-property-validation' spec https://review.openstack.org/638734 | |
| 17:54:39 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Remove misleading code from _move_operation_alloc_request() https://review.openstack.org/638700 | |
| 17:54:44 | mriedem | fried_rice: ^ | |
| 17:55:27 | mriedem | "It Doesn't Have to Be Crazy at Work (if you work in the EU" | |
| 17:58:53 | kashyap | LOL | |
| 17:59:10 | kashyap | Well ... it is always "hustle" if you make it a hustle :D | |
| 17:59:58 | kashyap | (That book is written by Americans :D) One of them is a Rails co-founder. They _really_ know what they're talking about. | |
| 18:01:19 | kashyap | ) The Rails part is to note that it's written by a developer, and not some "tech journalist" | |
| 18:01:30 | kashyap | Anyhow, /me --> dinner and air | |
| 18:33:21 | openstackgerrit | Artom Lifshitz proposed openstack/nova master: Remove _legacy_dict methods https://review.openstack.org/636210 | |
| 18:33:22 | openstackgerrit | Artom Lifshitz proposed openstack/nova master: Introduce live_migration_claim() https://review.openstack.org/635669 | |
| 18:33:22 | openstackgerrit | Artom Lifshitz proposed openstack/nova master: Add migration param to check_can_live_migrate_destination https://review.openstack.org/634605 | |
| 18:33:23 | openstackgerrit | Artom Lifshitz proposed openstack/nova master: New objects to transmit NUMA config from dest to source https://review.openstack.org/634827 | |
| 18:33:23 | openstackgerrit | Artom Lifshitz proposed openstack/nova master: Use live_migration_claim() to check dest resources https://review.openstack.org/634606 | |
| 18:33:24 | openstackgerrit | Artom Lifshitz proposed openstack/nova master: LM: update NUMA-related XML on the source https://review.openstack.org/635229 | |
| 18:33:24 | openstackgerrit | Artom Lifshitz proposed openstack/nova master: LM: Make dest send NUMAMigrateData to the source https://review.openstack.org/634828 | |
| 18:33:25 | openstackgerrit | Artom Lifshitz proposed openstack/nova master: [WIP] Drop MoveClaim in rollback_live_migration_at_destination https://review.openstack.org/638654 | |
| 18:34:30 | temka | mriedem_lunch, fixed https://review.openstack.org/#/c/636210/11 when you're back | |
| 18:34:43 | temka | Or actually dansmith, you wanna handle it? | |
| 18:35:31 | dansmith | temka: what was the issue? | |
| 18:36:08 | temka | There's a field called connection_info_json that's a string, but was being printed the way a dict would | |
| 18:36:27 | temka | So I was trying and failing to assert equality between two dicts when they were actually strings | |
| 18:37:01 | temka | Or rather, I was asserting about their containing dicts, and sometimes the JSON would be in the wrong order and compare false | |
| 18:37:30 | temka | And I was trying to fix it by treating the JSON like a dict, when I should have just loads and compared that | |
| 18:38:47 | dansmith | ah, Is ee | |
| 18:39:37 | sean-k-mooney | i have no other context of this but just looking a dmesg after a kernel update i noticed this | |
| 18:39:40 | sean-k-mooney | "capability: warning: `privsep-helper' uses deprecated v2 capabilities in a way that may be insecure" | |
| 18:41:02 | sean-k-mooney | considering this is an an all in one containerised deployment i have no idea which privsep-help that might be but i have never noticed this before | |
| 18:41:07 | temka | dansmith, cheers! | |
| 18:48:41 | dansmith | fried_rice: I just -1d this that you had +2d.. not sure if you know the answer to my concern, but: https://review.openstack.org/#/c/635006 | |
| 19:13:57 | dansmith | jroll: ^ | |
| 19:14:42 | jroll | y u so mean | |
| 19:15:50 | dansmith | man, I've deleted like three non-PC joke responses to that | |
| 19:16:51 | jroll | heh | |
| 19:19:07 | jroll | dansmith: even worse, I agree with you | |
| 19:19:13 | jroll | I'll respin monday morning | |
| 19:19:16 | dansmith | YASS | |
| 19:25:36 | mriedem | twizzlers really needs to rethink their packaging because the smashed together brick of licorice that you have to destroy the bag to get 1 rope from is frustrating | |
| 19:26:07 | jroll | you need fresher twizzlers yo | |
| 19:26:16 | mriedem | does not exist | |
| 19:26:53 | mriedem | and by destroying the bag, you guarantee staleness within 48 hours | |
| 19:27:20 | temka | Solution: eat the whole bag. | |