Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2019-02-13
09:18:19 gibi then I got the reason of the change in _create_consoles_qemu_kvm()
09:18:26 kashyap Exactly
09:18:44 kashyap If 'virtlogd' is available, the _create_file_device() just returns.
09:18:49 gibi kashyap: correct
09:19:02 kashyap So, we just elided the whole function, and the places where it is called
09:19:08 kashyap Including the one in s390x
09:19:36 kashyap (_create_file_device() was called in two places, and both the two occurrences were removed)
09:20:01 gibi but in the s390x you replaced the removed _create_file_device call with a _create_pty_device call
09:21:13 gibi is that _create_pty_device for sclplm needed for our always-use-virtlogd case?
09:21:44 kashyap That I can use some s390x eyes :-(
09:22:26 kashyap Let me check with a libvirt dev on that
09:22:37 gibi kashyap: thanks for taking care of it
09:23:10 kashyap gibi: Thanks for the careful review
09:30:01 openstackgerrit Zhenyu Zheng proposed openstack/nova master: Add method to allow reset fields for root bdm in BDM obj https://review.openstack.org/614672
09:30:56 kashyap gibi: So, the "sclplm" is required, here is the background from the Nova spec that added support for s390x:
09:30:59 kashyap [quote]
09:31:00 kashyap For the interactive console and the log of OpenStack instances, console devices need to be generated (instead of serial devices), if the host architecture is System z (see [2]). These console devices need to have a target type "sclp" for the interactive console of OpenStack, and "sclplm" for the log of OpenStack.
09:31:05 kashyap [/quote]
09:46:24 gibi kashyap: do we have some kind of CI for s390x?
09:46:52 kashyap gibi: I see "IBM zKVM CI"
09:47:08 kashyap And when I click on its log, I get a "Not Found"
09:48:06 gibi it voted for PS2 and PS3 of your patch
09:48:12 gibi but nothing newer
09:48:38 gibi and yeah, I also cannot get to the logs
09:48:57 kashyap Hmm
09:49:14 kashyap gibi: I'm first asking an s390x developer about the behaviour ... because it is all black box for me
09:51:48 gibi me too
09:56:42 Shilpa coreycb: hi
10:05:06 openstackgerrit Balazs Gibizer proposed openstack/nova master: Fill the RequestGroup mapping during schedule https://review.openstack.org/619528
10:05:06 openstackgerrit Balazs Gibizer proposed openstack/nova master: Calculate RequestGroup resource provider mapping https://review.openstack.org/616239
10:05:07 openstackgerrit Balazs Gibizer proposed openstack/nova master: Recalculate request group - RP mapping during re-schedule https://review.openstack.org/619529
10:05:07 openstackgerrit Balazs Gibizer proposed openstack/nova master: Pass resource provider mapping to neutronv2 api https://review.openstack.org/616240
10:05:08 openstackgerrit Balazs Gibizer proposed openstack/nova master: Send RP uuid in the port binding https://review.openstack.org/569459
10:05:09 openstackgerrit Balazs Gibizer proposed openstack/nova master: Record requester in the InstancePCIRequest https://review.openstack.org/625310
10:05:09 openstackgerrit Balazs Gibizer proposed openstack/nova master: Remove port allocation during detach https://review.openstack.org/622421
10:05:09 openstackgerrit Balazs Gibizer proposed openstack/nova master: Test boot with more ports with bandwidth request https://review.openstack.org/573317
10:05:10 openstackgerrit Balazs Gibizer proposed openstack/nova master: Ensure that bandwidth and VF are from the same PF https://review.openstack.org/623543
10:05:10 openstackgerrit Balazs Gibizer proposed openstack/nova master: Add pf_interface_name tag to passthrough_whitelist https://review.openstack.org/625311
10:05:11 openstackgerrit Balazs Gibizer proposed openstack/nova master: Support server create with ports having resource request https://review.openstack.org/636360
10:12:28 openstackgerrit Silvan Kaiser proposed openstack/nova master: Added mount fstype based validation of Quobyte mounts https://review.openstack.org/522245
10:13:01 kashyap gibi: One thing the s390x maintainer in QEMU confirmed is that: 'pty' for "sclplm" device will work.
10:13:20 kashyap But I want to get one more view from DanPB, who wrote the 'virtlogd' daemon.
10:18:29 gibi kashyap: cool
10:18:50 gibi kashyap: you also have a nit in the commit message, about the new min Qemu version which should be 2.8.0 not 2.5.0
10:18:56 gibi besides these I'm OK with your patch
10:18:58 kashyap Ah, thank you
10:19:11 kashyap gibi: Yeah, getting this will allow me to clean up all the now needless version constants
10:19:26 kashyap And getting that unit tests fixed took 8 days :/
10:19:43 gibi yeah, I can imagine the pain
10:20:21 openstackgerrit Lee Yarwood proposed openstack/nova master: compute: Reject resize requests when the source host is down https://review.openstack.org/623489
10:20:33 stephenfin kashyap: Sorry, forgot to start HexChat. I thought mriedem had suggested we do that min version bump early in Train instead?
10:20:53 kashyap stephenfin: He was ambivalent on it.
10:21:36 kashyap stephenfin: IMHO, don't see any compelling blockers (/me hopes this statement doesn't come back to bite him)
10:22:02 stephenfin kashyap: Cool. I'll hold of +2ing personally until I double check, though I'd be happy to get it in of course
10:22:08 kashyap Re-working / rebasing the unit tests again for Train becomes a lot more more painful
10:22:29 kashyap stephenfin: I actually asked him (MattR) last night here, but his nick was _afk
10:24:20 kaisers stephenfin: Thanks, i updated the CL. If you're rolling I'd also be happy to have somebody revisit https://review.openstack.org/#/c/554195/
10:24:24 kashyap stephenfin: gibi: Release-wise, we're just about to reach M3 (Mar 04-08), and the GA is aroud 12-Apr — we still have decent time for this to soak in
10:26:10 openstackgerrit Silvan Kaiser proposed openstack/nova master: Exec systemd-run without --user flag in Quobyte driver https://review.openstack.org/554195
10:31:37 openstackgerrit Silvan Kaiser proposed openstack/nova master: Exec systemd-run without --user flag in Quobyte driver https://review.openstack.org/554195
10:45:18 stephenfin kashyap: Comments left. Just the commit message fix needed, fwict
10:45:29 kashyap stephenfin: Most excellent.
10:45:58 kashyap gibi: stephenfin: Meanwhile, I double-checked with DanPB, and what I'm doing is "sane". Here's the conversation snippet:
10:46:01 kashyap < kashyap> danpb: Is changing the behaviour in this case, by using the console type 'pty' instead of 'file' for s390x's "sclplm" okay?
10:46:04 kashyap < kashyap> (FWIW, checking with Corneila of s390x, she said using 'pty' type for "sclplm" device will work.)
10:46:07 kashyap < kashyap> If you're wondering WTH is this "sclplm", s390x has two types of console devices:
10:46:10 kashyap < danpb> the guest doesnt' care what's done in the backend
10:46:13 kashyap < kashyap> (1) "sclp" -- for interactive consoles
10:46:15 kashyap < kashyap> (2) "sclplm" -- for log files
10:46:18 kashyap < kashyap> danpb: Ah, okay, then.
10:46:20 kashyap < danpb> personally i'd just get rid of that duplication
10:46:23 kashyap < kashyap> Okay, I'll make that in a separate logical change
10:46:36 kashyap stephenfin: Thanks for the quick review!
10:47:36 kashyap stephenfin: Related to your comment, look up "negative code" here :-) -- https://en.wikipedia.org/wiki/Douglas_McIlroy#Views_on_computing
10:49:39 stephenfin kashyap: Very true, but there's no reason removing code can't be done in multiple steps to help grok'ability. See https://review.openstack.org/#/c/636384/ and the preceding patch
10:50:05 kashyap stephenfin: Oh, absolutely: I try to be iron-clad on the "one logical change per commit"
10:57:29 kashyap stephenfin: Nice work there.
10:59:01 openstackgerrit Sylvain Bauza proposed openstack/nova master: libvirt: implement reshaper for vgpu https://review.openstack.org/599208
10:59:02 openstackgerrit Sylvain Bauza proposed openstack/nova master: WIP: Use the correct mdev allocated from the pGPU https://review.openstack.org/636591
10:59:02 openstackgerrit Sylvain Bauza proposed openstack/nova master: Add functional test for libvirt vgpu reshape https://review.openstack.org/631559
10:59:24 bauzas gibi: ^
10:59:48 bauzas gibi: I thought about the fact that we blindly use mdevs without checking the pGPU
10:59:55 bauzas gibi: and I think it's not a problem
11:00:07 bauzas at least until we support multiple types
11:00:15 bauzas since libvirt will be able to find a specific mdev
11:00:40 bauzas that said, I'll take my old internal hardware and do a lot of checks
11:01:03 stephenfin kaisers: More comments on https://review.openstack.org/#/c/522245/ after a second reading
11:04:27 openstackgerrit Kashyap Chamarthy proposed openstack/nova master: libvirt: Bump MIN_{LIBVIRT,QEMU}_VERSION for "Stein" https://review.openstack.org/632507
11:04:46 kashyap gibi: stephenfin: When you can, addressed both your remarks ^
11:06:43 kaisers stephenfin: thnx, checkin' in a min
11:14:57 stephenfin kaisers: And on https://review.openstack.org/#/c/554195/2
11:28:06 kaisers stephenfin: yup, thnx again!
13:00:45 openstackgerrit Surya Seetharaman proposed openstack/nova master: API microversion 2.69: Handles Down Cells https://review.openstack.org/591657
13:00:45 openstackgerrit Surya Seetharaman proposed openstack/nova master: Plumbing required in servers ViewBuilder to construct partial results https://review.openstack.org/635146
13:00:46 openstackgerrit Surya Seetharaman proposed openstack/nova master: API microversion 2.69: Handles Down Cells Documentation https://review.openstack.org/635147
13:13:29 openstackgerrit Surya Seetharaman proposed openstack/nova master: API microversion 2.69: Handles Down Cells Documentation https://review.openstack.org/635147
13:15:22 openstackgerrit Jim Rollenhagen proposed openstack/nova master: ironic: partition compute services by conductor group https://review.openstack.org/635006
13:18:27 openstackgerrit Jim Rollenhagen proposed openstack/nova master: Ensure config regexes match the entire string https://review.openstack.org/636627
13:22:24 openstackgerrit Matt Riedemann proposed openstack/nova master: Change nova-next tempest test regex https://review.openstack.org/636459
13:28:12 Shilpa stephenfin: hi, under Taskflow, added https://bugs.launchpad.net/taskflow/+bug/1815738, do let me know is this active channel? Unable to trace PTL for this, but https://pypi.org/project/taskflow/ reports latest release in Jan'19

Earlier   Later