Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2019-02-13
00:36:09 openstackgerrit Michael Still proposed openstack/nova master: Move arping to privsep. https://review.openstack.org/624593
00:36:10 openstackgerrit Michael Still proposed openstack/nova master: Move killing processes to privsep. https://review.openstack.org/635432
00:36:10 openstackgerrit Michael Still proposed openstack/nova master: Privsepify ipv4 forwarding enablement. https://review.openstack.org/635431
00:36:11 openstackgerrit Michael Still proposed openstack/nova master: Cleanup the exec_ebtables code a little. https://review.openstack.org/635434
00:36:11 openstackgerrit Michael Still proposed openstack/nova master: Move FP device creation and deletion to privsep. https://review.openstack.org/635433
00:36:12 openstackgerrit Michael Still proposed openstack/nova master: Move adding vlans to interfaces to privsep. https://review.openstack.org/635436
00:36:12 openstackgerrit Michael Still proposed openstack/nova master: Privsep the ebtables modification code. https://review.openstack.org/635435
00:37:47 mriedem http://paste.openstack.org/show/744987/
00:38:40 dansmith also, eye mowt
00:41:05 sean-k-mooney mriedem: so that is effectivly returning the instance ids which we no because they are in the instance mapping table in the api db but everything else is the blank/the default value since the cell is down
00:42:22 mriedem yes
00:56:43 mriedem dansmith: ok, tried to capture the startup "hang" https://bugs.launchpad.net/nova/+bug/1815697
00:56:44 openstack Launchpad bug 1815697 in OpenStack Compute (nova) "[upgrade_levels]compute=auto grinds the API response times when a cell is down" [Medium,Confirmed]
00:56:54 mriedem by my calculation by default each API worker will take ~52 minutes to start...
06:34:01 openstackgerrit Merged openstack/nova master: Move binding ips to privsep. https://review.openstack.org/622151
06:41:37 openstackgerrit Takashi NATSUME proposed openstack/nova master: Fix resetting non-persistent fields when saving obj https://review.openstack.org/636271
09:00:21 kashyap Huzzah, all unit tests pass: https://review.openstack.org/#/c/632507/
09:00:48 openstackgerrit Lee Yarwood proposed openstack/nova master: WIP Restore connection_info after live migration rollback https://review.openstack.org/551349
09:01:11 kashyap gibi: Morning, when you have a minute, would really appreciate a couple of eyes on this: https://review.openstack.org/#/c/632507/ (libvirt: Bump MIN_{LIBVIRT,QEMU}_VERSION for "Stein")
09:01:19 kashyap stephenfin: ^
09:01:55 gibi kashyap: looking
09:02:54 kashyap The commit message explains it (hopefully). And getting this in reduces expensive rebase churn.
09:03:24 kashyap I'll be here to answer any questions.
09:05:59 kashyap The code that is being removed in driver.py is what the original author (markus_z) asked us to do in his "NOTE"
09:06:33 kashyap And FWIW, I double-checked with the libvirt upstream developers to ensure what I'm removing makes sense.
09:06:43 bauzas gibi: FWIW, I had to bail out yesterday early
09:06:55 bauzas gibi: so I'll upload my series now with a big -W
09:07:09 bauzas so we could discuss with other folks later
09:07:43 gibi bauzas: ack, I will look at it
09:08:11 gibi kashyap: is there a connection between the min version bump and the removed virtlogd code?
09:08:36 kashyap gibi: Yes, it is unavoidable (as noted in the commit message) in this case
09:08:46 kashyap Due to the version constant check
09:10:08 gibi kashyap: so the min version now bigger than what the virtlogd needs
09:10:27 openstackgerrit Lee Yarwood proposed openstack/nova master: WIP Restore connection_info after live migration rollback https://review.openstack.org/551349
09:10:27 openstackgerrit Lee Yarwood proposed openstack/nova master: Avoid redundant initialize_connection on source post live migration https://review.openstack.org/551302
09:10:46 gibi kashyap: so we can remove the check
09:10:54 kashyap Yes, indeed.
09:12:00 kashyap gibi: Oh, just noticed, I actually didn't remove two constant files themselves :-):
09:12:03 kashyap # Use the "logd" backend for handling stdout/stderr from QEMU processes.
09:12:08 kashyap MIN_LIBVIRT_VIRTLOGD = (1, 3, 3)
09:12:10 kashyap MIN_QEMU_VIRTLOGD = (2, 7, 0)
09:12:41 gibi kashyap: OK, then what I miss is the reason of the removal of self._create_file_device from _create_consoles_qemu_kvm()
09:12:53 gibi and the reason of the change in _create_consoles_s390x()
09:14:30 kashyap gibi: First is that: we're adding two serial devices — one of them bypasses Nova
09:15:20 kashyap And Nova should not allow an extra serial console (so that one can use external tools like `virsh` to monitor the guest serial console)
09:17:05 kashyap I'll the reasoning in the commit message (and for the _create_consoles_s390x() change)
09:17:30 gibi hm as far as I understand _create_file_device only makes sure that there is a console.log file
09:17:43 gibi ahh I see now
09:17:51 gibi that code is actually noop with virtlogd
09:18:19 gibi then I got the reason of the change in _create_consoles_qemu_kvm()
09:18:26 kashyap Exactly
09:18:44 kashyap If 'virtlogd' is available, the _create_file_device() just returns.
09:18:49 gibi kashyap: correct
09:19:02 kashyap So, we just elided the whole function, and the places where it is called
09:19:08 kashyap Including the one in s390x
09:19:36 kashyap (_create_file_device() was called in two places, and both the two occurrences were removed)
09:20:01 gibi but in the s390x you replaced the removed _create_file_device call with a _create_pty_device call
09:21:13 gibi is that _create_pty_device for sclplm needed for our always-use-virtlogd case?
09:21:44 kashyap That I can use some s390x eyes :-(
09:22:26 kashyap Let me check with a libvirt dev on that
09:22:37 gibi kashyap: thanks for taking care of it
09:23:10 kashyap gibi: Thanks for the careful review
09:30:01 openstackgerrit Zhenyu Zheng proposed openstack/nova master: Add method to allow reset fields for root bdm in BDM obj https://review.openstack.org/614672
09:30:56 kashyap gibi: So, the "sclplm" is required, here is the background from the Nova spec that added support for s390x:
09:30:59 kashyap [quote]
09:31:00 kashyap For the interactive console and the log of OpenStack instances, console devices need to be generated (instead of serial devices), if the host architecture is System z (see [2]). These console devices need to have a target type "sclp" for the interactive console of OpenStack, and "sclplm" for the log of OpenStack.
09:31:05 kashyap [/quote]
09:46:24 gibi kashyap: do we have some kind of CI for s390x?
09:46:52 kashyap gibi: I see "IBM zKVM CI"
09:47:08 kashyap And when I click on its log, I get a "Not Found"
09:48:06 gibi it voted for PS2 and PS3 of your patch
09:48:12 gibi but nothing newer
09:48:38 gibi and yeah, I also cannot get to the logs
09:48:57 kashyap Hmm
09:49:14 kashyap gibi: I'm first asking an s390x developer about the behaviour ... because it is all black box for me
09:51:48 gibi me too
09:56:42 Shilpa coreycb: hi
10:05:06 openstackgerrit Balazs Gibizer proposed openstack/nova master: Fill the RequestGroup mapping during schedule https://review.openstack.org/619528
10:05:06 openstackgerrit Balazs Gibizer proposed openstack/nova master: Calculate RequestGroup resource provider mapping https://review.openstack.org/616239
10:05:07 openstackgerrit Balazs Gibizer proposed openstack/nova master: Recalculate request group - RP mapping during re-schedule https://review.openstack.org/619529
10:05:07 openstackgerrit Balazs Gibizer proposed openstack/nova master: Pass resource provider mapping to neutronv2 api https://review.openstack.org/616240
10:05:08 openstackgerrit Balazs Gibizer proposed openstack/nova master: Send RP uuid in the port binding https://review.openstack.org/569459
10:05:09 openstackgerrit Balazs Gibizer proposed openstack/nova master: Record requester in the InstancePCIRequest https://review.openstack.org/625310
10:05:09 openstackgerrit Balazs Gibizer proposed openstack/nova master: Remove port allocation during detach https://review.openstack.org/622421
10:05:09 openstackgerrit Balazs Gibizer proposed openstack/nova master: Test boot with more ports with bandwidth request https://review.openstack.org/573317
10:05:10 openstackgerrit Balazs Gibizer proposed openstack/nova master: Ensure that bandwidth and VF are from the same PF https://review.openstack.org/623543
10:05:10 openstackgerrit Balazs Gibizer proposed openstack/nova master: Add pf_interface_name tag to passthrough_whitelist https://review.openstack.org/625311
10:05:11 openstackgerrit Balazs Gibizer proposed openstack/nova master: Support server create with ports having resource request https://review.openstack.org/636360
10:12:28 openstackgerrit Silvan Kaiser proposed openstack/nova master: Added mount fstype based validation of Quobyte mounts https://review.openstack.org/522245
10:13:01 kashyap gibi: One thing the s390x maintainer in QEMU confirmed is that: 'pty' for "sclplm" device will work.
10:13:20 kashyap But I want to get one more view from DanPB, who wrote the 'virtlogd' daemon.
10:18:29 gibi kashyap: cool
10:18:50 gibi kashyap: you also have a nit in the commit message, about the new min Qemu version which should be 2.8.0 not 2.5.0
10:18:56 gibi besides these I'm OK with your patch
10:18:58 kashyap Ah, thank you
10:19:11 kashyap gibi: Yeah, getting this will allow me to clean up all the now needless version constants
10:19:26 kashyap And getting that unit tests fixed took 8 days :/
10:19:43 gibi yeah, I can imagine the pain
10:20:21 openstackgerrit Lee Yarwood proposed openstack/nova master: compute: Reject resize requests when the source host is down https://review.openstack.org/623489
10:20:33 stephenfin kashyap: Sorry, forgot to start HexChat. I thought mriedem had suggested we do that min version bump early in Train instead?

Earlier   Later