| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2019-02-12 | |||
| 20:50:32 | mriedem | huh i see the 12.0.0 liberty GA release notes aren't published https://docs.openstack.org/releasenotes/nova/liberty.html | |
| 20:54:07 | mriedem | dansmith: you wanna help get the legacy-grenade-dsvm-neutron-multinode-live-migration job fixed? https://review.openstack.org/#/c/634962/ already +2d | |
| 20:55:31 | dansmith | DO I EVER | |
| 20:55:43 | mriedem | not sure why that job isn't voting, probably should be | |
| 20:55:58 | mriedem | seems like live migrating back and forth across n and n-1 nodes is good to keep working.. | |
| 21:00:46 | cfriesen | dansmith: how does https://git.openstack.org/cgit/openstack/nova/commit/?id=804215017f38300ac429e4401ce9c23f0c8ff3c6 avoid the traceback when it saves and re-raises the exception? | |
| 21:02:50 | dansmith | cfriesen: I think the point of that was to log the important details where we had them, which are lost in the generic stack trace above | |
| 21:02:52 | mriedem | cfriesen: i think the point is it's avoiding this https://review.openstack.org/#/c/546423/5/nova/virt/block_device.py@313 | |
| 21:03:25 | dansmith | ah, maybe that too, | |
| 21:03:45 | dansmith | but the bug was that the generic error got logged in like compute manager orsomething and it wasn't clear that the problem was that it failed to detach a volume | |
| 21:05:31 | mriedem | i'm +1 now on the down cell servers view builder change https://review.openstack.org/#/c/635146/ | |
| 21:05:39 | mriedem | withholding +2 for now since it calls out 2.69 | |
| 21:06:32 | artom | Can I rant about unit testing? I'm ranting about unit testing. Unit testing is not "mock everything the function calls and assert it was called the way the current implementation you're testing would. | |
| 21:09:06 | edleafe | artom: Most of our unit tests could be named "test_that_python_works" | |
| 21:09:33 | artom | edleafe, hah, I'm laughing now, but maybe I should cry? | |
| 21:17:19 | artom | mdbooth would love that | |
| 21:35:53 | aspiers | mriedem, efried: I seem to have successfully(?) rebased https://review.openstack.org/538498 on top of the removal of get_traits() | |
| 21:36:43 | aspiers | mriedem, efried: git-irebase has just brought it 250 commits closer to master, but it's just hit another conflict at master~788 so I've got a way to go still ... | |
| 21:36:59 | aspiers | but I think I actually sort of understand what's going on now, which is encouraging | |
| 21:37:18 | openstackgerrit | Artom Lifshitz proposed openstack/nova master: Add migration param to check_can_live_migrate_destination https://review.openstack.org/634605 | |
| 21:37:18 | openstackgerrit | Artom Lifshitz proposed openstack/nova master: Remove _legacy_dict methods https://review.openstack.org/636210 | |
| 21:37:19 | openstackgerrit | Artom Lifshitz proposed openstack/nova master: [WIP] Introduce live_migration_claim() https://review.openstack.org/635669 | |
| 21:37:19 | openstackgerrit | Artom Lifshitz proposed openstack/nova master: New objects to transmit NUMA config from dest to source https://review.openstack.org/634827 | |
| 21:37:20 | openstackgerrit | Artom Lifshitz proposed openstack/nova master: [WIP] LM: Make dest send NUMAMigrateData to the source https://review.openstack.org/634828 | |
| 21:37:20 | openstackgerrit | Artom Lifshitz proposed openstack/nova master: [WIP] Use live_migration_claim() to check dest resources https://review.openstack.org/634606 | |
| 21:37:21 | openstackgerrit | Artom Lifshitz proposed openstack/nova master: [WIP] LM: update NUMA-related XML on the source https://review.openstack.org/635229 | |
| 21:38:51 | aspiers | Ah, that conflict was super easy to resolve. Onwards... | |
| 21:40:55 | aspiers | OK, I think I am officially declaring git-irebase as awesome | |
| 21:44:08 | efried | aspiers: what is git-irebase? | |
| 21:44:17 | aspiers | incremental rebase | |
| 21:44:24 | aspiers | one commit at a time | |
| 21:44:34 | aspiers | so you are only ever resolving conflicts against a single commit | |
| 21:45:07 | efried | ye gods, that sounds like the hard way to go, but good on ya. | |
| 21:45:16 | aspiers | no, it's really easier | |
| 21:45:28 | aspiers | this change you pointed me at is over 1000 commits behind master | |
| 21:45:38 | aspiers | it conflicts with multiple commits along the way | |
| 21:45:44 | efried | right, but only a handful of those would have conflicted. | |
| 21:46:21 | aspiers | yes, but I would have had to understand *all* of those commits at the same time to resolve the conflict via a normal single-shot rebase | |
| 21:46:38 | aspiers | with code I've never seen before, that's a nightmare | |
| 21:46:49 | aspiers | even if I'd seen it I suspect it would have been tricky | |
| 21:47:31 | aspiers | I'm now at master~510 and so far I've had to handle one major conflict (the get_traits() removal from ironic driver) and 3 minor conflicts | |
| 21:49:00 | aspiers | also it means I can run the tests after each resolve, which increases the chances of catching logic errosr | |
| 21:49:30 | aspiers | just hit another major conflict | |
| 21:49:43 | aspiers | but it's only a single commit, so now manageable :) | |
| 21:51:46 | aspiers | ah it wasn't major, just a method signature change | |
| 21:54:24 | efried | aspiers: I looked at the all-in-one rebase, and you're right, it would be pretty hairy. Thanks for tackling it. | |
| 21:54:45 | aspiers | yw! only 307 commits behind master now :) | |
| 21:55:15 | aspiers | efried: do I understand that for adding an SEV capability to the libvirt driver, capabilities has to be an instance variable rather than a class variable (like for powervm) because the SEV capability is determined dynamically per host? | |
| 21:57:21 | efried | aspiers: I'm pretty sure that's what we figured out for the PowerVM image cache capability, which is based on which disk driver is set up. edmondsw, back me up here. | |
| 21:57:38 | aspiers | yeah, I saw the image cache cap being set at runtime | |
| 21:57:50 | efried | I actually can't remember the exact reason we couldn't use the class variable. | |
| 21:58:37 | efried | or maybe we just thought it was ugly to set PowerVMDriver.capabilities['image_cache'] from the context of 'self'. | |
| 21:58:40 | aspiers | presumably it varies from host to host - does the driver get instantiated once per host? | |
| 21:59:00 | efried | At least once, yes. | |
| 21:59:26 | efried | and it's the "possibly more than once" part that might be what gets you into trouble using a class var. But that doesn't make a lot of sense. | |
| 21:59:48 | efried | Let me go find the review where that happened. | |
| 22:01:03 | efried | aspiers: Ah, it may have just been for testing purposes: https://github.com/openstack/nova-powervm/commit/cc7564549a90a59f2ef27cca14862c33b9a07c25 | |
| 22:02:52 | aspiers | ahhh ok | |
| 22:03:14 | aspiers | rebase finished!! | |
| 22:03:28 | efried | swheet! | |
| 22:03:36 | aspiers | I think there were about 8 commits conflicting in total | |
| 22:03:44 | aspiers | out of ~1000 | |
| 22:03:46 | efried | quick, upload the rebase-only so you have a checkpoint. | |
| 22:03:57 | aspiers | to the same review? | |
| 22:04:00 | efried | absolutely | |
| 22:04:05 | aspiers | OK | |
| 22:05:28 | openstackgerrit | Adam Spiers proposed openstack/nova master: WIP: Convert driver supported capabilities to compute node provider traits https://review.openstack.org/538498 | |
| 22:06:39 | aspiers | efried: there ya go | |
| 22:06:55 | aspiers | who knows, Zuul might even verify it :) | |
| 22:07:11 | cdent | wow, that's like time travel or something | |
| 22:07:42 | efried | aspiers: I'm a fan of doing rebase in one PS and updates in another. Doing an incremental review when rebase+changes are in one PS is suck. | |
| 22:07:54 | aspiers | efried: totally agree | |
| 22:07:55 | efried | especially when the rebase is massive. | |
| 22:08:09 | mriedem | dansmith: comments in the down cell api microversion change https://review.openstack.org/#/c/591657/ - at this point i think i need to pull it into a devstack environment and kick the tires because I think it's being aggressive about processing filters when 'nova list' might send some parameters by default that would otherwise be ignored | |
| 22:08:26 | dansmith | mriedem: okay | |
| 22:08:56 | aspiers | efried: unfortunately in this case diffing between PS7 and my new PS8 is also full of suck, because we're running an ancient Gerrit which can't distinguish between real changes and stuff dragged in by the rebase | |
| 22:09:05 | aspiers | newer Gerrit handles this correctly | |
| 22:09:13 | efried | aspiers: customary to use -W instead of -1 to signify wip with changes on the way. | |
| 22:09:29 | efried | aspiers: Oh, really, there's a better gerrit where that's concerned? That would be pretty amazing. | |
| 22:09:30 | aspiers | efried: I would have if I had W permissions ... | |
| 22:09:40 | efried | aspiers: duh, of course. | |
| 22:09:44 | aspiers | XD | |
| 22:09:59 | aspiers | yes, I remember seeing it demoed at the Gerrit User Summit in London | |
| 22:10:07 | aspiers | I can maybe even find the youtube for you | |
| 22:10:10 | efried | As it stands, I open two tabs, one with old and one with new, and flip-diff 'em. | |
| 22:10:21 | aspiers | yeah, that's better | |
| 22:11:36 | aspiers | efried: https://youtu.be/yWTvUyvP24M?t=963 you can even see my shiny head in the 2nd row ;-) | |
| 22:12:26 | aspiers | although unfortunately we're still on 2.13, not even 2.14 yet let alone 2.15 ... | |
| 22:18:16 | aspiers | OK, time for a very late dinner... | |
| 22:18:23 | aspiers | l8rs | |
| 22:42:25 | edmondsw | efried yep, you found it... sorry, was in a mtg | |
| 22:42:30 | edmondsw | (in a lot of those these days...) | |
| 22:52:09 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Change nova-next tempest test regex https://review.openstack.org/636459 | |
| 22:52:24 | mriedem | ^ drops a bunch of tempest API tests that we don't care about for nova changes | |
| 22:52:41 | mriedem | hopefully making that job a bit faster and less redundant | |
| 23:08:45 | openstackgerrit | Merged openstack/nova master: Fix legacy-grenade-dsvm-neutron-multinode-live-migration https://review.openstack.org/634962 | |
| 23:10:38 | openstackgerrit | Matt Riedemann proposed openstack/python-novaclient master: API microversion 2.69: Handles Down Cells https://review.openstack.org/579563 | |
| 23:21:21 | openstackgerrit | Matt Riedemann proposed openstack/python-novaclient master: API microversion 2.69: Handles Down Cells https://review.openstack.org/579563 | |
| 23:35:54 | mriedem | dansmith: what would be a simple way to effectively disable/stop the nova_cell1 db without actually stopping mysqld? failing at finding a db stop command | |
| 23:35:57 | mriedem | jaypipes: ^ | |