Posted	Nick	Remark
#openstack-nova - 2019-02-12
17:44:32	sean-k-mooney	stephenfin: cool i will try to adress them later today
17:47:00	sean-k-mooney	stephenfin: it can wait till tomorow but we need to review https://review.openstack.org/#/c/636061/ tool the ironic and neutron spec were approved after m2 so apparently this is intending to target stien.
17:48:45	sean-k-mooney	stephenfin: so 1 we need to validate it makes sense and 2 merge it and releas a new os-vif version before teh 27th. i was hoping to do a new release on friday week anyway but i would have prefered to at least have a nova/os-vif blueprint for this earlier
17:48:46	prometheanfire	sean-k-mooney: they don't think they'd be able to support the driver fully upstream is the reason I asked
17:49:40	sean-k-mooney	prometheanfire: so technically you can use out of tree drivers but they are not offically supported by nova (since they are out of tree) and nova may break them at any time
17:50:04	sean-k-mooney	historically i dont know how volitile that interface has been
17:50:22	openstackgerrit	Surya Seetharaman proposed openstack/nova master: Plumbing required in servers ViewBuilder to construct partial results https://review.openstack.org/635146
17:50:23	openstackgerrit	Surya Seetharaman proposed openstack/nova master: API microversion 2.69: Handles Down Cells Documentation https://review.openstack.org/635147
17:50:23	openstackgerrit	Surya Seetharaman proposed openstack/nova master: API microversion 2.69: Handles Down Cells https://review.openstack.org/591657
17:50:34	sean-k-mooney	prometheanfire: so there is noting preventign kolla from supproting deploying them but they may break
17:52:15	sean-k-mooney	prometheanfire: being out of tree means that maintaining comptablity with nova fall entirly onto the xenxl team. but yes being intree requires ci and other testing requirement so its non trivial
17:54:04	prometheanfire	sean-k-mooney: not asking for osa (or kolla), that comes as the cost of out of tree :D
17:54:37	sean-k-mooney	well being out of tree has benifits too
17:55:07	sean-k-mooney	if the hypervior you are intergrating with is evolving quickly you can add features and adapt your driver much faster out of tree
17:55:44	sean-k-mooney	so it best to bring it in tree when it stable and you have hit the baseline of feature you want o support
17:56:45	prometheanfire	yep
17:58:42	odyssey4me	prometheanfire OSA has implementations of out of tree drivers for nova already - for powervm IIRC
17:59:14	prometheanfire	odyssey4me: good point I'll point him there
17:59:19	odyssey4me	nova supports the use of out of tree drivers, but obviously the core team for nova does not 'support' those drivers - that'd be for the out of tree driver team
17:59:42	odyssey4me	OSA also has nova-lxd driver support
18:09:51	openstackgerrit	Paul-Emile Element proposed openstack/nova master: Add emulated TPM support to Nova https://review.openstack.org/631363
18:17:29	prometheanfire	the pci_whitelist can accept a value like passthrough_whitelist= "{ "vendor_id": "10de", "product_id": "15f7" }" ?
18:17:42	prometheanfire	or does it need to look like { "vendor_id": "10de", "product_id": "15f7" }
18:24:45	sean-k-mooney	the later i think
18:25:13	sean-k-mooney	prometheanfire: there a a bunch of examples here https://github.com/openstack/nova/blob/master/nova/conf/pci.py#L128-L162
18:28:26	openstackgerrit	Matt Riedemann proposed openstack/nova master: Move finish_resize.(start|end) notifications to helper method https://review.openstack.org/635079
18:28:27	openstackgerrit	Matt Riedemann proposed openstack/nova master: Add Destination.allow_cross_cell_move field https://review.openstack.org/614035
18:28:27	openstackgerrit	Matt Riedemann proposed openstack/nova master: Add Migration.cross_cell_move and get_by_uuid https://review.openstack.org/614012
18:28:28	openstackgerrit	Matt Riedemann proposed openstack/nova master: Change HostManager to allow scheduling to other cells https://review.openstack.org/614037
18:28:28	openstackgerrit	Matt Riedemann proposed openstack/nova master: Add InstanceAction/Event create() method https://review.openstack.org/614036
18:28:28	mriedem_afk	dansmith: there will be some easy pickings at the bottom of this series ^
18:28:29	openstackgerrit	Matt Riedemann proposed openstack/nova master: Add Instance.hidden field https://review.openstack.org/631123
18:28:29	openstackgerrit	Matt Riedemann proposed openstack/nova master: Add CrossCellWeigher https://review.openstack.org/614353
18:28:30	openstackgerrit	Matt Riedemann proposed openstack/nova master: Add CrossCellMigrationTask https://review.openstack.org/631581
18:28:30	openstackgerrit	Matt Riedemann proposed openstack/nova master: Add TargetDBSetupTask https://review.openstack.org/627892
18:28:31	openstackgerrit	Matt Riedemann proposed openstack/nova master: Add can_connect_volume() compute driver method https://review.openstack.org/621313
18:28:31	openstackgerrit	Matt Riedemann proposed openstack/nova master: Execute TargetDBSetupTask https://review.openstack.org/633853
18:28:32	openstackgerrit	Matt Riedemann proposed openstack/nova master: WIP: Add PrepResizeAtDestTask https://review.openstack.org/627890
18:28:32	openstackgerrit	Matt Riedemann proposed openstack/nova master: WIP: Add prep_snapshot_based_resize_at_dest compute method https://review.openstack.org/633293
18:28:33	openstackgerrit	Matt Riedemann proposed openstack/nova master: WIP: Add PrepResizeAtSourceTask https://review.openstack.org/627891
18:28:33	openstackgerrit	Matt Riedemann proposed openstack/nova master: Add prep_snapshot_based_resize_at_source compute method https://review.openstack.org/634832
18:28:34	openstackgerrit	Matt Riedemann proposed openstack/nova master: Add FinishResizeAtDestTask https://review.openstack.org/635646
18:28:34	openstackgerrit	Matt Riedemann proposed openstack/nova master: WIP: Add finish_snapshot_based_resize_at_dest compute method https://review.openstack.org/635080
18:28:35	openstackgerrit	Matt Riedemann proposed openstack/nova master: Execute CrossCellMigrationTask from MigrationTask https://review.openstack.org/635668
18:30:30	openstackgerrit	Merged openstack/nova master: Follow up (#2) for the bw resource provider series https://review.openstack.org/634767
18:37:19	edleafe	melwitt: At Doug Hellman's suggestion, I went ahead and created https://review.openstack.org/#/c/636416/
18:37:39	edleafe	melwitt: I was going to wait until we discussed it at Thursday's team meeting
18:39:23	melwitt	edleafe: ack, thanks
19:13:52	openstackgerrit	Kashyap Chamarthy proposed openstack/nova master: libvirt: Bump MIN_{LIBVIRT,QEMU}_VERSION for "Stein" https://review.openstack.org/632507
19:14:39	kashyap	Only 16 more tests to fix! (Down from 34.)
19:15:29	kashyap	mriedem_afk: ^ When you get a moment: I think it makes sense to get the above in in Stein (even at the end of the release). IMHO, it just gets rid of the needless cruft
19:16:12	kashyap	The unit test "noise" is largely mechanical (as I noted in the commit message): remove the needless extra serial device.
19:17:33	kashyap	I'll fix the rest of the 16 tests in the morning.
20:28:00	openstackgerrit	Kashyap Chamarthy proposed openstack/nova master: libvirt: Bump MIN_{LIBVIRT,QEMU}_VERSION for "Stein" https://review.openstack.org/632507
20:28:38	kashyap	Alright, actually rest of the 16 are fixed, too.
20:50:32	mriedem	huh i see the 12.0.0 liberty GA release notes aren't published https://docs.openstack.org/releasenotes/nova/liberty.html
20:54:07	mriedem	dansmith: you wanna help get the legacy-grenade-dsvm-neutron-multinode-live-migration job fixed? https://review.openstack.org/#/c/634962/ already +2d
20:55:31	dansmith	DO I EVER
20:55:43	mriedem	not sure why that job isn't voting, probably should be
20:55:58	mriedem	seems like live migrating back and forth across n and n-1 nodes is good to keep working..
21:00:46	cfriesen	dansmith: how does https://git.openstack.org/cgit/openstack/nova/commit/?id=804215017f38300ac429e4401ce9c23f0c8ff3c6 avoid the traceback when it saves and re-raises the exception?
21:02:50	dansmith	cfriesen: I think the point of that was to log the important details where we had them, which are lost in the generic stack trace above
21:02:52	mriedem	cfriesen: i think the point is it's avoiding this https://review.openstack.org/#/c/546423/5/nova/virt/block_device.py@313
21:03:25	dansmith	ah, maybe that too,
21:03:45	dansmith	but the bug was that the generic error got logged in like compute manager orsomething and it wasn't clear that the problem was that it failed to detach a volume
21:05:31	mriedem	i'm +1 now on the down cell servers view builder change https://review.openstack.org/#/c/635146/
21:05:39	mriedem	withholding +2 for now since it calls out 2.69
21:06:32	artom	Can I rant about unit testing? I'm ranting about unit testing. Unit testing is not "mock everything the function calls and assert it was called the way the current implementation you're testing would.
21:09:06	edleafe	artom: Most of our unit tests could be named "test_that_python_works"
21:09:33	artom	edleafe, hah, I'm laughing now, but maybe I should cry?
21:17:19	artom	mdbooth would love that
21:35:53	aspiers	mriedem, efried: I seem to have successfully(?) rebased https://review.openstack.org/538498 on top of the removal of get_traits()
21:36:43	aspiers	mriedem, efried: git-irebase has just brought it 250 commits closer to master, but it's just hit another conflict at master~788 so I've got a way to go still ...
21:36:59	aspiers	but I think I actually sort of understand what's going on now, which is encouraging
21:37:18	openstackgerrit	Artom Lifshitz proposed openstack/nova master: Add migration param to check_can_live_migrate_destination https://review.openstack.org/634605
21:37:18	openstackgerrit	Artom Lifshitz proposed openstack/nova master: Remove _legacy_dict methods https://review.openstack.org/636210
21:37:19	openstackgerrit	Artom Lifshitz proposed openstack/nova master: [WIP] Introduce live_migration_claim() https://review.openstack.org/635669
21:37:19	openstackgerrit	Artom Lifshitz proposed openstack/nova master: New objects to transmit NUMA config from dest to source https://review.openstack.org/634827
21:37:20	openstackgerrit	Artom Lifshitz proposed openstack/nova master: [WIP] LM: Make dest send NUMAMigrateData to the source https://review.openstack.org/634828
21:37:20	openstackgerrit	Artom Lifshitz proposed openstack/nova master: [WIP] Use live_migration_claim() to check dest resources https://review.openstack.org/634606
21:37:21	openstackgerrit	Artom Lifshitz proposed openstack/nova master: [WIP] LM: update NUMA-related XML on the source https://review.openstack.org/635229
21:38:51	aspiers	Ah, that conflict was super easy to resolve. Onwards...
21:40:55	aspiers	OK, I think I am officially declaring git-irebase as awesome
21:44:08	efried	aspiers: what is git-irebase?
21:44:17	aspiers	incremental rebase
21:44:24	aspiers	one commit at a time
21:44:34	aspiers	so you are only ever resolving conflicts against a single commit
21:45:07	efried	ye gods, that sounds like the hard way to go, but good on ya.
21:45:16	aspiers	no, it's really easier
21:45:28	aspiers	this change you pointed me at is over 1000 commits behind master
21:45:38	aspiers	it conflicts with multiple commits along the way
21:45:44	efried	right, but only a handful of those would have conflicted.
21:46:21	aspiers	yes, but I would have had to understand *all* of those commits at the same time to resolve the conflict via a normal single-shot rebase
21:46:38	aspiers	with code I've never seen before, that's a nightmare
21:46:49	aspiers	even if I'd seen it I suspect it would have been tricky
21:47:31	aspiers	I'm now at master~510 and so far I've had to handle one major conflict (the get_traits() removal from ironic driver) and 3 minor conflicts
21:49:00	aspiers	also it means I can run the tests after each resolve, which increases the chances of catching logic errosr
21:49:30	aspiers	just hit another major conflict
21:49:43	aspiers	but it's only a single commit, so now manageable :)
21:51:46	aspiers	ah it wasn't major, just a method signature change

Earlier   Later