| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2019-02-08 | |||
| 16:52:09 | spatel | I got my answer :) thanks | |
| 16:55:47 | sean-k-mooney | spatel: can you file a bug just so we dont forget | |
| 16:56:09 | sean-k-mooney | as i said we either should update the docs or the code | |
| 17:02:09 | spatel | i think we should update code and add one more row ( disabled compute node ) ;) | |
| 17:21:00 | mriedem | ew another subunit parser giant log capture http://logs.openstack.org/27/619527/16/check/openstack-tox-py35/ab8a233/job-output.txt.gz#_2019-02-08_14_57_03_415588 | |
| 17:21:41 | mriedem | gross that's from o.vo | |
| 17:22:06 | mriedem | so i suppose we need to set log levels to debug for oslo.versionedobjects and oslo.messaging in our test runs | |
| 17:22:16 | mriedem | s/debug/warning/ | |
| 17:22:35 | mriedem | although for oslo.messaging we're tracing exceptions in those conductor unit tests... | |
| 17:22:44 | sean-k-mooney | mriedem: one question do we know what the cause is? i was wondering if it could be a locale issue or something like that | |
| 17:24:12 | melwitt | sean-k-mooney: I don't think so. see the comments in this earlier bug for more info https://bugs.launchpad.net/cinder/+bug/1728640 | |
| 17:24:14 | openstack | Launchpad bug 1728640 in Cinder "py35 unit test subunit.parser failures" [Critical,Fix released] - Assigned to Sean McGinnis (sean-mcginnis) | |
| 17:25:08 | mriedem | i think the summary is we're sending a shit load of content to the subunit output stream capture which blows it up | |
| 17:25:52 | sean-k-mooney | ya that was the other ting i was wondering but i guess that means we are not mocking out the loggers enough in the unit tests | |
| 17:26:14 | melwitt | yeah. from mtreinish: "we may be exceeding the max attachment size in subunit" | |
| 17:26:35 | melwitt | (from a comment in that bug) | |
| 17:27:21 | sean-k-mooney | on the plus side if we do reduce the log output it will both help with space on logs.openstack.org and maybe speed up the tests | |
| 17:27:36 | sean-k-mooney | all that io is proably slowing them down | |
| 17:34:38 | mriedem | well normally i don't think you get a lot of this output unless a test fails | |
| 17:34:52 | mriedem | or the subunit parser blows up | |
| 17:35:38 | openstackgerrit | Elod Illes proposed openstack/nova stable/queens: Handle IndexError in _populate_neutron_binding_profile https://review.openstack.org/635897 | |
| 17:59:31 | mnaser | mriedem, cdent, dansmith: https://review.openstack.org/#/c/635852/ has an openstack ansible cross repo job (which you can see installs from the zuul cloned nova -- http://logs.openstack.org/52/635852/1/check/nova-openstack-ansible-cross-repo/9738be9/logs/ara-report/result/113b6602-4a28-4512-964b-4174593eb507/ "Processing /home/zuul/src/git.openstack.org/openstack/nova") | |
| 17:59:55 | mnaser | i will add another tox env which will run it making sure that we *skip* placement deploy to merge that eventually | |
| 18:00:15 | mnaser | and then the normal functional test will run *with* out-of-repo placement | |
| 18:00:26 | cdent | awesome, thanks | |
| 18:02:53 | cdent | I'll look more closely soon, probably monday | |
| 18:06:53 | dansmith | mriedem: should I not nit out over the presumptive microversion comment? https://review.openstack.org/#/c/635121/4 | |
| 19:10:54 | aspiers | is there a reason that the trait string values in this dict are not referenced using os_traits constants? http://git.openstack.org/cgit/openstack/nova/tree/nova/virt/libvirt/utils.py#n49 | |
| 19:11:39 | aspiers | wouldn't it be helpful to have the compile-time checks resulting from using os_traits? or am I misunderstanding something? | |
| 19:13:39 | cdent | aspiers: I think it's a matter of "didn't happen yet" | |
| 19:13:52 | aspiers | cdent: so a patch would be gratefully received? :) | |
| 19:14:10 | cdent | ask fried_rice or leakypipes to confirm, but I suspect so | |
| 19:14:16 | cdent | I'm not savvy to that section of the coe | |
| 19:14:16 | aspiers | OK thanks | |
| 19:14:20 | cdent | and it is dinner time | |
| 19:16:50 | openstackgerrit | Corey Bryant proposed openstack/nova master: xenapi/agent: Change openssl error handling https://review.openstack.org/635533 | |
| 19:22:25 | cfriesen | If I were to request a release of os-traits (in order to make use of the new vTPM traits) would I ask for release 0.10.1 or 0.11.0? | |
| 19:23:03 | melwitt | new traits = "new features" so a minor version bump | |
| 19:23:35 | aspiers | melwitt: speaking of traits, do you have any thoughts on the above? I can submit a review easily | |
| 19:25:13 | leakypipes | aspiers: no reason other than legacy I think... I'd welcome a cleanup patch. | |
| 19:25:28 | melwitt | ok, good. I was about to say, I don't know and I'd ask jay | |
| 19:25:36 | aspiers | :) | |
| 19:25:50 | aspiers | leakypipes, melwitt: coming in about 15 seconds ... | |
| 19:25:51 | cfriesen | aspiers: I see you just added some stuff to os-traits...were you planning on requesting a new release? | |
| 19:26:13 | openstackgerrit | Adam Spiers proposed openstack/nova master: Convert CPU_TRAITS_MAPPING to use os_traits https://review.openstack.org/635919 | |
| 19:26:16 | aspiers | cfriesen: don't need one urgently yet - still working on the code to consume the new trait :) | |
| 19:26:39 | cfriesen | aspiers: I'm in the same boat, just don't want to get caught waiting too long | |
| 19:26:52 | aspiers | cfriesen: fair enough | |
| 19:27:33 | aspiers | leakypipes, melwitt: added you as reviewers | |
| 19:28:01 | mriedem | dansmith: yeah good point, that should move | |
| 19:28:10 | dansmith | I shall convert | |
| 19:28:27 | dansmith | I shall wait until you drop your +2 | |
| 19:28:31 | melwitt | aspiers: ack | |
| 19:28:44 | mriedem | dansmith: already done | |
| 19:28:55 | dansmith | mriedem: I shall be already done as well | |
| 19:28:56 | mriedem | dansmith: are you just going to move it to https://review.openstack.org/#/c/591657/ ? | |
| 19:29:28 | openstackgerrit | Elod Illes proposed openstack/nova stable/pike: Handle IndexError in _populate_neutron_binding_profile https://review.openstack.org/635921 | |
| 19:30:41 | dansmith | mriedem: am I? | |
| 19:31:06 | aspiers | leakypipes: just checking IIUC: is update_provider_tree() the right place to add a call to new code which tests for SEV support and then calls provider_tree.add_traits() if support is found? | |
| 19:31:51 | aspiers | leakypipes: I guess _get_cpu_traits() might be the other candidate, but that seems dependent on the guest CPU mode, which I don't think we want for SEV | |
| 19:32:32 | mriedem | dansmith: i'm not sure what 'convert' meant | |
| 19:32:36 | mriedem | oh -1? | |
| 19:32:42 | dansmith | mriedem: heh yeah, convert my vote | |
| 19:32:48 | mriedem | ah i see | |
| 19:32:55 | mriedem | saved my sweet sweet stats sheet | |
| 19:33:01 | mriedem | a true gentleman | |
| 19:33:21 | mriedem | aspiers: yes upt | |
| 19:33:28 | mriedem | to set inventory/aggregates/traits/etc | |
| 19:33:31 | aspiers | mriedem: thanks! | |
| 19:33:38 | mriedem | aspiers: fried_rice is your captain for upt | |
| 19:33:44 | aspiers | got it :) | |
| 19:33:55 | aspiers | hmm, that nick is making me hungry | |
| 19:53:07 | aspiers | leakypipes, fried_rice, mriedem: I'm wondering if it makes sense to detect SEV support in get_available_resource(), possibly under data["cpu_info"] | |
| 19:53:39 | mriedem | for what reason? | |
| 19:54:10 | aspiers | for one, so it's visible via the API | |
| 19:54:37 | mriedem | it is visible the API, | |
| 19:54:38 | mriedem | the placement API | |
| 19:54:42 | mriedem | as a trait on the compute node resource provider | |
| 19:55:09 | aspiers | right, but not via "openstack hypervisor show" IIUC? | |
| 19:55:11 | mriedem | we're not trying to game all new traits into the old hypervisor stats API | |
| 19:55:15 | mriedem | correct | |
| 19:55:16 | mriedem | and that's ok | |
| 19:55:28 | mriedem | in the long long future the hypervisor stats/show stuff could be proxied to placement | |
| 19:55:30 | aspiers | ah OK, so the idea is to move away from the old API? | |
| 19:55:32 | aspiers | got it | |
| 19:56:34 | aspiers | that thought arose because the get_domain_capabilities() I've added sits next to get_capabilities() https://review.openstack.org/#/c/633855/1/nova/virt/libvirt/host.py | |
| 19:56:50 | aspiers | which is currently called from _get_cpu_info() | |
| 19:57:34 | mriedem | but you can also get that via update_provider_tree yes? | |
| 19:57:40 | mriedem | self.host.get_domain_capabilities() | |
| 19:57:43 | aspiers | yup | |
| 19:57:46 | mriedem | if 'sev' in caps: add_my_trait() | |
| 19:57:53 | aspiers | makes sense, thanks! | |
| 19:57:59 | mriedem | the cpu feature flag stuff sort of works like that | |
| 19:58:54 | fried_rice | aspiers: Give me a bit, I'm on a call, but - yes, at a glance, it makes sense to me that SEV support would be discovered and the trait injected in update_provider_tree. | |
| 19:59:14 | aspiers | fried_rice: cool, thanks! | |
| 19:59:28 | aspiers | I need to grab some dinner | |
| 19:59:31 | aspiers | back in a bit | |
| 19:59:35 | fried_rice | aspiers: Or, during init_host, add it to the virt driver's capabilities dict. | |
| 20:00:18 | fried_rice | but that relies on a) an in-flight patch from mriedem that converts those to traits on the compute RP, and b) making the capabilities dict an instance var on the relevant virt drivers, like PowerVM has. | |
| 20:02:05 | aspiers | interesting, I'll check that out | |