Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2019-02-06
00:33:32 sean-k-mooney so for mempage size if the flavor has set a spefici page size and the image does not agree its an error
00:34:21 sean-k-mooney if the flavoer was hw:mem_page_size=large or hw:mem_page_size=any and the image had hw_mem_page_size=1G that should be allow but i dont know if we support it or not
00:34:31 openstackgerrit Matt Riedemann proposed openstack/nova master: WIP: Add prep_snapshot_based_resize_at_dest compute method https://review.openstack.org/633293
00:34:32 openstackgerrit Matt Riedemann proposed openstack/nova master: Add prep_snapshot_based_resize_at_source compute method https://review.openstack.org/634832
00:34:32 openstackgerrit Matt Riedemann proposed openstack/nova master: WIP: Add PrepResizeAtDestTask https://review.openstack.org/627890
00:34:33 openstackgerrit Matt Riedemann proposed openstack/nova master: Move finish_resize.(start|end) notifications to helper method https://review.openstack.org/635079
00:34:33 openstackgerrit Matt Riedemann proposed openstack/nova master: WIP: Add PrepResizeAtSourceTask https://review.openstack.org/627891
00:34:34 openstackgerrit Matt Riedemann proposed openstack/nova master: WIP: Add finish_snapshot_based_resize_at_dest compute method https://review.openstack.org/635080
00:35:09 artom sean-k-mooney, so based on unit tests it looks like mem_page_size in image is outright forbidden...
00:35:19 mriedem artom: i've always though image overrides flavor since the user can sometimes upload their own images
00:35:35 mriedem stephenfin might think otherwise as well since i think he's written something up about this brfeore
00:35:37 mriedem *before
00:36:10 sean-k-mooney well the user should not be able to overide the admin but if ther is no conflict then its fine
00:36:13 artom mriedem, hrmm, doesn't look like that's universally true
00:36:19 artom sean-k-mooney, mriedem, https://github.com/openstack/nova/blob/f7252b586b4b9f5a098fedfa27715b8f7e662af6/nova/tests/unit/virt/test_hardware.py#L2253-L2264
00:36:32 artom To me that reads as we bail if there's a page size in image props
00:36:56 sean-k-mooney artom: https://github.com/openstack/glance/blob/master/etc/metadefs/compute-guest-memory-backing.json
00:37:40 sean-k-mooney artom no in test_get_requested_mempages_pagesize_from_image_forbidden
00:38:18 sean-k-mooney the flavor is hw:mem_page_size=small so not hugepages but the image asks for 2m hugepages so that is not allowed because teh admin said no
00:39:00 sean-k-mooney test_get_requested_mempages_pagesize_from_image_forbidden2 fails befause for the image to be allow to ask for hugepages teh flaovr must have hw:mem_page_size=large or any
00:39:24 artom Ah, so https://github.com/openstack/nova/blob/f7252b586b4b9f5a098fedfa27715b8f7e662af6/nova/virt/hardware.py#L1120 exists
00:39:36 sean-k-mooney artom: basically you can only aske for a specific page size via the image if the admin said it was ok in the flavor
00:39:41 sean-k-mooney at least that was the intent
00:40:54 sean-k-mooney artom https://github.com/openstack/nova/blob/f7252b586b4b9f5a098fedfa27715b8f7e662af6/nova/virt/hardware.py#L1169-L1170
00:42:18 sean-k-mooney artom: the idea wa that if the admin wanted to supprot hugepage guest they would only ever set hw:mem_page_size=large. and if the tenant cared about the size of the hugepage they would then say so in the image
00:42:59 artom sean-k-mooney, aha, that makes sense
00:44:09 artom Concretely, in our live migration claim case, it looks like we'll have to override both with the actual pagesize on the source host
00:44:21 artom Somehow
00:46:26 sean-k-mooney artom: the instance_numa_topology object has the pagesize
00:46:27 sean-k-mooney https://github.com/openstack/nova/blob/f7252b586b4b9f5a098fedfa27715b8f7e662af6/nova/objects/instance_numa_topology.py#L51
00:46:42 sean-k-mooney so when you are claiming the memory for the instance jsut pull it out of that
00:46:47 artom sean-k-mooney, yeah, that wasn't what I was bugging on
00:47:23 artom So actually, because https://github.com/openstack/nova/blob/f7252b586b4b9f5a098fedfa27715b8f7e662af6/nova/virt/hardware.py#L1168-L1170, if we set a numerical pagesize in the flavor, it'll override anything in the image
00:47:27 artom OK, I'm good
00:47:48 sean-k-mooney artom: yes but we should not mess with the flavor
00:47:54 sean-k-mooney or the image
00:48:04 sean-k-mooney just keep it as a seperate value
00:48:12 artom sean-k-mooney, not on the original, but if we deepcopy it we can do whatever we want :)
00:48:32 artom I know it's ugly, but I'd rather not dive into the claims code to make it understand a separate pagesize
00:48:57 sean-k-mooney its a nova object wich is a ovo so you all have to reset the fields to make shour it does not get persited back into the db in some cases
00:50:48 sean-k-mooney artom: well throw up a poc and then we can see what it looks like
00:50:57 artom sean-k-mooney, yep
01:39:01 sean-k-mooney night all o/
02:21:02 openstackgerrit Merged openstack/nova master: Move retry from _update to _update_to_placement https://review.openstack.org/634252
03:26:08 openstackgerrit Artom Lifshitz proposed openstack/nova master: [WIP] New objects to transmit NUMA config from dest to source https://review.openstack.org/634827
03:26:08 openstackgerrit Artom Lifshitz proposed openstack/nova master: [WIP] Create claims when live migrating https://review.openstack.org/634606
03:26:09 openstackgerrit Artom Lifshitz proposed openstack/nova master: [WIP] Send dest NUMA info inside LiveMigrateData https://review.openstack.org/634828
07:10:21 openstackgerrit Takashi NATSUME proposed openstack/nova master: Replace glance command with openstack command https://review.openstack.org/635102
07:13:56 openstackgerrit Takashi NATSUME proposed openstack/nova master: Replace glance command with openstack command https://review.openstack.org/635102
07:55:32 openstackgerrit Jan Gutter proposed openstack/nova master: Ignore some PendingDeprecationWarnings for os-vif https://review.openstack.org/634928
08:20:15 openstackgerrit Jan Gutter proposed openstack/os-vif master: Convert hardcoded regexes to raw strings for py36 https://review.openstack.org/635111
10:10:34 openstackgerrit Surya Seetharaman proposed openstack/nova master: Modify InstanceMappingList.get_not_deleted_by_cell_and_project() https://review.openstack.org/635120
10:10:34 openstackgerrit Surya Seetharaman proposed openstack/nova master: API microversion 2.68: Handles Down Cells https://review.openstack.org/591657
10:10:35 openstackgerrit Surya Seetharaman proposed openstack/nova master: Plumbing for ignoring list_records_by_skipping_down_cells https://review.openstack.org/635121
10:53:54 openstackgerrit Andrey Volkov proposed openstack/nova master: Check hosts have no instances for AZ rename https://review.openstack.org/509206
11:18:06 openstackgerrit Stephen Finucane proposed openstack/python-novaclient master: Microversion 2.68: Remove 'forced' live migrations, evacuations https://review.openstack.org/635131
11:22:03 openstackgerrit Stephen Finucane proposed openstack/nova master: API: Remove evacuate/live-migrate 'force' parameter https://review.openstack.org/634600
12:41:53 openstackgerrit Surya Seetharaman proposed openstack/nova master: Plumbing for ignoring list_records_by_skipping_down_cells https://review.openstack.org/635121
12:41:54 openstackgerrit Surya Seetharaman proposed openstack/nova master: Plumbing for allowing the all-tenants filter https://review.openstack.org/635145
12:41:54 openstackgerrit Surya Seetharaman proposed openstack/nova master: API microversion 2.68: Handles Down Cells https://review.openstack.org/591657
12:41:55 openstackgerrit Surya Seetharaman proposed openstack/nova master: API microversion 2.68: Handles Down Cells Documentation https://review.openstack.org/635147
12:41:55 openstackgerrit Surya Seetharaman proposed openstack/nova master: Plumbing required in ViewBuilder to construct partial results https://review.openstack.org/635146
13:10:30 openstackgerrit Artom Lifshitz proposed openstack/nova master: [WIP] Create claims when live migrating https://review.openstack.org/634606
13:10:31 openstackgerrit Artom Lifshitz proposed openstack/nova master: [WIP] Send dest NUMA info inside LiveMigrateData https://review.openstack.org/634828
13:10:31 openstackgerrit Artom Lifshitz proposed openstack/nova master: [WIP] New objects to transmit NUMA config from dest to source https://review.openstack.org/634827
13:45:07 bauzas good afternoon Nova, now begins my upstream day
13:46:12 sean-k-mooney o/ hello upstream bauzas :)
13:46:26 bauzas sylvainb != bauzas :)
13:46:41 bauzas so 'upstream bauzas' is just a pleonasm
13:47:40 sean-k-mooney bauzas: the real question is who is the evil one and who is the good one sylvainb or bauzas
13:48:02 bauzas it's schizophrenic, I know
13:48:16 bauzas mwuaaahahahah
13:49:50 mriedem tssurya: i could be wrong but it seems the commit message and comment in https://review.openstack.org/#/c/635120/ are backward
13:50:53 sean-k-mooney bauzas: the real question is who is the evil one and who is the good one sylvainb or bauzas
13:51:26 bauzas I can't answer this question without the presence of my lawyer
14:26:56 tssurya mriedem: um, no I meant for the ones where the data migration is run, it would be False/True while for the new ones its None/NULL at least in the database..
14:27:05 tssurya I'll update it on the review.
14:29:02 mriedem i'm not sure what "new ones" means
14:29:07 mriedem new instance mappings should have a default of false
14:29:11 mriedem existing records would have None
14:29:15 mriedem and those are what get migrated
14:29:22 tssurya like fresh instance_mappings from Stein
14:29:30 tssurya that is what I mean by new
14:29:47 mriedem and those should have queued_for_delete=False in the db by default
14:29:55 tssurya which they don't
14:30:05 mriedem ?
14:30:20 tssurya I thought they should have qfd=False by default too
14:30:30 tssurya but in the new devstack in which I tested they are NULL
14:30:32 tssurya by default
14:30:33 mriedem if they don't, then we have a problem because we'd never be able to complete that data migration
14:30:54 tssurya well I am assuming once we run the migration, we would not run it again
14:31:20 mriedem but if you're saying that new instance mappings records don't have queued_for_delete=false in the db, then we'd have to migrate those as well
14:31:33 tssurya would have to ask dansmith
14:31:33 mriedem b/c the migration is looking for queued_for_delete=None
14:31:57 tssurya but I am thinking for the newer ones None also means not queued_for_delete
14:32:17 tssurya and when they get deleted it would become True
14:32:32 dansmith why ask me? :)
14:33:08 dansmith if we're writing the qfd flag on object save, then new records should have =False, if not then it depends on whether or not we have a default in the schema
14:33:18 tssurya https://review.openstack.org/#/c/584504/5//COMMIT_MSG@16
14:34:24 dansmith oh ;)

Earlier   Later