Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2019-01-31
15:23:57 ShilpaSD sean-k-money: thanks will check that, example will be great help
15:24:05 mriedem or make it conditional like here https://github.com/openstack/python-novaclient/blob/master/novaclient/tests/unit/fixture_data/hypervisors.py#L129
15:24:14 mriedem or sublcass and overwrite that mock
15:24:17 mriedem *subclass
15:25:47 ShilpaSD mriedem: here based on API version url is different, so its conditional
15:26:00 ShilpaSD will check option of subclass
15:26:02 sean-k-mooney ShilpaSD: basically all you need to do is make the fuction that is set as the side effect stateful in some way so that it can yeild idfferent results
15:27:31 ShilpaSD sean-k-money: will check how i can do this
15:30:44 sean-k-mooney ShilpaSD: i think something like this will work
15:30:47 sean-k-mooney def side_effect_generator(items):
15:30:49 sean-k-mooney for x in items:
15:30:51 sean-k-mooney yeild x
15:30:53 sean-k-mooney
15:30:55 sean-k-mooney my_mock.side_effect = side_effect_generator
15:32:06 sean-k-mooney actully more like this
15:32:10 sean-k-mooney def side_effect_generator(items):
15:32:12 sean-k-mooney for x in items:
15:32:14 sean-k-mooney yeild x
15:32:16 sean-k-mooney results = [suff, more_stuff]
15:32:18 sean-k-mooney my_mock.side_effect = side_effect_generator(results)
15:32:33 sean-k-mooney ShilpaSD: does that makes sense ^
15:32:38 ShilpaSD sean-k-mooney: will try and get back to you
15:34:39 sean-k-mooney cool basically we are usign the fact that corouties/generator fuction will maintain there internal state so you can pass a set of results and everytime it gets invoke it will advance the genortor one step thoguh the list of results
15:41:21 ShilpaSD sean-k-mooney: ok
15:43:35 jangutter why do I, even when working on simple things, always end up with a minimum of 10 gerrit tabs open? (only about 3 unique reviews in them). Should I seek medical attention?
15:44:36 sean-k-mooney if you use chome you should maybe seek more ram for you laptop
15:44:41 openstackgerrit Eric Fried proposed openstack/os-resource-classes master: Add normalize_name utility https://review.openstack.org/634258
16:16:34 openstackgerrit Jack Ding proposed openstack/nova master: Flavor extra spec and image properties validation https://review.openstack.org/620706
16:17:12 openstackgerrit Jack Ding proposed openstack/nova master: Correct instance port binding for rebuilds https://review.openstack.org/603844
16:19:51 openstackgerrit Jack Ding proposed openstack/nova master: Improve libvirt image and snapshot handling https://review.openstack.org/616692
16:20:31 openstackgerrit Eric Fried proposed openstack/os-resource-classes master: Add normalize_name utility https://review.openstack.org/634258
16:20:32 openstackgerrit Jack Ding proposed openstack/nova master: Preserve UEFI NVRAM variable store https://review.openstack.org/621646
17:25:37 sean-k-mooney jaypipes: mriedem: stephenfin: looks like the ci is finally happy with https://review.openstack.org/#/c/626381 if yet have time to take a look.
17:25:38 openstackgerrit Chris Dent proposed openstack/nova master: Switch to using os-resource-classes https://review.openstack.org/628278
17:26:34 mriedem in the middle of something but i'll leave a tab open
17:27:23 sean-k-mooney no worries.
18:17:17 openstackgerrit Matt Riedemann proposed openstack/nova master: WIP: Add PrepResizeAtDestTask https://review.openstack.org/627890
18:17:17 openstackgerrit Matt Riedemann proposed openstack/nova master: Add prep_snapshot_based_resize_at_dest compute method https://review.openstack.org/633293
18:17:18 openstackgerrit Matt Riedemann proposed openstack/nova master: WIP: Add PrepResizeAtSourceTask https://review.openstack.org/627891
18:19:00 openstackgerrit Eric Fried proposed openstack/nova master: Move retry from _update to _update_to_placement https://review.openstack.org/634252
19:40:44 mriedem sean-k-mooney: comments in https://review.openstack.org/#/c/626381/
19:40:58 mriedem fix is good, just needs polish
19:41:10 sean-k-mooney mriedem: thanks
19:41:30 sean-k-mooney ill fix it up today/tommorow
19:45:05 sean-k-mooney im just leavening of the day but ya all the comments make sense to me
19:53:41 mriedem dansmith: you want to send this backport on (it's your fix) https://review.openstack.org/#/c/633086/
19:55:00 dansmith yeah
20:05:55 openstackgerrit Hang Yang proposed openstack/nova stable/queens: Fix port dns_name reset https://review.openstack.org/633807
20:39:05 openstackgerrit Hang Yang proposed openstack/nova stable/queens: Fix port dns_name reset https://review.openstack.org/633807
20:40:41 openstackgerrit Hang Yang proposed openstack/nova stable/queens: Fix port dns_name reset https://review.openstack.org/633807
20:45:19 mriedem nova meeting in 15 minutes
21:19:42 lbragstad mriedem when is nova specification freeze?
21:19:50 lbragstad or did that already happen?
21:20:48 edleafe lbragstad: that was in early January
21:20:56 mriedem lbragstad: jan 10
21:21:19 lbragstad aha - gotcha, thanks edleafe and mriedem
21:21:39 mriedem lbragstad: i assume you're asking because of https://review.openstack.org/#/c/602201/
21:22:16 mriedem which seemed to enter the summit blackhole and was vaporized
21:22:34 lbragstad correct
21:22:52 mriedem sounds like you need a pop up team mr
21:23:00 mriedem a formal one anyway
21:23:02 lbragstad :)
21:23:25 mnaser someone actually reads [tc] tagged ml posts?
21:23:37 lbragstad i'll see if i can catch johnthetubaguy or jaypipes sometime so we can sync on it at least
21:23:47 lbragstad but i assume the ship has said for stein
21:23:52 lbragstad sailed*
21:23:55 mriedem mnaser: i had a whole reply written and everything
21:23:56 smcginnis mriedem: Glance is very actively battling the subunit parser issues right now too.
21:24:06 mriedem smcginnis: ok i knew it hit glance as well
21:24:25 mriedem i'm hoping one of our fine contributors will pick up the investigation as to what changes are needed in nova for that subnit thing
21:24:29 mriedem *subunit
21:24:33 smcginnis If your interested, can probably ping rosmaita for any latest findings.
21:24:43 mriedem i'm interested in someone else being interested
21:24:54 mriedem i spent enough time on the udhcp..pid bug the last 2 weeks
21:25:01 smcginnis The only way I was able to "fix" it in Cinder was to try to get rid of as much log output as possible from unit test runs.
21:25:33 mriedem so my guess is there is a correlation between py3 deprecate/user warnings and our console logs
21:25:41 mriedem which we've worked on stifling over time
21:25:49 smcginnis Seems likely.
21:25:50 mriedem hell i have a glance patch for that as well...
21:25:57 mriedem but some joker nacked it
21:26:06 mriedem https://review.openstack.org/#/c/625092/
21:26:35 smcginnis Part of the Cinder fix, IIRC, was getting rid of all those warnings.
21:27:26 mriedem ok that's a good tip though, thanks
21:34:35 mriedem b"/home/zuul/src/git.openstack.org/openstack/nova/.tox/py35/lib/python3.5/site-packages/sqlalchemy/orm/evaluator.py:99: SAWarning: Evaluating non-mapped column expression 'id' onto ORM instances; this is a deprecated use case. Please make use of the actual mapped columns in ORM-evaluated UPDATE / DELETE expressions."
21:34:35 mriedem this is probably the worst warning that shows up
21:34:41 mriedem 866 hits in one py35 unit test run
21:36:47 stephenfin mriedem: I'm gone to FOSDEM tomorrow, but I should be able to take on https://blueprints.launchpad.net/nova/+spec/remove-force-flag-from-live-migrate-and-evacuate if alex_xu and gibi aren't available. Mention it to me on Monday?
21:37:16 mriedem sure
22:01:12 openstackgerrit Merged openstack/nova stable/rocky: Fix incompatible version handling in BuildRequest https://review.openstack.org/631731
22:01:21 openstackgerrit Matt Riedemann proposed openstack/nova master: Add microversion to expose virtual device tags https://review.openstack.org/631948
22:39:11 openstackgerrit Matt Riedemann proposed openstack/nova master: Fix race in test_volume_swap_server_with_error https://review.openstack.org/634334
22:39:12 mriedem easy gate bug fix ^
22:58:21 openstackgerrit Jack Ding proposed openstack/nova master: Flavor extra spec and image properties validation https://review.openstack.org/620706
#openstack-nova - 2019-02-01
00:19:00 openstackgerrit Merged openstack/nova master: Make 'plugin' a required argument for '_get_vif_instance' https://review.openstack.org/608279
02:17:05 openstackgerrit Merged openstack/nova stable/rocky: Fix using template cell urls with nova-manage https://review.openstack.org/633086
02:24:50 openstackgerrit Zhenyu Zheng proposed openstack/nova master: Don't change volume status to `in-use` when attach to shelved vm. https://review.openstack.org/627096
09:29:56 openstackgerrit Zhenyu Zheng proposed openstack/nova master: Per-instance serial number https://review.openstack.org/619953
12:07:15 openstackgerrit Lee Yarwood proposed openstack/nova master: WIP libvirt: Avoid premature calls to disconnect_volume during LM https://review.openstack.org/634398
12:07:53 lyarwood mdbooth: ^ if you wouldn't mind taking a look at this when you're back, from a downstream triage bug.
12:15:30 mdbooth lyarwood: Looking

Earlier   Later